From nobody Mon Apr 6 10:32:51 2026 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA1D01F4CA9 for ; Thu, 19 Mar 2026 14:11:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773929483; cv=none; b=YH/nfz6LIgoyhS/pXL/1x+AOfHTBUnR536+jRRfZeA6FbbHv7IXSV7UG8R5UJW2iyx42l4GB0be/HOIMhqO6lHSUPW/CR1x8CQCmnnT/mCeS0f4F5D6kOu3QYvavLrz/RwjxVfR5Y74XSprBVhkCyW1AY0E9isuwfQV5jmbvV/0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773929483; c=relaxed/simple; bh=EHz3OH4NQl+5kez4lALoytwa8lBXo9ZxXlJ92g4WOaw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i0fsn069NXZkEjac1LaoPHpeSHlUCXJkt/nvVH4cSX3FevFSlc6KEqAuZ1PVjIDGRE9iam+Mnxi0Uz9Slw6aPwy83b4y6wsbMyxMJokc7M38qFEy8LhXnBtU6acrLMV94z0IhsF24XevjJaKiGinCuCqMtmji2N6bKZeDx2LCvs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f27AktSQ; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f27AktSQ" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-c70ea5e9e9dso452028a12.1 for ; Thu, 19 Mar 2026 07:11:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773929480; x=1774534280; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QTUhuvZrbPLi65P2qC19uSSj7YWJnMpGLDgt32EXjPU=; b=f27AktSQVfmCpmqxYkfLPIydj8qF+sYPX/v1uiBLIuINUIYM3AYheoWf5hDQgDH1OQ hey8QDpaKcHkcTxu1eEqUGuX3EIEQaftC86TTQd/pkDqw7fn0T4FOFu18i6LUti1dZdU mdtig3K/2VbvaMAZpinjCGy0bi5MpXpgI9ieMneYj7ugi2jVo2g5p1E0FKvW1QDcXF0q EBl0c+bZYrJkNjzxnwF6ds1BamjR0gZXPHyfwIAlqiyikq9xjeE+DDSeTUKnMK3LJTPl SmMkolvgwD9dmZbOMW15Z6Z8AaTm7Fk2cAL8YlYHHONT97uNpmJgqMpwVs1jXvC/WQGU Lxzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773929480; x=1774534280; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QTUhuvZrbPLi65P2qC19uSSj7YWJnMpGLDgt32EXjPU=; b=gcaL0Ptr2Zi35m7nLLcaRVYxook9VdnOVBS3jPLrGEpkFeGCKaDB3Lm4OFrbq1EWGB 7ipGG2NkLxLEBl9a7eiR4GWEpLpdQFDS0ju6THbDzqSNHZQrw53onQdO2lO+AKiZ92G5 4jyhlS57uLMN8898mZA3Vv+KtBCgChAACDfUoG0rrTFywgJWMdTwDnyHhQB9xkwa4jIF m2NO7+ur4fs0E/sqRirVjB0yj5uNV7zzyxkvhCZlDjVTTqdaaUv2vDyoVvhlLH/px98F UDVLNM+SHy7mUFoX1753d10zWg+7h9WJ8oPUmqH3HUdl3Eliki9HI35ntU+yv+ShiyE8 Tm3w== X-Forwarded-Encrypted: i=1; AJvYcCWbeS1OcVamCIYZcRHcEiQ0MvX6rrHT/575BYE3aRZklTKqQmaUm7rM4CfaqQyqH5scqUCRJKWk+amZPXU=@vger.kernel.org X-Gm-Message-State: AOJu0YwU8W6ljLB2bVbF+g4z2sQz3Pbs39TIo/2BMI0g75HBzWCMO7aB 1HVgmxQWjmEdrVk19wVcnCG5fJLoZ/Pn8oxe6Oy9IUi2vzv+Pr2hzG/o X-Gm-Gg: ATEYQzxrT+iY7BuH3tLU6f71sPVnEliR3Jza/wINFYbOlDW4dneCmDZQywC3yQWx6DM rK6t39/51C+Cptph0uCtvobK99iwJEE7rWIws1CPbvwBf4fYVscpA+6+adMv/dchQjURUUKc2VT YeVYyoid6DiNUSTHKpsJtqwEyFEdNWSHyLOLL68P/qwu3O/UJFl9Ut3ROSkHXs4yE8hGEru0WXT Dt4wKOSvOF6eHBlVA8uEcLxvGndzQmt55inl3dnwXuiDk50wXVkGXuUzKoo/S4p74uP2XFJ1psp KEeuqyE+DJwaELVl5qBRsUHah42GtvhyuBKC0uOzqY1NO7kidWlLclt3ZaPTarXacha45r6FUuH OzRGlYRK3YT9xpCYFj8+cNbgKv5F1P1BY17Yr8knlXKLE2pYkvNcvcUEIYMQtDdC1DdAhKcT26u Q/1Yo9Ajqj6EirseGZyLeEE+K5ROFoDqsNBg== X-Received: by 2002:a17:902:ef4d:b0:2b0:5520:f49c with SMTP id d9443c01a7336-2b06e39a1dfmr83537885ad.25.1773929480129; Thu, 19 Mar 2026 07:11:20 -0700 (PDT) Received: from aadarsh.. ([2409:40d0:11f4:e9ce:f110:1acf:6031:3b39]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-2b06e5ef3d1sm54781385ad.38.2026.03.19.07.11.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 07:11:19 -0700 (PDT) From: Aadarsh Mandal To: luka.gejak@linux.dev Cc: aadarshmandal9354@gmail.com, dan.carpenter@linaro.org, ethantidmore06@gmail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, straube.linux@gmail.com Subject: [PATCH v4] staging: rtl8723bs: removed dead code Date: Thu, 19 Mar 2026 19:41:09 +0530 Message-ID: <20260319141109.7212-1-aadarshmandal9354@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <2A37C741-68A1-47E2-AB3D-833593B5C392@linux.dev> References: <2A37C741-68A1-47E2-AB3D-833593B5C392@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" - removed the dead code. Signed-off-by: Aadarsh Mandal --- v4: - removed the space insertion. - deleted the commented codes. v3: - added the extra space that count as insertion. - removed unwanted addition. v2: - accidently deleted the braces for the standalone code blocks {}. - deleted the reindented comment code, extra space. v1: - reindented comment code,extra space remained. drivers/staging/rtl8723bs/hal/sdio_halinit.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index 063a0737933e..96a0c8e304da 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -481,9 +481,6 @@ static void _initSdioAggregationSetting(struct adapter = *padapter) { struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); - /* Tx aggregation setting */ -/* sdio_AggSettingTxUpdate(padapter); */ - /* Rx aggregation setting */ HalRxAggr8723BSdio(padapter); @@ -635,9 +632,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) return _SUCCESS; } - /* Disable Interrupt first. */ -/* rtw_hal_disable_interrupt(padapter); */ - ret =3D _InitPowerOn_8723BS(padapter); if (ret =3D=3D _FAIL) return _FAIL; @@ -656,8 +650,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) rtl8723b_InitializeFirmwareVars(padapter); -/* SIC_Init(padapter); */ - if (pwrctrlpriv->reg_rfoff) pwrctrlpriv->rf_pwrstate =3D rf_off; @@ -740,11 +732,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) rtw_hal_set_chnl_bw(padapter, padapter->registrypriv.channel, CHANNEL_WIDTH_20, HAL_PRIME_CHNL_OFFSET_DONT_CARE, HAL_PRIME_CHNL_OFFSET_= DONT_CARE); - /* Record original value for template. This is arough data, we can only = use the data */ - /* for power adjust. The value can not be adjustde according to differen= t power!!! */ -/* pHalData->OriginalCckTxPwrIdx =3D pHalData->CurrentCckTxPwrIdx; */ -/* pHalData->OriginalOfdm24GTxPwrIdx =3D pHalData->CurrentOfdm24GTxPwrIdx;= */ - rtl8723b_InitAntenna_Selection(padapter); /* */ @@ -786,8 +773,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) /* ack for xmit mgmt frames. */ rtw_write32(padapter, REG_FWHW_TXQ_CTRL, rtw_read32(padapter, REG_FWHW_TXQ= _CTRL) | BIT(12)); -/* pHalData->PreRpwmVal =3D SdioLocalCmd52Read1Byte(padapter, SDIO_REG_HRP= WM1) & 0x80; */ - { pwrctrlpriv->rf_pwrstate =3D rf_on; @@ -1075,8 +1060,6 @@ static void _ReadPROMContent(struct adapter *padapter) pEEPROM->EepromOrEfuse =3D (eeValue & BOOT_FROM_EEPROM) ? true : false; pEEPROM->bautoload_fail_flag =3D (eeValue & EEPROM_EN) ? false : true; -/* pHalData->EEType =3D IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EEPR= OM_BOOT_EFUSE; */ - _ReadEfuseInfo8723BS(padapter); } -- 2.43.0