From nobody Mon Apr 6 12:13:52 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A62BC3D34AB for ; Thu, 19 Mar 2026 12:51:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773924715; cv=none; b=U6zxNsOFna97F8/iktehz3OcDdnRBYvi6TsSbALLmbKCHSRiVdqXDS8xIPdjZ5dU7pv/SJEMm1QCuX4G4q7iZq5qpPeBjFd5M2pQJviHORtWvwU117SUcKt6UPhqZeUc/oos+BpaqRiwL4ZXajJKddvnRu0aq+jND2Py23u6CYY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773924715; c=relaxed/simple; bh=p1Dy5QwacmRT/b3H3p4y11qC+z1schtfyshS1B+/Zb0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tF+zWej3PHDAAygcpeUxOIip6niWZdbyzFiQbpjysw7n9mzBlQN4ZRFRbOCCF35MUUuyq0BcKsCpUz1g1LWmFuvXANnKrvE0wYcCOweKIQSV1GBaeiMzbnn+xF6ozVjlToDaV1kmPTapWaD/wszlKa4L8A3gFM/nWK8ES4tCfxM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mA1lclRx; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mA1lclRx" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-483487335c2so6788405e9.2 for ; Thu, 19 Mar 2026 05:51:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773924710; x=1774529510; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dpin9fgTSd6+Bb+khmyQR5GOT1G9JWW0tiZ2kKEgCN8=; b=mA1lclRx0l5QRBMUjfpEfV5KRNAmF2cRlBKRUK+Fq5EfJ2KlfZEMiE8IjzIc4WSBFX te9/eeaqyuV3WhZRRIrXarpUIihqLyg3MNfW++glTP5veO0Yo1QdsM/Y8bjsxtC7+tsP sLGX1nabOE06/erqET9U1G2SER2eMoIRKVepa4U/CM1FQ39ik/oMYqWKAkD6GyF3SlB0 +l+OkuTI3Ab3GvFTpnJqcC4jJU/h2gnydNjWrc40c05HmOEWjJq5QfwA55XkL9b3qgyX SbT5FKWtzMWZvCnLj3KYTWMT19uEkDfAC0tyac9InmKOL35uTvY+s7jeSIHsXPdIg66Q rIiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773924710; x=1774529510; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dpin9fgTSd6+Bb+khmyQR5GOT1G9JWW0tiZ2kKEgCN8=; b=rFoJ0KvuPauZbapLZFBljuSe7ybV4eFOSW7U9HDPyGxquPJQ87/UuvkLQe0uUKIR4h wZPCrhV5oQb6r4u1cV8WGwxfgXPaqRwBw2kZCXx68NtLJONbOXVOQJXCJiZ/csX+B6fj Sswg0GcFtNI+TSle/cMd87swJlhR2LFFqGknBmYgPAna1ZTMbrp2v871XX9yd2ipAP+y c7y7vxk01jKlsUmkFK3Rn00pteXtjrYun46yK9TcvFinimHdobri4abC5ItFHiJUIMtu DW1iNcae6zfEK+bQxlv3JFIswmFH+c0dYKkWLVZoL3uN8ZYhPxd5yd/DtwyqTmS3l5SW BptQ== X-Forwarded-Encrypted: i=1; AJvYcCX42bibD+o9K0F1JWwuL10KIuhksLYfxZ40KWUboMJQ1duzsskN2aDFJwM2DRiKoVRpYahjU08GcYGWscw=@vger.kernel.org X-Gm-Message-State: AOJu0YzpXt7k41cOq194jYZxzpyK+jeuswOxXuKmrvwZWPWwopoPgOPv GKeYVrI+OiruwACIl16LL0nUujlJ1xlduUNwj7JBPfF54jNLhke1Pt0w X-Gm-Gg: ATEYQzzoDIbvNO/HuWWTc79UeZ0UXCxGNy5l6k5yTN/SAexaBvuf7pLUQ2/IrJySWBK qsw6mKcwCtzLBGFW5lwp1TxWGUr3YsYK4JtZ2GI5gM1heuy9VtyjtZ1EfMgDhlsGqHqurBY3ELr pghGCXXPcegil/meELYNZkHuPWlF7n522Zp8DHuHswzwXt4QxuABICLyTTbfVlvRISME3JSHsK6 TSeGnJzPvuvC+xTXiTxVVHD0/3HzOuxWMc52A1FKbHm6dr9/VA5aj/eOAF9Vpr9x+Nsfii7z3Kr q7qvnHgn1rrHcgwYhf/mRWWRmI/aDtM1/LX3IHHo9h0mIug9rM8cvY8xmpaYx+jb/L1QTepfXZ6 dsYmLfoFPbKFR+1zw9Mc9fdCwdhY/GnpvKNfxUXAofcYN3rzAk0/x0gNB5+jBfy5SfxNjVJBbqq 2R+nZVqzn5hin9SQIEZ1jZdMANJtmASLg= X-Received: by 2002:a05:600c:4e42:b0:480:1e40:3d2 with SMTP id 5b1f17b1804b1-486f446359emr111081835e9.29.1773924709573; Thu, 19 Mar 2026 05:51:49 -0700 (PDT) Received: from biju.lan ([2a00:23c4:a758:8a01:8326:7b31:bf82:d2d0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f4bc96c6sm72382035e9.5.2026.03.19.05.51.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 05:51:49 -0700 (PDT) From: Biju X-Google-Original-From: Biju To: Geert Uytterhoeven , Michael Turquette , Stephen Boyd , Philipp Zabel Cc: Biju Das , linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar Mahadev Lad , Biju Das Subject: [PATCH v6 04/10] clk: renesas: rzg2l-cpg: Add rzg2l_mod_clock_init_mstop_helper() Date: Thu, 19 Mar 2026 12:51:28 +0000 Message-ID: <20260319125143.230377-5-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260319125143.230377-1-biju.das.jz@bp.renesas.com> References: <20260319125143.230377-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das Refactor the mstop initialisation logic in rzg2l_mod_clock_init_mstop() into a dedicated helper function rzg2l_mod_clock_init_mstop_helper(). This decouples the logic for setting module stop state on disabled clocks from the iteration loop, allowing it to be reused during resume to re-enable critical clocks. No functional change. Signed-off-by: Biju Das Reviewed-by: Geert Uytterhoeven --- v6: * New patch --- drivers/clk/renesas/rzg2l-cpg.c | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/drivers/clk/renesas/rzg2l-cpg.c b/drivers/clk/renesas/rzg2l-cp= g.c index f9e4af7f49d0..b68b0312f0e3 100644 --- a/drivers/clk/renesas/rzg2l-cpg.c +++ b/drivers/clk/renesas/rzg2l-cpg.c @@ -1586,6 +1586,20 @@ static struct mstop *rzg2l_mod_clock_get_mstop(struc= t rzg2l_cpg_priv *priv, u32 return NULL; } =20 +static void rzg2l_mod_clock_init_mstop_helper(struct rzg2l_cpg_priv *priv, + struct mod_clock *clk) +{ + /* + * Out of reset all modules are enabled. Set module state + * in case associated clocks are disabled at probe. Otherwise + * module is in invalid HW state. + */ + scoped_guard(spinlock_irqsave, &priv->rmw_lock) { + if (!rzg2l_mod_clock_is_enabled(&clk->hw)) + rzg2l_mod_clock_module_set_state(clk, true); + } +} + static void rzg2l_mod_clock_init_mstop(struct rzg2l_cpg_priv *priv) { struct mod_clock *clk; @@ -1595,15 +1609,7 @@ static void rzg2l_mod_clock_init_mstop(struct rzg2l_= cpg_priv *priv) if (!clk->mstop) continue; =20 - /* - * Out of reset all modules are enabled. Set module state - * in case associated clocks are disabled at probe. Otherwise - * module is in invalid HW state. - */ - scoped_guard(spinlock_irqsave, &priv->rmw_lock) { - if (!rzg2l_mod_clock_is_enabled(&clk->hw)) - rzg2l_mod_clock_module_set_state(clk, true); - } + rzg2l_mod_clock_init_mstop_helper(priv, clk); } } =20 --=20 2.43.0