From nobody Mon Apr 6 10:36:57 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6855C205E02 for ; Thu, 19 Mar 2026 12:47:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773924480; cv=none; b=lMoKww10RIPRIVEFmG1HSxaGIaqBdUjapbKJ0m6cdsDLINOJCV7z9wR+x+ul2wum9vMEmf7mNTIDhb+nEZ1dxdoC8HhG/DEUCGvj9yVCpgf+G2Ng2YFb68dKJ6I0T01xKD98t+dnxvC0wXncO2Lcj30ip4O0ybkx6zAyLJFQxeE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773924480; c=relaxed/simple; bh=pMPxPxDRNfc+0N6HiTnGZ1alPljuJjXc5/7GKiABYe4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=h4KxQMsAeXNsiI4I89EW9gr65w3LsTrvWXR4Nn0s5lo5b2YGC2Y/jG7uMqNchoQzz053YTbSohNdW3REXnwr9e6GI8yKu/isoV/M79Sb0oMg5Z9GNxKcQh1fHFl+OCd5CWxr6YNrBfbH/aehmxIWbUpgsej9FquqCM5y8yXlG04= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=K+XNkPqU; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="K+XNkPqU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773924479; x=1805460479; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=pMPxPxDRNfc+0N6HiTnGZ1alPljuJjXc5/7GKiABYe4=; b=K+XNkPqUob5KoN5cA6q5Qg3aMRC+MQaW2qXaUPHzjwK3TyZJkuFR8i89 hQLtMvZ5W8kumHL1dxgCGNEaMqQk5f54XSjWITql4l6NHprXYzstN4nK3 0LGVsgbrbVTMM5QbZQG1N/2KvRq/bl3kSUyD7JCkQa+NSVQez14XxgYql 3KNq6XzhyLeN56F286jNdeV6Gg0c2LQ3r5it4it/q9pHnohpBWCADfw/k pXydwRgVaKbV0Oy/ArDmB9P0FFZuN56dLKD2jHfHs2HWMFxXwsXlaeNIi 2jw5qXo5dFrxEhNKyDWKMYeUZ1qUtmpsaeeaU7dOG0r26WkAioRZO0WDn g==; X-CSE-ConnectionGUID: x0AsVJKrRH+4pz77NWxmPw== X-CSE-MsgGUID: 9AluuHNER66acuR7c/0RiA== X-IronPort-AV: E=McAfee;i="6800,10657,11733"; a="74881202" X-IronPort-AV: E=Sophos;i="6.23,129,1770624000"; d="scan'208";a="74881202" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2026 05:47:59 -0700 X-CSE-ConnectionGUID: 6p7TbT0kR7qfz157/t0SzQ== X-CSE-MsgGUID: iW8ysklORiK/R+/U0uUkaw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,129,1770624000"; d="scan'208";a="222057833" Received: from sannilnx-dsk.jer.intel.com ([10.12.231.107]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2026 05:47:58 -0700 From: Alexander Usyskin To: Greg Kroah-Hartman Cc: Menachem Adin , Alexander Usyskin , linux-kernel@vger.kernel.org, Todd Brandt Subject: [char-misc v2] mei: me: reduce the scope on unexpected reset Date: Thu, 19 Mar 2026 14:30:23 +0200 Message-ID: <20260319123023.2739223-1-alexander.usyskin@intel.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Avoid false-positive detection of unready hardware by triggering link reset only when we have driver in ENABLED state. Reported-by: Todd Brandt Closes: https://bugzilla.kernel.org/show_bug.cgi?id=3D221023 Tested-by: Todd Brandt Fixes: 2cedb296988c ("mei: me: trigger link reset if hw ready is unexpected= ") Signed-off-by: Alexander Usyskin --- V2: rebase over v7.0-rc4 drivers/misc/mei/hw-me.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/misc/mei/hw-me.c b/drivers/misc/mei/hw-me.c index d4612c659784..1e4a41ac428f 100644 --- a/drivers/misc/mei/hw-me.c +++ b/drivers/misc/mei/hw-me.c @@ -1337,19 +1337,13 @@ irqreturn_t mei_me_irq_thread_handler(int irq, void= *dev_id) /* check if we need to start the dev */ if (!mei_host_is_ready(dev)) { if (mei_hw_is_ready(dev)) { - /* synchronized by dev mutex */ - if (waitqueue_active(&dev->wait_hw_ready)) { - dev_dbg(&dev->dev, "we need to start the dev.\n"); - dev->recvd_hw_ready =3D true; - wake_up(&dev->wait_hw_ready); - } else if (dev->dev_state !=3D MEI_DEV_UNINITIALIZED && - dev->dev_state !=3D MEI_DEV_POWERING_DOWN && - dev->dev_state !=3D MEI_DEV_POWER_DOWN) { + if (dev->dev_state =3D=3D MEI_DEV_ENABLED) { dev_dbg(&dev->dev, "Force link reset.\n"); schedule_work(&dev->reset_work); } else { - dev_dbg(&dev->dev, "Ignore this interrupt in state =3D %d\n", - dev->dev_state); + dev_dbg(&dev->dev, "we need to start the dev.\n"); + dev->recvd_hw_ready =3D true; + wake_up(&dev->wait_hw_ready); } } else { dev_dbg(&dev->dev, "Spurious Interrupt\n"); --=20 2.43.0