From nobody Mon Apr 6 10:31:29 2026 Received: from mail-dl1-f45.google.com (mail-dl1-f45.google.com [74.125.82.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D508B3C9ED4 for ; Thu, 19 Mar 2026 12:02:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773921737; cv=none; b=gGukFJsUZGRXTVNp/z6stNuPMfgz/QFewUyIlB4IVZgRolc/9ltofUqCjQ52UUXxM3fBZOn6c43RZiy3b+qTHQCfX+v3+Vv4k7x1M4Lik0pVNpcAoxOYJASLtuBOXAR3AyYe8IoGyW6X/kvXhQuz0S/VUpCGKX0jKrLZFUO5bJk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773921737; c=relaxed/simple; bh=JUiUzabyePhuSj+i+hRICxzD74qG7YCEqOwub/6eTkE=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=NXMUcEO8EA8EIQAvG5jUuJyfk/WijHFIFoH/7naMUb1kjfLfryqnTSBbCW3uO+5CHP9Cfk4kZp/PgeQ5C/PlrFm3bFnp4Ot+0KVvWkGsmcf0dea7UKmsHIFnjQN/BAeZUN/ypkKX8H6VyvNNo1T5KHmUGTlQaDi6Asm6Hw5ufXM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gAS1vTtF; arc=none smtp.client-ip=74.125.82.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gAS1vTtF" Received: by mail-dl1-f45.google.com with SMTP id a92af1059eb24-126ea4b77adso538401c88.1 for ; Thu, 19 Mar 2026 05:02:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773921735; x=1774526535; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=cx0qCYEgpEY0APyH3BW58E7QngJ1Y7p1bZt4MgX1Fjw=; b=gAS1vTtF/lp1R1oe2MP6j1GZph1tahAYMgGKttQZDZ3HSSdoMro9z72pnhpOM5WhHP HOifHfg8+zlGeYp4lHElEh2flB2crwHgANzpAv13WstJCwtq4wIujf3YRDWgD4HArK+t ucUo7RoK8LnaTOVlspMyPK31wl4LCOYYMQbc0N1Es6AFmRN1IfkNVfdyWCngFbUgB95f /k6dHLgX94EuAzgRqENU/79Kfo7pSg1nEKY9H46gTTFaqGXuK18M+A3XaN1jK2Dc1cOb u9OUe6o462ymfLgSGP9xKacF0QanRjNMp40SMIaQ6HWYCk8lkqBs9dRgNuGyLLWih8xu 4mJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773921735; x=1774526535; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cx0qCYEgpEY0APyH3BW58E7QngJ1Y7p1bZt4MgX1Fjw=; b=mgwl+W2YP8/d155T5MXDK+VJ8we4u8+pg/fykMLAwoK/ngR/LE6A2HTcoc4RkGFzby JfI0QaVN8xhoIRrE9DwtzNfuQ/acyvV4kVMdnJyTTl3PO/OilzYLsL3luuPYUEl7YXNP rEnNxMtVPgDKSPE6HihbYz5+kgaXQX3OsgAm/G5rWgCvmC7Qarp28QP2vHWMb0IClnKL R24l1teYxXLr5g7ZnDjEEXkP6FBEWw0d6q/iLgv/zeHMeO6xWrOktso8xOqyHtKkthwl Uq9lr0AZXV3Ofcqvv+qulnooFAz9o8QfG8ZbOaIamlPVE7l2IHmv8AbpqXWH56dtJCIL dp6g== X-Forwarded-Encrypted: i=1; AJvYcCV2ag48ey1UlaHLr10xQurwu2PZg+5HPExtJ0Rogr0tOaTXsw0vDcecqOMiXVEr5aKfzBZcVX0A7SUoqcs=@vger.kernel.org X-Gm-Message-State: AOJu0YxxkG06U1hZT4dVWuDT0mtKDc95XXFHJNV5QSS1NPxXqLVKhZB/ vlNkWfGhebTtKEcWjHReYGrymrm7pL144UcPXienPDXvzki0NcMx7cki X-Gm-Gg: ATEYQzxg2EU64qa0Gtuyt8uRkmDkvRAGj3KRZKbERn/R77Q26F2qaZrJurn2LunTnnS KAVa5oJeYzUkDG9QvY0kw1R2sCU4G7cCXtXFKmMhLkhUUm3/KIbcUz9nH1cdrtwSh7vLqErI/zk uXDZmG+0RNsv8VE0j7FrL0cT48X4ZAVzYDj0eY3w8QTTDdNgG1Mnpzc0KqLxwjjZsaO6S58CpuH 45cLIcPdG3+JiyuRx+YEOv5ZzkOY6TENmyIW+uNeR6Z0UvCUbpWIajdlMcWjWc3pDKysoTP0e0X I0Ewdz92tHnQT12WamNWedVJA6pfUXY44UaHRS8c1SIHJ+4Efv6gQMzbKfHbsLCzDTk3Q6awhJa mC64VimOrUlHpHNaqWyh9t08s+xt6neH8f7CaYHiixpqtsKMCOqpPEkO2A8ZxGI2jIJ0grSTy/g vVvCKSxzKokbj5lilpDIkWLgufr/dW2Mtd X-Received: by 2002:a05:7022:692:b0:128:d375:f1d4 with SMTP id a92af1059eb24-129a7160854mr3759174c88.28.1773921734412; Thu, 19 Mar 2026 05:02:14 -0700 (PDT) Received: from localhost.localdomain ([149.102.251.98]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-129a7153051sm6311253c88.0.2026.03.19.05.02.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 05:02:13 -0700 (PDT) From: Gabriel Rondon To: vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org Cc: greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] staging: greybus: audio: use sysfs_emit() in show functions Date: Thu, 19 Mar 2026 12:02:01 +0000 Message-Id: <20260319120201.25210-1-grondon@gmail.com> X-Mailer: git-send-email 2.33.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace sprintf() with sysfs_emit() in all sysfs attribute show functions. sysfs_emit() is aware of the sysfs buffer page size limit and should be used instead of sprintf() for sysfs show callbacks to prevent potential buffer overflows. Also add the missing trailing newline to each output, which is the standard convention for sysfs attributes. Signed-off-by: Gabriel Rondon --- drivers/staging/greybus/audio_manager_module.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/stagi= ng/greybus/audio_manager_module.c index e87b82ca6..f22ee73eb 100644 --- a/drivers/staging/greybus/audio_manager_module.c +++ b/drivers/staging/greybus/audio_manager_module.c @@ -76,7 +76,7 @@ static void gb_audio_module_release(struct kobject *kobj) static ssize_t gb_audio_module_name_show(struct gb_audio_manager_module *m= odule, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sprintf(buf, "%s", module->desc.name); + return sysfs_emit(buf, "%s\n", module->desc.name); } =20 static struct gb_audio_manager_module_attribute gb_audio_module_name_attri= bute =3D @@ -85,7 +85,7 @@ static struct gb_audio_manager_module_attribute gb_audio_= module_name_attribute =3D static ssize_t gb_audio_module_vid_show(struct gb_audio_manager_module *mo= dule, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sprintf(buf, "%d", module->desc.vid); + return sysfs_emit(buf, "%d\n", module->desc.vid); } =20 static struct gb_audio_manager_module_attribute gb_audio_module_vid_attrib= ute =3D @@ -94,7 +94,7 @@ static struct gb_audio_manager_module_attribute gb_audio_= module_vid_attribute =3D static ssize_t gb_audio_module_pid_show(struct gb_audio_manager_module *mo= dule, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sprintf(buf, "%d", module->desc.pid); + return sysfs_emit(buf, "%d\n", module->desc.pid); } =20 static struct gb_audio_manager_module_attribute gb_audio_module_pid_attrib= ute =3D @@ -104,7 +104,7 @@ static ssize_t gb_audio_module_intf_id_show(struct gb_a= udio_manager_module *modu struct gb_audio_manager_module_attribute *attr, char *buf) { - return sprintf(buf, "%d", module->desc.intf_id); + return sysfs_emit(buf, "%d\n", module->desc.intf_id); } =20 static struct gb_audio_manager_module_attribute @@ -115,7 +115,7 @@ static ssize_t gb_audio_module_ip_devices_show(struct g= b_audio_manager_module *m struct gb_audio_manager_module_attribute *attr, char *buf) { - return sprintf(buf, "0x%X", module->desc.ip_devices); + return sysfs_emit(buf, "0x%X\n", module->desc.ip_devices); } =20 static struct gb_audio_manager_module_attribute @@ -126,7 +126,7 @@ static ssize_t gb_audio_module_op_devices_show(struct g= b_audio_manager_module *m struct gb_audio_manager_module_attribute *attr, char *buf) { - return sprintf(buf, "0x%X", module->desc.op_devices); + return sysfs_emit(buf, "0x%X\n", module->desc.op_devices); } =20 static struct gb_audio_manager_module_attribute --=20 2.33.0