From nobody Mon Apr 6 10:32:53 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2764375F83 for ; Thu, 19 Mar 2026 11:38:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773920329; cv=none; b=lGMIq3ZEICGPG3ndfn6yvnHwFfKaLxlKKpF2B16BPngqHfbVsodg8EidH2EZy6OLK4sdHpqXbE+eftoN22POkksx7tkHVLiHRRQxq/TEAvFk11VqbPEgLUGxTPLIyIyhw9FbrVMObrHITSiWURMfcz0FXhnDiOoU+UkGtAPcgOo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773920329; c=relaxed/simple; bh=t5jw6g7YnoYXCemaevIyVUj0hWiJOSZ0OosTNRjkSZ8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=F5nt5eJISL2NZ+wwPaWW37r8mZFLONDxlq1dOL+G7SouoWjKdHTeBcKv19TlvpHklGJ/OV5dVN9uPKJHJQxklfaSghzJOJZrFHJfwTRvBJ8ULpOHjLAkWcgnV51+gk8IMam6vYq84r+reXcr9jqvN9XP5tYWfvBptDDEUtAzpsU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IsvlvHbM; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IsvlvHbM" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-35bb7afdc38so596224a91.1 for ; Thu, 19 Mar 2026 04:38:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773920325; x=1774525125; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=b4w2v6nZzIlyeI0PLLl+tEcOygbxhs5NbzP+idI4uiU=; b=IsvlvHbMGd+hgJwz4DsVgNCnfXGpiMXc3CWnDaCUaCGMPFK8juK1qZsih/JrGDK9Cv cR+5+uN4+MOfLNkwcRStbiPoC5+1RViUsIclhmm41MAsbWGqO8yc8qI+Z92hpdUGs7ON rARASY4qZs9mLwKLGexcnjxsmWGSGZVjmHqfh1FFWuXpweW6USv8HcX4damxp7Ik1OWh dc4VaAUtmsw0j0jCBq7qB1eUymgV4gxKdBnfmD3TyePNTZ2nBon4Mjh8Qgx3lMnUy7rn 7d1d3w9PDGF1L1go5wrxmXQw22bRQ69lHqoLWIj5pMKi6UEjQrHGwewS53bAKeMYS8eK s7CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773920325; x=1774525125; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=b4w2v6nZzIlyeI0PLLl+tEcOygbxhs5NbzP+idI4uiU=; b=DmRPpbaq95ceXTok0fnJYyGeUn0PDM+vhafWogvjnWIH1BQ878Vm9t4fHNR5mPFilA xy3v9IZJGEFW1aT28W+BiVorjXNuSl1GLaDVQnWxkSYB6Lv44WFTVSgkTaJLrhFe4HFX mB3LvaWI8W5j8tlXiNbFqTlEYmBWGttXHq+CISuU9PwXQMSTtEeFgAYwXi3252e26hHb JOjGYYn6EmNBbPh/ZninwJNKn2sd3om1PJrK+qOsVEhWZds8Kc3BdG43cwu9DI7VXaDB 1k07N97pSAGDs+/Kkl4TjvB1gf92nXWtBvENMHH2PdkGwcc3uVZTfhEzggsTOGu7sWXA 7YFg== X-Forwarded-Encrypted: i=1; AJvYcCXmkEePHsQ8i+geUEMXa+1ZKvtO04nDjK8+/oV0bODz0do+1bE97gX6Nfpin7mcXMGwLZWGKdPXEztJCeo=@vger.kernel.org X-Gm-Message-State: AOJu0YyBYK6rHvHjodCYcwcImd0J6dSHugGEi5Nu9d03pGN4ND92Py3z XJ+7Wvbflw8uAz2ozu/JkJev444nwnooadm6nnK2mNerKXGLRwP7q9ng X-Gm-Gg: ATEYQzydaf4E4nEJmLJjUHS5QvsUXZVgZO5VRJD7z7xST1QGk7/NRTUR89UuabLKg5/ u6+WquSqcA3nhkhMS2ipWMfTs0lxlCM6x6QcFJOfmXOHjyF9ma1H58kMdAESyOzH/OERRZRtzyE u0Rxc++Fn72k3aW668XBZlUaKti+UhmPZfJDwwgxlCi4kazIl7rdH+TvpTVoEgoTDR7NpKb8wSL /WN14lhobzoiWYIdgf5JbGWQBpAOaclVCaXd83yDKszpMGdlv3ZEGnOzb7pjAQqEU3vWL1TOgiU 4+fpy880AXE0O9vtIbtfVD/x9ubm9L1/Ich9EGEJ/O6nfObQYjk8zpqHru2GDDU1TQWE8WYLCZ/ Be6C+MoxgaDBcm2x/dUa+hSatUF3z/PvIrh1hBMnZ0rRLnzroqN6r/xeQu5AoFoIOOikoljjieK mqCmdhe2SHv6NuhmL5rY0upp56weWddZyYZEJ9rZERSAlMAfSTdp23 X-Received: by 2002:a17:90b:3f47:b0:35b:90e7:c458 with SMTP id 98e67ed59e1d1-35bb9e3b965mr6170487a91.3.1773920324745; Thu, 19 Mar 2026 04:38:44 -0700 (PDT) Received: from ZC-202510311500 ([123.139.41.12]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c741e0da7a6sm5191149a12.13.2026.03.19.04.38.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 04:38:44 -0700 (PDT) From: Haoyu Lu To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, "haoyu.lu" Subject: [PATCH] staging: rtl8723bs: fix long lines in core files Date: Thu, 19 Mar 2026 19:38:35 +0800 Message-ID: <20260319113836.1063-1-hechushiguitu666@gmail.com> X-Mailer: git-send-email 2.53.0.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "haoyu.lu" Fix lines longer than 80 characters in rtl8723bs core files: - drivers/staging/rtl8723bs/core/rtw_ap.c - drivers/staging/rtl8723bs/core/rtw_cmd.c Split long comment lines into multiple lines and extract repeated expressions to temporary variables to reduce line length. This addresses the TODO item "checkpatch.pl fixes - most of the remaining ones are lines too long." Signed-off-by: haoyu.lu --- drivers/staging/rtl8723bs/core/rtw_ap.c | 18 +++++++++++------- drivers/staging/rtl8723bs/core/rtw_cmd.c | 9 ++++++--- 2 files changed, 17 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8= 723bs/core/rtw_ap.c index 864cd8b6d1f1..0d40c8f45899 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ap.c +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c @@ -270,7 +270,8 @@ void expire_timeout_chk(struct adapter *padapter) u8 backup_oper_channel =3D 0; struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; =20 - /* switch to correct channel of current network before issue keep-alive= frames */ + /* switch to correct channel of current network before issue */ + /* keep-alive frames */ if (rtw_get_oper_ch(padapter) !=3D pmlmeext->cur_channel) { backup_oper_channel =3D rtw_get_oper_ch(padapter); r8723bs_select_channel(padapter, pmlmeext->cur_channel); @@ -610,9 +611,9 @@ static void update_hw_ht_param(struct adapter *padapter) * AMPDU_para [1:0]:Max AMPDU Len =3D> 0:8k , 1:16k, 2:32k, 3:64k * AMPDU_para [4:2]:Min MPDU Start Spacing */ - max_AMPDU_len =3D pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para & 0x03; - - min_MPDU_spacing =3D (pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para & 0x= 1c) >> 2; + u8 ampdu_para =3D pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para; + max_AMPDU_len =3D ampdu_para & 0x03; + min_MPDU_spacing =3D (ampdu_para & 0x1c) >> 2; =20 rtw_hal_set_hwreg(padapter, HW_VAR_AMPDU_MIN_SPACE, (u8 *)(&min_MPDU_spac= ing)); =20 @@ -839,7 +840,8 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 = *pbuf, int len) /* beacon interval */ /* ie + 8; 8: TimeStamp, 2: Beacon Interval 2:Capability */ p =3D rtw_get_beacon_interval_from_ie(ie); - /* pbss_network->configuration.beacon_period =3D le16_to_cpu(*(unsigned s= hort*)p); */ + /* pbss_network->configuration.beacon_period =3D le16_to_cpu */ + /* (*(unsigned short*)p); */ pbss_network->configuration.beacon_period =3D get_unaligned_le16(p); =20 /* capability */ @@ -1497,7 +1499,8 @@ void update_beacon(struct adapter *padapter, u8 ie_id= , u8 *oui, u8 tx) switch (ie_id) { case 0xFF: =20 - update_bcn_fixed_ie(padapter);/* 8: TimeStamp, 2: Beacon Interval 2:Capa= bility */ + update_bcn_fixed_ie(padapter); + /* 8: TimeStamp, 2: Beacon Interval 2:Capability */ =20 break; =20 @@ -2075,7 +2078,8 @@ void stop_ap_mode(struct adapter *padapter) pmlmepriv->update_bcn =3D false; pmlmeext->bstart_bss =3D false; =20 - /* reset and init security priv , this can refine with rtw_reset_security= priv */ + /* reset and init security priv, this can refine */ + /* with rtw_reset_securitypriv */ memset((unsigned char *)&padapter->securitypriv, 0, sizeof(struct security_priv)); diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl= 8723bs/core/rtw_cmd.c index abb84f8aecbe..57e6aa433627 100644 --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c @@ -171,7 +171,8 @@ int rtw_init_cmd_priv(struct cmd_priv *pcmdpriv) =20 pcmdpriv->cmd_seq =3D 1; =20 - pcmdpriv->cmd_allocated_buf =3D kzalloc(MAX_CMDSZ + CMDBUFF_ALIGN_SZ, GFP= _ATOMIC); + pcmdpriv->cmd_allocated_buf =3D kzalloc(MAX_CMDSZ + CMDBUFF_ALIGN_SZ, + GFP_ATOMIC); if (!pcmdpriv->cmd_allocated_buf) return -ENOMEM; =20 @@ -183,7 +184,8 @@ int rtw_init_cmd_priv(struct cmd_priv *pcmdpriv) return -ENOMEM; } =20 - pcmdpriv->rsp_buf =3D pcmdpriv->rsp_allocated_buf + 4 - ((SIZE_PTR)(pcmdp= riv->rsp_allocated_buf) & 3); + pcmdpriv->rsp_buf =3D pcmdpriv->rsp_allocated_buf + 4 - + ((SIZE_PTR)(pcmdpriv->rsp_allocated_buf) & 3); =20 pcmdpriv->cmd_issued_cnt =3D 0; pcmdpriv->cmd_done_cnt =3D 0; @@ -298,7 +300,8 @@ void rtw_free_cmd_priv(struct cmd_priv *pcmdpriv) int rtw_cmd_filter(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj); int rtw_cmd_filter(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj) { - u8 bAllow =3D false; /* set to true to allow enqueuing cmd when hw_init_c= ompleted is false */ + u8 bAllow =3D false; + /* set to true to allow enqueuing cmd when hw_init_completed is false */ =20 if (cmd_obj->cmdcode =3D=3D GEN_CMD_CODE(_SetChannelPlan)) bAllow =3D true; --=20 2.53.0.windows.1