From nobody Mon Apr 6 14:58:40 2026 Received: from zg8tmtyylji0my4xnjeumjiw.icoremail.net (zg8tmtyylji0my4xnjeumjiw.icoremail.net [162.243.161.220]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 669C139FCB6; Thu, 19 Mar 2026 08:02:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=162.243.161.220 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773907384; cv=none; b=rNM1c5NT8hmQ5UkIO/7sg1QcZiZn1q1UQXKnJIrQoY6e6SdUBdh0ZGkNZSKHBnN6USme1EGsW7+vhrzQSUF/Rt+gfvzxpu4Jy7dPD53EsJxjvTO9RHmMIPD//tZb2bRscmUi3KobqS/aWULPNvy86jsnIVTogAIAWnIaVPGTDuo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773907384; c=relaxed/simple; bh=Vswjcnpvn4iFua0DERMLys0sUVckqLaR59H5FUHpf98=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Md6lV2sY96Q3clXlLuaktwnD6jztDZMxrHqh0zsMBdL22JqlqI/FlKwrJfrBMtwCLrQbUtMY+FxBa8MCzRkI+n7IZ+2Wten4lSo85/xasGIhtURpaKc5me0hww1qBDnTjCkFwh+vxskriVkmU9xL77pro4VVABLbP3vN6YZZfQM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lzu.edu.cn; spf=pass smtp.mailfrom=lzu.edu.cn; arc=none smtp.client-ip=162.243.161.220 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lzu.edu.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lzu.edu.cn Received: from a800-server-1.tail7779b.ts.net (unknown [172.30.111.252]) by app2 (Coremail) with SMTP id zQmowACHHoWUrbtpLTsjAA--.18246S2; Thu, 19 Mar 2026 16:02:28 +0800 (CST) From: Yang Yang To: aconole@redhat.com, echaudro@redhat.com, i.maximets@ovn.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, pshelar@ovn.org, martin.varghese@nokia.com, netdev@vger.kernel.org, dev@openvswitch.org, linux-kernel@vger.kernel.org, yifanwucs@gmail.com, tomapufckgml@gmail.com, tanyuan98@outlook.com, bird@lzu.edu.cn, n05ec@lzu.edu.cn Subject: [PATCH net] openvswitch: validate MPLS set/set_masked payload length Date: Thu, 19 Mar 2026 08:02:27 +0000 Message-ID: <20260319080228.3423307-1-n05ec@lzu.edu.cn> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQmowACHHoWUrbtpLTsjAA--.18246S2 X-Coremail-Antispam: 1UD129KBjvJXoW7AFyrGrykCr1UXF17ZF48Crg_yoW8Gr43pF y2kr17trW5Ary2gw4kAF1xuay7KF1kXrsrGF90ka18A3Z0gF95trWrKFZIvwnrCrWqkFWf XrZFqFsxAasxZFJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUBF1xkIjI8I6I8E6xAIw20EY4v20xvaj40_JrC_JFWl1IIY67AE w4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2 IY67AKxVW7JVWDJwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2 z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcV Aq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j 6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64 vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4IIrI8v6xkF7I0E8cxan2IY04v7MxkF7I0E n4kS14v26r4a6rW5MxkIecxEwVCm-wCF04k20xvY0x0EwIxGrwCF04k20xvE74AGY7Cv6c x26r48MxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCj r7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVW8ZVWrXwCIc40Y0x0EwIxGrwCI42IY6x IIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAI w20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x 0267AKxVW8Jr0_Cr1UYxBIdaVFxhVjvjDU0xZFpf9x0pRpOJnUUUUU= X-CM-SenderInfo: zqqvvuo6o23hxhgxhubq/1tbiAQILCWm6ynkMRAACsr Content-Type: text/plain; charset="utf-8" validate_set() accepted OVS_KEY_ATTR_MPLS as variable-sized payload for SET/SET_MASKED actions. In action handling, OVS expects fixed-size MPLS key data (struct ovs_key_mpls). Use the already normalized key_len (masked case included) and reject non-matching MPLS action key sizes. Reject invalid MPLS action payload lengths early. Fixes: fbdcdd78da7c ("Change in Openvswitch to support MPLS label depth of = 3 in ingress direction") Reported-by: Yifan Wu Reported-by: Juefei Pu Tested-by: Ao Zhou Co-developed-by: Yuan Tan Signed-off-by: Yuan Tan Suggested-by: Xin Liu Signed-off-by: Yang Yang Reviewed-by: Ilya Maximets --- net/openvswitch/flow_netlink.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c index 67fbf6e48a301..45444b81e9b97 100644 --- a/net/openvswitch/flow_netlink.c +++ b/net/openvswitch/flow_netlink.c @@ -2953,6 +2953,8 @@ static int validate_set(const struct nlattr *a, case OVS_KEY_ATTR_MPLS: if (!eth_p_mpls(eth_type)) return -EINVAL; + if (key_len !=3D sizeof(struct ovs_key_mpls)) + return -EINVAL; break; =20 case OVS_KEY_ATTR_SCTP: --=20 2.43.0