From nobody Mon Apr 6 14:58:41 2026 Received: from azure-sdnproxy.icoremail.net (azure-sdnproxy.icoremail.net [207.46.229.174]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4B63F40DFAA; Thu, 19 Mar 2026 07:43:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=207.46.229.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773906233; cv=none; b=R8GsKGENM/H7FHDWqtK0Ua+ths+XkOiz/uL9ijlZROz3cjOdhIO16F9Q7opL4+xMEwqvT00wX64ebHF4q0t3Vvj/6bll3Nd4eEqOJc2WzeesaaERl2f+3EGydvl8PhA0aN8WAEag9Nv0lvJlZVDzelch8WfPYiqDCqypR7A4v1c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773906233; c=relaxed/simple; bh=mR6mXk1flXLAr0a0ukqfOmFaeg6R/Ivk6Et7pJ4qX6I=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=XVY+e0jX/kIdlhT8OK1BCkNU8358sG6UAGSlCJLsZHGnsLxGIozXAqf4e5x7MIp8glcYFSqbpoUyJp6Vj9NXagb6UGmiKo2E/H9E2NVho7HApOk1HOTVHVMTL7Bn1UzyOr80LeFqKNePvYkCp2xyvGRlqbk/cnmdZWAsR12mPUg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lzu.edu.cn; spf=pass smtp.mailfrom=lzu.edu.cn; arc=none smtp.client-ip=207.46.229.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lzu.edu.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lzu.edu.cn Received: from a800-server-1.tail7779b.ts.net (unknown [172.30.111.252]) by app1 (Coremail) with SMTP id ygmowACnHf7xqLtpkeh1AA--.9689S2; Thu, 19 Mar 2026 15:42:42 +0800 (CST) From: Yang Yang To: aconole@redhat.com, echaudro@redhat.com, i.maximets@ovn.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, pshelar@nicira.com, tgraf@suug.ch, netdev@vger.kernel.org, dev@openvswitch.org, linux-kernel@vger.kernel.org, yifanwucs@gmail.com, tomapufckgml@gmail.com, tanyuan98@outlook.com, bird@lzu.edu.cn, n05ec@lzu.edu.cn Subject: [PATCH net] openvswitch: defer tunnel netdev_put to RCU release Date: Thu, 19 Mar 2026 07:42:41 +0000 Message-ID: <20260319074241.3405262-1-n05ec@lzu.edu.cn> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: ygmowACnHf7xqLtpkeh1AA--.9689S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Zw4xXr43Zw1kJFy5Jw4xWFg_yoW8XF1rpa 9agFWUKry8AFsrJa18A3yxury09Fs5AF1UGa4DC34fZr4DX3sak34UKrWqvFW5ArWfJFZY vr9Fvry8tw1fArJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUBY1xkIjI8I6I8E6xAIw20EY4v20xvaj40_JrC_JFWl1IIY67AE w4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2 IY67AKxVW7JVWDJwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2 z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcV Aq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j 6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64 vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4IIrI8v6xkF7I0E8cxan2IY04v7MxkF7I0E n4kS14v26r4a6rW5MxkIecxEwVCm-wCF04k20xvY0x0EwIxGrwCF04k20xvE74AGY7Cv6c x26r48MxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCj r7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVW8ZVWrXwCIc40Y0x0EwIxGrwCI42IY6x IIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAI w20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x 0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7sRi_HU3UUUUU== X-CM-SenderInfo: zqqvvuo6o23hxhgxhubq/1tbiAQULCWm6ynkGAgAEsm Content-Type: text/plain; charset="utf-8" ovs_netdev_tunnel_destroy() may run after NETDEV_UNREGISTER already detached the device. Dropping the netdev reference in destroy can race with concurrent readers that still observe vport->dev. Do not release vport->dev in ovs_netdev_tunnel_destroy(). Instead, let vport_netdev_free() drop the reference from the RCU callback, matching the non-tunnel destroy path and avoiding additional synchronization under RTNL. Fixes: a9020fde67a6 ("openvswitch: Move tunnel destroy function to oppenvsw= itch module.") Reported-by: Yifan Wu Reported-by: Juefei Pu Tested-by: Ao Zhou Co-developed-by: Yuan Tan Signed-off-by: Yuan Tan Suggested-by: Xin Liu Signed-off-by: Yang Yang Reviewed-by: Ilya Maximets --- net/openvswitch/vport-netdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/openvswitch/vport-netdev.c b/net/openvswitch/vport-netdev.c index 6574f9bcdc026..44dbe8a9b0778 100644 --- a/net/openvswitch/vport-netdev.c +++ b/net/openvswitch/vport-netdev.c @@ -189,8 +189,6 @@ void ovs_netdev_tunnel_destroy(struct vport *vport) */ if (vport->dev->reg_state =3D=3D NETREG_REGISTERED) rtnl_delete_link(vport->dev, 0, NULL); - netdev_put(vport->dev, &vport->dev_tracker); - vport->dev =3D NULL; rtnl_unlock(); =20 call_rcu(&vport->rcu, vport_netdev_free); --=20 2.43.0