From nobody Wed Apr 8 10:21:41 2026 Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D7F03451DC for ; Thu, 19 Mar 2026 06:26:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773901597; cv=none; b=ay2bTCVuooZv3WhwleCi6af7JVLN4XkFsora87fEbJciWStjAb0X4g4LPuUvJps7zY0M3x+KfIJkzl28kD3zbFpgsF7WhagUOECV2+Us8l/eI0b5NExR9D29T+j/5mnunIy1yg2l/4ST6Rt/ez83Yb7t/ZN+tBBprSiJB1d0Hi4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773901597; c=relaxed/simple; bh=IWzRBK7yZLv5/LuGuwE7ds2/nn6NnLWIT8wBa+Wt7mI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Hl1hhRQUAP1MNLzuDtQtTyURMW+Q1MTUN23zWJp6lGAcMu1T+h7K9uEJIMQ0t+YxWUhII7AFLbP5t2UhgaouLY6dHDhsdcSPKYp2g6uYF8/ZMTYKUJDyf7EtWdRkALZwi2o0c0LkyRtL+9GwpF1XAbJjLO0vSjRwcuRLHomASH4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mbvMkr7L; arc=none smtp.client-ip=209.85.167.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mbvMkr7L" Received: by mail-oi1-f176.google.com with SMTP id 5614622812f47-46704177508so482020b6e.0 for ; Wed, 18 Mar 2026 23:26:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773901595; x=1774506395; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=TeL0PGol9P+fZjiED2N5BcwRBJQEArDL1vipr1fxFGE=; b=mbvMkr7L8dEbEpCXL/qqh5lmdAPhMfnxafjNiV51z8yW3rWZirc2t0gzPjA51kL6px y4V5Hm0RaW7+FUbGorfZEeuODX5gz2wzAC5ErWJalLJshx6IZvVPl9Jvenw263D9Bo2V y232S/tvTGptTrT+YzotCyV1QtDWcS3b0Q7v8TRsL4mV3thsYvW0NvqkVbn75kZ2H1nu St529gfPai+MWur139IfVIeAneadU5LjIpwHjivwt7Nc4mXgWUoz6ynkoCN6qu1q2ahH STVmBNvR+Pibv/cg2rGY679tLG9y7wfNP8+SKaR6hwknKOv6jE3iWnM7pIvJQ7rowLB8 NJ/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773901595; x=1774506395; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TeL0PGol9P+fZjiED2N5BcwRBJQEArDL1vipr1fxFGE=; b=neitd5Bncknapa+6aSCkIpvyGOJfXjyoDdiB5WQawXsVPJei3YuqYI/iujIE4Y2nrm UrZpJ0RsNoqRg/tvZGBsyj1RbuxhDaiOpWN/a35KUijErk2rOqC9sS/HThhsZZLs/OuD 6/MsQGHFeD8TDqjtJxvlla+Ti2ZTipnzGB40YxlhV6ioKIAR8e94ioAigLnWf+81+acA oX/KjLaIRwSNl+K1t1qfBWDHt5vLst11mIcGqRXcsOs2i7IFJdAc9PjnVsmZrHYUAlWQ l3BitCYu740SjqSUlgYKZEgt5I09Pj8H0v0LlwQntqPiRjv17mUhuh05uutZzWhhLUK+ oh0A== X-Forwarded-Encrypted: i=1; AJvYcCWJSUT6R0+fGEUKkvyrUgp8ZaXLFdCQ0Ji+DdDCZ9ASM2sJEIWoUAPwwRv8R+R6QCPAcW16F+fF6XwXMYQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yyr26yQiV68muX1wd51CoeYpxZB/792tmav+MjskXA8J0ZEWbpO lPN7ow3+qCLVmyc0ygdy8zClUKlHJk8gb7atatb+rV/dpFhvE72wKHDD X-Gm-Gg: ATEYQzwIXuHRzYKcCFffjYpR9qvx5OZ7qv8bySLf/IamKg0NRuFQIrEuIgpvvniV2G9 EIbddG/11y2HHhZ4DEcZzOrPBQe7XjhwFtq2lo+v8Oud1e5BhqVwWxkwhRur+iyPvOE//SZhdLr L0o0R+OY/bqV4ra/mdXreRBTqPnwlgrGB19wDzG+73anipqXWT7UBDRdKrqUVaMW+AoRi877BaP cclMPNvksWbVzDEBcC2aVOtYz2IAzchOOdmtcvRBvpsjEc8gSG8QtK5bI6B0jc5q0pPPBQPQ4el HlDdEjYGTGSY5L9hm7VSt03+CwQYJDsNaYpT1blxZl0eCoNiWVI0YPlI9OwqLIGJZz/nBajN2+B oH0vm8zpKOJ/W7vql76dnZIQ/v5Vk0ffz+S+9qlJIxPIXXf420k1FIiAOmclAFycpRKg+eXIoQp ztKC41eLlXKuY= X-Received: by 2002:a05:6808:c195:b0:467:4a7:e3f6 with SMTP id 5614622812f47-467ba0c1a8dmr3264312b6e.2.1773901595167; Wed, 18 Mar 2026 23:26:35 -0700 (PDT) Received: from arch ([177.249.162.66]) by smtp.gmail.com with ESMTPSA id 5614622812f47-467baaccdccsm3093124b6e.16.2026.03.18.23.26.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 23:26:34 -0700 (PDT) From: Marco Antonio Solis Segura To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Marco Antonio Solis Segura Subject: [PATCH] staging: rtl8723bs: split multiple assignment in rtw_mgmt_xmitframe_coalesce Date: Thu, 19 Mar 2026 00:26:26 -0600 Message-ID: <20260319062626.605200-1-mshdevv@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Cleanup the multiple assignment of tmp_buf and BIP_AAD to fix the checkpatch.pl CHECK: "Multiple assignments should be avoided". Additionally, reorder the assignments to ensure tmp_buf is assigned only after BIP_AAD has been validated as non-NULL. Signed-off-by: Marco Antonio Solis Segura --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 19758e2f5903..d75f60efb7b6 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -1194,12 +1194,13 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *pad= apter, struct sk_buff *pkt, s pwlanhdr =3D (struct ieee80211_hdr *)pframe; =20 ori_len =3D BIP_AAD_SIZE + pattrib->pktlen; - tmp_buf =3D BIP_AAD =3D kzalloc(ori_len, GFP_ATOMIC); - subtype =3D GetFrameSubType(pframe); /* bit(7)~bit(2) */ + BIP_AAD =3D kzalloc(ori_len, GFP_ATOMIC); =20 if (!BIP_AAD) return _FAIL; =20 + tmp_buf =3D BIP_AAD; + subtype =3D GetFrameSubType(pframe); /* bit(7)~bit(2) */ spin_lock_bh(&padapter->security_key_mutex); =20 /* only support station mode */ --=20 2.53.0