From nobody Mon Apr 6 17:41:33 2026 Received: from mail-qt1-f227.google.com (mail-qt1-f227.google.com [209.85.160.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EFBC397E99 for ; Thu, 19 Mar 2026 05:53:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.227 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773899586; cv=none; b=aspolCZThxXqwJzvTn3wATuUAh8YjXc9aY/uLJLvb54aNyhnrRaeg/EYi80Mlpfn0ZbvETD/6V44tx2GlJxrm95FJ+549vj/WbmgiXVkhXf0vgma0yYzwFeqKAuZPEhKjH69gd12EnD+yRdLLl5HNsLSMWFl7QEEKhjNjOGuS+I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773899586; c=relaxed/simple; bh=xeLBGKWLDwoWzVUgrLFagxSMqAxIiAVyI6AvxJHgAb4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EcljydsJyP7YaPlei2xWQB6nt5ZlVgIKHOyEoFtazwvXxqoB8B8u8wyD7sbBD/7Hef/25W0XI8FbOABASuCt4vnmIqweH2oByAL3mhECLX+2rPozxf1oIXgmGH2WYMIVEpL8oHd8xzEvXnmLmrb3z4A0+pfo3y2SXpJt9oie6qw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Ro0wtw1A; arc=none smtp.client-ip=209.85.160.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Ro0wtw1A" Received: by mail-qt1-f227.google.com with SMTP id d75a77b69052e-50934b8ab60so17258891cf.0 for ; Wed, 18 Mar 2026 22:53:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773899584; x=1774504384; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AAh3ISKJQxB+of/XmTrFR/7AjtNkBJimjNnj4gDwdz4=; b=YjKfFy3HlE+0GTMnjjd4eLDq9RDhZTbhEzADoXWKSEfjQvkktZZ/QuBNl26KqWLlbd IKNPfnLxFraz/eAMtSLfj/yIxeA33CiQ6+J7kOLkcLh3axgls3RqkuNLjC7kl8/WnAhv uPq1lym3qfpbXAMo2ugo5dc0oiTCWso5zy0j8iLbFrfnqnH/aEqu7tfnl4bEdEnOv2vI c7xeEnR16wJWlR12kzmlTt2VN7fV0EqWlVIa6tuYpMxHkFHmYlc9zCDIIM3IJuHFVbxn rD++5eGQoLdpSgMhAUv3xqWS3jb1enDSOYWg6cy4drRVEhsKOXPUhsZ5TDqkObQ7wfxD aiyw== X-Forwarded-Encrypted: i=1; AJvYcCXTG2ZZKIofNtMMg0O6D8XOnPCTONhSihpJzRC/6W5fRmb4sCrW8ifv9ddlehDArB7c2lX7jYFuZWVkTAQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxoO8g6THF4mkSMhIMFv+4uhdutr1XSWnF+pWSI/RC08fcmIs+D ekyxRf76KMYvlygXxWzDoJQ6WtzvIuC7xoT96qlKp37FTgHPXFDly+MDKl7iCzuEF0DY7JUdQI6 invDlDdzfJO8B/s3JHBRo40KpQqXr1LNKx8i+fbmTVPlQ2pTsYBUDtDdgpL1qlEgly9jF9hhwOT 6XeRIJk7Eh0B+kBMmLkceq5pnlGDwSrO0tng9mB5B374y9bdpOuJNNuxN71CTRhLykjnPHFGmxm N0cyCXrw8q8/6gTzQ== X-Gm-Gg: ATEYQzzVpbiOo9ScX8iPgtE28gdW/fiMyoyvOb1CH7GXSlui3gbAFDda/dLD25PPVlZ ML7GOvDai644flnKUj8wkBilMge61Z7aYinVrhJPDbIJZC8rK25d12FeisiIFGnO+YKB45cmllQ xpa29IfZAa8rz9+/IA09uhShWXVGlylGH4mBxRTWXHBtwrXsH1tg5AF9GrAk1HrL/6EkZ++doiN BloygVx5BVTqW1nV6RlFccBct+3DmzTltxFjvtzBg4dHDlvQKzqbyW+DwgOxgHd+bnlupzpDEY5 ain55ZGrhiTTp9Oav5Ab6PJPxI3YzUJAd3/f1PpXOt2Wppq/dYvnjlkUGI8rfrOVtIb5scQbQT8 SV1Ofj2/z5LPBBlUcpiZ8KiAToa038OC6PTD+VoYtBmeoPeNkoZGMG81DNTGPJluT+ZmatiMTtY r4oEgDXLlK65SlP6fjXTfvWVwuBmHgrfldQwg+c5pcpENWFRCYLNaEB8s= X-Received: by 2002:a05:622a:612:b0:509:2231:977a with SMTP id d75a77b69052e-50b247666c6mr28799971cf.30.1773899584291; Wed, 18 Mar 2026 22:53:04 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-22.dlp.protect.broadcom.com. [144.49.247.22]) by smtp-relay.gmail.com with ESMTPS id d75a77b69052e-50b135a80ebsm5434981cf.4.2026.03.18.22.53.04 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Mar 2026 22:53:04 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-yx1-f71.google.com with SMTP id 956f58d0204a3-64ca2fce827so2404738d50.0 for ; Wed, 18 Mar 2026 22:53:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1773899583; x=1774504383; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AAh3ISKJQxB+of/XmTrFR/7AjtNkBJimjNnj4gDwdz4=; b=Ro0wtw1ATY+kSZTpKf0mOx1AxeQZCNlhIZWMHjGqMAi5G9wwCLBD/nMtEf2k98d989 awxAjFCApLnX947fWFhB5wfYKlgAGgJhMtaen0Rr4+cBvAnABq4ZSM/dEdNUDF2gP5Tz uGtCzexENolCoxDmFSYXxvNZYOU/lsBcZXkzc= X-Forwarded-Encrypted: i=1; AJvYcCVqJVlrD6yKqVO/8yS95vCpouAILa4K0wMnyI2PDI+0EH1+HFmL1RzMUvc9BJMIGxuACXtiglQUXjn0dps=@vger.kernel.org X-Received: by 2002:a05:690e:16e4:b0:64c:9c1c:5f6e with SMTP id 956f58d0204a3-64e9ccc4ed3mr1469948d50.5.1773899583695; Wed, 18 Mar 2026 22:53:03 -0700 (PDT) X-Received: by 2002:a05:690e:16e4:b0:64c:9c1c:5f6e with SMTP id 956f58d0204a3-64e9ccc4ed3mr1469937d50.5.1773899583275; Wed, 18 Mar 2026 22:53:03 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64e91a1cd32sm2918980d50.2.2026.03.18.22.52.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 22:53:02 -0700 (PDT) From: Vikas Gupta To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, rajashekar.hudumula@broadcom.com, ajit.khaparde@broadcom.com, Bhargava Marreddy , Vikas Gupta Subject: [PATCH net-next v8 08/10] bng_en: implement ndo_get_stats64 Date: Thu, 19 Mar 2026 11:21:22 +0530 Message-ID: <20260319055124.1350670-9-vikas.gupta@broadcom.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260319055124.1350670-1-vikas.gupta@broadcom.com> References: <20260319055124.1350670-1-vikas.gupta@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" From: Bhargava Marreddy Implement the ndo_get_stats64 callback to report aggregate network statistics. The driver gathers these by accumulating the per-ring counters into the provided rtnl_link_stats64 structure. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 100 ++++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_netdev.h | 2 + 2 files changed, 102 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 93f0149bd775..2513b0907693 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -2904,6 +2904,99 @@ static int bnge_shutdown_nic(struct bnge_net *bn) return 0; } =20 +static void bnge_get_ring_stats(struct bnge_dev *bd, + struct rtnl_link_stats64 *stats) +{ + struct bnge_net *bn =3D netdev_priv(bd->netdev); + int i; + + for (i =3D 0; i < bd->nq_nr_rings; i++) { + struct bnge_napi *bnapi =3D bn->bnapi[i]; + struct bnge_nq_ring_info *nqr; + u64 *sw; + + nqr =3D &bnapi->nq_ring; + sw =3D nqr->stats.sw_stats; + + stats->rx_packets +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_pkts); + stats->rx_packets +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + stats->rx_packets +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_pkts); + + stats->tx_packets +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_pkts); + stats->tx_packets +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_pkts); + stats->tx_packets +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_pkts); + + stats->rx_bytes +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_bytes); + stats->rx_bytes +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_bytes); + stats->rx_bytes +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_bytes); + + stats->tx_bytes +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_bytes); + stats->tx_bytes +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_bytes); + stats->tx_bytes +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_bytes); + + stats->rx_missed_errors +=3D + BNGE_GET_RING_STATS64(sw, rx_discard_pkts); + + stats->multicast +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + stats->tx_dropped +=3D BNGE_GET_RING_STATS64(sw, tx_error_pkts); + } +} + +static void bnge_add_prev_stats(struct bnge_net *bn, + struct rtnl_link_stats64 *stats) +{ + struct rtnl_link_stats64 *prev_stats =3D &bn->net_stats_prev; + + stats->rx_packets +=3D prev_stats->rx_packets; + stats->tx_packets +=3D prev_stats->tx_packets; + stats->rx_bytes +=3D prev_stats->rx_bytes; + stats->tx_bytes +=3D prev_stats->tx_bytes; + stats->rx_missed_errors +=3D prev_stats->rx_missed_errors; + stats->multicast +=3D prev_stats->multicast; + stats->tx_dropped +=3D prev_stats->tx_dropped; +} + +static void bnge_get_stats64(struct net_device *dev, + struct rtnl_link_stats64 *stats) +{ + struct bnge_net *bn =3D netdev_priv(dev); + struct bnge_dev *bd =3D bn->bd; + + rcu_read_lock(); + if (!test_bit(BNGE_STATE_OPEN, &bd->state)) { + rcu_read_unlock(); + *stats =3D bn->net_stats_prev; + return; + } + + bnge_get_ring_stats(bd, stats); + bnge_add_prev_stats(bn, stats); + + if (bn->flags & BNGE_FLAG_PORT_STATS) { + u64 *rx =3D bn->port_stats.sw_stats; + u64 *tx =3D bn->port_stats.sw_stats + + BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + + stats->rx_crc_errors =3D + BNGE_GET_RX_PORT_STATS64(rx, rx_fcs_err_frames); + stats->rx_frame_errors =3D + BNGE_GET_RX_PORT_STATS64(rx, rx_align_err_frames); + stats->rx_length_errors =3D + BNGE_GET_RX_PORT_STATS64(rx, rx_undrsz_frames) + + BNGE_GET_RX_PORT_STATS64(rx, rx_ovrsz_frames) + + BNGE_GET_RX_PORT_STATS64(rx, rx_runt_frames); + stats->rx_errors =3D + BNGE_GET_RX_PORT_STATS64(rx, rx_false_carrier_frames) + + BNGE_GET_RX_PORT_STATS64(rx, rx_jbr_frames); + stats->collisions =3D + BNGE_GET_TX_PORT_STATS64(tx, tx_total_collisions); + stats->tx_fifo_errors =3D + BNGE_GET_TX_PORT_STATS64(tx, tx_fifo_underruns); + stats->tx_errors =3D BNGE_GET_TX_PORT_STATS64(tx, tx_err); + } + rcu_read_unlock(); +} + static void bnge_close_core(struct bnge_net *bn) { struct bnge_dev *bd =3D bn->bd; @@ -2911,10 +3004,16 @@ static void bnge_close_core(struct bnge_net *bn) bnge_tx_disable(bn); =20 clear_bit(BNGE_STATE_OPEN, &bd->state); + synchronize_rcu(); =20 timer_delete_sync(&bn->timer); bnge_shutdown_nic(bn); bnge_disable_napi(bn); + + /* Save ring stats before shutdown */ + if (bn->bnapi) + bnge_get_ring_stats(bd, &bn->net_stats_prev); + bnge_free_all_rings_bufs(bn); bnge_free_irq(bn); bnge_del_napi(bn); @@ -2936,6 +3035,7 @@ static const struct net_device_ops bnge_netdev_ops = =3D { .ndo_open =3D bnge_open, .ndo_stop =3D bnge_close, .ndo_start_xmit =3D bnge_start_xmit, + .ndo_get_stats64 =3D bnge_get_stats64, .ndo_features_check =3D bnge_features_check, }; =20 diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index 548c5a77e76a..a23302a1ab9d 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -353,6 +353,8 @@ struct bnge_net { =20 u64 flags; =20 + struct rtnl_link_stats64 net_stats_prev; + struct bnge_stats_mem port_stats; struct bnge_stats_mem rx_port_stats_ext; struct bnge_stats_mem tx_port_stats_ext; --=20 2.47.1