From nobody Mon Apr 6 17:41:32 2026 Received: from mail-oo1-f97.google.com (mail-oo1-f97.google.com [209.85.161.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6198539A06D for ; Thu, 19 Mar 2026 05:53:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.97 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773899582; cv=none; b=DhKGj6iE3Vz6wn9q1832Us0mhCzaisgt+wXz3UacL59Gf3aF7x1KgUf768b1Nri10tcQvy61eN64JUpLwQ/h3YINbttD08+J6WmScc4IdHNXS+O509BWcBYZbKMbZXl6WtrIB2LurRi5gz4wkPDSybDy5I9I9r7bLNG2W/TU3Aw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773899582; c=relaxed/simple; bh=uNBl9Psxva5SJPexCKlx/63Rr8yoHyHROPl3twU89Vw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=drCA7oZWkJDYDFWl7Lfe30OhV5LahaLy0+way2WR0Gvc/m+1iz9CH63YgKEYe4ifSbxdrgIqdzIDBpswZ2jFRmtPsQ4lFOC7y9RB4P2bdz9NFwrZaFOirJVECSYxyX2aARHNRsj0x+nlS7zqW+SEFDS53h2bly3KkEc7DDtPJYg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=NxQEEq4a; arc=none smtp.client-ip=209.85.161.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="NxQEEq4a" Received: by mail-oo1-f97.google.com with SMTP id 006d021491bc7-67bb04151dcso157013eaf.0 for ; Wed, 18 Mar 2026 22:53:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773899579; x=1774504379; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Kebxp6wh4nYYGznvwFFSyNwKbOSUnFEmSaJutA9Bji8=; b=ciFPzBKRbqZVH2DE9FFacwIzgUwNq1ECNj2uU8Jb5UnnIVJ6khvOHRMoACexbeeQZI 0RnjGwnAGGtOc+rPXEyyzBcG8kBi76w1nfU3jqN1uMbdtDFscpHe+sW6fySlagTtTJT7 Kc50q7J/rVUlH2vBlaDYO/g0654QPi+k3tyS0tcrBi+NsbdmZpJxieW9mM0qFwz0EdTy q2yc5ActCVDy4azFV7U8Jv6jkTIAAUN2LnrnbhSrBiYUU7a9okCFTcJc6qhmZIRNenvt F4QpmlLcjX7zbJEhdJi4YeMUkRd5Sl/75kFW73UjI0r//rjCDbmVENF8VV4ak1j4dnKk 3cNA== X-Forwarded-Encrypted: i=1; AJvYcCV957FQxVNSOiFNmeRD66QKJTI906niqafob0k3w8d1zGE/7v+3S6Yom7QAqakoySjf7jQxR2nG18KY7Eo=@vger.kernel.org X-Gm-Message-State: AOJu0YwfxxBJAnW4C0A0lfUtC6JpY9vRoVv63rgD/RRACpHKbpkJ94Xn 7k2/JfFsD2x+eBDXjxfci8ClRYpVSwIC0Z41whO8d+wWg/NmYgP/3YHsn/mq9V/+MqYPGFe/4Se +kv+AEelrQTZfkLY5cV+/6MDOgz+NwzaAg23n7s+b5Sa8BKkQi+o0CsllonBfE4C3bR/YtCoodX eo7LevvK2bxCtxUoHR5XkiWFB2wTyKrZynffH3Gb3W6lmGbQUzebN9X6Nvgs5qKt1+QsTmcPyGg I4D5657PiQFVAVzyA== X-Gm-Gg: ATEYQzxOYIxsZgjKDzxlAxVFhhcal+hopdUTzLxgLelCx762JxZXdp9M58Xje1qOyPV 4zOCvzp+CPkFdqVRYnHYX2jJVEhFH8EPct90i6B/usVrU5c/0REs/WofucsG2oxvWFUQCYF70yf 1ft28ip3j8wmjb733F75W0G7sW4QWjUqShO2RjauzT7ZYLoP++0eP6vCfH5oJ+/3/u+hXHlVxSO BaDiScbikjwQ19E6rNJS1JKMOZTa8/nbHjwKd3o9EKk+vah1pZpsy0odXgTHUgcCLf5/8hF5WEt vOlfpanL+sRUjuqx1pv9g2We2DKE36bEeibjCLCJbfnRiouxzyS6QYzCTnwl2LwGDLa8En4PizS wJL4bI0L7xPYm7LcHPhfTkCtopAoFiOEYfoMpT+8DWah04OjAK2MVGQJq1tHaORsJqlancbBnjm 6wcydRoq3iytIhgw3O6FaontcWIyspc+gL7A7gClPlndfBvZ41Hyljo6k= X-Received: by 2002:a05:6820:4df4:b0:67b:ab68:b5f2 with SMTP id 006d021491bc7-67c0daa1ab1mr3944126eaf.22.1773899579100; Wed, 18 Mar 2026 22:52:59 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-22.dlp.protect.broadcom.com. [144.49.247.22]) by smtp-relay.gmail.com with ESMTPS id 006d021491bc7-67c0d8f3593sm338191eaf.7.2026.03.18.22.52.58 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Mar 2026 22:52:59 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-798531a0f58so4841097b3.0 for ; Wed, 18 Mar 2026 22:52:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1773899578; x=1774504378; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Kebxp6wh4nYYGznvwFFSyNwKbOSUnFEmSaJutA9Bji8=; b=NxQEEq4aa7HpC+t3A1hKxltp30Sx8N46DqSQgLhOeTW95oGuH4q0d2CVmnY+35UJN0 782mnWgw7DNYN+b42NmgjTaSPxk8HkVJue0Cj2NbovEv7aj4unY3oOQJmNvSW+Rw9Kgk O8gAhj3ExzyS+I1+OPNZv3rWwuOifaxAu057Q= X-Forwarded-Encrypted: i=1; AJvYcCUnVNyqRhyOI8zmlgVCmd0/tCsigffwqJjRBdRBU784qIH8AmTLt50rV8x4nQHRiB5PwY8v0DYgJxQcLh4=@vger.kernel.org X-Received: by 2002:a05:690c:45c1:b0:79a:5508:5831 with SMTP id 00721157ae682-79a7190cc29mr65815017b3.20.1773899577867; Wed, 18 Mar 2026 22:52:57 -0700 (PDT) X-Received: by 2002:a05:690c:45c1:b0:79a:5508:5831 with SMTP id 00721157ae682-79a7190cc29mr65814857b3.20.1773899577410; Wed, 18 Mar 2026 22:52:57 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64e91a1cd32sm2918980d50.2.2026.03.18.22.52.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 22:52:57 -0700 (PDT) From: Vikas Gupta To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, rajashekar.hudumula@broadcom.com, ajit.khaparde@broadcom.com, Bhargava Marreddy , Vikas Gupta Subject: [PATCH net-next v8 07/10] bng_en: periodically fetch and accumulate hardware statistics Date: Thu, 19 Mar 2026 11:21:21 +0530 Message-ID: <20260319055124.1350670-8-vikas.gupta@broadcom.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260319055124.1350670-1-vikas.gupta@broadcom.com> References: <20260319055124.1350670-1-vikas.gupta@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" From: Bhargava Marreddy Use the timer to schedule periodic stats collection via the workqueue when the link is up. Fetch fresh counters from hardware via DMA and accumulate them into 64-bit software shadows, handling wrap-around for counters narrower than 64 bits. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 90 +++++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_netdev.h | 1 + 2 files changed, 91 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 9f62b5f19a2e..93f0149bd775 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -313,9 +313,93 @@ static void bnge_timer(struct timer_list *t) } } =20 + if (BNGE_LINK_IS_UP(bd) && bn->stats_coal_ticks) + bnge_queue_sp_work(bn, BNGE_PERIODIC_STATS_SP_EVENT); + mod_timer(&bn->timer, jiffies + bn->current_interval); } =20 +static void bnge_add_one_ctr(u64 hw, u64 *sw, u64 mask) +{ + u64 sw_tmp, sw_val; + + hw &=3D mask; + sw_val =3D READ_ONCE(*sw); + sw_tmp =3D (sw_val & ~mask) | hw; + if (hw < (sw_val & mask)) + sw_tmp +=3D mask + 1; + WRITE_ONCE(*sw, sw_tmp); +} + +static void __bnge_accumulate_stats(__le64 *hw_stats, u64 *sw_stats, u64 *= masks, + int count) +{ + int i; + + for (i =3D 0; i < count; i++) { + u64 hw =3D le64_to_cpu(READ_ONCE(hw_stats[i])); + + if (masks[i] =3D=3D -1ULL) + sw_stats[i] =3D hw; + else + bnge_add_one_ctr(hw, &sw_stats[i], masks[i]); + } +} + +static void bnge_accumulate_stats(struct bnge_stats_mem *stats) +{ + if (!stats->hw_stats) + return; + + __bnge_accumulate_stats(stats->hw_stats, stats->sw_stats, + stats->hw_masks, stats->len / 8); +} + +static void bnge_accumulate_all_stats(struct bnge_dev *bd) +{ + struct bnge_net *bn =3D netdev_priv(bd->netdev); + struct bnge_stats_mem *ring0_stats =3D NULL; + int i; + + for (i =3D 0; i < bd->nq_nr_rings; i++) { + struct bnge_napi *bnapi =3D bn->bnapi[i]; + struct bnge_nq_ring_info *nqr; + struct bnge_stats_mem *stats; + + nqr =3D &bnapi->nq_ring; + stats =3D &nqr->stats; + + if (!ring0_stats) + ring0_stats =3D &bn->bnapi[0]->nq_ring.stats; + + __bnge_accumulate_stats(stats->hw_stats, stats->sw_stats, + ring0_stats->hw_masks, + ring0_stats->len / 8); + } + + if (bn->flags & BNGE_FLAG_PORT_STATS) { + struct bnge_stats_mem *stats =3D &bn->port_stats; + __le64 *hw_stats =3D stats->hw_stats; + u64 *sw_stats =3D stats->sw_stats; + u64 *masks =3D stats->hw_masks; + u16 cnt; + + cnt =3D sizeof(struct rx_port_stats) / 8; + __bnge_accumulate_stats(hw_stats, sw_stats, masks, cnt); + + hw_stats +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + sw_stats +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + masks +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + cnt =3D sizeof(struct tx_port_stats) / 8; + __bnge_accumulate_stats(hw_stats, sw_stats, masks, cnt); + } + + if (bn->flags & BNGE_FLAG_PORT_STATS_EXT) { + bnge_accumulate_stats(&bn->rx_port_stats_ext); + bnge_accumulate_stats(&bn->tx_port_stats_ext); + } +} + static void bnge_sp_task(struct work_struct *work) { struct bnge_net *bn =3D container_of(work, struct bnge_net, sp_task); @@ -327,6 +411,12 @@ static void bnge_sp_task(struct work_struct *work) return; } =20 + if (test_and_clear_bit(BNGE_PERIODIC_STATS_SP_EVENT, &bn->sp_event)) { + bnge_hwrm_port_qstats(bd, 0); + bnge_hwrm_port_qstats_ext(bd, 0); + bnge_accumulate_all_stats(bd); + } + if (test_and_clear_bit(BNGE_UPDATE_PHY_SP_EVENT, &bn->sp_event)) { int rc; =20 diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index 74b08d492c53..548c5a77e76a 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -276,6 +276,7 @@ enum bnge_sp_event { BNGE_LINK_SPEED_CHNG_SP_EVENT, BNGE_LINK_CFG_CHANGE_SP_EVENT, BNGE_UPDATE_PHY_SP_EVENT, + BNGE_PERIODIC_STATS_SP_EVENT, }; =20 struct bnge_net { --=20 2.47.1