From nobody Mon Apr 6 15:50:54 2026 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E19FD36895E for ; Thu, 19 Mar 2026 02:40:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773888020; cv=none; b=Kc5NxAbgfpxaa3a4DJDIjJ9VZgY/aZS3ubYR5uz2GJ9H1NoMmZDWRgJ2KLQ5E7YBeSPvY//S6SHEO7xw9RWkOyt/cr6uOxKKqQH23xPUdIDRtynLcjZqMGEI/mphfzuoSuJTDrBeBJEZqsftxvNlwrU6hFgqS3tsYtzTvA/stg0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773888020; c=relaxed/simple; bh=mY5S4EvLe4ZlOs204lwhOVN2qu5Qw+xOHZptPLW7WU4=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=I9UKglKCrs98yIsrEQqylJNyvU6f8wuJmb2WVBKRt3mhVpqIiw3LfMHMBhDNjPfsz/HXi5uxWPAn80hBnfc5eyGeWL3j8KjCrsFzed2DIhPyK9yyRPbdqVkpEu/dzr3aA3LXT4LDkUI1ZmoxnjyA5lpUAZ2U+RqjESPeIhG5ZNc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eNyn5FyA; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eNyn5FyA" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-c742882d2a4so265778a12.0 for ; Wed, 18 Mar 2026 19:40:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773888017; x=1774492817; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=HF3dhpPX3brhaCSBxcgIx0vD92ueHkK4Zsm76LgK6Dk=; b=eNyn5FyAoDzLDs2NiEww7FdV/t3HEbGJTFJ6cvz92JTO1Z4C6ODpWff2WPL/902cLg XcL4EO4BKelSaOTkpKNuVEZrgaiqef4h2oN7Dfpv0IlVhEzN89PG/dcGeS/Zyy2FmL8z fTrb4Ux4J4AQ7ZilfXtGEE7UJxvL6O4+yws46UI07pGmwe9LjSprKvTaT4+6Af8N66Li blqY4zggotPxgXImcEgqNksLz38tQqr1OuR3SyjKgvwiEHnKbu8+eQM0JvU9aXxO+7SB ftlTm3qVb5a56LmbKxzpvLZCzFDu3ivYgtIWefi+7kGJsYavnvAj7DWX7J2zIiarTKT0 tqhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773888017; x=1774492817; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HF3dhpPX3brhaCSBxcgIx0vD92ueHkK4Zsm76LgK6Dk=; b=nblJQI4Iv/LuBRwzJOyHprU+zAiK1QZVDS75Wma+17SBkGqPH270d7L7HltISpCwBE NiECheWTkzbcv4Oxe8wpEUSvUf5MXl+93LJbg5nicVuLkJvb0mUmFRIeijicQcDlJFeO yegT59dqcmRoU67PyEs0EY6OqYLiDePhxTI47EhupUe8tHmO8CWVMnpXIqZgc8hqbEdr a7FUu0fwIGzrNBXw4pCkzCxf2uq9uKxAOW9EwdT2tDCp5irnOcdy5+HpbsRdBVbDs4tT Tknz0RWfjn0zoKoV9dsvHsX3pgYqUuxrgDAIza4KGE+ZfRZIB3c056O14DmmlOM62vX3 RP9g== X-Forwarded-Encrypted: i=1; AJvYcCULBN2UkDM9RZF/NeWkCMMT+9rfm4/Qvfkm8KxR1Ov6t11uLqJsFrUa/FP5VBp6FcrGYMjWnsr8w5pbVO8=@vger.kernel.org X-Gm-Message-State: AOJu0YwPlCBPfydZxYGmBWdINcFl+9ctHpzSqXRhgjlo67XNmlGteyqO wbEVbloePpcSjyVq6oRPm+tXjfC9UjoN9iheaZNbjDDaDsqMthP1NYFr X-Gm-Gg: ATEYQzwt6B6zXQAagxCspM9mYj1UvRttMlt8pHpU4NAhhEIUsHdHEJjeD0MwdpTEE5v v8voz1W+Xd1rupIxmJ9E310C+EBgng8hVr8/59JYXcHZgd0YmQnTJY5pNekr3hflXVtSffyIBql 8hI26LwDq7CUdHPk6A/D0yOMo6VF9Pat+DXuyN1XHcBSz8RLGZPlCaxuxOyuQyhRR0ZvPyEmlA+ uKPTedINMHqmFOmueEu7J7moiBNv8ym+kmzPRFNSVCaeIo6N870nZzBfpBSxR3UfbhO8O2Wuz4/ v3c0AIdYe4S8JkwoZZCT+Cq6PxxPw1cTSbLcasTKOnWZzPLP25PkfkpO1qDXz9Qe9kaP+215gaT N5FHRarnSAkjyW9SiOEOmfU6k+o6raHWFezi/eMwZbSk361fcnuCxbfe6bx7wvLsyNss+b1S5Pr 9dVtXUMGKKpNB2LR29+w== X-Received: by 2002:a05:6a21:690:b0:398:9c27:2479 with SMTP id adf61e73a8af0-39b99c8d2d6mr5321541637.5.1773888017010; Wed, 18 Mar 2026 19:40:17 -0700 (PDT) Received: from localhost ([111.228.63.84]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c742bc99cf4sm528427a12.0.2026.03.18.19.40.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 19:40:16 -0700 (PDT) From: Cen Zhang To: jaegeuk@kernel.org, chao@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, baijiaju1990@gmail.com, Cen Zhang , stable@vger.kernel.org Subject: [PATCH] f2fs: annotate data races around fi->i_flags Date: Thu, 19 Mar 2026 10:23:35 +0800 Message-Id: <20260319022335.3213311-1-zzzccc427@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" fi->i_flags can be read by f2fs_update_inode() in the writeback path, f2fs_getattr(), and f2fs_fileattr_get() without holding inode_lock or fi->i_sem, while it can be concurrently written by f2fs_setflags_common(), set_compress_context(), and f2fs_disable_compressed_file() under inode_lock and/or fi->i_sem. This is a data race as defined by the LKMM. Use READ_ONCE() on the read side and WRITE_ONCE() on the write side to ensure proper marking of the concurrent accesses. Fixes: 360985573b55 ("f2fs: separate f2fs i_flags from fs_flags and ext4 i_= flags") Cc: stable@vger.kernel.org Signed-off-by: Cen Zhang --- fs/f2fs/f2fs.h | 4 ++-- fs/f2fs/file.c | 6 +++--- fs/f2fs/inode.c | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index c66472e409a3..28161df79e4f 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -4764,7 +4764,7 @@ static inline int set_compress_context(struct inode *= inode) fi->i_compress_algorithm =3D=3D COMPRESS_ZSTD) && F2FS_OPTION(sbi).compress_level) fi->i_compress_level =3D F2FS_OPTION(sbi).compress_level; - fi->i_flags |=3D F2FS_COMPR_FL; + WRITE_ONCE(fi->i_flags, READ_ONCE(fi->i_flags) | F2FS_COMPR_FL); set_inode_flag(inode, FI_COMPRESSED_FILE); stat_inc_compr_inode(inode); inc_compr_inode_stat(inode); @@ -4791,7 +4791,7 @@ static inline bool f2fs_disable_compressed_file(struc= t inode *inode) return false; } =20 - fi->i_flags &=3D ~F2FS_COMPR_FL; + WRITE_ONCE(fi->i_flags, READ_ONCE(fi->i_flags) & ~F2FS_COMPR_FL); stat_dec_compr_inode(inode); clear_inode_flag(inode, FI_COMPRESSED_FILE); f2fs_mark_inode_dirty_sync(inode, true); diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index c8a2f17a8f11..abff927a8699 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -1005,7 +1005,7 @@ int f2fs_getattr(struct mnt_idmap *idmap, const struc= t path *path, } } =20 - flags =3D fi->i_flags; + flags =3D READ_ONCE(fi->i_flags); if (flags & F2FS_COMPR_FL) stat->attributes |=3D STATX_ATTR_COMPRESSED; if (flags & F2FS_APPEND_FL) @@ -2153,7 +2153,7 @@ static int f2fs_setflags_common(struct inode *inode, = u32 iflags, u32 mask) } } =20 - fi->i_flags =3D iflags | (fi->i_flags & ~mask); + WRITE_ONCE(fi->i_flags, iflags | (READ_ONCE(fi->i_flags) & ~mask)); f2fs_bug_on(F2FS_I_SB(inode), (fi->i_flags & F2FS_COMPR_FL) && (fi->i_flags & F2FS_NOCOMP_FL)); =20 @@ -3437,7 +3437,7 @@ int f2fs_fileattr_get(struct dentry *dentry, struct f= ile_kattr *fa) { struct inode *inode =3D d_inode(dentry); struct f2fs_inode_info *fi =3D F2FS_I(inode); - u32 fsflags =3D f2fs_iflags_to_fsflags(fi->i_flags); + u32 fsflags =3D f2fs_iflags_to_fsflags(READ_ONCE(fi->i_flags)); =20 if (IS_ENCRYPTED(inode)) fsflags |=3D FS_ENCRYPT_FL; diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c index 078874db918c..17c8aff690fb 100644 --- a/fs/f2fs/inode.c +++ b/fs/f2fs/inode.c @@ -720,7 +720,7 @@ void f2fs_update_inode(struct inode *inode, struct foli= o *node_folio) else if (S_ISREG(inode->i_mode)) ri->i_gc_failures =3D cpu_to_le16(fi->i_gc_failures); ri->i_xattr_nid =3D cpu_to_le32(fi->i_xattr_nid); - ri->i_flags =3D cpu_to_le32(fi->i_flags); + ri->i_flags =3D cpu_to_le32(READ_ONCE(fi->i_flags)); ri->i_pino =3D cpu_to_le32(fi->i_pino); ri->i_generation =3D cpu_to_le32(inode->i_generation); ri->i_dir_level =3D fi->i_dir_level; --=20 2.34.1