From nobody Mon Apr 6 12:12:14 2026 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5D943CD8CA for ; Thu, 19 Mar 2026 11:59:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773921556; cv=none; b=d7B32TYLSDKieUTw/Z+o4reVBlS+f4KO3JJ8KfNgEZnGc7aqaTS/k5LXePPa909y5zP3L9ZIHuDJ9MQHbs1bzMfsKfJgZxdlYsnpfItbjbn9aW3jkjiJfDGwkyWc3grDOxp60D+CH40U4uorFlG/1QOCVVJbypMTVT41mWThn1E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773921556; c=relaxed/simple; bh=fwyYVczkGGhNbbtuDw6wb0iPQK79Hav8hEBxFnyoihs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZoMk5Kl3J9xPXGY6EXCLVzQne07gpNCFLijhD1+Ww081+vPwrgMo5ZApojYWl4R1SU75Ha3N7BMRAgDqI6dYeL1VUEY++GGciL9Awdv2agYbPrHKBIZyr3461TDlVOEzEPfcxDfYIc/B6bWik9CwYPTbfEBpftV8fFYPL6BnmEg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KJ+p+LcP; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KJ+p+LcP" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-b932fe2e1a7so99655266b.1 for ; Thu, 19 Mar 2026 04:59:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773921551; x=1774526351; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=l5lDxPgHMLUWf4KOAgcF/BaGDb9kL4QT6S8GOy/ie+w=; b=KJ+p+LcPAg6rX4yzoY8TJmHJ6WFt4qPQuZi50EsAg4tC6I/tiap+lBopao4J5I0hBB 30HNCZoDi35A/yyPYWSqXkgdGXHccs+Sp06tub5I0Wh2Z9ZpFKHa6/Ichi5NFJKL9aFl Tv50VE1zLX1tPmY8jVcsXRZ5/YhCVqIkxUgfGnTHfYhXgNLb9WnehyeKBqiCWyyc6Elb uTajEnR85h8uJXZeDYaGo1EapgZZSSl/6DRmkscE2NTPclDG0ZEouL6vr8SXfC3q0C6f HjNwttD4NXBmWYdCzKz9rmfRvMyRYVLCwvUxNE1AfoWOBEulgm7frtrZtKJAy2ea6P1j bEXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773921551; x=1774526351; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=l5lDxPgHMLUWf4KOAgcF/BaGDb9kL4QT6S8GOy/ie+w=; b=kw+D0MZH8NqtMozU/SK/qxLUHiecnLpMmkXWaYoBK4GGjDz91SVsSZNvwazWZ2N/xb XLXhJpS4DaS1YyA+Pu1siY5337hwB15+wfi274hUrA5G91QeTk6X4g+pYjX0hrH18Y8f s259E/514VZJHPWaKaT7psudQqJDU+1TSroeBxuagdL4UgFVEAs22yHzaB+iSGYlSBM7 k9dt9x3vBehg/BhYYG2MFEogVCmm+Xkf1SxsQfkfaqWm07RKU7zS/9aRC+TuQf6UyDZf mqvStIhCD38WsN37k3xm5LA5EQab5Wpg0xTbg3cSgSf8DTGV7KsIIZfGN07ijA0ojlbO DDUw== X-Forwarded-Encrypted: i=1; AJvYcCUvaJgXKTyqrRCPsJovVRj+BY7MPCsPVh8E4b9gEi/uI7xsylM4dd1tCN7FhJIFY2oUN/jzP7IABKRBYv0=@vger.kernel.org X-Gm-Message-State: AOJu0YxHlMQNvg1yQtYvuRvaRvv2sGV+Xvb9Rd5Llm5WleIRkjvr0lO0 aHYykSiezNGfDuuqVV6VWihBPrQT1XJ8AvoIJ0ZbupziD7k8eqyqVf5R X-Gm-Gg: ATEYQzzky1z9v2et/oK2KrP3DlKW9ABpEYFK8BL0OXktKVuMC/xWKe/GB9ycZ/bf953 oI0d0uR+WRIvsUjJ0piUVZMIDb0wetYaWQVE54dhba2kSM0lrOQ+Z5TNzsGLE55UsjZrT8Y7xDB +Aika5XiSaSNkM1AUvZQS5NXGpDTKfKakugZQgxLqkwIswLaC4MX1CXSv6eB94SBgXvqtxk4tcT HZqdjxRPh3W+sGYfPk+lKw1Pq5SCAMF6SKkXGUsFOX92nyEgJc2fR6B/meMk9yjnN8cqVaX5sKI qEsIY+Fw5WZ/6K1Ok1eZeuWVZzUVBwssmq1DWtO356M+9cfjRvo7zx8BDaXdI4P7g5UAVU7okgi 8KO20dE8KKFVDQfTE+Ds6u9wXzuadbsJJv2be+JJVqPeoGTBaSoOK8tFczl/QfaFQIUFHPwLwJA lVJLe6lCGJ3cUF1QtnP8880IJXfg== X-Received: by 2002:a17:907:869f:b0:b93:89cd:2bbc with SMTP id a640c23a62f3a-b97f4b83175mr487536366b.56.1773921550571; Thu, 19 Mar 2026 04:59:10 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97f16d3380sm461399166b.42.2026.03.19.04.59.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 04:59:10 -0700 (PDT) From: Erikas Bitovtas Date: Thu, 19 Mar 2026 13:58:41 +0200 Subject: [PATCH v5 3/8] iio: light: vcnl4000: move power enablement from init to probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260319-vcnl4000-regulators-v5-3-a025d3332805@gmail.com> References: <20260319-vcnl4000-regulators-v5-0-a025d3332805@gmail.com> In-Reply-To: <20260319-vcnl4000-regulators-v5-0-a025d3332805@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.14.3 Given both vcnl4000_init and vcnl4200_init end with dev->chip_spec->set_power_state(), they can be called once from the probe to enable the sensors. Move the set_power_state function from init and call it after init function in probe. Reviewed-by: David Lechner Signed-off-by: Erikas Bitovtas --- drivers/iio/light/vcnl4000.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index 939ff2d65105..287ccd89cfb2 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -280,7 +280,7 @@ static int vcnl4000_init(struct vcnl4000_data *data) data->rev =3D ret & 0xf; data->al_scale =3D 250000; =20 - return data->chip_spec->set_power_state(data, true); + return 0; }; =20 static ssize_t vcnl4000_write_als_enable(struct vcnl4000_data *data, bool = en) @@ -425,10 +425,6 @@ static int vcnl4200_init(struct vcnl4000_data *data) if (ret < 0) return ret; =20 - ret =3D data->chip_spec->set_power_state(data, true); - if (ret < 0) - return ret; - return 0; }; =20 @@ -2003,6 +1999,10 @@ static int vcnl4000_probe(struct i2c_client *client) if (ret < 0) return ret; =20 + ret =3D data->chip_spec->set_power_state(data, true); + if (ret) + return ret; + dev_dbg(&client->dev, "%s Ambient light/proximity sensor, Rev: %02x\n", data->chip_spec->prod, data->rev); =20 --=20 2.53.0