From nobody Mon Apr 6 10:44:14 2026 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73BFB376BE3 for ; Thu, 19 Mar 2026 11:59:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773921554; cv=none; b=APiDWaM6kKltjkNKfqcvOkNT5pW4DaP6feBpN3XWsK/CaVh3EsBC4NxeJmNC+qVB2WsdEqHtyLc2xIsBDsRNWypJSWD2heqxCO0fMWHbxyieg0BY3+Bdob/W2CJ/peO0C+0xI68GHpJ8DsWBJqJ6wYZgjsLlhb1HDi3BmIQv/TY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773921554; c=relaxed/simple; bh=aiPXxbkBtL2g1i14xqt2LGY7RPn85iUFNe9a0NClGa4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NaR2gfw0UJ8J9Fj2ZTFUTYKE5J2sQWAth3J8Xp5tnr/zNrhE8iuCbm/VZ8+OPUFRKJ9s4YwQqA89XpSkJpFYUBSr/vRmGFK6pm0JuMwTZYbxW/2M6WhsF0veY/ly5U6z7SfeGveIfcRhmem+QUM1REZep4Ltn9mCXouA7JSwRgI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jwXrFg59; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jwXrFg59" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-b7cf4a975d2so113540166b.2 for ; Thu, 19 Mar 2026 04:59:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773921548; x=1774526348; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=cZa0s7hz2156Ccpdoak30m2Gw7JDYqAQedbI9A51ZyU=; b=jwXrFg5916CCvzLfTU0t6sbRD+c7bpyZTKNdYFN3nwU52oGcjtegr1wh7G2cQLyPoc TaRQR4cDmr40W7OatWJ76qncMx0H12GXhR7oonw2qjjHtwFNwQfmc8gabdZwI8xgbtEY 2/AGBzv1m9TC38AAqiwBbymy54FmRJu5Fcma7/0YJgYAKFi+OafHExB1nFaBO/q3YP4f ov76Qf52i9tXV+ilupxpyridYtx43+zMxGTTo8mMD30MCUQpo1rZKiQgy0l1idVvAGF8 Sfb620oTBsEGo8w/HEwm8zck8uynOVgBpKZnKi5qI+a1wDKTsYyn3qc5nxV9vp73gUyD SxxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773921548; x=1774526348; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=cZa0s7hz2156Ccpdoak30m2Gw7JDYqAQedbI9A51ZyU=; b=nTRlqU4a+Vc2AX/L6m1K2Tv/c4wq3OQIpgFe8Orh1Nl36k85R3yEsEvfDgcKJGFUL8 i0wpLXMHMyDnlNa+JrNUlkv/d+zdwN7s7usZ0gEM9DYTXf7fbugv7greBRlE2IBhrOqH K2z+IGQtcDvqekcDu2Eg7c4ovPIWybKgkafVZK7YOM4RYTzrmruMRHYzOvJrgH4kE/Pc cRFO91Ls3aLaw/olkEoMD3LRLkO+v5CBhADcKt3YoGMSueWeH+uB6rC9J8Yif7gH3tHN hGI3Fa3GvUOoereb6n2/q/fvfMk7mg3VT+Ksf70BswkMWaJxYdFndFt1sPZxHyxsxX8v KWCg== X-Forwarded-Encrypted: i=1; AJvYcCWxe+37ndxrkEem5j6YhEWC17yRDWW2JONeSDARAdPyUcwwqJ60RrtH0e9YVtZMz5ko/2LU85ao/Pz549k=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8o2MTyGDroYlDmkj605pQfem/dQN4BUCOQ9194LVkhZfo883n TVkV5cgK63EZ1SGJCsrZ7gTJEm9FnUpqTjsVhtueWPRkTfaLnqinV+B3 X-Gm-Gg: ATEYQzwi8nfQAwUtsGUoFR+yPtz7QkFcvOnTuC3Oy2HCL2WPqOppB1MspDGbY1+1C60 8t7925QtzyTZZILl4jKhLoC58utblOxypyO8CjEngRbBxhnQLjt5RgcnG8R/r7erTux4pK86gOL c/BAXH9qfS2VN2ytFhEVYglLSaC2G4Ap7a0Kae021RMDKI7UiEQzfVgD8bjku9PJs1EXCbZbZP7 CTgMdVbgA3UjW0HAY8W9D9ghIOT8HQTM3eXxvFTMzHxQb9Q0fRxMW6sRDYDjuLq66TzkTqjBsmv zcSqy0haTM9o0jb+lqEgF94LYLwJAg0nU645ZuyFwZkOighJyMwBsHqPskZneTru82eWEoyVNNG UZl/cZvA2sQq/dJXkYN8KCEG3ANOx5gpoMx4ZjylTwKRMv82bPbsuJ5REMf7bddhji88fJlEVUg qzLRIE1C425s0J1e9srUppGNCBFIH1sPw5llTe X-Received: by 2002:a17:907:728e:b0:b98:667:2e1d with SMTP id a640c23a62f3a-b9806672ff4mr337932966b.25.1773921547845; Thu, 19 Mar 2026 04:59:07 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97f16d3380sm461399166b.42.2026.03.19.04.59.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 04:59:07 -0700 (PDT) From: Erikas Bitovtas Date: Thu, 19 Mar 2026 13:58:39 +0200 Subject: [PATCH v5 1/8] dt-bindings: iio: light: vcnl4000: add regulators Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260319-vcnl4000-regulators-v5-1-a025d3332805@gmail.com> References: <20260319-vcnl4000-regulators-v5-0-a025d3332805@gmail.com> In-Reply-To: <20260319-vcnl4000-regulators-v5-0-a025d3332805@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.14.3 These sensors can accept 2 supplies - one for the sensor and one for IR LED [1]. Add supply properties for the sensor - 2 for the sensors and one external, for their open drain interrupt line, to ensure the sensor is powered on before proceeding with setup. [1] https://www.vishay.com/docs/84274/vcnl4040.pdf Reviewed-by: David Lechner Signed-off-by: Erikas Bitovtas --- Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 7 +++++= ++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.ya= ml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml index 2ba4d5de4ec4..44882a90bc76 100644 --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml @@ -33,6 +33,10 @@ properties: interrupts: maxItems: 1 =20 + vdd-supply: true + vio-supply: true + vled-supply: true + reg: maxItems: 1 =20 @@ -54,6 +58,9 @@ examples: compatible =3D "vishay,vcnl4200"; reg =3D <0x51>; proximity-near-level =3D <220>; + vdd-supply =3D <®_vdd>; + vddio-supply =3D <®_vddio>; + vled-supply =3D <®_vled>; }; }; ... --=20 2.53.0 From nobody Mon Apr 6 10:44:14 2026 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB3EE3D0916 for ; Thu, 19 Mar 2026 11:59:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773921556; cv=none; b=CtOGfNeGCbdXRASpgbxz/ZfJ2zUfWoiyuKbIy/ZidJ4r3Z+dOmVd8SNvNR59PULrOVuuY04CVzW9gOGYogN5UTL8wZsIQM8QhoQB7GG/KuHgq4M3COih921ABLdbxyqMB78aP6lPR9KVAt+wgvle1csHviy2qYr803O2Z4ANzLs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773921556; c=relaxed/simple; bh=FyYL7KjhfBkhq4Z8eKOH65vilPS2pr7+rN80jiOzQpc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=H1NqpKcfL9Sd8Z/OKIsixQqXAap9prYTjuHlq4TgXHET44OdsahNy90JZK/4COldYTvmOX/fz7LqnSn18dMpLYzWiLTD/HyOWLDf3jnfuV8J4YL6VT2afPcZ03Uz+bBtR6EF5iz7BXBvDXTH2zJZGd1TR434g55+gPip/8qCfr0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Jr5exfEK; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Jr5exfEK" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-b941762394aso73501366b.1 for ; Thu, 19 Mar 2026 04:59:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773921549; x=1774526349; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=AGTiQESNTxF+kqg9mPQcr06UPYRyUnWm55j6lAp7RWY=; b=Jr5exfEK9YaQ/thIlySFnLsSKgAz6iUh/nMJRplGQa9P+FisjinJcPAKWx5ZaVQz+2 Wm1R7NhYdxJCX7v83hVDHWgUsD5n/310rd2G3+a1p2AFhxxmKZNmWt61KRSUor7/7JDe BYwieDWtqGI61vosW7Nfty+w1swF66taFB9GUaUayGLWfRhOFHwyD1I8gG8mrOH9ckuF P59NgU18z2kQwL8mV2t24SpkQWH5zSXgCTuWOJhjRcntvvld0wMPfHNF1dOd8hI/deCV AkDdmlyJO2RKgxibJKUvRRDcc6NN1tAJiLwsrpYESDVbvVbtT4z2REU50pTQXuGVxJbE vjTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773921549; x=1774526349; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=AGTiQESNTxF+kqg9mPQcr06UPYRyUnWm55j6lAp7RWY=; b=beuwHwM6sd0kypA6wAi9kjgmhHPQbROghJssTXc8FmDWC/+1gCotVsaQoKWe7ujQKS ycA+xYekCoAcKs0QhtV9XCvvDsOCP/1EZnRBmTKLG8TvyXC6luRBK0dlXENgitZ5IKSH UHv7zwnuUrZ9+fPU3AnMWkIthdisLXAFd4PJYnfN1cbeXmgCU04bmrUZUTWjQU1y88Y6 zp+bHII34W/bzyWLIWKTB9HDc6uMKnjqxp0OEh1aKr2KXh3J7JsGurMZnNXzvHpSqKkz EjeeVoRatSNiRin1cjesudy5sgz+EvblUxM9aXqUYWnJZZJlYATSseFZQLh5/hUIypVh 9+Tg== X-Forwarded-Encrypted: i=1; AJvYcCUQzzFrobIoz0P8e69FPK0K0SW4UCUfy66hzkxAuAIRSD63Uo/2BOXldghqwXXGnG8YtVPoXGESmM5s7jA=@vger.kernel.org X-Gm-Message-State: AOJu0YyGxe5PmtCdQrps80iSFjTrnkRJbDcfeSMAlMppum+cvHQBgkTA 6FDTzehsKKCFNKQxkbSJeIj3KR7G53NaM39C0L2TmavSCodtlih+bPu2 X-Gm-Gg: ATEYQzxwhkqYmnOdJFOm3mugOyeazBvBa16+LNCO2FBgEv9u+LKBFa9k3qVkdYtrM4K tXJi7ZKisSGjHsZPgYJAzhdtcL9IPgL6/OX7i3i1Nuc405qPnDnX1fXLpVpMpa4hb3Fxk1Rd5e3 4y9sggzEJfiNcCzlP1ipPyE3VfHsr7eMYRJfV5nx+5+t0qcbj7V502gt/x5etMpdI+da7BbTs9U HNlzWLSYEYfd14Z2k3U4h+m3iJNBrjXblV7W3B1TbqsREqCJgvZ9zuvBuYnukXH4441yUbyVhsy P68+PczdswXu4k84p54irDew+XQ6vmEQ/qkkmZNcmOGEzJ9/vE/y0ISRVxUYjUGJAYvT5LpOPV1 Ak04TYAnwYe2aCSVYQY9qcL6g5J3orY8JxENLVGv93m7KCWeENJ5XYAwLEPfrNbT4OLiKuj8q0V z8o+vEYC37wTHMisIjijlh681xPA== X-Received: by 2002:a17:907:ea6:b0:b97:fb80:dd12 with SMTP id a640c23a62f3a-b97fb810dcfmr397921866b.33.1773921549259; Thu, 19 Mar 2026 04:59:09 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97f16d3380sm461399166b.42.2026.03.19.04.59.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 04:59:08 -0700 (PDT) From: Erikas Bitovtas Date: Thu, 19 Mar 2026 13:58:40 +0200 Subject: [PATCH v5 2/8] iio: light: vcnl4000: sort includes by their name Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260319-vcnl4000-regulators-v5-2-a025d3332805@gmail.com> References: <20260319-vcnl4000-regulators-v5-0-a025d3332805@gmail.com> In-Reply-To: <20260319-vcnl4000-regulators-v5-0-a025d3332805@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.14.3 Sort include headers by file name for better readability. Reviewed-by: David Lechner Signed-off-by: Erikas Bitovtas --- drivers/iio/light/vcnl4000.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index 5e03c3d8874b..939ff2d65105 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -18,12 +18,12 @@ */ =20 #include -#include -#include -#include #include -#include +#include +#include #include +#include +#include #include =20 #include --=20 2.53.0 From nobody Mon Apr 6 10:44:14 2026 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5D943CD8CA for ; Thu, 19 Mar 2026 11:59:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773921556; cv=none; b=d7B32TYLSDKieUTw/Z+o4reVBlS+f4KO3JJ8KfNgEZnGc7aqaTS/k5LXePPa909y5zP3L9ZIHuDJ9MQHbs1bzMfsKfJgZxdlYsnpfItbjbn9aW3jkjiJfDGwkyWc3grDOxp60D+CH40U4uorFlG/1QOCVVJbypMTVT41mWThn1E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773921556; c=relaxed/simple; bh=fwyYVczkGGhNbbtuDw6wb0iPQK79Hav8hEBxFnyoihs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZoMk5Kl3J9xPXGY6EXCLVzQne07gpNCFLijhD1+Ww081+vPwrgMo5ZApojYWl4R1SU75Ha3N7BMRAgDqI6dYeL1VUEY++GGciL9Awdv2agYbPrHKBIZyr3461TDlVOEzEPfcxDfYIc/B6bWik9CwYPTbfEBpftV8fFYPL6BnmEg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KJ+p+LcP; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KJ+p+LcP" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-b932fe2e1a7so99655266b.1 for ; Thu, 19 Mar 2026 04:59:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773921551; x=1774526351; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=l5lDxPgHMLUWf4KOAgcF/BaGDb9kL4QT6S8GOy/ie+w=; b=KJ+p+LcPAg6rX4yzoY8TJmHJ6WFt4qPQuZi50EsAg4tC6I/tiap+lBopao4J5I0hBB 30HNCZoDi35A/yyPYWSqXkgdGXHccs+Sp06tub5I0Wh2Z9ZpFKHa6/Ichi5NFJKL9aFl Tv50VE1zLX1tPmY8jVcsXRZ5/YhCVqIkxUgfGnTHfYhXgNLb9WnehyeKBqiCWyyc6Elb uTajEnR85h8uJXZeDYaGo1EapgZZSSl/6DRmkscE2NTPclDG0ZEouL6vr8SXfC3q0C6f HjNwttD4NXBmWYdCzKz9rmfRvMyRYVLCwvUxNE1AfoWOBEulgm7frtrZtKJAy2ea6P1j bEXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773921551; x=1774526351; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=l5lDxPgHMLUWf4KOAgcF/BaGDb9kL4QT6S8GOy/ie+w=; b=kw+D0MZH8NqtMozU/SK/qxLUHiecnLpMmkXWaYoBK4GGjDz91SVsSZNvwazWZ2N/xb XLXhJpS4DaS1YyA+Pu1siY5337hwB15+wfi274hUrA5G91QeTk6X4g+pYjX0hrH18Y8f s259E/514VZJHPWaKaT7psudQqJDU+1TSroeBxuagdL4UgFVEAs22yHzaB+iSGYlSBM7 k9dt9x3vBehg/BhYYG2MFEogVCmm+Xkf1SxsQfkfaqWm07RKU7zS/9aRC+TuQf6UyDZf mqvStIhCD38WsN37k3xm5LA5EQab5Wpg0xTbg3cSgSf8DTGV7KsIIZfGN07ijA0ojlbO DDUw== X-Forwarded-Encrypted: i=1; AJvYcCUvaJgXKTyqrRCPsJovVRj+BY7MPCsPVh8E4b9gEi/uI7xsylM4dd1tCN7FhJIFY2oUN/jzP7IABKRBYv0=@vger.kernel.org X-Gm-Message-State: AOJu0YxHlMQNvg1yQtYvuRvaRvv2sGV+Xvb9Rd5Llm5WleIRkjvr0lO0 aHYykSiezNGfDuuqVV6VWihBPrQT1XJ8AvoIJ0ZbupziD7k8eqyqVf5R X-Gm-Gg: ATEYQzzky1z9v2et/oK2KrP3DlKW9ABpEYFK8BL0OXktKVuMC/xWKe/GB9ycZ/bf953 oI0d0uR+WRIvsUjJ0piUVZMIDb0wetYaWQVE54dhba2kSM0lrOQ+Z5TNzsGLE55UsjZrT8Y7xDB +Aika5XiSaSNkM1AUvZQS5NXGpDTKfKakugZQgxLqkwIswLaC4MX1CXSv6eB94SBgXvqtxk4tcT HZqdjxRPh3W+sGYfPk+lKw1Pq5SCAMF6SKkXGUsFOX92nyEgJc2fR6B/meMk9yjnN8cqVaX5sKI qEsIY+Fw5WZ/6K1Ok1eZeuWVZzUVBwssmq1DWtO356M+9cfjRvo7zx8BDaXdI4P7g5UAVU7okgi 8KO20dE8KKFVDQfTE+Ds6u9wXzuadbsJJv2be+JJVqPeoGTBaSoOK8tFczl/QfaFQIUFHPwLwJA lVJLe6lCGJ3cUF1QtnP8880IJXfg== X-Received: by 2002:a17:907:869f:b0:b93:89cd:2bbc with SMTP id a640c23a62f3a-b97f4b83175mr487536366b.56.1773921550571; Thu, 19 Mar 2026 04:59:10 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97f16d3380sm461399166b.42.2026.03.19.04.59.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 04:59:10 -0700 (PDT) From: Erikas Bitovtas Date: Thu, 19 Mar 2026 13:58:41 +0200 Subject: [PATCH v5 3/8] iio: light: vcnl4000: move power enablement from init to probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260319-vcnl4000-regulators-v5-3-a025d3332805@gmail.com> References: <20260319-vcnl4000-regulators-v5-0-a025d3332805@gmail.com> In-Reply-To: <20260319-vcnl4000-regulators-v5-0-a025d3332805@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.14.3 Given both vcnl4000_init and vcnl4200_init end with dev->chip_spec->set_power_state(), they can be called once from the probe to enable the sensors. Move the set_power_state function from init and call it after init function in probe. Reviewed-by: David Lechner Signed-off-by: Erikas Bitovtas --- drivers/iio/light/vcnl4000.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index 939ff2d65105..287ccd89cfb2 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -280,7 +280,7 @@ static int vcnl4000_init(struct vcnl4000_data *data) data->rev =3D ret & 0xf; data->al_scale =3D 250000; =20 - return data->chip_spec->set_power_state(data, true); + return 0; }; =20 static ssize_t vcnl4000_write_als_enable(struct vcnl4000_data *data, bool = en) @@ -425,10 +425,6 @@ static int vcnl4200_init(struct vcnl4000_data *data) if (ret < 0) return ret; =20 - ret =3D data->chip_spec->set_power_state(data, true); - if (ret < 0) - return ret; - return 0; }; =20 @@ -2003,6 +1999,10 @@ static int vcnl4000_probe(struct i2c_client *client) if (ret < 0) return ret; =20 + ret =3D data->chip_spec->set_power_state(data, true); + if (ret) + return ret; + dev_dbg(&client->dev, "%s Ambient light/proximity sensor, Rev: %02x\n", data->chip_spec->prod, data->rev); =20 --=20 2.53.0 From nobody Mon Apr 6 10:44:14 2026 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 535613D0926 for ; Thu, 19 Mar 2026 11:59:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773921558; cv=none; b=PIUYrinnKdxxi+uUimxMlIHvxPOktuaCps4N9uDSahrh5WwTIDUgFZeRVV2gyppQgg6mJyi1k609bFUl3mM/UNvnhXQVTYoo9v/359YtwxCX7A1WY0N6wtGUkblCqa7/zjolsJ5CyQtUyYFypSijXpf5FXxEmP4VwzEGNJvot0E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773921558; c=relaxed/simple; bh=vP7EEpgruq7jb0BDTrxCYCk5LMVt/Xx+6zryX3dg/1Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sPFVfN3kqSfywo0JKZbk3YQphsKLGWA1kShx2xQYGKnB2WOuQejYhvzIdJLAHXBI/5vZKdkZd1hqngSCABs81nMtc/vrDH6pCKHVS7evhFQF8J2AHpzEF62TQ3p5gXg2Lqbn67v6LZFBBr71WnxiawJF6bL4jpsh9qQkUf/A/Lw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l7OQDXqI; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l7OQDXqI" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-b9382e59c0eso131398666b.0 for ; Thu, 19 Mar 2026 04:59:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773921552; x=1774526352; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kmQLMk8d0z4Tj8kbX0Ny9TubbIjksPecuXhm9eaS99k=; b=l7OQDXqIkrquyEl9F9P++NtxrMfAcBxbuN1XXy4/TavPtiQQZz/KQ6Ltr9bdn4scDm Y6ASrV7Zf8b2dZsYPVqXSwAIzTkrqKurpGeHR+vHxBHKDEo38DO7WVL05AHkEYP8DxVW cgPT3Cm2a0vG4WQ16j7HZhZdVCigCVd/H8JowXiOpwxs8xYTvG9ombgdSx+rWrlmALyY S7N320pFRbB7AM39GAoSTMgpSennphYZjQujPsl7AXcu+tjP84HHLLCorEg0Hj3mA3tx jLGm7VTuCagDBbCVdRMjme2ymHcHc2+yj6j/fAhEBEDKLgluL6/pXzvhDj7/EJ419dm+ BQjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773921552; x=1774526352; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=kmQLMk8d0z4Tj8kbX0Ny9TubbIjksPecuXhm9eaS99k=; b=XGL1m0fB9+8jphpzrHuPUNGVJ5UNgRLEQBHUGUx5fVX2woZgHC5Bjbgv2bA7UIkfr0 h0hymHscyogAykpqL/0Vuqa/yEIFilYWINdKayCDKZLh58BoZWGDd4E4thnwmdEBXJqe 7mxZ9vXArqGvb4p0925sZz59K4ipLlVHeF0OrjTMXSOmQCfdPizPxjxigcyMFb9UCwcF J+HD9SYjZfb/OJyfATSLG2kmiPOE1O3P3XhdlrNw47H1dn71tP7szK8wTweIrlBsuwIj 6wm3Jozk9xPFUe7L+s81VUoUXbJIhMA0dTqow/rffLMbfyzc3onZ01JM3AI1gdxEC5UC vE1w== X-Forwarded-Encrypted: i=1; AJvYcCVYWNlntPDToYLkzNYibvspC/GmaD6tfiVmCG5DC7TF5k4iKo/xjHEf+wbq71XMYlm7diVD53GB9q2kLfQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwAYVRk5DR2ekAImXJ6Qyxsr3N2dw4Gw2+xMr4n6HMmDZ7JqwlB BEFQgK9FeDhnv0DZ9h6L40c1jOJkXehAfg4QWcAvMk63Radsfj8ur2hM X-Gm-Gg: ATEYQzxR9ejWTYcCNB6+HJtyHxFWu+LR/1Bd/Gt/bt+CpJRKm5677419D4MM7brH162 dkZIKteGs4QOpAQNDPdA23GnXyiGk8OYHmJF54GZdfB0IB/I26IyRHqY9swHFRX+5CRB+c3PwbH lBUlt5b9nH86m+Qe2+VyiBAqgumbJb0bpoxHC8+B6FSQe6It2aRkYg4MpHG+ceZsTLRgSRXLML+ ujt9VxWCNdMFvAHo9wFhSRbP/eYOKpMB9qoOXsPETkV9khkaxb/2i6YKMPHi/BJlGI1RfFF1BH0 WRvrnPKqUHXdNXyABoNkjpnMh2WAPjlJe9F1Hyb9mdgVasCAI2ST5nOwNQkxnjVZ0xh+K29RirF ODF0dGnjK/XzeAD/yNgq/qiwl5F5BBhccnp381Qym82Ol4zLsYxGF4SZfV9DRuqPYoywoo24QGs 6RFnadxuJFKj7T44NjLcoAKpvprg== X-Received: by 2002:a17:906:1d01:b0:b97:91c0:fc3b with SMTP id a640c23a62f3a-b97f48c1dc4mr394199366b.16.1773921552076; Thu, 19 Mar 2026 04:59:12 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97f16d3380sm461399166b.42.2026.03.19.04.59.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 04:59:11 -0700 (PDT) From: Erikas Bitovtas Date: Thu, 19 Mar 2026 13:58:42 +0200 Subject: [PATCH v5 4/8] iio: light: vcnl4000: replace mutex_init with devm_mutex_init Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260319-vcnl4000-regulators-v5-4-a025d3332805@gmail.com> References: <20260319-vcnl4000-regulators-v5-0-a025d3332805@gmail.com> In-Reply-To: <20260319-vcnl4000-regulators-v5-0-a025d3332805@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.14.3 Replace mutex_init used across driver with its device-managed counterpart, so all assigned mutexes get destroyed. Reviewed-by: David Lechner Signed-off-by: Erikas Bitovtas --- drivers/iio/light/vcnl4000.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index 287ccd89cfb2..cd7e6ee42cc5 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -356,6 +356,8 @@ static int vcnl4200_set_power_state(struct vcnl4000_dat= a *data, bool on) =20 static int vcnl4200_init(struct vcnl4000_data *data) { + struct i2c_client *client =3D data->client; + struct device *dev =3D &client->dev; int ret, id; u16 regval; =20 @@ -400,8 +402,14 @@ static int vcnl4200_init(struct vcnl4000_data *data) } data->al_scale =3D data->chip_spec->ulux_step; data->ps_scale =3D 16; - mutex_init(&data->vcnl4200_al.lock); - mutex_init(&data->vcnl4200_ps.lock); + + ret =3D devm_mutex_init(dev, &data->vcnl4200_al.lock); + if (ret) + return ret; + + ret =3D devm_mutex_init(dev, &data->vcnl4200_ps.lock); + if (ret) + return ret; =20 /* Use 16 bits proximity sensor readings */ ret =3D i2c_smbus_read_word_data(data->client, VCNL4200_PS_CONF1); @@ -1979,6 +1987,7 @@ static int vcnl4010_probe_trigger(struct iio_dev *ind= io_dev) static int vcnl4000_probe(struct i2c_client *client) { const struct i2c_device_id *id =3D i2c_client_get_device_id(client); + struct device *dev =3D &client->dev; struct vcnl4000_data *data; struct iio_dev *indio_dev; int ret; @@ -1993,7 +2002,9 @@ static int vcnl4000_probe(struct i2c_client *client) data->id =3D id->driver_data; data->chip_spec =3D &vcnl4000_chip_spec_cfg[data->id]; =20 - mutex_init(&data->vcnl4000_lock); + ret =3D devm_mutex_init(dev, &data->vcnl4000_lock); + if (ret) + return ret; =20 ret =3D data->chip_spec->init(data); if (ret < 0) --=20 2.53.0 From nobody Mon Apr 6 10:44:14 2026 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE3813D093D for ; Thu, 19 Mar 2026 11:59:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773921560; cv=none; b=T3lSzjGuudgR0JjucUyWwM8J0V+ANjtXmA5KW9TxgSuB97v204djp1Q8NLeuR4PZcQ2sH7NchclczGKZsvBB9HHql8Jbd+TZtrJ6udaW4619iGdfIxIUvdVdEa0KmcY/8XjKyFnmKrt77ahpSCdCOWt4Kg5cqgObGdEu+LtjNu8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773921560; c=relaxed/simple; bh=F8JhpNRtISwTJCZ0mFH9huui70rVNKoYVUHt0NiS600=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HVBJsuXTh8iE+9MZnD1mMAuSG30hMkTVcLzsT1MJnmTIEYX0mUA573p2Trf16S5IJqYmDupucek79XHR0lNSvj/DEzTRAupfEXRil/MKglE4E6PJzBa8CN4wsqJHgpezjj/JuHoSMbmfK/uo0Hpq9weaXkrvNrxuJrRmK/qD9AE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M7rH3nYs; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M7rH3nYs" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-b941762394aso73510666b.1 for ; Thu, 19 Mar 2026 04:59:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773921554; x=1774526354; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=NwqEwLydPXTJh37lAhGuKLAvUQ1T9VTG2r0Fov0v/5k=; b=M7rH3nYsa/1bYKGY4Vf71pP3ixR4qLr4GhC1P0jTJIjtx5qT/eBaAehYKmQkQpG9eZ mSx71J0pmLip0//UK3SM+JCNP0myN2WkeWAIIyDM+x2YwDsybMPOsNzin9I9nln5x3JH gCqNDVuhtPNxMJpyxdoPX4GPLjlxX0neoyfVKBBdJoSZrTsWcC+qWQggc8GPqGU0x4Oi zGu0Cug4cI2MHvrPqlTOvq5RsjaP1s+ve5agb3g7ksc3chx8JLpeNe9/XSThTO+v63rV jcnhnafRbxBpc5ak9DJGUeLTk+ByWl8KXah7ZAmyGCCAZ1KEGmYIePNoDOLH0VOahtnD 1Alg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773921554; x=1774526354; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=NwqEwLydPXTJh37lAhGuKLAvUQ1T9VTG2r0Fov0v/5k=; b=a4APTAcp0zQp9ggBIVd8ftyBMVT0SXEjUTyXYpuxR1XcFZKco2nG+58E33F4r4PCz6 Psa1CZRIIcR5m1e7e104Pn4VAwpb5BBTTfobLoqlIN9FeN91SBqU+RVmzLPJmFueKo5x XtxQUBmBuU5hztfplngXJTEp1+v9qxw4bH7CmsnmPpu6+P/IRUxJgfpj/fMD4TdlN1te TTBBjOl2CUs78XWOoCLoFo316NXIvCWYs3vnWLDB0cF7/4HNUuBMY1QQyAO61CUoaDdZ LH+5cWZKiPIfjmrQAnIRnITmzociZYGozS/4XSRQKs2r5Z6KNDdT4ko1eaLUbUVFxsJu qNbQ== X-Forwarded-Encrypted: i=1; AJvYcCVXiaJW0aOlMW+Ll7EQt2KZFk0d1zm4nNXD8EOmX/DNi5WNYWBiWUnpIumsdG8EjLBQCb6OD/BbboUvHjM=@vger.kernel.org X-Gm-Message-State: AOJu0YyEp0wuuAQyF64m7GHk2cADPkwsnctH03wTxYqDpumkw6GYjQa7 cegk6PqRCGDwh8PTxUspYMEfu3Ci5sME1ZaFJz5N+jnRmGsJ0JNTsNWC X-Gm-Gg: ATEYQzzGM+vuA6PvuLCWz8ujzmB8elt2vBlRhvTM5rQnnTQ7BgqDJZ3olJJ2rkTzLPZ oE4BUewJw4tuW4H1/7Td0Dg+U2h0oFcscEH3uBQs/0LCNBuiB8t7fG6WMx8DvpEUiS0zYqQpciW oc2aAO9NOBPPp5bQ1dBjdHxTJVw6SImJQBf6bbCMWLiF5e8EYIF7mGD2Tb0RqrEK0gAB5g6Imeh JCtNRInncx34dVCF5E4lAESlhMMCIzI24YauY+6unbP6Q4+6JErpWWhw6+aKFnOHqtJYGajGTma 1yCZqElyvlWp9Xf9tJ18IYseO1HdQfrHk+UA4d1iwIb+y50YmNg4SoXMqm8arHEcmk6I1ZNZAeH +L4J+ATk1HdVV7320laHuBY6bOJVeBqvNjg45EiBBXrV8NXIS/ccWHZ2d2wNwiD/WeqjAcKS0er qw8nZXaTBFeKQHuoiSf5Xel03/PQ== X-Received: by 2002:a17:907:3d4a:b0:b96:f329:e66 with SMTP id a640c23a62f3a-b97f4b010b0mr492191266b.51.1773921553701; Thu, 19 Mar 2026 04:59:13 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97f16d3380sm461399166b.42.2026.03.19.04.59.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 04:59:13 -0700 (PDT) From: Erikas Bitovtas Date: Thu, 19 Mar 2026 13:58:43 +0200 Subject: [PATCH v5 5/8] iio: light: vcnl4000: remove error messages for trigger and irq Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260319-vcnl4000-regulators-v5-5-a025d3332805@gmail.com> References: <20260319-vcnl4000-regulators-v5-0-a025d3332805@gmail.com> In-Reply-To: <20260319-vcnl4000-regulators-v5-0-a025d3332805@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.14.3 The error code is available in the log after return. In our case, attaching a triggered buffer can only fail if we are out of memory, as no other buffer is being attached. Remove duplicate error messages to reduce noise in dmesg. Reviewed-by: David Lechner Signed-off-by: Erikas Bitovtas --- drivers/iio/light/vcnl4000.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index cd7e6ee42cc5..76aee16d479b 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -2033,11 +2033,8 @@ static int vcnl4000_probe(struct i2c_client *client) NULL, data->chip_spec->trig_buffer_func, data->chip_spec->buffer_setup_ops); - if (ret < 0) { - dev_err(&client->dev, - "unable to setup iio triggered buffer\n"); + if (ret < 0) return ret; - } } =20 if (client->irq && data->chip_spec->irq_thread) { @@ -2047,10 +2044,8 @@ static int vcnl4000_probe(struct i2c_client *client) IRQF_ONESHOT, "vcnl4000_irq", indio_dev); - if (ret < 0) { - dev_err(&client->dev, "irq request failed\n"); + if (ret < 0) return ret; - } =20 ret =3D vcnl4010_probe_trigger(indio_dev); if (ret < 0) --=20 2.53.0 From nobody Mon Apr 6 10:44:14 2026 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 532AA3D16FA for ; Thu, 19 Mar 2026 11:59:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773921562; cv=none; b=RQBU441tEiG7RILjlWYDqVyIXJvcHDH7VElbVAXKFr02ldW6MLhPolMNYGntgOQH/rV8q+fhGvu0mZgbNN1eaqAdmkykxBZXZoTMWGm0USH1FSTnURTUx24GBnri2RBUV1ZXF9+PQiLg0ILtTwmYpW5t1Yxqu927dTrkB/ZDtXE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773921562; c=relaxed/simple; bh=egKHr0hohoUF1Y46/QK4pbAPf8UkacKpEmSV/fnmdIg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Kx1rdkJvjLKD8kBK5A1jPeFWmLMcwCRVyA7LWziFIGEZ8LqA7Ca4Wm+zMLBFR80RihNYZWjwdAN27PTKxT493EETbuwiQTvMgqmTiSatxdjaNDHUMgo/h2ZdkgNNV/AxxYotW3gY3nAeWzL+W4ish7zwCMgUjW7CCkl1+1RW8iE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GjrdSSgm; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GjrdSSgm" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-b9382e59c0eso131404866b.0 for ; Thu, 19 Mar 2026 04:59:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773921555; x=1774526355; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Dtlos7JIiB738v4Wa8FtbGBxNvY35k21oQSX4LVS2wk=; b=GjrdSSgmlb2KrbbOT6j+43Ru+iTKWJP24YhsLvvuE6FQf81yA4j2BvWIkRyDGknu/+ 7PH8nx7WcNBKDp1LDt4HGa+OY9yMp7mjwbae7tRzyoTAtT+0valqkhMwgDJOe+JHvEbS BYy+K0AyFJTBvXdVws352ZlStgUqX4OXH//QpqVl+te38byYNCzpRkz0lYtGdblkMy5I PQ1YPvGl1IgZkSdW2/oYGMjhhiF4bLGySEuYhGfpXyLdIbfEQM/l5qSjG6NhkCh0quAk 78m5OxBWwdHeUJCBt4TCzxkULbYXYPGkrYiwRSvxnm8Bg53vEggYy0iqBbmiaTmkY/To 5VOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773921555; x=1774526355; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Dtlos7JIiB738v4Wa8FtbGBxNvY35k21oQSX4LVS2wk=; b=CbKE6JcRciadirIy0rBLHt+fMfs3+fdq6JjYc/lHeIYuTRGL0fFILdltG22NuI12py /olUIkCpqBeFqt4q7/7Kit+3FVPqJXKuxAGwIkSQx/UwqqlJaXz10uAW9iPg4TFJQ/Dx P0GUggocLRz4agzf0re8iO+IbKw9J3XduPC9fyeLv1i2GZ2wywkD+nn5UUp8J7q3Ywbl XELjGK+E+neQWSUP4vr6MPOVlzw2msihRyJuQIGxhy76tlUIsB7F/OyCDigo0g92sn46 d2GCEv+HiO0UcKsWgSLnzxOuV1w2jJnUHLVTCOQxFiHJfU0G1jch2cDHyiBTVcWICYkC VNPQ== X-Forwarded-Encrypted: i=1; AJvYcCVrPc6QO5L/98XQU9i5JS69+Y11B+t6R9yBmU1vjKlveUii5UuXUDwH1JSVQl2yIwsC7TFfjQufi4qW3AA=@vger.kernel.org X-Gm-Message-State: AOJu0Yyorn+LQUCTc1dp81QTEUYU4Pk6xIohmiWCJ8cRomkfZXDNjqXi xOjWT0BqajBCdZHA8zEO9D6hBmZ/WNyJx5BzLHTl7OSS0c3bl5BPBZ8z X-Gm-Gg: ATEYQzzC6/yDxBlEJWMo7M+lfeXEPH3sFxfAKlAW/8UHYvqiCkJkzFV3h4dzGWMLkmo NGIsw7618rnrsmf37t1DYfJasQ18KG4r4K0+dt8i66E7p58AAc2Uyvy2UU7fpgYyst6TW6Jv6dM Ji3C7R/Rnwbn11ivZFWoc0ZFD8yGLS2fdg4Q6OfyhHFAkECN8XFNEswhh5cmX9Y3vtEYs0/w1Ak Mde/LhaN5TmqpmbJOLZsQZsb0EOt4cgzhZpw0Rzui1HW9O/PMolPSXhwrRW7FiHCHEDJgWqoMj2 /jnykY3pURFpuOhXCGSao966/s66VPxKG89y8BwngFxS9/iYd7ucTW9Uoxcpk17nA3XhurlvdsY EXkq035JolSzylqfceYyATdTmG90HX0DyanR7W6of/O8+zGH3Ep433ElXclA4Ifg4jA8jde31eZ fSFa3MNmaWvlP1qkNBBDifwGsi1avbfr/Zxn5Y X-Received: by 2002:a17:907:60d5:b0:b97:cc05:61a7 with SMTP id a640c23a62f3a-b97f4aad93cmr479421466b.51.1773921554991; Thu, 19 Mar 2026 04:59:14 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97f16d3380sm461399166b.42.2026.03.19.04.59.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 04:59:14 -0700 (PDT) From: Erikas Bitovtas Date: Thu, 19 Mar 2026 13:58:44 +0200 Subject: [PATCH v5 6/8] iio: light: vcnl4000: use variables for I2C client and device instances Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260319-vcnl4000-regulators-v5-6-a025d3332805@gmail.com> References: <20260319-vcnl4000-regulators-v5-0-a025d3332805@gmail.com> In-Reply-To: <20260319-vcnl4000-regulators-v5-0-a025d3332805@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.14.3 After moving data->client and client->dev into variables of their own, replace all instances of data->client and client->dev being used in vcnl4200_init() and vcnl4000_probe() by the said variables to reduce clutter. Reviewed-by: David Lechner Signed-off-by: Erikas Bitovtas --- drivers/iio/light/vcnl4000.c | 35 ++++++++++++++++------------------- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index 76aee16d479b..34b52725aff6 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -361,14 +361,14 @@ static int vcnl4200_init(struct vcnl4000_data *data) int ret, id; u16 regval; =20 - ret =3D i2c_smbus_read_word_data(data->client, VCNL4200_DEV_ID); + ret =3D i2c_smbus_read_word_data(client, VCNL4200_DEV_ID); if (ret < 0) return ret; =20 id =3D ret & 0xff; =20 if (id !=3D VCNL4200_PROD_ID) { - ret =3D i2c_smbus_read_word_data(data->client, VCNL4040_DEV_ID); + ret =3D i2c_smbus_read_word_data(client, VCNL4040_DEV_ID); if (ret < 0) return ret; =20 @@ -378,7 +378,7 @@ static int vcnl4200_init(struct vcnl4000_data *data) return -ENODEV; } =20 - dev_dbg(&data->client->dev, "device id 0x%x", id); + dev_dbg(dev, "device id 0x%x", id); =20 data->rev =3D (ret >> 8) & 0xf; data->ps_int =3D 0; @@ -412,24 +412,22 @@ static int vcnl4200_init(struct vcnl4000_data *data) return ret; =20 /* Use 16 bits proximity sensor readings */ - ret =3D i2c_smbus_read_word_data(data->client, VCNL4200_PS_CONF1); + ret =3D i2c_smbus_read_word_data(client, VCNL4200_PS_CONF1); if (ret < 0) return ret; =20 regval =3D ret | VCNL4040_PS_CONF2_PS_HD; - ret =3D i2c_smbus_write_word_data(data->client, VCNL4200_PS_CONF1, - regval); + ret =3D i2c_smbus_write_word_data(client, VCNL4200_PS_CONF1, regval); if (ret < 0) return ret; =20 /* Align proximity sensor sample rate to 16 bits data width */ - ret =3D i2c_smbus_read_word_data(data->client, VCNL4200_PS_CONF3); + ret =3D i2c_smbus_read_word_data(client, VCNL4200_PS_CONF3); if (ret < 0) return ret; =20 regval =3D ret | VCNL4040_CONF3_PS_SAMPLE_16BITS; - ret =3D i2c_smbus_write_word_data(data->client, VCNL4200_PS_CONF3, - regval); + ret =3D i2c_smbus_write_word_data(client, VCNL4200_PS_CONF3, regval); if (ret < 0) return ret; =20 @@ -1992,7 +1990,7 @@ static int vcnl4000_probe(struct i2c_client *client) struct iio_dev *indio_dev; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&client->dev, sizeof(*data)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*data)); if (!indio_dev) return -ENOMEM; =20 @@ -2014,7 +2012,7 @@ static int vcnl4000_probe(struct i2c_client *client) if (ret) return ret; =20 - dev_dbg(&client->dev, "%s Ambient light/proximity sensor, Rev: %02x\n", + dev_dbg(dev, "%s Ambient light/proximity sensor, Rev: %02x\n", data->chip_spec->prod, data->rev); =20 if (device_property_read_u32(&client->dev, "proximity-near-level", @@ -2029,8 +2027,7 @@ static int vcnl4000_probe(struct i2c_client *client) =20 if (data->chip_spec->trig_buffer_func && data->chip_spec->buffer_setup_ops) { - ret =3D devm_iio_triggered_buffer_setup(&client->dev, indio_dev, - NULL, + ret =3D devm_iio_triggered_buffer_setup(dev, indio_dev, NULL, data->chip_spec->trig_buffer_func, data->chip_spec->buffer_setup_ops); if (ret < 0) @@ -2038,8 +2035,8 @@ static int vcnl4000_probe(struct i2c_client *client) } =20 if (client->irq && data->chip_spec->irq_thread) { - ret =3D devm_request_threaded_irq(&client->dev, client->irq, - NULL, data->chip_spec->irq_thread, + ret =3D devm_request_threaded_irq(dev, client->irq, NULL, + data->chip_spec->irq_thread, IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "vcnl4000_irq", @@ -2052,7 +2049,7 @@ static int vcnl4000_probe(struct i2c_client *client) return ret; } =20 - ret =3D pm_runtime_set_active(&client->dev); + ret =3D pm_runtime_set_active(dev); if (ret < 0) goto fail_poweroff; =20 @@ -2060,9 +2057,9 @@ static int vcnl4000_probe(struct i2c_client *client) if (ret < 0) goto fail_poweroff; =20 - pm_runtime_enable(&client->dev); - pm_runtime_set_autosuspend_delay(&client->dev, VCNL4000_SLEEP_DELAY_MS); - pm_runtime_use_autosuspend(&client->dev); + pm_runtime_enable(dev); + pm_runtime_set_autosuspend_delay(dev, VCNL4000_SLEEP_DELAY_MS); + pm_runtime_use_autosuspend(dev); =20 return 0; fail_poweroff: --=20 2.53.0 From nobody Mon Apr 6 10:44:14 2026 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AF633D170F for ; Thu, 19 Mar 2026 11:59:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773921564; cv=none; b=qAiXkO9dhtZFMNfPcAfsBD4pfg7NdkwOKIaUoHo/A677x48OKAw3L8fvR8W3W1ZLjAv61Hc6ByH7eT0GBnxfT3KWxmsBhPTWF9bfT5hRGW8S5joVUXjn99hmlhX8L/bJSjJsMULXicLN2bGD4a12XM5Q6n9bwzHh6j7HfP4LHAo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773921564; c=relaxed/simple; bh=w5xtoSN57Gl+VyOZOhDTahGIJ0RwHfPPzLNAzvBUd4A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ky7IuxRPNdjBsjfiHswA040mhCnqK0m/sczGRY2q1hu4UB7T7DXJAcx+u1EpTevMNLONSJ5vWjZzVRxYik5VSd7Ts8DUngsD0P/SJlKfA1+Jb30UWPUM4obPwbWxsQDICb8zJ7tPC2E+8tu4gjmuIuj1pA/JM9A0RdYufhL85GI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Zvu8xG6r; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zvu8xG6r" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-b98069e41b0so135354766b.1 for ; Thu, 19 Mar 2026 04:59:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773921556; x=1774526356; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=j0qPqA1xbNhE1Dv/S7BEHSx+8WdubNnnHdrMlRxqcOc=; b=Zvu8xG6rcyOuEEd2lpOn5kftwGlhOXPHnSb9o2l+mee9JE4OOS/qZoa76kImD2Fp0G kxj2D446KnYb2Sgtow6s5GHVmKzi4ye62m+SaO8t4X2gS2JRl2WyYp2JXLcBAUU4ADxe Kutq6A8q8D44EpmqC+Ea5CjE288WYX7q8VOXM7eoUjNVI3xs9/x7FoqxS6hrWgF6lqmH Wb6P0Gf+gbsYf5mYU1g8PlI9M2z3cForTawzKAD9fBQ3uD42T8uQGe0w/kTex+NMEhDM LCTTfVCo3fNV3/QrGw/nuzo3kpJf0PLc1TA6ZCrW1F27D+cCaiIYrKqNG1I5qXxraPFj yGUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773921556; x=1774526356; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=j0qPqA1xbNhE1Dv/S7BEHSx+8WdubNnnHdrMlRxqcOc=; b=HJBZq9YXeldUTe4rDgHSiOXramZx3FuCxr/u0DDzdimQtSj+rKZVTukILEjizrkEZs gTCMa5nghAtUJ0vHLNr6OzGN5pxwi6zuL4K1mm3y8nSNxfAeB3ctrh3KkwdO39FGI0vw xuEonYTms54hFYXGpDN79iv/D0dOVey/p01ckwDIWhhyZWXMatqw7kSDAjqDhjkgr+/T e0pqbPyZmhCsKv0ccqWsS/d5cQ+8Di57vicb/F955LsLebw+Zj3LEfwmHh3iN1C0smw4 3q/tfoIR0pHHrwFkf19YBbNCoGVo1sUGrQodJtPaFvLswTUVVbvQVYr5mcFb0ZQcB81W 86QQ== X-Forwarded-Encrypted: i=1; AJvYcCXm+otx+n29I5W3N+CQVjLhTIt2J/dozel5IrHTgeFMxyVNhn2te58ac9KTwXsadr3PGHVjYceGRmjxjeM=@vger.kernel.org X-Gm-Message-State: AOJu0YxkGOw+b4zUJAZe1YJaGzBEAqWbijhb+sK83buS8zxSpFOnoOFG 4mhDLFePiqvCgaJIOfGripktbntEm7YlvYVOlk/CGTE8cDoxbTZDu5kh X-Gm-Gg: ATEYQzzy4wxQWrhDtX/1THAJ3Z3/bNBbYnQ0jsC4Mt3XZosgYmqHwAp0ssuK6hXTzQl TtV0J92yZx8JjV/ts2Jxg27VAO75tGqyVHdufTbWxCnLhVhYKppC2n7e4H4luWId2jszHRE5u5y OFcIWx4DKrFxOj98CxNIC1qqYk0RgZmAH2STFm0XUwaFrOjmqbwkbkIyZ2d800J3KHgnGbJOjoT QT+AOoXl4ShwlojIvmJ1lgiC3q8EoQLmfAI6fzaylGGvoVNjtfsq/DinGWsv37ByWfXepclELmi BBn1dYwdqeq+ONfYz1L25JZ4Jg/ybvndUy9H3MerK+9qxCn4QSqLqwtbPkUzGummHrV2bMGNviR sYY75imDaHa5D9vRJ/WamhFVv0EnHj2ytGjI1XXSx6/m+lBHqDR1Kj6JEymtJsXo+fVILQDdqO8 ZNbXpohSTMi0XNe3leOeKTu2l6HQ== X-Received: by 2002:a17:906:c102:b0:b96:f4f6:2a02 with SMTP id a640c23a62f3a-b980faad336mr197971066b.25.1773921556389; Thu, 19 Mar 2026 04:59:16 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97f16d3380sm461399166b.42.2026.03.19.04.59.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 04:59:15 -0700 (PDT) From: Erikas Bitovtas Date: Thu, 19 Mar 2026 13:58:45 +0200 Subject: [PATCH v5 7/8] iio: light: vcnl4000: remove redundant check for proximity-near-level Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260319-vcnl4000-regulators-v5-7-a025d3332805@gmail.com> References: <20260319-vcnl4000-regulators-v5-0-a025d3332805@gmail.com> In-Reply-To: <20260319-vcnl4000-regulators-v5-0-a025d3332805@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.14.3 The data->near_level variable is already assigned 0 during devm_kzalloc(), therefore checking if the property is present and then assigning it 0 is redundant. Remove the check for device tree property and let it fail silently if it is missing or invalid. Reviewed-by: David Lechner Signed-off-by: Erikas Bitovtas --- drivers/iio/light/vcnl4000.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index 34b52725aff6..0a4d82679cfe 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -2015,9 +2015,7 @@ static int vcnl4000_probe(struct i2c_client *client) dev_dbg(dev, "%s Ambient light/proximity sensor, Rev: %02x\n", data->chip_spec->prod, data->rev); =20 - if (device_property_read_u32(&client->dev, "proximity-near-level", - &data->near_level)) - data->near_level =3D 0; + device_property_read_u32(dev, "proximity-near-level", &data->near_level); =20 indio_dev->info =3D data->chip_spec->info; indio_dev->channels =3D data->chip_spec->channels; --=20 2.53.0 From nobody Mon Apr 6 10:44:14 2026 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 023F63D1CB2 for ; Thu, 19 Mar 2026 11:59:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773921563; cv=none; b=JLyZ5TWbOU5ZVUAbb6/EXCi4VqjnXPljDO4gi1NDgRJEZyyPIg08/MdMjRUy/dXuQeV1CnFLsRjt/7V5ZGJ+oVMxpbbrc4/vHXBUwQdAXwwP6ZzBraE5RK2fn11hsitQdsqRX31djP2evRtGpccmt0uAiiQmneDvjsK1nwabrt8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773921563; c=relaxed/simple; bh=TzB0TDBcyModHlhscKkRyhu+DntXkSWYAGvIUGrcGVo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=O+P9TVkgq57Bkr1CCstc0a6p1YRjvn/Qgr6z3ITp+TD+17qbn66sShd0upW0+V0yhSfA8NwVOSBZlC0VhfiRaEohkz5njgxTSSa5l06w0tNSoDriLnKp+j1dsrhEJ/qJyYdVY3PCIuwIpIItBfvu0cI7be1jvt/y2DtO6yEJisw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DMkyFP2+; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DMkyFP2+" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-b9793fa5371so79733666b.2 for ; Thu, 19 Mar 2026 04:59:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773921558; x=1774526358; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=WUcQHeprPMeRllf18ooNN99GRIW3qgL3Mo3SFM1oI1s=; b=DMkyFP2+RoShdqM5fkCewz3/YopJRFfIKyjB/7aWy43bEWh7HaSr/E5vUqANaoMSuX epwv4rj/yKxfFnO5X7ZoNgVkm/eLO5nUnAKPaZolMz/hEvbO9vzUkCqbJcf/5tiFR8xK lJNhKfZL3YFeyYEb0R2KAWan3neVPFB5CzaPTHyj3ltIPH0ECgf2aWlbwVlRFe/qCTJf /ecaUNRmxeNcWfc7BNh4H7VxZORFDn+yd9o3UEAq7aBhCQsYbvuMm2DQ3mvRS9rU5Fxm Ssc08XU5QG2VdaDTCJPv1Ze9w/2da9rPljuW0wFIs2r46kQF5Tjy6YY4xQ7rRaORXjel 2vqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773921558; x=1774526358; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=WUcQHeprPMeRllf18ooNN99GRIW3qgL3Mo3SFM1oI1s=; b=XA4crk9r/bPGCCTsxsmsjb4dwJVxfdtd2oqaF55wwhswrDh2SL0ayiTBWSyCE8z5wd KbBixQ9sedgVJbz9voQg7rwuwH9AymmU6mgRttN9D9ZPvhhEfWkwiyQ4BkjrlL+3kwDQ WXfRoD1toBD/aafn+4ifgzuLgZX/cljOMVYjsrDEP2juZbf8L97PZOzppYC0g1DFh3RY URNUbofFkVMawOh9jFYUN+XIoim8W+9KKkegaFnz/yUe7nBtAs1LNvWWJZgTvBIcAeTQ A4gmhpi0nGNzUYFhW4SPufUmn8mbKVMKCEAonrRd9qAJ83z4w8Gro1SLe2TE2v7IZhgZ ozeA== X-Forwarded-Encrypted: i=1; AJvYcCWVgAbZ0KSc3vHg+OHWSg7+i3g+3l0wfmZxa6cpyGeUtVDEK7hPgDtLdK4jK1RTCNMq/+qMVk1WLd8m9+s=@vger.kernel.org X-Gm-Message-State: AOJu0YzYniy2vcpmIyX0XTcj9IDVrt+6JxmfmpNQPVmm+rZ0H+DoK1yL lnWYjnti4YtnJdbPGMoZCK0Qcowvum6Ot2dHmtM+SEmWAkZ2rhgx0aiK X-Gm-Gg: ATEYQzzzNDPfnJroE4KhbYGhtP+OV5KeNJEUY1QGnuryB76YNFWprMiHX8dLk7l4zkK 1aZRyjSDCSQsVlzFErWTYpU+bQL4y3O57rQQLq+LWU6lrYfW6SqUI4NxJuvP9jU6RxiDFYl1/qz cqNMrCXwl3OmJerqB1hps7mbWQQuJ7W+SIwWtGUMpdyFKpNBXYKemOlBjBBDrmmjSuXWX+hknM+ DMmIVNoLXYtkOTqyYIDsskqvwclAypTZ1zry0DBZAyDFaB3AMvxikyhziEDImycbRXqwEQ90IEc +QFFh5OOXwni+ZuJFmyt9zRAFwd48m4si5e0RdRYGEcaoNu/ihDrp8tsNXH04KoqHz1NPZQQu77 LoJhrxMmSpq5LBkC/MUieo6vtA32MILX1wz58rOhKXyBmOU2TgUxdT9nABaa97IFF9RMsZSbq+1 PpVjRLp/973yy8KsVTp/3GT73gsg== X-Received: by 2002:a17:907:806:b0:b97:a9ac:5e05 with SMTP id a640c23a62f3a-b97f4a700e4mr524920666b.35.1773921557711; Thu, 19 Mar 2026 04:59:17 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97f16d3380sm461399166b.42.2026.03.19.04.59.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 04:59:17 -0700 (PDT) From: Erikas Bitovtas Date: Thu, 19 Mar 2026 13:58:46 +0200 Subject: [PATCH v5 8/8] iio: light: vcnl4000: add support for regulators Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260319-vcnl4000-regulators-v5-8-a025d3332805@gmail.com> References: <20260319-vcnl4000-regulators-v5-0-a025d3332805@gmail.com> In-Reply-To: <20260319-vcnl4000-regulators-v5-0-a025d3332805@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas , Raymond Hackley X-Mailer: b4 0.14.3 Add supply, I2C and cathode voltage regulators to the sensor and enable them. This keeps the sensor powered on even after its only supply shared by another device shuts down. Reported-by: Raymond Hackley Reviewed-by: David Lechner Signed-off-by: Erikas Bitovtas --- drivers/iio/light/vcnl4000.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index 0a4d82679cfe..9650dbc41f2b 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -24,6 +24,7 @@ #include #include #include +#include #include =20 #include @@ -1985,6 +1986,7 @@ static int vcnl4010_probe_trigger(struct iio_dev *ind= io_dev) static int vcnl4000_probe(struct i2c_client *client) { const struct i2c_device_id *id =3D i2c_client_get_device_id(client); + const char * const regulator_names[] =3D { "vdd", "vio", "vled" }; struct device *dev =3D &client->dev; struct vcnl4000_data *data; struct iio_dev *indio_dev; @@ -2000,6 +2002,11 @@ static int vcnl4000_probe(struct i2c_client *client) data->id =3D id->driver_data; data->chip_spec =3D &vcnl4000_chip_spec_cfg[data->id]; =20 + ret =3D devm_regulator_bulk_get_enable(dev, ARRAY_SIZE(regulator_names), + regulator_names); + if (ret) + return ret; + ret =3D devm_mutex_init(dev, &data->vcnl4000_lock); if (ret) return ret; --=20 2.53.0