From nobody Mon Apr 6 10:46:34 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A2AD3EF66A for ; Thu, 19 Mar 2026 16:56:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773939369; cv=none; b=XhejTy0Ir3tLqcc6WfgNaY1mWgCDK7Dx+LrPu+mX9yEfVjBQSA+8wyBVB12c2FQU74NSPjoYSwF7e9MaFJj6+KoI71qdT35W7dFg7XMuCp5fYUp+cBzcSPmtGqSY20KvsIfDcOJCZ4+MlC+DnIZ62G3Qg5HjbfxVdypwqviyNWc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773939369; c=relaxed/simple; bh=cewxigfhr8A62nFh2/tWGpwMAz9fbmcaksUZ7wDWT78=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Pejg0mJctz+JSZ2Wpbsk4Nisi5kQRDJSKwe7HyUMu/FjHX/0V5OsBKj/XIqdh//o/tf3xx1KY5OMXK8xxh7338rzleEYqhr00990C7ro41hXtia+AUSYrEVD/IQvPI7bVl78uQfsjyVDzQRXPqZwxkqqd+9y+pFVtcPGLkxmTQ4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w3Gf1-000547-Ad; Thu, 19 Mar 2026 17:55:51 +0100 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w3Gf0-0016i9-2v; Thu, 19 Mar 2026 17:55:50 +0100 Received: from hardanger.blackshift.org (p4ffb2dc6.dip0.t-ipconnect.de [79.251.45.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519MLKEM768 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 8AB2650877D; Thu, 19 Mar 2026 16:55:50 +0000 (UTC) From: Marc Kleine-Budde Date: Thu, 19 Mar 2026 17:55:35 +0100 Subject: [PATCH spi-next v2 01/11] spi: spi-fsl-lpspi: adapt to kernel coding style Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260319-spi-fsl-lpspi-cleanups-v2-1-02b56c5d44a8@pengutronix.de> References: <20260319-spi-fsl-lpspi-cleanups-v2-0-02b56c5d44a8@pengutronix.de> In-Reply-To: <20260319-spi-fsl-lpspi-cleanups-v2-0-02b56c5d44a8@pengutronix.de> To: Frank Li , Mark Brown Cc: Marek Vasut , linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-5154a X-Developer-Signature: v=1; a=openpgp-sha256; l=1415; i=mkl@pengutronix.de; h=from:subject:message-id; bh=cewxigfhr8A62nFh2/tWGpwMAz9fbmcaksUZ7wDWT78=; b=owGbwMvMwCV2xirl17qZay8xnlZLYsjco9V53zDzykF/+djlAikzU0/2ci2ONmlveRe7UWPrz Zbue26iHaUsDGJcDLJiiixLf5xQFAh0KO19mTAJZg4rE8gQBi5OAZjIPyZGhp5z9YsMTwdYWDbk K12epenaaMzHtUxC84PzdJt33689ecDwv3L5oYRD+ro6rjwnVweYnc6I/cR7jMvA5t7KtTXxeg7 8LAA= X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Adapt the driver to current kernel coding style standards. Signed-off-by: Marc Kleine-Budde --- drivers/spi/spi-fsl-lpspi.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index b361c1bb3e43..989d0ffddc25 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -112,8 +112,8 @@ struct fsl_lpspi_data { =20 void *rx_buf; const void *tx_buf; - void (*tx)(struct fsl_lpspi_data *); - void (*rx)(struct fsl_lpspi_data *); + void (*tx)(struct fsl_lpspi_data *fsl_lpspi); + void (*rx)(struct fsl_lpspi_data *fsl_lpspi); =20 u32 remain; u8 watermark; @@ -271,8 +271,9 @@ static void fsl_lpspi_write_tx_fifo(struct fsl_lpspi_da= ta *fsl_lpspi) } =20 fsl_lpspi_intctrl(fsl_lpspi, IER_FCIE); - } else + } else { fsl_lpspi_intctrl(fsl_lpspi, IER_TDIE); + } } =20 static void fsl_lpspi_read_rx_fifo(struct fsl_lpspi_data *fsl_lpspi) @@ -348,11 +349,10 @@ static int fsl_lpspi_set_bitrate(struct fsl_lpspi_dat= a *fsl_lpspi) return -EINVAL; } =20 - if (config.speed_hz > perclk_rate / 2) { + if (config.speed_hz > perclk_rate / 2) div =3D 2; - } else { + else div =3D DIV_ROUND_UP(perclk_rate, config.speed_hz); - } =20 for (prescale =3D 0; prescale <=3D prescale_max; prescale++) { scldiv =3D div / (1 << prescale) - 2; --=20 2.53.0 From nobody Mon Apr 6 10:46:34 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0762F3EFD1E for ; Thu, 19 Mar 2026 16:56:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773939373; cv=none; b=SxdgJpReBxV2y1bfH6x8rKL5SdoWKMUxvJKa6Bh7HQGnthP/a1pl4uFL2s81HfY10+ICD7EWbQzmqZc9OWehWtRhSn6HPcnegQ9rQqb+JgBLd7jnZAcsIqMgcenpwmHCuWhzg2WO5VKlc+DkgWJJ/7BmurFOf7LaGlHAyUcOUr8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773939373; c=relaxed/simple; bh=eFJ17SEXA3yxx+mKNJAWcaWMYlO+mNp7CmFTIq8Af3Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jSZThkuEjMeynwJTFBnKD2+R6eWHitGi25Q6e6WzTC12ZUhE6uWRyf8y3aBwVXH6s8/C3ZVcgkTCfBjEnG7v4CGvqfizn2Vj73INXTS9dP+HgtulKpeAJtk/i2K0+IHsPN3EzbjyiKHE3fESv5x2eyH6csZIn2F+P4wZ93RQGgQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w3Gf1-000549-Ac; Thu, 19 Mar 2026 17:55:51 +0100 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w3Gf1-0016iA-01; Thu, 19 Mar 2026 17:55:51 +0100 Received: from hardanger.blackshift.org (p4ffb2dc6.dip0.t-ipconnect.de [79.251.45.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519MLKEM768 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 961FD50877E; Thu, 19 Mar 2026 16:55:50 +0000 (UTC) From: Marc Kleine-Budde Date: Thu, 19 Mar 2026 17:55:36 +0100 Subject: [PATCH spi-next v2 02/11] spi: spi-fsl-lpspi: fsl_lpspi_set_watermark(): use FIELD_PREP() to encode FIFO Control register Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260319-spi-fsl-lpspi-cleanups-v2-2-02b56c5d44a8@pengutronix.de> References: <20260319-spi-fsl-lpspi-cleanups-v2-0-02b56c5d44a8@pengutronix.de> In-Reply-To: <20260319-spi-fsl-lpspi-cleanups-v2-0-02b56c5d44a8@pengutronix.de> To: Frank Li , Mark Brown Cc: Marek Vasut , linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-5154a X-Developer-Signature: v=1; a=openpgp-sha256; l=1521; i=mkl@pengutronix.de; h=from:subject:message-id; bh=eFJ17SEXA3yxx+mKNJAWcaWMYlO+mNp7CmFTIq8Af3Q=; b=owGbwMvMwCV2xirl17qZay8xnlZLYsjco9V1dP+hCQ3z1lSKLPBz11d5I/9oFe+lq/uZvlnf3 XciyL3Zp6OUhUGMi0FWTJFl6Y8TigKBDqW9LxMmwcxhZQIZwsDFKQATeXib4Q+H+G3z52HXTmbe CLKVVuAXfVLTU6F2j8WwMF54M/+Lcy8YfrM2FizZZN1ZbHtv+rOvOfxGtWET1STaRGXzs9hYb2/ 1YgEA X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Instead of open coding mask and shift operations and to increase readability use FIELD_PREP() to encode the FIFO Control register. Signed-off-by: Marc Kleine-Budde --- drivers/spi/spi-fsl-lpspi.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 989d0ffddc25..fdd14caf6659 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -75,6 +75,8 @@ #define CFGR1_PCSPOL_MASK GENMASK(11, 8) #define CFGR1_NOSTALL BIT(3) #define CFGR1_HOST BIT(0) +#define FCR_RXWATER GENMASK(18, 16) +#define FCR_TXWATER GENMASK(2, 0) #define FSR_TXCOUNT (0xFF) #define RSR_RXEMPTY BIT(1) #define TCR_CPOL BIT(31) @@ -319,17 +321,18 @@ static void fsl_lpspi_set_cmd(struct fsl_lpspi_data *= fsl_lpspi, =20 static void fsl_lpspi_set_watermark(struct fsl_lpspi_data *fsl_lpspi) { + u8 watermark =3D fsl_lpspi->watermark >> 1; u32 temp; =20 if (!fsl_lpspi->usedma) - temp =3D fsl_lpspi->watermark >> 1 | - (fsl_lpspi->watermark >> 1) << 16; + temp =3D FIELD_PREP(FCR_TXWATER, watermark) | + FIELD_PREP(FCR_RXWATER, watermark); else - temp =3D fsl_lpspi->watermark >> 1; + temp =3D FIELD_PREP(FCR_TXWATER, watermark); =20 writel(temp, fsl_lpspi->base + IMX7ULP_FCR); =20 - dev_dbg(fsl_lpspi->dev, "FCR=3D0x%x\n", temp); + dev_dbg(fsl_lpspi->dev, "FCR=3D0x%08x\n", temp); } =20 static int fsl_lpspi_set_bitrate(struct fsl_lpspi_data *fsl_lpspi) --=20 2.53.0 From nobody Mon Apr 6 10:46:34 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0F1D3EF674 for ; Thu, 19 Mar 2026 16:56:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773939371; cv=none; b=MIC/BGF68VB7rpOrbRvBxOqT+ctss6LwQpOQ2pC0pnOW5pfTkV/oOiLPmVRMMiKMBSuf+tOeLukmyUP9mxkljg8bo0GwOI0YyZ/uBqElV+JwW7SMC3bloi3whQGKdbksPMZw3kwK/OfwHLD5SpIgT3ohJMrDmo0yXbuXF5vA2mM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773939371; c=relaxed/simple; bh=PkC2yo5BI1aEo+Xf+NS4EiYcu8oB75ML9kN9GINNcjo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iNeISBcW5Hi1EoU0XpiL2RAlxgddJnSNcJb8tcZnu2xe0NCj0WJa0jBfu2ugrZqUCE9im/r+Q3mtvHM67KUUSa4V3En6C0Xt6iD9pB+tllrUdzBIVCyQ1gmtyV3OFvO09ZNagOFsBGc035QNPKxmlhELUyA4HP1wcnMs+VnSrNw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w3Gf1-00054B-Kn; Thu, 19 Mar 2026 17:55:51 +0100 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w3Gf1-0016iF-0Y; Thu, 19 Mar 2026 17:55:51 +0100 Received: from hardanger.blackshift.org (p4ffb2dc6.dip0.t-ipconnect.de [79.251.45.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519MLKEM768 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id A26A750877F; Thu, 19 Mar 2026 16:55:50 +0000 (UTC) From: Marc Kleine-Budde Date: Thu, 19 Mar 2026 17:55:37 +0100 Subject: [PATCH spi-next v2 03/11] spi: spi-fsl-lpspi: fsl_lpspi_probe(): use FIELD_GET to decode Parameter register and add size check Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260319-spi-fsl-lpspi-cleanups-v2-3-02b56c5d44a8@pengutronix.de> References: <20260319-spi-fsl-lpspi-cleanups-v2-0-02b56c5d44a8@pengutronix.de> In-Reply-To: <20260319-spi-fsl-lpspi-cleanups-v2-0-02b56c5d44a8@pengutronix.de> To: Frank Li , Mark Brown Cc: Marek Vasut , linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-5154a X-Developer-Signature: v=1; a=openpgp-sha256; l=2704; i=mkl@pengutronix.de; h=from:subject:message-id; bh=PkC2yo5BI1aEo+Xf+NS4EiYcu8oB75ML9kN9GINNcjo=; b=owGbwMvMwCV2xirl17qZay8xnlZLYsjco9Vzq8Zo38MPH12+b+C2rssI2VFdKZ6R6ybrZ7R4r bT3JIkdHaUsDGJcDLJiiixLf5xQFAh0KO19mTAJZg4rE8gQBi5OAZjIwRiGP1wzY4SNLlbPe+Sl cHLpRKbEr0lb1S2XZmpfaKnpf/BAayMjw6brS/YfmnNYvNonIS61/BPj1n6Bc4/r5z7JkmP4obj Ugh0A X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org According to the i.MX93 datasheet both FIFO order fields are 8 bits wide. Widen the PARAM_RXFIFO and PARAM_TXFIFO according to the datasheet. A 8 bit wide FIFO order field can result in a max FIFO size of 2^255, sanity check and limit the FIFO order against the width of the watermark field. Instead of open coding mask and shift operations and to increase readability use FIELD_GET() to decode the Parameter register. Signed-off-by: Marc Kleine-Budde --- drivers/spi/spi-fsl-lpspi.c | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index fdd14caf6659..75f4e0e9acee 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -55,6 +55,9 @@ #define IMX7ULP_RDR 0x74 =20 /* General control register field define */ +#define PARAM_PCSNUM GENMASK(23, 16) +#define PARAM_RXFIFO GENMASK(15, 8) +#define PARAM_TXFIFO GENMASK(7, 0) #define CR_RRF BIT(9) #define CR_RTF BIT(8) #define CR_RST BIT(1) @@ -77,6 +80,8 @@ #define CFGR1_HOST BIT(0) #define FCR_RXWATER GENMASK(18, 16) #define FCR_TXWATER GENMASK(2, 0) +#define RXFIFO_ORDER_MAX (ilog2(FIELD_MAX(FCR_RXWATER) + 1)) +#define TXFIFO_ORDER_MAX (ilog2(FIELD_MAX(FCR_TXWATER) + 1)) #define FSR_TXCOUNT (0xFF) #define RSR_RXEMPTY BIT(1) #define TCR_CPOL BIT(31) @@ -906,6 +911,7 @@ static int fsl_lpspi_probe(struct platform_device *pdev) struct fsl_lpspi_data *fsl_lpspi; struct spi_controller *controller; struct resource *res; + unsigned int txfifo_order, rxfifo_order; int ret, irq; u32 num_cs; u32 temp; @@ -981,12 +987,22 @@ static int fsl_lpspi_probe(struct platform_device *pd= ev) } =20 temp =3D readl(fsl_lpspi->base + IMX7ULP_PARAM); - fsl_lpspi->txfifosize =3D 1 << (temp & 0x0f); - fsl_lpspi->rxfifosize =3D 1 << ((temp >> 8) & 0x0f); + txfifo_order =3D FIELD_GET(PARAM_TXFIFO, temp); + rxfifo_order =3D FIELD_GET(PARAM_RXFIFO, temp); + if (txfifo_order > TXFIFO_ORDER_MAX || rxfifo_order > RXFIFO_ORDER_MAX) { + dev_info(fsl_lpspi->dev, + "TX-FIFO order (%u) or RX-FIFO order (%u) too high, limiting to %u\n", + txfifo_order, rxfifo_order, TXFIFO_ORDER_MAX); + + txfifo_order =3D min(TXFIFO_ORDER_MAX, txfifo_order); + rxfifo_order =3D min(RXFIFO_ORDER_MAX, rxfifo_order); + } + fsl_lpspi->txfifosize =3D 1 << txfifo_order; + fsl_lpspi->rxfifosize =3D 1 << rxfifo_order; if (of_property_read_u32((&pdev->dev)->of_node, "num-cs", &num_cs)) { if (devtype_data->query_hw_for_num_cs) - num_cs =3D ((temp >> 16) & 0xf); + num_cs =3D FIELD_GET(PARAM_PCSNUM, temp); else num_cs =3D 1; } --=20 2.53.0 From nobody Mon Apr 6 10:46:34 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AB2C3EF0DA for ; Thu, 19 Mar 2026 16:56:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773939372; cv=none; b=UOmLzObT36NHgbwDK2MvmgN9OKQ172Ir+8OCLpCbDCfJHllQaJ5IsMxg8B1q84i+lFrF0mUIEol5l59p09Liz3Vcj0howV9rfQKFmbf6Oe6IIW4dueZQe1Z8bjhEjX+A+oKxAEuQtmxSupoYM/i7zeQYeaJ5zjahqCdXo194p1Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773939372; c=relaxed/simple; bh=ZlPwpl16UHpdcmGdEM2Pg3oWIFE6Wu98DdD6pPcKcVk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rXEolEdpx0r0iibdgEAyvn+pfTQMn+VG8tfF/9anpE1GnnB+4/7Uui9kR8KRrUelUKFyX6kbf5j1pwHhboGPYJi/arAmzl/AP/1nU71VS/Lya8TWOHrROvkOlG5TtLgrd5PF8A0FyCS+uvhe2rHpPjmg7uFMrE0MELY8HgzCYV4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w3Gf1-00054A-Ed; Thu, 19 Mar 2026 17:55:51 +0100 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w3Gf1-0016iE-0X; Thu, 19 Mar 2026 17:55:51 +0100 Received: from hardanger.blackshift.org (p4ffb2dc6.dip0.t-ipconnect.de [79.251.45.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519MLKEM768 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id ACAFA508780; Thu, 19 Mar 2026 16:55:50 +0000 (UTC) From: Marc Kleine-Budde Date: Thu, 19 Mar 2026 17:55:38 +0100 Subject: [PATCH spi-next v2 04/11] spi: spi-fsl-lpspi: fsl_lpspi_set_cmd(): use mode from struct fsl_lpspi_data::config::mode Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260319-spi-fsl-lpspi-cleanups-v2-4-02b56c5d44a8@pengutronix.de> References: <20260319-spi-fsl-lpspi-cleanups-v2-0-02b56c5d44a8@pengutronix.de> In-Reply-To: <20260319-spi-fsl-lpspi-cleanups-v2-0-02b56c5d44a8@pengutronix.de> To: Frank Li , Mark Brown Cc: Marek Vasut , linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-5154a X-Developer-Signature: v=1; a=openpgp-sha256; l=2149; i=mkl@pengutronix.de; h=from:subject:message-id; bh=ZlPwpl16UHpdcmGdEM2Pg3oWIFE6Wu98DdD6pPcKcVk=; b=owGbwMvMwCV2xirl17qZay8xnlZLYsjco9WzJtNL8eObx54unZuOq3jO+Wb7M1QtUM3p+60F3 aUWVx86d5SyMIhxMciKKbIs/XFCUSDQobT3ZcIkmDmsTCBDGLg4BWAiDHKMDNMfxhr9mt9ybvE8 u9bfMunHBG7+Xf+u3PHIpACm9oTwFdoM/8z5jI3lmL2mX3843Zn/Pf+Sr+kCx5Lmdxg3f+UVE7E 1YgQA X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Commit 7ae4d097b752 ("spi: spi-fsl-lpspi: Handle clock polarity and phase") enhances the driver with clock polarity and phase handling. That commit adds a 2nd argument ("struct spi_device *spi") to the fsl_lpspi_set_cmd() function. The "spi" pointer is used to access the "mode" of the current transfer. However the mode is already available via "fsl_lpspi->config.mode". To simplify the driver remove the 2nd argument and use "fsl_lpspi->config.mode" to access the mode. Cc: Marek Vasut Reviewed-by: Marek Vasut Signed-off-by: Marc Kleine-Budde --- drivers/spi/spi-fsl-lpspi.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 75f4e0e9acee..c20376da1d37 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -289,8 +289,7 @@ static void fsl_lpspi_read_rx_fifo(struct fsl_lpspi_dat= a *fsl_lpspi) fsl_lpspi->rx(fsl_lpspi); } =20 -static void fsl_lpspi_set_cmd(struct fsl_lpspi_data *fsl_lpspi, - struct spi_device *spi) +static void fsl_lpspi_set_cmd(struct fsl_lpspi_data *fsl_lpspi) { u32 temp =3D 0; =20 @@ -313,10 +312,10 @@ static void fsl_lpspi_set_cmd(struct fsl_lpspi_data *= fsl_lpspi, } } =20 - if (spi->mode & SPI_CPOL) + if (fsl_lpspi->config.mode & SPI_CPOL) temp |=3D TCR_CPOL; =20 - if (spi->mode & SPI_CPHA) + if (fsl_lpspi->config.mode & SPI_CPHA) temp |=3D TCR_CPHA; =20 writel(temp, fsl_lpspi->base + IMX7ULP_TCR); @@ -533,7 +532,7 @@ static int fsl_lpspi_prepare_message(struct spi_control= ler *controller, if (ret < 0) return ret; =20 - fsl_lpspi_set_cmd(fsl_lpspi, spi); + fsl_lpspi_set_cmd(fsl_lpspi); =20 /* No IRQs */ writel(0, fsl_lpspi->base + IMX7ULP_IER); @@ -813,7 +812,7 @@ static int fsl_lpspi_transfer_one(struct spi_controller= *controller, =20 t->effective_speed_hz =3D fsl_lpspi->config.effective_speed_hz; =20 - fsl_lpspi_set_cmd(fsl_lpspi, spi); + fsl_lpspi_set_cmd(fsl_lpspi); fsl_lpspi->is_first_byte =3D false; =20 if (fsl_lpspi->usedma) --=20 2.53.0 From nobody Mon Apr 6 10:46:34 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0464F3EFD0D for ; Thu, 19 Mar 2026 16:56:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773939372; cv=none; b=cljYApLwnRXIeEy9MDqMIz4Q16LysD7hGpPIv7vqt7mljacsKbuf+fwhAHabFaT53ZllBDvLQzamQ+8D5TFVpsAswUl2djAaAXD8LbzieHgahcYTwWy3Tun1dZhVK9kfpZqzZ0xtLLZHteqiH149PbjycSUCXXJHd9e0ruBfxZ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773939372; c=relaxed/simple; bh=dy11iQJKxpsIuMdWWq+CSR2WKBQnNeC1vmiLhqqUDtU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nBCcr/yubWgrYBvBSYd+95dl9zqv5Nh8xt9S8p9E5F8Oe54GqFoVOC3kZQE9OsFmBz0GYRzTocGlzU3FnxmanS4Hrr8L6k0FDm2wkB0agZgsldRBNrk6+fl3FcEBqvbINtHPnBfpnzkUcKSG5rDrUzH4Q4tbC4AtnLDG/PUnX1Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w3Gf1-00054C-Ij; Thu, 19 Mar 2026 17:55:51 +0100 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w3Gf1-0016iH-0Z; Thu, 19 Mar 2026 17:55:51 +0100 Received: from hardanger.blackshift.org (p4ffb2dc6.dip0.t-ipconnect.de [79.251.45.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519MLKEM768 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id B8D18508781; Thu, 19 Mar 2026 16:55:50 +0000 (UTC) From: Marc Kleine-Budde Date: Thu, 19 Mar 2026 17:55:39 +0100 Subject: [PATCH spi-next v2 05/11] spi: spi-fsl-lpspi: fsl_lpspi_set_cmd(): remove obfuscated and obsolete assignment of TCR_CPOL and SPI_CPHA Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260319-spi-fsl-lpspi-cleanups-v2-5-02b56c5d44a8@pengutronix.de> References: <20260319-spi-fsl-lpspi-cleanups-v2-0-02b56c5d44a8@pengutronix.de> In-Reply-To: <20260319-spi-fsl-lpspi-cleanups-v2-0-02b56c5d44a8@pengutronix.de> To: Frank Li , Mark Brown Cc: Marek Vasut , linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-5154a X-Developer-Signature: v=1; a=openpgp-sha256; l=1545; i=mkl@pengutronix.de; h=from:subject:message-id; bh=dy11iQJKxpsIuMdWWq+CSR2WKBQnNeC1vmiLhqqUDtU=; b=owGbwMvMwCV2xirl17qZay8xnlZLYsjco9Vrvu5mXZNJ0I5bP1l/bv8c1m4YW9/W0TU/rn0r1 47jE0t6OkpZGMS4GGTFFFmW/jihKBDoUNr7MmESzBxWJpAhDFycAjARdQlGhm+OnjUzUmobnulp blslM8G433NVt3H8kkNBnf8CZ61NSWVk+PXiivXqQG/dO9tjtRds0bac2vRQy8Pa88TaTU6KLU6 bOQA= X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Commit 7ae4d097b752 ("spi: spi-fsl-lpspi: Handle clock polarity and phase") enhances the driver with clock polarity and phase handling. Among other things that commit in fsl_lpspi_set_cmd() explicitly set the bits TCR_CPOL and TCR_CPHA bits in the TCR register depending on their corresponding bits in the SPI mode (SPI_CPOL and SPI_CPHA), to configure clock polarity and phase. That change made the assignment of the lowest 2 bits of lpspi_config::mode shifted by << 30 to the TCR register obsolete. The lowest 2 bits of struct lpspi_config::mode (=3D SPI_CPOL and SPI_CPHA) match the corresponding bits in the TCR register (TCR_CPOL and TCR_CPHA) if shifted. Keep the better readable and maintainable version provided in commit 7ae4d097b752 ("spi: spi-fsl-lpspi: Handle clock polarity and phase") and remove the obfuscated version. Cc: Marek Vasut Signed-off-by: Marc Kleine-Budde --- drivers/spi/spi-fsl-lpspi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index c20376da1d37..4cf73e56d2f2 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -294,7 +294,6 @@ static void fsl_lpspi_set_cmd(struct fsl_lpspi_data *fs= l_lpspi) u32 temp =3D 0; =20 temp |=3D fsl_lpspi->config.bpw - 1; - temp |=3D (fsl_lpspi->config.mode & 0x3) << 30; temp |=3D (fsl_lpspi->config.chip_select & 0x3) << 24; if (!fsl_lpspi->is_target) { temp |=3D fsl_lpspi->config.prescale << 27; --=20 2.53.0 From nobody Mon Apr 6 10:46:34 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 449BD3EFD03 for ; Thu, 19 Mar 2026 16:56:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773939372; cv=none; b=G+yPSEeN2xby+OB/zx4j+9rAjBLGOYMqT5gd0v0WDC+HZzJnloRGb9MjFIbCezV90G0iEIT2fsZPbgkRFsOEgVT4plx27RpbCHR6SbVDaJ6kopvmuhzIHgWfX2MDAPvZ4ar6xY/Vow/a/HOElwAUtlju+E6an0686CU6WHPJL7U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773939372; c=relaxed/simple; bh=q2mJy7eypUAaxJ3eYEvEi0fYF3PcXvRF1wjPDL8lxOI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UKah38hXHf76lMIhDBKzJqSJW3Ed5+p2pmBrPpMVS15/r2DVMhS3EktjdxCLVwOUVESs2hYeprHCO65EHyVpgYXVCQx7hvNzcGh9KaD35J3Zv0BfV5YYp/7Q2RbqvKOYZm2IiKibsk4CkXfgzVc5PVdUCZH8+AJGw8YLVloFU/k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w3Gf1-00054D-Hm; Thu, 19 Mar 2026 17:55:51 +0100 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w3Gf1-0016iI-0c; Thu, 19 Mar 2026 17:55:51 +0100 Received: from hardanger.blackshift.org (p4ffb2dc6.dip0.t-ipconnect.de [79.251.45.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519MLKEM768 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id C2E5F508782; Thu, 19 Mar 2026 16:55:50 +0000 (UTC) From: Marc Kleine-Budde Date: Thu, 19 Mar 2026 17:55:40 +0100 Subject: [PATCH spi-next v2 06/11] spi: spi-fsl-lpspi: fsl_lpspi_set_cmd(): use FIELD_PREP to encode Transmit Command register Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260319-spi-fsl-lpspi-cleanups-v2-6-02b56c5d44a8@pengutronix.de> References: <20260319-spi-fsl-lpspi-cleanups-v2-0-02b56c5d44a8@pengutronix.de> In-Reply-To: <20260319-spi-fsl-lpspi-cleanups-v2-0-02b56c5d44a8@pengutronix.de> To: Frank Li , Mark Brown Cc: Marek Vasut , linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-5154a X-Developer-Signature: v=1; a=openpgp-sha256; l=1510; i=mkl@pengutronix.de; h=from:subject:message-id; bh=q2mJy7eypUAaxJ3eYEvEi0fYF3PcXvRF1wjPDL8lxOI=; b=owGbwMvMwCV2xirl17qZay8xnlZLYsjco9XHW7vX9duz/fOFtlsEXZORiXmQ7Xp17TOBh1evu dcmP+c+1VHKwiDGxSArpsiy9McJRYFAh9LelwmTYOawMoEMYeDiFICJKDAw/I/Q/s5d5dmzeSfj 13/lfcavUrI0L9o3pl/M3K6y88VyIRuG/4HibovZfdft2HnWIHv1tLAqrolBnXM9P641Cii6oR2 wmgsA X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Instead of open coding mask and shift operations and to increase readability use FIELD_PREP() to encode the Transmit Command register. Signed-off-by: Marc Kleine-Budde --- drivers/spi/spi-fsl-lpspi.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 4cf73e56d2f2..38e4e991e97e 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -86,10 +86,14 @@ #define RSR_RXEMPTY BIT(1) #define TCR_CPOL BIT(31) #define TCR_CPHA BIT(30) +#define TCR_MODE GENMASK(31, 30) +#define TCR_PRESCALE GENMASK(29, 27) +#define TCR_PCS GENMASK(25, 24) #define TCR_CONT BIT(21) #define TCR_CONTC BIT(20) #define TCR_RXMSK BIT(19) #define TCR_TXMSK BIT(18) +#define TCR_FRAMESZ GENMASK(11, 0) =20 #define SR_CLEAR_MASK GENMASK(13, 8) =20 @@ -293,10 +297,10 @@ static void fsl_lpspi_set_cmd(struct fsl_lpspi_data *= fsl_lpspi) { u32 temp =3D 0; =20 - temp |=3D fsl_lpspi->config.bpw - 1; - temp |=3D (fsl_lpspi->config.chip_select & 0x3) << 24; + temp |=3D FIELD_PREP(TCR_FRAMESZ, fsl_lpspi->config.bpw - 1); + temp |=3D FIELD_PREP(TCR_PCS, fsl_lpspi->config.chip_select); if (!fsl_lpspi->is_target) { - temp |=3D fsl_lpspi->config.prescale << 27; + temp |=3D FIELD_PREP(TCR_PRESCALE, fsl_lpspi->config.prescale); /* * Set TCR_CONT will keep SS asserted after current transfer. * For the first transfer, clear TCR_CONTC to assert SS. --=20 2.53.0 From nobody Mon Apr 6 10:46:34 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DE9C3EE1C4 for ; Thu, 19 Mar 2026 16:56:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773939371; cv=none; b=du8usc8zGOYaJDcUo9YPtOCWlftsp8xYh/ch7twfSn+vMmj5BQtYOnQLgoKCHv5kogspkv3og21ApvEjQi/881nbHGDDRaQBRfMoc8H7kJaPMCx77oCGEF4/pIoz46ck2h54PRwS+O90fCLZazdf5s3wgAklEEb4d4bHSwIk6rM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773939371; c=relaxed/simple; bh=LNugL5fW2X1cEj7zjSNuviQZrKi7Wm/l+PYVtQ45H74=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=K/t2BfR4IBNeDJGGWbjlW+Ds//vuapLYHotnOaX4i6HVT6++trgzoFGZri8QDt6MWIRWDmisVE08GeKaHLHPdt0RGfDcqrdbovL21RSMHTBoGHa5rAngoyU3YeUl6papUcA+MBUmY8vrRm5rpqWU6WYZYoiCw64UVHF4bCFhrfM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w3Gf1-00054E-P9; Thu, 19 Mar 2026 17:55:51 +0100 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w3Gf1-0016iL-0o; Thu, 19 Mar 2026 17:55:51 +0100 Received: from hardanger.blackshift.org (p4ffb2dc6.dip0.t-ipconnect.de [79.251.45.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519MLKEM768 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id D127C508783; Thu, 19 Mar 2026 16:55:50 +0000 (UTC) From: Marc Kleine-Budde Date: Thu, 19 Mar 2026 17:55:41 +0100 Subject: [PATCH spi-next v2 07/11] spi: spi-fsl-lpspi: fsl_lpspi_setup_transfer(): remove useless spi_transfer NULL pointer check Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260319-spi-fsl-lpspi-cleanups-v2-7-02b56c5d44a8@pengutronix.de> References: <20260319-spi-fsl-lpspi-cleanups-v2-0-02b56c5d44a8@pengutronix.de> In-Reply-To: <20260319-spi-fsl-lpspi-cleanups-v2-0-02b56c5d44a8@pengutronix.de> To: Frank Li , Mark Brown Cc: Marek Vasut , linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-5154a X-Developer-Signature: v=1; a=openpgp-sha256; l=1149; i=mkl@pengutronix.de; h=from:subject:message-id; bh=LNugL5fW2X1cEj7zjSNuviQZrKi7Wm/l+PYVtQ45H74=; b=owGbwMvMwCV2xirl17qZay8xnlZLYsjco9X/dc+TtJzE6dOfXjKTVrnfubD8sYHEJKmPhw+XW V3TD5rQ1VHKwiDGxSArpsiy9McJRYFAh9LelwmTYOawMoEMYeDiFICJRB5j+J/62nZ64b1jX1pe nv8zq4tjoUH5+u8uEyaY/V8guIXnwj9jRoa+5ZuV4q7qVTYxflFhevXodDtLhsZ82SuOvNMFEk2 vfeEBAA== X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org fsl_lpspi_setup_transfer() is either called via: | fsl_lpspi_prepare_message() | -> fsl_lpspi_setup_transfer() or | -> spi_transfer_one_message() | -> controller->transfer_one =3D=3D fsl_lpspi_transfer_one() | -> fsl_lpspi_setup_transfer() The first call path already has a spi_transfer NULL pointer check, the second one explicitly iterates over all spi_transfer of the spi_message. Simplify the code by removing the useless NULL pointer check. Signed-off-by: Marc Kleine-Budde --- drivers/spi/spi-fsl-lpspi.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 38e4e991e97e..15ec7b3a5cd1 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -476,9 +476,6 @@ static int fsl_lpspi_setup_transfer(struct spi_controll= er *controller, struct fsl_lpspi_data *fsl_lpspi =3D spi_controller_get_devdata(spi->controller); =20 - if (t =3D=3D NULL) - return -EINVAL; - fsl_lpspi->config.mode =3D spi->mode; fsl_lpspi->config.bpw =3D t->bits_per_word; fsl_lpspi->config.speed_hz =3D t->speed_hz; --=20 2.53.0 From nobody Mon Apr 6 10:46:34 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F6213EF66E for ; Thu, 19 Mar 2026 16:56:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773939371; cv=none; b=XIyo+ATppxYNeoA742S71z98Kde6E9CYNLFn5cbB/gqy+kETIyWUuM9W1CblsUlgHJ79gsSyPccXvsDa5HDQFGEuPkYcbZKyMugTU58i/piMhm/EWFQyahAlP2v7wsuHxEJJriTnjBbcWPTcUH/Oo4XUzG5v9yy2NVzNukDC6MI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773939371; c=relaxed/simple; bh=tvBQXKhpDbXnkhHjloEEnk1mbMC1sz0squTl51pxRAg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EKmSVBlydd5Flgf4Jg+KXBTYTxdyw8ljKmj09hwAq45iwtn78T8HxXIkhVkCwn/ctlnDVY3kY/vQZdan/JOXe9yiHnlgsEjCzPdCtlcWS1soTDcqtcIOgBKAXwIB37WJFt3kvJtNIsTl3YcFRvFUqNgc6Ge15kQGA2c6WWo/Q4c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w3Gf1-00054J-OR; Thu, 19 Mar 2026 17:55:51 +0100 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w3Gf1-0016iM-10; Thu, 19 Mar 2026 17:55:51 +0100 Received: from hardanger.blackshift.org (p4ffb2dc6.dip0.t-ipconnect.de [79.251.45.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519MLKEM768 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id E009B508784; Thu, 19 Mar 2026 16:55:50 +0000 (UTC) From: Marc Kleine-Budde Date: Thu, 19 Mar 2026 17:55:42 +0100 Subject: [PATCH spi-next v2 08/11] spi: spi-fsl-lpspi: fsl_lpspi_can_dma(): directly assign return value to fsl_lpspi->usedma Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260319-spi-fsl-lpspi-cleanups-v2-8-02b56c5d44a8@pengutronix.de> References: <20260319-spi-fsl-lpspi-cleanups-v2-0-02b56c5d44a8@pengutronix.de> In-Reply-To: <20260319-spi-fsl-lpspi-cleanups-v2-0-02b56c5d44a8@pengutronix.de> To: Frank Li , Mark Brown Cc: Marek Vasut , linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-5154a X-Developer-Signature: v=1; a=openpgp-sha256; l=1330; i=mkl@pengutronix.de; h=from:subject:message-id; bh=tvBQXKhpDbXnkhHjloEEnk1mbMC1sz0squTl51pxRAg=; b=owGbwMvMwCV2xirl17qZay8xnlZLYsjcozVRf5OfkmnhpX350ibBIvc2Tvtx7fRrXgXO6BuRo U8CtneldZSyMIhxMciKKbIs/XFCUSDQobT3ZcIkmDmsTCBDGLg4BWAiVWsZGW7vyV6qv3m6y5SS tNreQO6q+54z363paxbL5vCJcJstKMTwP7/wndyZt9o7PmWZf9L5I9+iKa2xctd94ZijTmmcH9e +4wQA X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org The function fsl_lpspi_can_dma() returns a bool. Simplify the code, remove the if/else and assign the return value of fsl_lpspi_can_dma() directly to fsl_lpspi->usedma. Signed-off-by: Marc Kleine-Budde --- drivers/spi/spi-fsl-lpspi.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 15ec7b3a5cd1..f54b72e3a2aa 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -524,10 +524,7 @@ static int fsl_lpspi_prepare_message(struct spi_contro= ller *controller, fsl_lpspi->usedma =3D false; ret =3D fsl_lpspi_setup_transfer(controller, spi, t); =20 - if (fsl_lpspi_can_dma(controller, spi, t)) - fsl_lpspi->usedma =3D true; - else - fsl_lpspi->usedma =3D false; + fsl_lpspi->usedma =3D fsl_lpspi_can_dma(controller, spi, t); =20 if (ret < 0) return ret; @@ -801,10 +798,7 @@ static int fsl_lpspi_transfer_one(struct spi_controlle= r *controller, spi_controller_get_devdata(controller); int ret; =20 - if (fsl_lpspi_can_dma(controller, spi, t)) - fsl_lpspi->usedma =3D true; - else - fsl_lpspi->usedma =3D false; + fsl_lpspi->usedma =3D fsl_lpspi_can_dma(controller, spi, t); =20 ret =3D fsl_lpspi_setup_transfer(controller, spi, t); if (ret < 0) --=20 2.53.0 From nobody Mon Apr 6 10:46:34 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D0803EF0AC for ; Thu, 19 Mar 2026 16:56:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773939374; cv=none; b=sbgNTbayvhcCqjELnhFROw3flO5QIJ0/AY64kukdAnZikPm65AEshbmH0AIzVrbkRT4vUNx8pMqJxhIaskQCOd40qTlF3EVNab/B+UeVcz/X2KZUkDBdHChl+15s7Ejzc6k71fPsM8fP7HGC2Lpadi04EgStBVm40Eeyjwr4MHw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773939374; c=relaxed/simple; bh=UWUiatWg4MfD0SI42Vpr1GV3NKMVjp3KTsoMTQ9uxyY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qEhbcrK3Kk3j0m5Mb3Dc34WamhlRmnz1u0U5yEGiR8A5xDu5ooPFIEUyQGK+TKESgyi5mnQb2b4s3cErXMxMrDepSXNTuHsgQgeNytaFNB9wNfkyCV4hxiu3+wU63Qfb19UO0gnDlmkSx6BFz/W3x4SWGpVI+v6424Be5PAPbew= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w3Gf2-00054h-0S; Thu, 19 Mar 2026 17:55:52 +0100 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w3Gf1-0016iN-1M; Thu, 19 Mar 2026 17:55:51 +0100 Received: from hardanger.blackshift.org (p4ffb2dc6.dip0.t-ipconnect.de [79.251.45.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519MLKEM768 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id EF7F5508785; Thu, 19 Mar 2026 16:55:50 +0000 (UTC) From: Marc Kleine-Budde Date: Thu, 19 Mar 2026 17:55:43 +0100 Subject: [PATCH spi-next v2 09/11] spi: spi-fsl-lpspi: fsl_lpspi_reset(): convert to void function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260319-spi-fsl-lpspi-cleanups-v2-9-02b56c5d44a8@pengutronix.de> References: <20260319-spi-fsl-lpspi-cleanups-v2-0-02b56c5d44a8@pengutronix.de> In-Reply-To: <20260319-spi-fsl-lpspi-cleanups-v2-0-02b56c5d44a8@pengutronix.de> To: Frank Li , Mark Brown Cc: Marek Vasut , linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-5154a X-Developer-Signature: v=1; a=openpgp-sha256; l=1008; i=mkl@pengutronix.de; h=from:subject:message-id; bh=UWUiatWg4MfD0SI42Vpr1GV3NKMVjp3KTsoMTQ9uxyY=; b=owGbwMvMwCV2xirl17qZay8xnlZLYsjcozWpkl+1/ebRH46MB/fXN1isunLY9hj3MYZwDZcZm 5rN3+bu7ihlYRDjYpAVU2RZ+uOEokCgQ2nvy4RJMHNYmUCGMHBxCsBEvNYw/A/r4HnFG5X9xZ35 S3paarjOTdeHx3S4TE9zJC/w0bvpq8TI8D1z+nePyt/vOY7VaX5bofyxJuhfi77UNIYlzXOM9l/ /wwUA X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org The function fsl_lpspi_reset() cannot fail and it's return value is never checked. Simplify the code and convert it into a void function. Signed-off-by: Marc Kleine-Budde --- drivers/spi/spi-fsl-lpspi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index f54b72e3a2aa..9f0d7b9ce2ab 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -578,7 +578,7 @@ static int fsl_lpspi_wait_for_completion(struct spi_con= troller *controller) return 0; } =20 -static int fsl_lpspi_reset(struct fsl_lpspi_data *fsl_lpspi) +static void fsl_lpspi_reset(struct fsl_lpspi_data *fsl_lpspi) { u32 temp; =20 @@ -593,8 +593,6 @@ static int fsl_lpspi_reset(struct fsl_lpspi_data *fsl_l= pspi) =20 /* W1C for all flags in SR */ writel(SR_CLEAR_MASK, fsl_lpspi->base + IMX7ULP_SR); - - return 0; } =20 static void fsl_lpspi_dma_rx_callback(void *cookie) --=20 2.53.0 From nobody Mon Apr 6 10:46:34 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E87743EFD05 for ; Thu, 19 Mar 2026 16:56:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773939371; cv=none; b=mqQUhI1PW/oL4T6TPCh9M+yJAveyyes6MQzE2nzQuIqfYMpU43xhtFPH7v6DqNNjRrSStq5aZ/M9AyXMIBpsMkvIlp1dquuzxLXHHAfCIkM8FhF/lmR+UHaxsIgMlg1mqd9rey1pagdPWmyg71tcmMvngU89dQ0EOGmaqgGI9Tc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773939371; c=relaxed/simple; bh=BE/l40T2dZDyBtEpo7B8D85pG0t4e3LG06EbT0RmnJU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CCuMX+68c/LVqChjqMkuTFN+ZsiWK9vDwomPIllFTqGQVC4TKsixDw33ui91QYsvBAfEp2CT6+SqW+GEn9XaP8BKKq59mcxHPcjQKoGZAVCKTGee1FT12qhsvq8RmeeltxRkOA/+Xx6fqB10oAC1SHM6tn9ld4N+IsbMewM/owk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w3Gf1-00054i-VT; Thu, 19 Mar 2026 17:55:51 +0100 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w3Gf1-0016iS-1U; Thu, 19 Mar 2026 17:55:51 +0100 Received: from hardanger.blackshift.org (p4ffb2dc6.dip0.t-ipconnect.de [79.251.45.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519MLKEM768 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 0AF63508786; Thu, 19 Mar 2026 16:55:51 +0000 (UTC) From: Marc Kleine-Budde Date: Thu, 19 Mar 2026 17:55:44 +0100 Subject: [PATCH spi-next v2 10/11] spi: spi-fsl-lpspi: fsl_lpspi_write_tx_fifo(): simplify while() loop check Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260319-spi-fsl-lpspi-cleanups-v2-10-02b56c5d44a8@pengutronix.de> References: <20260319-spi-fsl-lpspi-cleanups-v2-0-02b56c5d44a8@pengutronix.de> In-Reply-To: <20260319-spi-fsl-lpspi-cleanups-v2-0-02b56c5d44a8@pengutronix.de> To: Frank Li , Mark Brown Cc: Marek Vasut , linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-5154a X-Developer-Signature: v=1; a=openpgp-sha256; l=837; i=mkl@pengutronix.de; h=from:subject:message-id; bh=BE/l40T2dZDyBtEpo7B8D85pG0t4e3LG06EbT0RmnJU=; b=owGbwMvMwCV2xirl17qZay8xnlZLYsjcozV59bzffLUKcwTuyQf6PBJx32Jh9m/RQ2UmaQnv6 f0S/0IbOkpZGMS4GGTFFFmW/jihKBDoUNr7MmESzBxWJpAhDFycAjCRPF1GhsbdzzmcPbu4povI suZHb+R9tc9Q8fzq38YG9TyrGrqXhjL8lbulfnhHxeqoI8YNPIbFBrJi62dssLl34LRE0DpJm0U pHAA= X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org To simplify the loop check. Combine both conditions of the while() and the directly following if() into the while(). Signed-off-by: Marc Kleine-Budde --- drivers/spi/spi-fsl-lpspi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 9f0d7b9ce2ab..3265618704b0 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -267,9 +267,7 @@ static void fsl_lpspi_write_tx_fifo(struct fsl_lpspi_da= ta *fsl_lpspi) =20 txfifo_cnt =3D readl(fsl_lpspi->base + IMX7ULP_FSR) & 0xff; =20 - while (txfifo_cnt < fsl_lpspi->txfifosize) { - if (!fsl_lpspi->remain) - break; + while (txfifo_cnt < fsl_lpspi->txfifosize && fsl_lpspi->remain) { fsl_lpspi->tx(fsl_lpspi); txfifo_cnt++; } --=20 2.53.0 From nobody Mon Apr 6 10:46:34 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44AA63EFD13 for ; Thu, 19 Mar 2026 16:56:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773939372; cv=none; b=V1c9FSRVtAK5jET//zQUs2kcUT1TY1Vi1CUs7fPnTeVpaA/0ZGFL4hdJhBRtjXeJf6B2zFreJqg4YnM6AmHDIG7OtbswEfG5eaD5SWb1f1Yznen9ihYx88X77Vv4iqWM0PTPZUoeDZb7e2AInOkPUFNY3x7xNhjB/4tFK5vISG8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773939372; c=relaxed/simple; bh=9AlK0jWUTCqrbfrUGkLnLcrwP0phLj9S1J9p+IZJm1k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jAU54CAeSwfQ/VzgDsDgudzfQtEBE88UU+5iF4QAEYXQw2KzNbZtWAIFMwTmKHzZ3sq6621VbAHzSbeREmYwP3eiBNNlXQK+kyjAEZcIFq9jEVm27VBdnpRG1LFoJWVf+wIRVleHfv8Vsd76Ifa0sNJPO+fryZgVO+CTRHZYLeU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w3Gf1-00054j-U3; Thu, 19 Mar 2026 17:55:51 +0100 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w3Gf1-0016iU-1U; Thu, 19 Mar 2026 17:55:51 +0100 Received: from hardanger.blackshift.org (p4ffb2dc6.dip0.t-ipconnect.de [79.251.45.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519MLKEM768 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 1B42B508787; Thu, 19 Mar 2026 16:55:51 +0000 (UTC) From: Marc Kleine-Budde Date: Thu, 19 Mar 2026 17:55:45 +0100 Subject: [PATCH spi-next v2 11/11] spi: spi-fsl-lpspi: make struct lpspi_config::mode u32 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260319-spi-fsl-lpspi-cleanups-v2-11-02b56c5d44a8@pengutronix.de> References: <20260319-spi-fsl-lpspi-cleanups-v2-0-02b56c5d44a8@pengutronix.de> In-Reply-To: <20260319-spi-fsl-lpspi-cleanups-v2-0-02b56c5d44a8@pengutronix.de> To: Frank Li , Mark Brown Cc: Marek Vasut , linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-5154a X-Developer-Signature: v=1; a=openpgp-sha256; l=794; i=mkl@pengutronix.de; h=from:subject:message-id; bh=9AlK0jWUTCqrbfrUGkLnLcrwP0phLj9S1J9p+IZJm1k=; b=owGbwMvMwCV2xirl17qZay8xnlZLYsjcozXl79nT2i3zBMvvVj+aeSfoz0HmZ5f8Xkj/mnDtX EX7PylJlY5SFgYxLgZZMUWWpT9OKAoEOpT2vkyYBDOHlQlkCAMXpwBMJDGLkWHR5M7NHQ0fJZrf LpQ9Ezlb4NXlK43zrfaz7xDa/7vnSiAXI8My9s9mL/4LL/X/smJCu1+FnEx41SQrQ5P2PakmPPY 881gA X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org The struct lpspi_config::mode holds a copy of the mode of struct spi_device::mode. In commit 937e6d756422 ("spi: expand mode support") the struct spi_device::mode was increased from u16 to u32. Increase the struct lpspi_config::mode to u32 avoid truncating the mode variable. Signed-off-by: Marc Kleine-Budde --- drivers/spi/spi-fsl-lpspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 3265618704b0..2c7a1c4db4f1 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -106,7 +106,7 @@ struct lpspi_config { u8 bpw; u8 chip_select; u8 prescale; - u16 mode; + u32 mode; u32 speed_hz; u32 effective_speed_hz; }; --=20 2.53.0