From nobody Mon Apr 6 10:43:31 2026 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CF08405AA3 for ; Thu, 19 Mar 2026 23:31:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773963061; cv=none; b=KDpZX7bOlXJexofTZl1MhFPUSNlydELQ3tW54pyAOUsFMPpIV1HjXeE9nXDt5eD5deXOByZTD08dopssMOij79bxXxV4Ux9A9/kyxGRHXHCS0VvHD4froGRacS29x0vkEyIC7/IZFGKzHY0R6O4zGwR9tVtNiF9UQgQZ0d1R1/E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773963061; c=relaxed/simple; bh=4nBmEq8PTxZ6noHdf3XYrTEMDbspLx8WC3hJcQV/KoI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=X7HQEDZDI39WpxzfhmDPACBtfC0wH1rhbKCHoJ37mMZiNeD4DCdBMEWO+KKtSGxTa/4+HriBfIX/H2uzOEIj3g9cDip5L3sVDzhSbCvb2RWKJ47Pr6SSZPl9OOkM5VUr75d2lIbSXnQLX0FaELS2zle6QxXzob8bsUHAzTeOrL0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--wyihan.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=p+j0/diJ; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--wyihan.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="p+j0/diJ" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-354bc535546so94047a91.3 for ; Thu, 19 Mar 2026 16:31:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1773963059; x=1774567859; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=ovB857WaY8E/qhB9OVlkciDwSTU3lGKfzkX9KK2x9wk=; b=p+j0/diJlY77CuXR9Tk54HsPz5ZqsgCDDIWCVmWTZ84Pw455+A4833FDXRQpK/fJKn 3oOnBeaov91Y5rKz5YbghTf3NYdHPpLxdqy9dtC2JL5hFMXrIILkljV4Em7LmbP2grSx cqnACMcEBZDF4zHjH9SDA+PkgNp8fDc+SndHLXgkoQl1GiIUMZtsXJNhKkxL0Ja7BB6J +YoQIQ4tnZsrSaW05T+6wWdlQTYzfELFO4n3368Sjz5kzQjrrLbuk07PinNja4eQubhy LsREzRmbjOgQh6qluOVQyI99vPptGXdRFh4/hEPpQ5laJfT9W1cRQlTF/LsNqXiuGJFx zUhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773963059; x=1774567859; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ovB857WaY8E/qhB9OVlkciDwSTU3lGKfzkX9KK2x9wk=; b=ssC4WPNAGaL26P7V8F0JBgjfILG6OWIThIEnb03Kd1hfmXpG/1MBrzJnHmE/nPVeTQ r/vtaC4kkjBBFWgL8l3WqBHKHfr3rJxf2k853GWr0pjzdfX25nHfGaLIZwhD+dCgG3M3 zMrO8dOORyBUeafvjamW6ybRoKtsm+lmLfGvLmDg7WUwfmwglhGAQcqoBrQ/Oo9YxUnA AbYK8enphgCKnuLYgNyxDSMvjxBhfTk8pHAVneSBTgK8Kc+JpRY1E28/Y4lZe3Ucf6N0 m4/uKsuMuufblGldy1xto9cZxH/VNjMJXQeoa9Iw+hVvrIPM7ZemBm9QCPCrOQ1SmOfP Ul3g== X-Forwarded-Encrypted: i=1; AJvYcCVHjdVee5Kq3qf/kEB5GeSH+64RKNinLNIB9om1drlCGQ5R4wkwtSH7QuiTgggrAqoXBc3O5lP6ClGDxVQ=@vger.kernel.org X-Gm-Message-State: AOJu0YykUHs+DcJIagiLgrv7f1zjpcH6lNPtt4OgSRHWeeYBGvZzeGmu wStFwopcvIyuqI8sbavv/reN63hTw0nXkDAQUAtvcMnabEuDZUIsd1zFTH4bN4J3qtEht+GAA/G cYa7DoA== X-Received: from pfbha19.prod.google.com ([2002:a05:6a00:8513:b0:82a:5ddb:b051]) (user=wyihan job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:6a2c:b0:398:8f38:441a with SMTP id adf61e73a8af0-39bce778777mr953630637.0.1773963059297; Thu, 19 Mar 2026 16:30:59 -0700 (PDT) Date: Thu, 19 Mar 2026 23:30:30 +0000 In-Reply-To: <20260319-memory-failure-mf-delayed-fix-rfc-v2-v2-0-92c596402a7a@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260319-memory-failure-mf-delayed-fix-rfc-v2-v2-0-92c596402a7a@google.com> X-Developer-Key: i=wyihan@google.com; a=ed25519; pk=cRi0fKzS5BMxlHyHY2pJv3w/1zcgfYKr6EYGYppdMYc= X-Developer-Signature: v=1; a=ed25519-sha256; t=1773963053; l=1597; i=wyihan@google.com; s=20260319; h=from:subject:message-id; bh=4nBmEq8PTxZ6noHdf3XYrTEMDbspLx8WC3hJcQV/KoI=; b=vxpkmKNhTZAlitbCxGvzVvglenrXGw3kA9VLn/NaSu26fMFzma1N7B2oDY+7WGhTEHrWyRZfI Xc+uBjA/xs8Cf3TsOP1JQPD7CsnWMD8SRzBy9zxDOlQIv328bdjw/Ai X-Mailer: b4 0.14.3 Message-ID: <20260319-memory-failure-mf-delayed-fix-rfc-v2-v2-3-92c596402a7a@google.com> Subject: [PATCH RFC v2 3/7] mm: shmem: Update shmem handler to the MF_DELAYED definition From: Lisa Wang To: Miaohe Lin , Naoya Horiguchi , Andrew Morton , Paolo Bonzini , Shuah Khan , Hugh Dickins , Baolin Wang , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: rientjes@google.com, seanjc@google.com, ackerleytng@google.com, vannapurve@google.com, michael.roth@amd.com, jiaqiyan@google.com, tabba@google.com, dave.hansen@linux.intel.com, Lisa Wang Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable To align with the definition of MF_DELAYED, update shmem_error_remove_folio() to return MF_DELAYED. shmem handles memory failures but defers the actual file truncation. The function's return value should therefore be MF_DELAYED to accurately reflect the state. Currently, this logical error does not cause a bug, because: - For shmem folios, folio->private is not set. - As a result, filemap_release_folio() is a no-op and returns true. - This, in turn, causes truncate_error_folio() to incorrectly return MF_RECOVERED. - The caller then treats MF_RECOVERED as a success condition, masking the issue. The previous patch relays MF_DELAYED to the caller of truncate_error_folio() before any logging, so returning MF_DELAYED from shmem_error_remove_folio() will retain the original behavior of not adding any logs. The return value of truncate_error_folio() is consumed in action_result(), which treats MF_DELAYED the same way as MF_RECOVERED, hence action_result() also returns the same thing after this change. Signed-off-by: Lisa Wang --- mm/shmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/shmem.c b/mm/shmem.c index b40f3cd48961..fd8f90540361 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -5207,7 +5207,7 @@ static void __init shmem_destroy_inodecache(void) static int shmem_error_remove_folio(struct address_space *mapping, struct folio *folio) { - return 0; + return MF_DELAYED; } =20 static const struct address_space_operations shmem_aops =3D { --=20 2.53.0.959.g497ff81fa9-goog