From nobody Mon Apr 6 17:26:11 2026 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF5D8392C2E for ; Wed, 18 Mar 2026 23:41:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773877294; cv=none; b=HobDhluTmfwC1FEYPkvv5kOhFHIOzGzVMpc2tavOoQ8352qSExUciX8JQOx1yf6ce2u+ItDfg/u400+qrxDD3IPH03K3jo8SZ60EOU+Cvpd2rhJbQM8uOo7PQqQC6AEtE5KyuvWcHssJ9suU/cS51PL4Fek+P0jEu/FdMTqHrow= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773877294; c=relaxed/simple; bh=RJgUXT5DXWLK+leEwz8SukvDwtIv5eDSkt+JLlf+c6o=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=tot/diyLAIMXNERMDj6d8adUqVsfS8JHRdNBLysNlzjBJO1rIHcVIkjXrs8ghjPy032aPJQ0i2IAScjIMExx6Q3u3rhp5f/LV5hyAtddtAEqWEOZUyRtkzo9hLUYOMwD3pAmHOaHIu+WpIHHWZ83NAOPP2Ta4htLN4lJfdwRxFQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--souravpanda.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=eR1pKkgq; arc=none smtp.client-ip=209.85.210.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--souravpanda.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="eR1pKkgq" Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-82a6c70f1f8so94515b3a.0 for ; Wed, 18 Mar 2026 16:41:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1773877292; x=1774482092; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Sn/QznSYS8PkR/CPS2jvk7ULex3hHuKEEqYbEge1aWI=; b=eR1pKkgqH6gKIh6mGmeRLmlX34sy8WYkGY3gWCD9Deikn6OKy2V+DzORf23jQnKBWE fOjguHOxEX5aBOpHvp3y2bg3Q8gBElr6J/NrUahLel+S3WyWPIwLhVu6/RwX3gS69R2X QaWuqYJB6wbNNkJyiFACVfbFzSftrQmVqXg+mt0ePz0kHS6IxTNQXI8sPsv6XglEglxT yPhWEMVwE2A6neoldDEMwm2ZYRcXlFtjvLjKGuaqxmz4TeUwwN5oVRfTVB/zD1Arve0X DBatpdYNw8Wv8DVakxfoDe/JDtpMYa+EGgWx/SHryZGL/zKOpq077Z1i4QCxrSFW4Adt J17g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773877292; x=1774482092; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Sn/QznSYS8PkR/CPS2jvk7ULex3hHuKEEqYbEge1aWI=; b=ioD2y7aAsqrLdR8xNqG7hXMEm5U1kljXMwyLs0pzb5sZo5MQ9v6z50P2Y726rjJV/s bs41eyTLknCBvjbWa3O5yX598nUI77CWefnFqfujhA6K4X8LxuiW48qUYABmE3fcOxnv +PY94a3tf1hrBXxI7Sm4UsSJXhX/gzNLmsTc+jPxklPR+X7Sd+ptbgGwcdDFYts0wiS5 JcU9QZT0JXauvPFmI+8GyivmN4J5g2g/72Rgcp9VNfAbONGzwgd5nRjs02cQ35vvgcPT 1QKWjsOw6PO4XPFiQf18JxO15MiwpphRKkcySC2g63IwZtkA1cvwIQdVhEmRAhr8hxRg yOwA== X-Forwarded-Encrypted: i=1; AJvYcCWj79kZAmkMcka2j52NBZDHQK/KNZJzkxe5eD2hjMHGYvjJ/Vg9Fo4MQGfZninF1l9tTvpaBS1u1nZQDb8=@vger.kernel.org X-Gm-Message-State: AOJu0YzIVTXVD9JBVdm+WHKEJ2IssDu8aFyhKJ1vZRkba3bKUUtzem7Y tK+GdiQaLW/Uz7bHm94vkrc1TK0guU15tIKxbr4DccYgs6gERvFHvTpMR0o0cCzrHqvYVXWPaSU 8f4KmqvGJUrYrrWwCyoc70TaDiA== X-Received: from pfbbe11.prod.google.com ([2002:a05:6a00:1f0b:b0:82a:6cac:7561]) (user=souravpanda job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:6c94:b0:829:809e:8977 with SMTP id d2e1a72fcca58-82a6af3c066mr4494854b3a.49.1773877291734; Wed, 18 Mar 2026 16:41:31 -0700 (PDT) Date: Wed, 18 Mar 2026 23:41:26 +0000 In-Reply-To: <20260318234126.3216529-1-souravpanda@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260318234126.3216529-1-souravpanda@google.com> X-Mailer: git-send-email 2.53.0.983.g0bb29b3bc5-goog Message-ID: <20260318234126.3216529-3-souravpanda@google.com> Subject: [LSF/MM/BPF TOPIC][RFC PATCH 2/2] mm/hugetlb: skip hugetlb shrinking for proactive reclaim From: Sourav Panda To: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: lsf-pc@lists.linux-foundation.org, songmuchun@bytedance.com, osalvador@suse.de, mike.kravetz@oracle.com, mathieu.desnoyers@efficios.com, willy@infradead.org, david@redhat.com, pasha.tatashin@soleen.com, rientjes@google.com, weixugc@google.com, gthelen@google.com, souravpanda@google.com, surenb@google.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Scan control can indicate if we are in the proactive reclaim mode. Pass that to shrinker control and preclude frozen memory hugetlb shrinking if set. Signed-off-by: Sourav Panda --- include/linux/shrinker.h | 1 + mm/hugetlb.c | 6 ++++++ mm/internal.h | 2 +- mm/shrinker.c | 10 ++++++---- mm/vmscan.c | 6 +++--- 5 files changed, 17 insertions(+), 8 deletions(-) diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h index 5374c251ee9e..973d5fd68803 100644 --- a/include/linux/shrinker.h +++ b/include/linux/shrinker.h @@ -52,6 +52,7 @@ struct shrink_control { unsigned long nr_scanned; =20 s8 priority; + bool proactive; =20 /* current memcg being shrunk (for memcg aware shrinkers) */ struct mem_cgroup *memcg; diff --git a/mm/hugetlb.c b/mm/hugetlb.c index d4953ff1dda1..a70aed7c8665 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -4145,6 +4145,9 @@ static unsigned long hugepage_shrinker_count(struct s= hrinker *s, if (sc->priority >=3D DEF_PRIORITY - 6) return 0; =20 + if (sc->proactive) + return 0; + if (!gigantic_page_runtime_supported()) return 0; =20 @@ -4193,6 +4196,9 @@ static unsigned long hugepage_shrinker_scan(struct sh= rinker *s, if (sc->nr_to_scan =3D=3D 0) return SHRINK_STOP; =20 + if (sc->proactive) + return SHRINK_STOP; + if (!gigantic_page_runtime_supported()) return SHRINK_STOP; =20 diff --git a/mm/internal.h b/mm/internal.h index cb0af847d7d9..cccb68d723d4 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -1660,7 +1660,7 @@ void __meminit __init_page_from_nid(unsigned long pfn= , int nid); =20 /* shrinker related functions */ unsigned long shrink_slab(gfp_t gfp_mask, int nid, struct mem_cgroup *memc= g, - int priority); + int priority, bool proactive); =20 int shmem_add_to_page_cache(struct folio *folio, struct address_space *mapping, diff --git a/mm/shrinker.c b/mm/shrinker.c index 8a7a05182465..21b8f0b9d092 100644 --- a/mm/shrinker.c +++ b/mm/shrinker.c @@ -467,7 +467,7 @@ static unsigned long do_shrink_slab(struct shrink_contr= ol *shrinkctl, =20 #ifdef CONFIG_MEMCG static unsigned long shrink_slab_memcg(gfp_t gfp_mask, int nid, - struct mem_cgroup *memcg, int priority) + struct mem_cgroup *memcg, int priority, bool proactive) { struct shrinker_info *info; unsigned long ret, freed =3D 0; @@ -530,6 +530,7 @@ static unsigned long shrink_slab_memcg(gfp_t gfp_mask, = int nid, .nid =3D nid, .memcg =3D memcg, .priority =3D priority, + .proactive =3D proactive, }; struct shrinker *shrinker; int shrinker_id =3D calc_shrinker_id(index, offset); @@ -586,7 +587,7 @@ static unsigned long shrink_slab_memcg(gfp_t gfp_mask, = int nid, } #else /* !CONFIG_MEMCG */ static unsigned long shrink_slab_memcg(gfp_t gfp_mask, int nid, - struct mem_cgroup *memcg, int priority) + struct mem_cgroup *memcg, int priority, bool proactive) { return 0; } @@ -613,7 +614,7 @@ static unsigned long shrink_slab_memcg(gfp_t gfp_mask, = int nid, * Returns the number of reclaimed slab objects. */ unsigned long shrink_slab(gfp_t gfp_mask, int nid, struct mem_cgroup *memc= g, - int priority) + int priority, bool proactive) { unsigned long ret, freed =3D 0; struct shrinker *shrinker; @@ -626,7 +627,7 @@ unsigned long shrink_slab(gfp_t gfp_mask, int nid, stru= ct mem_cgroup *memcg, * oom. */ if (!mem_cgroup_disabled() && !mem_cgroup_is_root(memcg)) - return shrink_slab_memcg(gfp_mask, nid, memcg, priority); + return shrink_slab_memcg(gfp_mask, nid, memcg, priority, proactive); =20 /* * lockless algorithm of global shrink. @@ -656,6 +657,7 @@ unsigned long shrink_slab(gfp_t gfp_mask, int nid, stru= ct mem_cgroup *memcg, .nid =3D nid, .memcg =3D memcg, .priority =3D priority, + .proactive =3D proactive, }; =20 if (!shrinker_try_get(shrinker)) diff --git a/mm/vmscan.c b/mm/vmscan.c index 0fc9373e8251..39151d1edeff 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -432,7 +432,7 @@ static unsigned long drop_slab_node(int nid) =20 memcg =3D mem_cgroup_iter(NULL, NULL, NULL); do { - freed +=3D shrink_slab(GFP_KERNEL, nid, memcg, 0); + freed +=3D shrink_slab(GFP_KERNEL, nid, memcg, 0, false); } while ((memcg =3D mem_cgroup_iter(NULL, memcg, NULL)) !=3D NULL); =20 return freed; @@ -4925,7 +4925,7 @@ static int shrink_one(struct lruvec *lruvec, struct s= can_control *sc) =20 success =3D try_to_shrink_lruvec(lruvec, sc); =20 - shrink_slab(sc->gfp_mask, pgdat->node_id, memcg, sc->priority); + shrink_slab(sc->gfp_mask, pgdat->node_id, memcg, sc->priority, sc->proact= ive); =20 if (!sc->proactive) vmpressure(sc->gfp_mask, memcg, false, sc->nr_scanned - scanned, @@ -6020,7 +6020,7 @@ static void shrink_node_memcgs(pg_data_t *pgdat, stru= ct scan_control *sc) shrink_lruvec(lruvec, sc); =20 shrink_slab(sc->gfp_mask, pgdat->node_id, memcg, - sc->priority); + sc->priority, sc->proactive); =20 /* Record the group's reclaim efficiency */ if (!sc->proactive) --=20 2.53.0.983.g0bb29b3bc5-goog