From nobody Mon Apr 6 15:50:55 2026 Received: from mail-yx1-f47.google.com (mail-yx1-f47.google.com [74.125.224.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C305826158C for ; Wed, 18 Mar 2026 23:06:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773875188; cv=none; b=L3ddXe9l+w5sZm+LHUNgMxJFZ4BKBh+KbkuyXPzZfBIlHcFakOWWSs+kQiq+2PbJl1toYmZE3sjaf5sKIMkp3+D7F3/hr9quwOTug6WvTnu8EyGt1HqrjfNZXmCXbYnCtlGdq9vdswSUA7BnEGmll6R758ORJkktuZadoGSWDos= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773875188; c=relaxed/simple; bh=WkDwWR97uPMYr198IbrL+66YAHoGZpqK3oLNIHB2518=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=PLJ6QzpHBdwB0hjC7BCMFwzVvdMwmwC5vB3T9JyUXmbNACYNFwJ/Ee2uiyST0C5mtmuCVUAc3Q9H8sXMtV5vay0CgO/twX5ZmTUZv5vfRP8CWTFQTI5trmIKCleSSIrpqF9k9mvqQRSA9eJKiOsoA7aodXY/F4ElKWxso7rkCfk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q0gYWQl6; arc=none smtp.client-ip=74.125.224.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q0gYWQl6" Received: by mail-yx1-f47.google.com with SMTP id 956f58d0204a3-64c9a398bc7so26667d50.2 for ; Wed, 18 Mar 2026 16:06:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773875186; x=1774479986; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pka3MFbB++QP8Jn1PcZH7W5IZI1eMirz9wRTwsjleEg=; b=Q0gYWQl60KkVSDw4+euR7P5czFfdjUXUFOuouGZJbarO9HKIcKDT/eDzqd5p53nbBS vFxrpgmKmzAgdZuKcLZHE2mbI06bDj2OeTaSLM+ztucODzO0x3h5G21PRVth6kiOUoqf 4trB0vcZ0VkNKEYTKNaLyTUjHsRHna4QiWolB69agYdNexcmY6JEJyg0vmBCDZ9TxX5F l5uAW1P2wrcoPE2tWv2iEQbOcMcQDvtH9yu22u+oD2ZJ8SoQ2kJ3PZuHVD8SG0GAYBKu 1ij3LuZ9wC3C2C39am0Ri9OJuwKS3JzMsvaRamin/9A62Oat3B0gHH22udCvx7aV5zOk DvJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773875186; x=1774479986; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pka3MFbB++QP8Jn1PcZH7W5IZI1eMirz9wRTwsjleEg=; b=BfiGXkwbJr1IPWNomrqtevlhzjeob/H5Gq4XDCGeAqgkdkdkIlmu/4sNwIvYHSCDK5 4h+Kwiu4VdXQteuh0XbktaDxiWDdqlZ5F43bf0OVPrsyUTZbOK54U9/VAxlPxCiFTSei jWMsIn/kGzHNIcO0Uj/0MXi7or1QRMv2QS9GCt8pPI4L8YV8+tgI7xNhZB4toR4QdMYR 1EQBTL8ES8HtLHKfjbTMT+IZlmv6lv7NoipjBHrlOlPqFk9MYSRApHfnpcmseIzipLJN xLhvfL4+QD+vwYRga3NAvC83Yvq6Jas2R94DgLKGsGrD179RoJITW/CSIW3qyZ/LXFxA Ki1Q== X-Forwarded-Encrypted: i=1; AJvYcCUvfrINk1uEe4h02qFVeur6Eo1/1oY+CwPBScCGC3lUMzQyy7Li5b1bG6/7K+K72/Xd1KncWNhNOSz+yQM=@vger.kernel.org X-Gm-Message-State: AOJu0YxobPRhRVrEMqaMjllUuVXgXaS2A5OCga1Ht3xRsA6sPTpRn/Kj 4jGgbZ6l7ODiIE4GVGx6lxcQ80Q5g7v2+UdkYoN2BnRIApqm8xzZraPj X-Gm-Gg: ATEYQzyP4Y3eh4fddhePZSQfQ0lelke3LJDkxA21YmgwHtquprscasa4eYXuox3HYQn 8MXZP3HE1J4Be1j1NkenoGFpzirqvXQpiVIgSK3RkczKsAotrVz/kcguGRAL9GjxW0LF+r6bzPV RRwikKMhbEpr2Ckjc/atu3wDAUc0D3drn/8fltZJXHWn3fxp+hixsM8HeizvOccrochpMVNYh2f ZwSCFc4RWPIsYrBICWOAjkrTloRWMg2BvlmYCADKM4C+2sxNkjZUJvv5kGEFISHfMMYf84P3vfg PU/ITdRtBPj2q45L+tixlSGorexlX40lAeVeE4lAikJTgt7OBrZ0Y5ycupIKZkYmdDKD/+bWztN KmU0EfIFk9mdYHAQVxre1BUcfY+twr8QpPkKkEgUddAb5GU/kuiL19qIe3itvBn3d8vNT0BHAZx OLFlDdeBhiVhs5Yk3rrOwDXZAO97q/CwhNaW4PuWQnc8OtUDCehFe1J4pDKAZwgtMXhR0NGryhM hHW4YKKb2wiQmtirr+RoiMc X-Received: by 2002:a53:b74f:0:b0:64c:a0eb:c4b5 with SMTP id 956f58d0204a3-64e9157c04dmr4140506d50.52.1773875185723; Wed, 18 Mar 2026 16:06:25 -0700 (PDT) Received: from tux ([2601:7c0:c37e:2360::f769]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64e91bba0c9sm2481644d50.13.2026.03.18.16.06.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 16:06:25 -0700 (PDT) From: Ethan Tidmore To: Binbin Zhou , Vinod Koul Cc: Frank Li , Huacai Chen , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH] dmaengine: loongson: Fix signedness bug Date: Wed, 18 Mar 2026 18:06:23 -0500 Message-ID: <20260318230623.1084926-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function platform_get_irq() returns negative error codes and lchan->irq is an unsigned integer, so the check (lchan->irq < 0) is always impossible. Make the return value of platform_get_irq() be assigned to ret, check for error, and then assign lchan->irq to ret. Detected by Smatch: drivers/dma/loongson/loongson2-apb-cmc-dma.c:677 loongson2_cmc_dma_probe() = warn: unsigned 'lchan->irq' is never less than zero. Fixes: 1c0028e725f15 ("dmaengine: loongson: New driver for the Loongson Mul= ti-Channel DMA controller") Signed-off-by: Ethan Tidmore --- drivers/dma/loongson/loongson2-apb-cmc-dma.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/dma/loongson/loongson2-apb-cmc-dma.c b/drivers/dma/loo= ngson/loongson2-apb-cmc-dma.c index 1c9a542edc85..2a702de8063c 100644 --- a/drivers/dma/loongson/loongson2-apb-cmc-dma.c +++ b/drivers/dma/loongson/loongson2-apb-cmc-dma.c @@ -673,9 +673,11 @@ static int loongson2_cmc_dma_probe(struct platform_dev= ice *pdev) for (i =3D 0; i < nr_chans; i++) { lchan =3D &lddev->chan[i]; =20 - lchan->irq =3D platform_get_irq(pdev, i); - if (lchan->irq < 0) - return lchan->irq; + ret =3D platform_get_irq(pdev, i); + if (ret < 0) + return ret; + + lchan->irq =3D ret; =20 ret =3D devm_request_irq(dev, lchan->irq, loongson2_cmc_dma_chan_irq, IR= QF_SHARED, dev_name(chan2dev(lchan)), lchan); --=20 2.53.0