From nobody Mon Apr 6 17:25:09 2026 Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACF3B37F018 for ; Wed, 18 Mar 2026 22:30:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773873003; cv=none; b=OjGyv5v7GgU+czwZzTeiF3mA7/huqkA0pv7LjwkGxfGxXXNRF+XCdlx/nKLEhW3rf62J5Weeop8S4Ypj+g5Y29NVGWBbyCr23icEB2TTcGCd+HFniwhOHpbxx7XiuQOqdJ7aPhGQfPyO3SVItocvW6bY7LmoVs+H4tZZcxlMVQ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773873003; c=relaxed/simple; bh=LlHIWMKorAg3gifPtuIPuc9aL19mRqXLOyrlrlnvDI0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZURBXUMjZDoYR8yzACFeIk5u1jsqD1k98KtCP1t5lB2Cvq9B2NKfC17zOK5VtkwAOGJtA1aqH3cGrJySr+Ytr20hiP5fozd49YucvR+zdPndUVPkDbF34ZgxVp3M84XAcA15Y+Ez5XlbZXs0oaSj5P7KlhuVmGZvwKleBR9I8zQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XhHbO/f3; arc=none smtp.client-ip=209.85.167.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XhHbO/f3" Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-4670676ba03so37425b6e.1 for ; Wed, 18 Mar 2026 15:30:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773873000; x=1774477800; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZHzOeFlaQp2gdFIuNzaMDht2eyy5SJ0a+c6tcwRztv0=; b=XhHbO/f3jo8AB5TXOeFs00pPzbD51V0Wbh3wEN3A0p+0k+Twh1Osqem/ySLd43vuXn GfvmEnjg30QwivcaBnAqboPBBQYjjgA7ppw6ZWhXg2uEgvvkAiwQaDKWlVca87y7dUkV E3l/p3L3xvbMbPS8BVyNrbpvA/0BtpzIBEeS/hf1QCNKltstgnScbpyQy6E9a/rqyD98 bkCUN9cwLJxwNQ+sPelVyrNH/wmYmoq9G9QwKy9zGXpkmFbZMciRIfwVWJV/4iWdvdb/ nep+XQtb6CB/uByiMd1ouuppUV3XXU5EiJUpSu0JM7MvbbaDDfhz7ACGiB7JZ+UU+td2 EZQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773873000; x=1774477800; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZHzOeFlaQp2gdFIuNzaMDht2eyy5SJ0a+c6tcwRztv0=; b=Lw5k1lHtteygSjOMVWmmx7a6q4Tu30qrUOzYxnizOyPv5mPNs37kBfNIxFLpOL/Yls oCL92NzJT7GtlNfkJ4isKOqnAJpWRhBu/uhWtwXEMrrXAEGcyr/LXsRhyG4lShUzhYwu 56x75j5qEGY0UaAdHenaynWbiIaMPS52tBIb7BNu6EzBVRXbVjPjc/jetkLqvoIEkebb +ZgnpYHA8o0ZXp2bgBRdydUB84tOnPiS3c3gm5TZgjIl2jrzuTw4/zPEMudhbsQp1Ixl Av2du5kXmmbGjtBopjSRRiL76s0YV+3ETU89jLQpZVi6zxZKN+FNYqM9dgJbeUV+zW5q 3GGA== X-Forwarded-Encrypted: i=1; AJvYcCVtn0Kj9RaFw37dKpSoPYiYkAQ2GX23RChIrs7dYrwBdUu4gQSSxSCinX4ed67H4DZDCsnMUr334s2TAV0=@vger.kernel.org X-Gm-Message-State: AOJu0YzCUtDUvf6wP2f9MnVNYfR1sry+86pYE7NpBNMXiEKmPn2G3EeS mw4k9cES+ChpScNx5oeYWkec2zmjyJ8SvLfMiEsrNOoNaU9x2IRjTYj9 X-Gm-Gg: ATEYQzzoFPNjCxwVy0l1L6o4RVmV9KV9adnLM0UrmllbFM36o//axQd8gNph63gHQPN 2any96p6dXD8KHTbtC5qPIcGkNWMm6/R3RfKwS/fBCJZ1m6P54ql4iOoYkT/8r0pyRsBHr44POw Y4+KRVumh9yAWL2Lwetl1kAd19PblhkLNWmR9Zz8OlNn1cJolW0SP+zW6KQzK6u3syAW68qJXYI SUh56C5S99mh84kRJ6cl34CNpCENqtTP2287SJ0phUUhzk0rGB1LaK9P6cYOly4QzeFTgbG4JXh /eerhLpmp0smO3B1xHBLCK3Qg3dt7jQNf+B0bRxUp+LtUVNhqNdDjfAq40zWuxX9DM3s/WlTiyF YN+ZL8l58uJBw3jlXUNTo8L+N5mFZ6Q0sjmilb64h2P9stDlqiXJlfNNwagY8oHlzOoEFGSvhBO iPnkrdHFSEUOkulvzNsNbvyns+lnWOQ+Dbp9OE77XTRYRJaw== X-Received: by 2002:a05:6808:4f67:b0:450:5e3a:6f20 with SMTP id 5614622812f47-467ba15fab5mr2899816b6e.10.1773873000519; Wed, 18 Mar 2026 15:30:00 -0700 (PDT) Received: from localhost ([2a03:2880:10ff:50::]) by smtp.gmail.com with ESMTPSA id 5614622812f47-467bab02e3esm2553952b6e.17.2026.03.18.15.29.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 15:30:00 -0700 (PDT) From: Nhat Pham To: kasong@tencent.com Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org, apopple@nvidia.com, axelrasmussen@google.com, baohua@kernel.org, baolin.wang@linux.alibaba.com, bhe@redhat.com, byungchul@sk.com, cgroups@vger.kernel.org, chengming.zhou@linux.dev, chrisl@kernel.org, corbet@lwn.net, david@kernel.org, dev.jain@arm.com, gourry@gourry.net, hannes@cmpxchg.org, hughd@google.com, jannh@google.com, joshua.hahnjy@gmail.com, lance.yang@linux.dev, lenb@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org, lorenzo.stoakes@oracle.com, matthew.brost@intel.com, mhocko@suse.com, muchun.song@linux.dev, npache@redhat.com, nphamcs@gmail.com, pavel@kernel.org, peterx@redhat.com, peterz@infradead.org, pfalcato@suse.de, rafael@kernel.org, rakie.kim@sk.com, roman.gushchin@linux.dev, rppt@kernel.org, ryan.roberts@arm.com, shakeel.butt@linux.dev, shikemeng@huaweicloud.com, surenb@google.com, tglx@kernel.org, vbabka@suse.cz, weixugc@google.com, ying.huang@linux.alibaba.com, yosry.ahmed@linux.dev, yuanchu@google.com, zhengqi.arch@bytedance.com, ziy@nvidia.com, kernel-team@meta.com, riel@surriel.com Subject: [PATCH v4 04/21] zswap: add new helpers for zswap entry operations Date: Wed, 18 Mar 2026 15:29:35 -0700 Message-ID: <20260318222953.441758-5-nphamcs@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260318222953.441758-1-nphamcs@gmail.com> References: <20260318222953.441758-1-nphamcs@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add new helper functions to abstract away zswap entry operations, in order to facilitate re-implementing these functions when swap is virtualized. Signed-off-by: Nhat Pham --- mm/zswap.c | 59 ++++++++++++++++++++++++++++++++++++------------------ 1 file changed, 40 insertions(+), 19 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index 315e4d0d08311..a5a3f068bd1a6 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -234,6 +234,38 @@ static inline struct xarray *swap_zswap_tree(swp_entry= _t swp) >> ZSWAP_ADDRESS_SPACE_SHIFT]; } =20 +static inline void *zswap_entry_store(swp_entry_t swpentry, + struct zswap_entry *entry) +{ + struct xarray *tree =3D swap_zswap_tree(swpentry); + pgoff_t offset =3D swp_offset(swpentry); + + return xa_store(tree, offset, entry, GFP_KERNEL); +} + +static inline void *zswap_entry_load(swp_entry_t swpentry) +{ + struct xarray *tree =3D swap_zswap_tree(swpentry); + pgoff_t offset =3D swp_offset(swpentry); + + return xa_load(tree, offset); +} + +static inline void *zswap_entry_erase(swp_entry_t swpentry) +{ + struct xarray *tree =3D swap_zswap_tree(swpentry); + pgoff_t offset =3D swp_offset(swpentry); + + return xa_erase(tree, offset); +} + +static inline bool zswap_empty(swp_entry_t swpentry) +{ + struct xarray *tree =3D swap_zswap_tree(swpentry); + + return xa_empty(tree); +} + #define zswap_pool_debug(msg, p) \ pr_debug("%s pool %s\n", msg, (p)->tfm_name) =20 @@ -1000,8 +1032,6 @@ static bool zswap_decompress(struct zswap_entry *entr= y, struct folio *folio) static int zswap_writeback_entry(struct zswap_entry *entry, swp_entry_t swpentry) { - struct xarray *tree; - pgoff_t offset =3D swp_offset(swpentry); struct folio *folio; struct mempolicy *mpol; bool folio_was_allocated; @@ -1040,8 +1070,7 @@ static int zswap_writeback_entry(struct zswap_entry *= entry, * old compressed data. Only when this is successful can the entry * be dereferenced. */ - tree =3D swap_zswap_tree(swpentry); - if (entry !=3D xa_load(tree, offset)) { + if (entry !=3D zswap_entry_load(swpentry)) { ret =3D -ENOMEM; goto out; } @@ -1051,7 +1080,7 @@ static int zswap_writeback_entry(struct zswap_entry *= entry, goto out; } =20 - xa_erase(tree, offset); + zswap_entry_erase(swpentry); =20 count_vm_event(ZSWPWB); if (entry->objcg) @@ -1427,9 +1456,7 @@ static bool zswap_store_page(struct page *page, if (!zswap_compress(page, entry, pool)) goto compress_failed; =20 - old =3D xa_store(swap_zswap_tree(page_swpentry), - swp_offset(page_swpentry), - entry, GFP_KERNEL); + old =3D zswap_entry_store(page_swpentry, entry); if (xa_is_err(old)) { int err =3D xa_err(old); =20 @@ -1563,11 +1590,9 @@ bool zswap_store(struct folio *folio) unsigned type =3D swp_type(swp); pgoff_t offset =3D swp_offset(swp); struct zswap_entry *entry; - struct xarray *tree; =20 for (index =3D 0; index < nr_pages; ++index) { - tree =3D swap_zswap_tree(swp_entry(type, offset + index)); - entry =3D xa_erase(tree, offset + index); + entry =3D zswap_entry_erase(swp_entry(type, offset + index)); if (entry) zswap_entry_free(entry); } @@ -1599,9 +1624,7 @@ bool zswap_store(struct folio *folio) int zswap_load(struct folio *folio) { swp_entry_t swp =3D folio->swap; - pgoff_t offset =3D swp_offset(swp); bool swapcache =3D folio_test_swapcache(folio); - struct xarray *tree =3D swap_zswap_tree(swp); struct zswap_entry *entry; =20 VM_WARN_ON_ONCE(!folio_test_locked(folio)); @@ -1619,7 +1642,7 @@ int zswap_load(struct folio *folio) return -EINVAL; } =20 - entry =3D xa_load(tree, offset); + entry =3D zswap_entry_load(swp); if (!entry) return -ENOENT; =20 @@ -1648,7 +1671,7 @@ int zswap_load(struct folio *folio) */ if (swapcache) { folio_mark_dirty(folio); - xa_erase(tree, offset); + zswap_entry_erase(swp); zswap_entry_free(entry); } =20 @@ -1658,14 +1681,12 @@ int zswap_load(struct folio *folio) =20 void zswap_invalidate(swp_entry_t swp) { - pgoff_t offset =3D swp_offset(swp); - struct xarray *tree =3D swap_zswap_tree(swp); struct zswap_entry *entry; =20 - if (xa_empty(tree)) + if (zswap_empty(swp)) return; =20 - entry =3D xa_erase(tree, offset); + entry =3D zswap_entry_erase(swp); if (entry) zswap_entry_free(entry); } --=20 2.52.0