From nobody Mon Apr 6 17:26:12 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DD3036CE14 for ; Wed, 18 Mar 2026 21:55:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773870912; cv=none; b=koPIMo+hrQ+EZKy/0D3pnJbU1qvEWdPpgxNPgdq2kRUXH7b6ZHlOiqtnVNt1HPUu1vhi/5AB/UntmT5J9TNWEwIe1QFMq9/mLNmNac6AGPuH1DDGtqQyFPJ6HDZWxU2J2epv5Ig5GP7br4IO2IPM10oFpO2ZlcnkCAC6adEQpa4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773870912; c=relaxed/simple; bh=2/LV7x1w5ZpN78khNcFfHL9/K9EjNlAJ+nQoAYrNtBY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NstAlY3BpVBDw5UojiX8NiiivMVTOLKKkfk1PbMrEpFXLp/1qlFmNnTb7XLHa3PiBIROqaatDjj7vY5JabVrp3bN0j1f30/g1AZoJmKAqjvAxryM2iv/MBtSHr4BDm2vcXpAwsC+yVkrRRLgXvHeJ8B4a0WNGXlBKHV9MRM/kVs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M3pOFD8Z; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M3pOFD8Z" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4852e9ca034so2371025e9.2 for ; Wed, 18 Mar 2026 14:55:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773870909; x=1774475709; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VWDjinezebp/AuPLcd5BKlN7px/L4sHMddcyTp7RIds=; b=M3pOFD8ZDY1KvrcAm94860DvZ6TEh9S4rIYfpSaG6K7BwV1HiHzB6B8IZU5OKWRFi6 VS9Vqe3ufFRD8zhptyKaYVNIU0kpa97MI+2oUFNKLe0G8GcAlpwOD2vE2d2+kLCiLhdM 3ePvD0dwVyB0pZceTOjMUQsANhWsLv75vxOinrZC3LSlwKPV3ZMTb/BwNAvIdvKx2wQR KfbwNJXHV2igY/vcWsFLp9GCAIrdS/H8daJbiMLuLmQLP/6RUZCpgBwCa3M6fl773Tzd ZPCB5A0CPiEjCmiuZKqCOvfFL46vzGESG8ZIfOtbPGR5EUwxXKLVNSaOu/QPy1Krmo3F lK+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773870909; x=1774475709; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VWDjinezebp/AuPLcd5BKlN7px/L4sHMddcyTp7RIds=; b=nZZnc87oUoYpPW6UWUp4MOXL3tD9+7Z36yNgL0KadpcwBwHs/j7OIgb/jC5PjbKBCz FHsqU7naMoSvcGFcO8lP/mfX9aSM905bvpuLSLt2lgCAmKdpwmvjREsHrs/u2+U5EDuP KZy5QGSoRKzKl+EmN/hGikxqPJcGVK9FhWdaBv0bH6hcgp8SJJfe+VSiM9V56iQM+O+k ERNClipLy8CgfuDnVO4jWqPSPDb9TkqFpy99qJKy7Yfz0p4vxzpDDnYJip+x076YBpeb 5ZCvWgx/4cJbC9VMXmn/Ae8ywpg/Fu8OKpBRrpi2dhSQBgDh4VoLU67InpfP9CKIC9LJ hkUQ== X-Forwarded-Encrypted: i=1; AJvYcCX2uIKIYcSFvhTekGhXZ3DfLnl+Hp6RArpsJQsSfMc71GZ84bNn3AlNHfbEuWI5WbV1YxZvSYOiLaxig0w=@vger.kernel.org X-Gm-Message-State: AOJu0YzQ9YzBa56DHOVU05Fye3catdhF05ndTP6VYwOlZyC+UhJ92jwq mk/+JwAOjpS4q4ZvqbnfDpagUA5LwyLLA9wgOpEjA82z+PLj6LmvKxeF X-Gm-Gg: ATEYQzz5rE6RosuH9K6I4fh7d7G24p6DM8rOBWKLrzQiik9WXkPZJuZAvnZndSE1Afs 7wDM4iG3yfSfQn08IbPU1ahRuGY5CsZBhMz41jIYKXLxJeDK1kMwkKeN294+GyA6nhc3e+g4PqC dJkt5Pe3b4sdg9LI/WFvXEcGBy8gBaE6QNh05ykkSLVvRUQyvTPUMFb47EAN9PYsO5Q3D47X45u XeDYlPT+JVmbPXKttTi1DUeRulKCO8tgnYJGrLk6G8t09gP2vh4vjLZtJd9iqJd3HvLRFM7Ft8Q Enr/6VzfS2qoM6d6NjvGLqHQ+tFwc65/jvYX9hFK3odLXiP/WoVGfED+4eI69BLLAXfMeV6BsAW /Uk+GS/2Bc/06R+yRsOWCtu220eI0PHcRLwGIPcaayxgRVMkI029y9WN4Bg2dMiTax1arc6+96r EpB5aPrjJnZs6jS51eoimSWi0= X-Received: by 2002:a05:600c:4e56:b0:485:3dfc:569 with SMTP id 5b1f17b1804b1-486f4441067mr75301165e9.16.1773870909451; Wed, 18 Mar 2026 14:55:09 -0700 (PDT) Received: from nas.local ([2001:912:1ac0:1e10:c662:37ff:fe09:94df]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f8c292e2sm19373735e9.2.2026.03.18.14.55.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 14:55:09 -0700 (PDT) From: Damien Dejean To: andrew@lunn.ch, krzk+dt@kernel.org, robh@kernel.org, kuba@kernel.org, maxime.chevallier@bootlin.com, pabeni@redhat.com Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, edumazet@google.com, davem@davemloft.net, hkallweit1@gmail.com, Damien Dejean Subject: [PATCH net-next v9 4/4] net: phy: realtek: add RTL8224 polarity support Date: Wed, 18 Mar 2026 22:55:01 +0100 Message-ID: <20260318215502.106528-5-dam.dejean@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260318215502.106528-1-dam.dejean@gmail.com> References: <20260318215502.106528-1-dam.dejean@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The RTL8224 has a register to configure the polarity of every pair of each port. It provides device designers more flexbility when wiring the chip. Unfortunately, the register is left in an unknown state after a reset. Thus on devices where the bootloader don't initialize it, the driver has to do it to detect and use a link. The MDI polarity swap can be set in the device tree using the property enet-phy-pair-polarity. The u32 value is a bitfield where bit[0..3] control the polarity of pairs A..D. Signed-off-by: Damien Dejean --- drivers/net/phy/realtek/realtek_main.c | 34 +++++++++++++++++++++++++- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/realtek/realtek_main.c b/drivers/net/phy/realt= ek/realtek_main.c index 63134e300c33..023e47ad605b 100644 --- a/drivers/net/phy/realtek/realtek_main.c +++ b/drivers/net/phy/realtek/realtek_main.c @@ -172,6 +172,7 @@ #define RTL8224_SRAM_RTCT_LEN(pair) (0x8028 + (pair) * 4) =20 #define RTL8224_VND1_MDI_PAIR_SWAP 0xa90 +#define RTL8224_VND1_MDI_POLARITY_SWAP 0xa94 =20 #define RTL8366RB_POWER_SAVE 0x15 #define RTL8366RB_POWER_SAVE_ON BIT(12) @@ -1870,9 +1871,40 @@ static int rtl8224_mdi_config_order(struct phy_devic= e *phydev) order ? BIT(port_offset) : 0); } =20 +static int rtl8224_mdi_config_polarity(struct phy_device *phydev) +{ + struct device_node *np =3D phydev->mdio.dev.of_node; + u8 offset =3D (phydev->mdio.addr & 3) * 4; + u32 polarity =3D 0; + int ret; + + ret =3D of_property_read_u32(np, "enet-phy-pair-polarity", &polarity); + + /* Do nothing if the property is not present */ + if (ret =3D=3D -EINVAL || ret =3D=3D -ENOSYS) + return 0; + + if (ret) + return ret; + + if (polarity & ~0xf) + return -EINVAL; + + return rtl8224_package_modify_mmd(phydev, MDIO_MMD_VEND1, + RTL8224_VND1_MDI_POLARITY_SWAP, + 0xf << offset, + polarity << offset); +} + static int rtl8224_config_init(struct phy_device *phydev) { - return rtl8224_mdi_config_order(phydev); + int ret; + + ret =3D rtl8224_mdi_config_order(phydev); + if (ret) + return ret; + + return rtl8224_mdi_config_polarity(phydev); } =20 static int rtl8224_probe(struct phy_device *phydev) --=20 2.47.3