From nobody Mon Apr 6 15:50:53 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D7D838944D for ; Wed, 18 Mar 2026 21:41:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773870092; cv=none; b=YVeDhWm7qbyi6mK0/geDE2tAT6SG9ffzB8uwuED8dMIbxw1CXoVgJGNvH4yrfUnmhzp2qIfdkP//ZExT/FNzQShxtUkSrJSpbP7iKhwX05imF51cecOe0AABXYxunJ9wAE7J7+VYEX6qK3rx/nmGPjMorbSt+7phR3cHeGuL4vk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773870092; c=relaxed/simple; bh=CCLfGPmo3oEX7y+08RUpRymT5dj7PG7uc1SEeuV84mQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CfWjem33pVvpcer683uPc4tr8bC/5juqFCfyOqQwWg/kFv9HijiomIarReguScTB41rhs9cDB9auQErNCBDsNUFbW1hPz049XJeph2u6JMB8BezK9k17hEZAmOZa4NDgaVZ/9dxuu09kSIjgB/WsyVhe1RsmptNc0sUWYsgvYP4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fbTmJ0bB; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fbTmJ0bB" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-48628ce9ab5so3791975e9.2 for ; Wed, 18 Mar 2026 14:41:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773870090; x=1774474890; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1az6/7PZmrBFavANPUIaTOGaFYDI7vbi47TrxB/EPko=; b=fbTmJ0bBCDCw9lHlih9Bb9rlYPHDojz2/gh4OySBIqBiSpyV7tWRJcj6BXuTvSNEX/ sqIRzWd3OplVsOzlIUHd+j0jEB4dNHZN2t+DTfIJYKX1GgIsGTRmiLSeLgyaXDVlkBIQ f6DolfXdxIfrO/jbcClgy11jiZJf+/j10qrgSqEEctcAMK6Y0lrLJjNSkt1Pw6Q9tbcf 3U3Gy2koHG+vt3VTxaoeFnZUH/93HVHyrZYhavjxRsrLOMaH5T347XigEQER6XFpMx4w KyWmyDyzuUjahds4AHRSuz4pqODw1axOz4/XiPxr4nEcZ575UH0vzlVJjJ2sKvX4yqqQ RvaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773870090; x=1774474890; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1az6/7PZmrBFavANPUIaTOGaFYDI7vbi47TrxB/EPko=; b=HnKECzozvmb3CYiH3UpeBM4PUg0cNSi08lzmoxh6K5zHtGje333CT725qkjpotszN6 BpGUMLT9fDL8pCw5KH6u7ukFVObFtu7TWkYxMq2phk1PBNimXDTv/FiuBO1H86dPDfRP IvRzL/jtFC0wA3MM4L7zrsHkt680TBOaw1zPkvHG/eXXnIeFKY+/0C6YXjz5DJ6V/HAi Tu8y8R15aSmP6qh21aUL43q8+Gw1mw8b4ZLKYtsBLR3dH5x9KRkETFrkhyvPSwddpN/E tvpWW2BvFPbRTY6LtHey+DzyOqlwYLMUlbdI84FSWYwSacENtVpogUgUjNndLjv9+b6l Q49Q== X-Forwarded-Encrypted: i=1; AJvYcCU7WxaIAy86kojlB3nrMOsQirli1kyqX6Cx8eP9X1JhczMiaZIlvwtX7W5VS3S/wJs/iYf5U6PRmbc9xAg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8CdvMcSz+Yt5HR79VvkbM1cJvd44ShfNyTwDBjnrNGiH/ez5+ fiTnDteg0qWv0p2ul9WKneamS1UyvgpWb48gfFD/oxria1lCt8ieo4Yy X-Gm-Gg: ATEYQzx152FggPDx71Jfq7BeNn4Mcm9Zfq1g2Qj9gAHB9guix1OJ8LQjmj08voavepd 0TS9hrPsvwEBfgF3LEK6vm8N9ihpgdMekTJWCBNvDxIz+ASyDdAB0TWqGy5RZCIsP4hnDXo3LhH lBujd9fQra8LN4zLPLzGvLiahbESLABrdA/r0ULx53k1wQ5xzkQA/kt0vM8U+XH/qhtCGt9DyVS 2sYpxw2OLqXDQIuuQ3XZPcLaYmDjdGMSFLov5tf+s2lnQqRDMPyw8xUwlQIViNE5q5jvk+qhl0i W/C5aUuduDNf6t3L0ELmAaxc1Kct/F63L87gmJ/FZhHtI1JldE/eyIPZ6RgCrVLsEx6cyy5XWUE E5oAUVw9Pd+629wlUvR8t2gkiBnoPSLvTEvDaU/jbh1WiZp0LgELIP60jnb/85uSrlIDFjmItPc xI2kCXfu19QAua70R6AQdLL2g= X-Received: by 2002:a05:600c:4f0c:b0:485:358b:e80c with SMTP id 5b1f17b1804b1-486f4208becmr91624835e9.0.1773870089547; Wed, 18 Mar 2026 14:41:29 -0700 (PDT) Received: from potato ([31.176.171.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f8c5318dsm17698845e9.14.2026.03.18.14.41.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 14:41:28 -0700 (PDT) From: Omer El Idrissi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi Subject: [PATCH] rtl8723bs: replace _SUCCESS/_FAIL with standard errno Date: Wed, 18 Mar 2026 22:41:03 +0100 Message-ID: <20260318214104.16971-1-omer.e.idrissi@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace non-standard return values with descriptive linux kernel error codes in probe path. Also replace the variable name 'status' with 'ret' to be more consistent with other kernel code Signed-off-by: Omer El Idrissi diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index d664e254912c..ff0ebcb59c68 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -345,38 +345,46 @@ static int rtw_drv_init( struct sdio_func *func, const struct sdio_device_id *id) { - int status =3D _FAIL; + int ret; struct adapter *if1 =3D NULL; struct dvobj_priv *dvobj; dvobj =3D sdio_dvobj_init(func); - if (!dvobj) + if (!dvobj) { + ret =3D -ENOMEM; goto exit; + } if1 =3D rtw_sdio_if1_init(dvobj, id); - if (!if1) + if (!if1) { + ret =3D -ENOMEM; goto free_dvobj; + } /* dev_alloc_name && register_netdev */ - status =3D rtw_drv_register_netdev(if1); - if (status !=3D _SUCCESS) + ret =3D rtw_drv_register_netdev(if1); + if (ret) { + ret =3D -EIO; goto free_if1; + } - status =3D sdio_alloc_irq(dvobj); - if (status !=3D _SUCCESS) + ret =3D sdio_alloc_irq(dvobj); + if (ret) { + ret =3D -EIO; goto free_if1; + } - status =3D _SUCCESS; + ret =3D _SUCCESS; free_if1: - if (status !=3D _SUCCESS && if1) + if (ret !=3D _SUCCESS && if1) rtw_sdio_if1_deinit(if1); free_dvobj: - if (status !=3D _SUCCESS) + if (ret !=3D _SUCCESS) sdio_dvobj_deinit(func); exit: - return status =3D=3D _SUCCESS ? 0 : -ENODEV; + return ret; } static void rtw_dev_remove(struct sdio_func *func) --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 30 +++++++++++++------- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index d664e254912c..ff0ebcb59c68 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -345,38 +345,46 @@ static int rtw_drv_init( struct sdio_func *func, const struct sdio_device_id *id) { - int status =3D _FAIL; + int ret; struct adapter *if1 =3D NULL; struct dvobj_priv *dvobj; =20 dvobj =3D sdio_dvobj_init(func); - if (!dvobj) + if (!dvobj) { + ret =3D -ENOMEM; goto exit; + } =20 if1 =3D rtw_sdio_if1_init(dvobj, id); - if (!if1) + if (!if1) { + ret =3D -ENOMEM; goto free_dvobj; + } =20 /* dev_alloc_name && register_netdev */ - status =3D rtw_drv_register_netdev(if1); - if (status !=3D _SUCCESS) + ret =3D rtw_drv_register_netdev(if1); + if (ret) { + ret =3D -EIO; goto free_if1; + } =20 - status =3D sdio_alloc_irq(dvobj); - if (status !=3D _SUCCESS) + ret =3D sdio_alloc_irq(dvobj); + if (ret) { + ret =3D -EIO; goto free_if1; + } =20 - status =3D _SUCCESS; + ret =3D _SUCCESS; =20 free_if1: - if (status !=3D _SUCCESS && if1) + if (ret !=3D _SUCCESS && if1) rtw_sdio_if1_deinit(if1); =20 free_dvobj: - if (status !=3D _SUCCESS) + if (ret !=3D _SUCCESS) sdio_dvobj_deinit(func); exit: - return status =3D=3D _SUCCESS ? 0 : -ENODEV; + return ret; } =20 static void rtw_dev_remove(struct sdio_func *func) --=20 2.51.0