From nobody Mon Apr 6 18:38:42 2026 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C7093EAC6B for ; Wed, 18 Mar 2026 20:04:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773864249; cv=none; b=VFo3P8dWUrbQI5jEKZdMJasvrEHrpfBmxkjIM140wN9tQMqfPCCaRBe8774HXgyU2opQ9WqYvc5TblMdMNmA0KyK/CT2yM3H5Oaz5aj764SglPstN/BZAdSuLNNjZr5BFgV/I0EiU1Sdcdbj/l2ka1CGpSgzCvbNeaqhsc/wFeU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773864249; c=relaxed/simple; bh=pydjHkIk5OAceZVxZINaGtjRgV2uvpT21+5I4TpV328=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KCq+b8xXfC9WdXmVCik7q6QDyh9BpdzVEIViNHhiZM9FwK0/IaUmUW1Y0lOtBcEoDOtNJ3VS0saJ2cW00hi0PtOQKw0zoETxLBF65tUbMCgRQBfzbfH9lqJT1nrwYgO46qlRzS4k5EX5iui6JEQC+M+nHroWwtqLEt4Vg6TfDU0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=dr9sTxdR; arc=none smtp.client-ip=209.85.222.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="dr9sTxdR" Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-8cfbbf35354so8212185a.0 for ; Wed, 18 Mar 2026 13:04:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1773864247; x=1774469047; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+lIBKuihBwhIz7SacTrjJRS4SfXMfl3HnekVF8WIFpY=; b=dr9sTxdRKM10SWlIZiAcVnUl/udNJJpX+SGMMS0Azx+l7Ng9RQ76wMwlva4yhTtqdR UEz8fsQnrQS9Mx/Jflg7DsU1xzCaMuCoMsLxW0Fz0hCVrzOjbtFix1K79trtwuMcefb4 KiaApucKIU2mTpqX1KMz84P36pimKcFC8WddxPVXHXCpv3twmuXvfqha7vCjYHbjf5sl hj1CFd//pRsGw7nse8ALEbLlTwl8P3PhZPWx+rPlrxiv7QeYt9ujsUDUt2eCLEZRU8l/ PrxgU8cgXzg8aVqBvXxtijCROymDp0rKyo/4SqkJEz1Nc4pUZTv6chgDMcW7rG8Uz1Ch RxNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773864247; x=1774469047; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+lIBKuihBwhIz7SacTrjJRS4SfXMfl3HnekVF8WIFpY=; b=lPD4xVmMQIuBiO/4H3R9BQTAJnKt3hkwOkLo3cLioKrPZxx+OXND3QhDiPgbCGJ7gI M7cBd21a1lx1noewCLI409c1fy5Qbei9SuqK0V7iVEbYhnP51VvwvZ+EdqQuYQZzLVKv FLacnGRN8VgAUn2WrfRxfmXb1vqrlQiVjIyCrtmkEFnkJ99fXVWbermNTQjntrtiRSIC S2yGoh5nKLbBhVpjirgBdhP3WV9PZrY6CKaDNAcNS0WwzpMx30LwxfN6VMlRS1EMrnlL GeHtL1jKb/dX5ZStlllZngRGnSl3uA0rdliN9QE32Z0JPIfBOg4CVg054rhVWWKck60G l5ew== X-Forwarded-Encrypted: i=1; AJvYcCWnW7+/JasikC7+pMyjfSCY0+iKlVyXnZ9PlqLbyaSMf79bFRwypoVEb72wHpsJcwWBDWYnBIw7RAE8l4M=@vger.kernel.org X-Gm-Message-State: AOJu0YxB86XThBvTR+4WmZJl6LPJLgZYi4pmYbjWFtZdr5DWp90xGJaJ JSm/YDYwrfjXJB8693n9yxJPGC10+W+pUBs1dY5iDpqgOP2qxGK4aKrbEs1Qpm89wqE= X-Gm-Gg: ATEYQzwmxbknfpf6mPzLKIGBhWsWDVMs5uYDv1BdoLJD2kwPywifSb/QSJkX04ENap5 SudPixeLuRPGBPC2ltgSzQrqvfvlyq1CyFhUWLKl2yghqNDrpMTOpUKVzrd9t+dP3PTYo6pzVWO zujvd7sC6NF0Q/IAKxvAF4JCupVybPuqSr78U63+n14IFRyDraRF8rvFdO7a2rj71p8fXKvXWkk AVt9VWH30WwO71wFxRDzrEQZGRSCQBV7f7P0jR2+FVxeWNdzIRFBvZgXMf0zaCVL2ngjFK2NP1N 7hb+rvPC1iYgRY/xAQnHnAfcYHGNWbfQF/IQlEQALWcLyTW9vfxTzqvTcqEvTeR9V8NAKlwg8XO BZIMVwLU2MqCp73l93OsFGCeIjxftM7q4vs1Evj4ZHnZAI/60KZ+qR+g/zG9QNqn6luMEGDfxkj sB8hjABc9jZaOEBEJu1oieaKpqPhbnj7+1 X-Received: by 2002:a05:620a:171e:b0:8cd:b641:b730 with SMTP id af79cd13be357-8cfad3a0f32mr663539485a.66.1773864247421; Wed, 18 Mar 2026 13:04:07 -0700 (PDT) Received: from localhost ([2603:7000:c00:3a00:365a:60ff:fe62:ff29]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89c6b9ec0fdsm27008986d6.40.2026.03.18.13.04.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 13:04:06 -0700 (PDT) From: Johannes Weiner To: Andrew Morton Cc: David Hildenbrand , Shakeel Butt , Yosry Ahmed , Zi Yan , "Liam R. Howlett" , Usama Arif , Kiryl Shutsemau , Dave Chinner , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 4/7] mm: list_lru: deduplicate lock_list_lru() Date: Wed, 18 Mar 2026 15:53:22 -0400 Message-ID: <20260318200352.1039011-5-hannes@cmpxchg.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260318200352.1039011-1-hannes@cmpxchg.org> References: <20260318200352.1039011-1-hannes@cmpxchg.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The MEMCG and !MEMCG paths have the same pattern. Share the code. Reviewed-by: David Hildenbrand (Arm) Signed-off-by: Johannes Weiner Acked-by: Shakeel Butt Reviewed-by: Lorenzo Stoakes (Oracle) --- mm/list_lru.c | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/mm/list_lru.c b/mm/list_lru.c index 1a39ff490643..4d74c2e9c2a5 100644 --- a/mm/list_lru.c +++ b/mm/list_lru.c @@ -15,6 +15,14 @@ #include "slab.h" #include "internal.h" =20 +static inline void lock_list_lru(struct list_lru_one *l, bool irq) +{ + if (irq) + spin_lock_irq(&l->lock); + else + spin_lock(&l->lock); +} + static inline void unlock_list_lru(struct list_lru_one *l, bool irq_off) { if (irq_off) @@ -68,14 +76,6 @@ list_lru_from_memcg_idx(struct list_lru *lru, int nid, i= nt idx) return &lru->node[nid].lru; } =20 -static inline void lock_list_lru(struct list_lru_one *l, bool irq) -{ - if (irq) - spin_lock_irq(&l->lock); - else - spin_lock(&l->lock); -} - static inline struct list_lru_one * lock_list_lru_of_memcg(struct list_lru *lru, int nid, struct mem_cgroup *m= emcg, bool irq, bool skip_empty) @@ -136,10 +136,7 @@ lock_list_lru_of_memcg(struct list_lru *lru, int nid, = struct mem_cgroup *memcg, { struct list_lru_one *l =3D &lru->node[nid].lru; =20 - if (irq) - spin_lock_irq(&l->lock); - else - spin_lock(&l->lock); + lock_list_lru(l, irq); =20 return l; } --=20 2.53.0