From nobody Mon Apr 6 18:37:42 2026 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1B953DDDB9 for ; Wed, 18 Mar 2026 20:04:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773864249; cv=none; b=mO8eMm4CCKjNIk9n6Hdq+g0ymNiGyVYuQUh6xIIJSDbZ2VTEKY/TgNLpWPCbfVhn3WJkSLeANgi1ULkTozkyg3JUt6bF0cxeZpwK+YF0CyUYXut8QE2fT3ADPEjngHqCA8NMteqAOw2lM5OPuCjqjUeBfjcuebiFlXL9F5XppgQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773864249; c=relaxed/simple; bh=AVFEPAIHQhNPTOlvWkbZ41tpiX3+mM/5HCnOo7aJOxU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=J2Cel1E0xMX/lHlRkzM9KFMsPmZo1L6noo4cFUynRNm2L3SbmMGWq2CQGlNikXf5nPnvvQld/9dBhg46WzamAKb8JQNBtXwN/bhZPzhXKnc0sKty8md69F59uR+gwBLdNqg6vxjsXKY4tRtbNGrmPxcHOqb7NaBre6o1PYD9n/Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=XLKPMFpy; arc=none smtp.client-ip=209.85.160.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="XLKPMFpy" Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-50905b779dfso2394361cf.3 for ; Wed, 18 Mar 2026 13:04:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1773864247; x=1774469047; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2wkyoaYJiF0XNGZN3CfUoqSmkjjAgGEnloqZ+FNXRgI=; b=XLKPMFpycqWD2Ok2BmmwwHU9SBuf5hfyTwT/KZE3LUmacVnZKIqrq3Sbb1TKx6SVW7 AifHfbS9+PEemkvWmaB+fah3sbhG2JSMjuH2GSXV5AJbmfqQDf22iPRerA8MBICOnKoj 93KRXu/65MLUgY3pKfnpHXneDER9TH5a9CA16scxSA05we4B5kQEGPjAQdPFRca/e6MM CIcKgdNOJxvoMndScgSmg44vfMTS07oK9Xco1s6xhcnnE3+4Lyr5xa+RXTk4lQ/Y8Ziv vRjt5U/+CRwzihorRdmF1ucbzgZS/R9N/2JTnjsyCM0aUgLLqaVN91rLvrOXCEMvHLqX xP1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773864247; x=1774469047; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2wkyoaYJiF0XNGZN3CfUoqSmkjjAgGEnloqZ+FNXRgI=; b=gf7xSGPt2oGkO10nNR5UOT9/p/BFtRCF4MsXiggeUdJnSda1sCYbP0IlIAmQab0VM0 9WDPlxDMa42+SpxDPiIk5wqvQvwH2POVBN9RIvagotpzkjd15U3CoDPXr02fQveKTScP gIdu4qnQwq4CraW3to/FGvP2jPH8iEKXIJ8gVaHibNptKua8W6M2dlyDLow6VlZ7m7F+ u59po0tdP0NibktESZOfJPhKvFErPnDNqpvRSRKMAKtQrGePtnpzVJGXk5QkR3vIzunB TnNUcCpRpxu6gTzrddG3Y4v9YOk3SBtfSaJJ6PTTkMMhpGRKk8mspC/eAl/H8ML+ib5o Yi2g== X-Forwarded-Encrypted: i=1; AJvYcCXWUPht43afG1Sudw1SvcVK/l/uPr3NER9bHcGAiDcpcBb1OK/ZMOdyKGg4ON2W1lQ6oHDIVcdzVZv4V+s=@vger.kernel.org X-Gm-Message-State: AOJu0YzBsJyNJN3/UusqF7S2znjlIEbgle1TQ2jiK0awiAlnbT1k9BMK igX451zoOcpPbAcKN2uqt/k63gIrvIQm4MPQZGRCUfbZecDPZuPyH0Zwyl5SfZ7ZKT8= X-Gm-Gg: ATEYQzxdMro29R1aeXbKNZMLtfH48fCfPT8N9eokWZ7fYh8xkyNljam01hL4RiJPvnW SPJPupq7IE9LRbbVLqWn48W+AEkXktMK6twvrIr4P+/5xnirYysI8GHgI1zhy+qCcX2vjIty4d3 20QD1ue4K8gieauVqKqdjUrboGgZj+uFL2qgJZ6LtynecXM7rx+m2eWDla+vKGPz3qY1i3lz9F4 SS0zGxPxhGgqDQZVTMlsouLTFD+ueJfyVjOE5Fqk58OMpltpXTsEanRpPGk/ywlWvdCiRQG+KXV 2OcxxYpuJhuBDr/QFSCIuKga8UWxg/VKus8WFek1Snh+DYupRkQwK4lpYGvUrPLv2h3jJltRVoz BxaFvuu7/dMwiQj+FOnVYXXReEFvVA/bAORdNAahqgxHmFVv7l9bpXac10fy+//Yg/7sCutW2zJ 6FoD+B/Ysum3UmG/ils72omQ== X-Received: by 2002:a05:622a:150:b0:509:3098:819a with SMTP id d75a77b69052e-50b1486333dmr64714801cf.44.1773864245907; Wed, 18 Mar 2026 13:04:05 -0700 (PDT) Received: from localhost ([2603:7000:c00:3a00:365a:60ff:fe62:ff29]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50b134ad438sm28515831cf.10.2026.03.18.13.04.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 13:04:04 -0700 (PDT) From: Johannes Weiner To: Andrew Morton Cc: David Hildenbrand , Shakeel Butt , Yosry Ahmed , Zi Yan , "Liam R. Howlett" , Usama Arif , Kiryl Shutsemau , Dave Chinner , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 3/7] mm: list_lru: move list dead check to lock_list_lru_of_memcg() Date: Wed, 18 Mar 2026 15:53:21 -0400 Message-ID: <20260318200352.1039011-4-hannes@cmpxchg.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260318200352.1039011-1-hannes@cmpxchg.org> References: <20260318200352.1039011-1-hannes@cmpxchg.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Only the MEMCG variant of lock_list_lru() needs to check if there is a race with cgroup deletion and list reparenting. Move the check to the caller, so that the next patch can unify the lock_list_lru() variants. Reviewed-by: David Hildenbrand (Arm) Signed-off-by: Johannes Weiner Acked-by: Shakeel Butt Reviewed-by: Lorenzo Stoakes (Oracle) --- mm/list_lru.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/mm/list_lru.c b/mm/list_lru.c index e873bc26a7ef..1a39ff490643 100644 --- a/mm/list_lru.c +++ b/mm/list_lru.c @@ -68,17 +68,12 @@ list_lru_from_memcg_idx(struct list_lru *lru, int nid, = int idx) return &lru->node[nid].lru; } =20 -static inline bool lock_list_lru(struct list_lru_one *l, bool irq) +static inline void lock_list_lru(struct list_lru_one *l, bool irq) { if (irq) spin_lock_irq(&l->lock); else spin_lock(&l->lock); - if (unlikely(READ_ONCE(l->nr_items) =3D=3D LONG_MIN)) { - unlock_list_lru(l, irq); - return false; - } - return true; } =20 static inline struct list_lru_one * @@ -90,9 +85,13 @@ lock_list_lru_of_memcg(struct list_lru *lru, int nid, st= ruct mem_cgroup *memcg, rcu_read_lock(); again: l =3D list_lru_from_memcg_idx(lru, nid, memcg_kmem_id(memcg)); - if (likely(l) && lock_list_lru(l, irq)) { - rcu_read_unlock(); - return l; + if (likely(l)) { + lock_list_lru(l, irq); + if (likely(READ_ONCE(l->nr_items) !=3D LONG_MIN)) { + rcu_read_unlock(); + return l; + } + unlock_list_lru(l, irq); } /* * Caller may simply bail out if raced with reparenting or --=20 2.53.0