From nobody Mon Apr 6 16:45:58 2026 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7D8519C546 for ; Wed, 18 Mar 2026 19:50:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.67 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773863414; cv=none; b=JHQknqv/s2VznCCzriLUDQbfWSaDmKLeyw/Tlai6+MqvlpSG09EkaVOrVKdRkE1W8p72L8x3w6DWTvZ3vG3cjrVBNtObhf7qImbsJsdUiGGkscR0d04UqZd2e1362EDCXehBc6x1gs1VQD3GDwi2aikPe1OxKcvz2urURO7oMIo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773863414; c=relaxed/simple; bh=//bcGiJKOcS3S7fv+h0cbs+hbw1ym/cPTQGJ4TytRy8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=Vp72GK00drq4xTRMZ261a+om8O2n6WAJIdgNEyfyLU6Iu/eRcLvKdk3ucnp/A8QB8DCHQ9BG6PiS09HSTTzAeJhSrNlvqFRfWb58GP9aShDmZJvE68HyriuJhbS7u0Wb7I6T6ylWbTT2HDsURb0LsClzfVxbL92YgYRwf9MJ0AE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iW1LlBjy; arc=none smtp.client-ip=209.85.128.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iW1LlBjy" Received: by mail-wm1-f67.google.com with SMTP id 5b1f17b1804b1-4852a9c6309so2167505e9.0 for ; Wed, 18 Mar 2026 12:50:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773863411; x=1774468211; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5JIR99UNR/WbbAtNAUT8+HmstMyC1vAIxyPdST6wJ1w=; b=iW1LlBjyrLiVPpEB2TA1yqoJQMSHmx8rq7tJpSURc11fRel6AtfUDWKPAIlHEfkYIn krYTtUou0DPGhDWJCaOBs6ZRumSeWrqHltSPNB78A5e1aD4iEzUITN2Av+ZL/gAwQUgR E0ys0Jvl+M5AwoXjPQSwNcOsF6GQtbUnu8nyKUc1mzj6rlA1qshis8lXFews/uplgs1I qWPNC5fKzoDLTZpUnFZH1A16bQujXKjVf9EYxc4+1BEhbVZAZy3wU6D8z/IRPhHYtfKZ cUiX86eFQiT9lhmOxW4ywXa5nJzeodk3AEpK6nNAPzdiMHcFbpsml8HAMoKYKeFQUhF6 upJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773863411; x=1774468211; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5JIR99UNR/WbbAtNAUT8+HmstMyC1vAIxyPdST6wJ1w=; b=JQIjGPMGDUeP2iA4VS9++8YyOaWAmqGyV3KRocCcxzY8nv5HuSqhjPJO4WoIaE9aRO TYneIyKnqZA7zi43yhGkbk9EpjJIb51BlbTN9pk0ednFUwg8hBq0nNn2bRzb9A0U+h3A AuhseNDuoQaBoALZ+Wcjc2nyCz1RTj8j5SEvoIfeEWtF3f8RMzqStTiYJYshGYDMQd77 bCGnFVheBeVScZILkd3GdzN05IoJgsk5tSckluE4pmGtCP6on+byMWmPJR4r5vpAlBlg OAqd/ffQ//MNFfTuSBr4aW6g1LM6IizcGqD0vX5576Lo5YnE3eIUdM6YSrsMJ9SqClKh ACzQ== X-Forwarded-Encrypted: i=1; AJvYcCVZXKJWQuhdH9u9dHBcZK3AxaBR+Mhk+tGVMAkbWIAFIiJODkhZ94ql44VVY5U+H5ekH2qR1yHVvZEQeJE=@vger.kernel.org X-Gm-Message-State: AOJu0YwhZ5Yj3KZWi8oV55VQUCE1LJyxkYui2ccyg016BqEojAc/oAeX 2xhlHl67qBunsCid980q9V9vXqvWtL53iGVM9SSUM82fyr9XXmUtIAYo X-Gm-Gg: ATEYQzzQPyj/tluhna6WLix3v9F4bFlKXf8Xw8kmQEs8mePvPHCWs9KslANyve9Iq9u 0kQJCdmQr+WaTHsI1gFHSpxovp0OSckxV/5ZfK90EEyXpT94C1fWDUDHEgDgG/PUfcP07tzdyJj pTGC1pMJii6wmruvIKciEV3NRfNa6wTrLfQeP7nQVwwcCDXaKLX6KEWncMpkeoCBT44ZD7LABma Pe6r8T5b32zlVsB/bswAk6uGxEW4b01NgWCGA8QW/rbnsFN6J3sV3c+z7r855AYlU1EQELKDMDV FZudfLcTMTVJCnDlvmjC/yoosQWv5LWxVFTtWWV3+8EnzBXB2b5E+FVdyf1L2ujFB/TjJrFzu9p 5FXa/8vaaaSwT9k0Lh5VOjhcXS9fPH4zH6VxhNZuU2bxq8U848wpQPMZcd9QuxOwFM1z+/QdeOt FWnDP9GSZ7FG2oHWokzXihuAM= X-Received: by 2002:a05:600c:c163:b0:485:9a50:338d with SMTP id 5b1f17b1804b1-486f441b7a5mr86684025e9.3.1773863410782; Wed, 18 Mar 2026 12:50:10 -0700 (PDT) Received: from bera-arch ([46.221.93.83]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f45f7e96sm53235095e9.0.2026.03.18.12.50.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 12:50:10 -0700 (PDT) From: =?UTF-8?q?Bera=20Y=C3=BCzl=C3=BC?= To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, =?UTF-8?q?Bera=20Y=C3=BCzl=C3=BC?= , Ethan Tidmore Subject: [PATCH v2] staging: rtl8723bs: Remove dead code Date: Wed, 18 Mar 2026 22:50:05 +0300 Message-ID: <20260318195005.23962-1-b9788213@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Clean up the dm_odm_t structure by removing commented-out members and related legacy comments. Signed-off-by: Bera Y=C3=BCzl=C3=BC Reviewed-by: Ethan Tidmore --- V2: Deleted other remaining comments. V2: Restored /* common */ comment. V1 link: https://lore.kernel.org/linux-staging/2026031851-elephant-unnamed-= 7e95@gregkh/T/#u drivers/staging/rtl8723bs/hal/odm.h | 34 ----------------------------- 1 file changed, 34 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723b= s/hal/odm.h index 38830552d5bc..d186cf2f3add 100644 --- a/drivers/staging/rtl8723bs/hal/odm.h +++ b/drivers/staging/rtl8723bs/hal/odm.h @@ -650,10 +650,6 @@ struct ant_detected_info { /* 2011/09/22 MH Copy from SD4 defined structure. We use to support PHY D= M integration. */ /* */ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */ - /* struct timer_list FastAntTrainingTimer; */ - /* */ - /* Add for different team use temporarily */ - /* */ struct adapter *Adapter; /* For CE/NIC team */ /* WHen you use Adapter or priv pointer, you must make sure the pointer = is ready. */ bool odm_ready; @@ -673,17 +669,6 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_S= tructure */ u8 ControlChannel; /* ODM HANDLE, DRIVER NEEDS NOT TO HOOK------ */ =20 -/* REMOVED COMMON INFO---------- */ - /* u8 PseudoMacPhyMode; */ - /* bool *BTCoexist; */ - /* bool PseudoBtCoexist; */ - /* u8 OPMode; */ - /* bool bAPMode; */ - /* bool bClientMode; */ - /* bool bAdHocMode; */ - /* bool bSlaveOfDMSP; */ -/* REMOVED COMMON INFO---------- */ - /* 1 COMMON INFORMATION */ =20 /* */ @@ -766,7 +751,6 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_St= ructure */ u8 *pAntennaTest; bool *pbNet_closed; u8 *mp_mode; - /* u8 *pAidMap; */ u8 *pu1ForcedIgiLb; /* For 8723B IQK----------- */ bool *pIs1Antenna; @@ -865,18 +849,9 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_S= tructure */ =20 /* Latest packet phy info (ODM write) */ struct odm_phy_dbg_info PhyDbgInfo; - /* PHY_INFO_88E PhyInfo; */ =20 /* Latest packet phy info (ODM write) */ struct odm_mac_status_info *pMacInfo; - /* MAC_INFO_88E MacInfo; */ - - /* Different Team independent structure?? */ - - /* */ - /* TX_RTP_CMN TX_retrpo; */ - /* TX_RTP_88E TX_retrpo; */ - /* TX_RTP_8195 TX_retrpo; */ =20 /* */ /* ODM Structure */ @@ -902,15 +877,6 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_S= tructure */ /* */ =20 /* common */ - /* u8 DM_Type; */ - /* u8 PSD_Report_RXHP[80]; Add By Gary */ - /* u8 PSD_func_flag; Add By Gary */ - /* for DIG */ - /* u8 bDMInitialGainEnable; */ - /* u8 binitialized; for dm_initial_gain_Multi_STA use. */ - /* for Antenna diversity */ - /* u8 AntDivCfg; 0:OFF , 1:ON, 2:by efuse */ - /* PSTA_INFO_T RSSI_target; */ =20 bool *pbDriverStopped; bool *pbDriverIsGoingToPnpSetPowerSleep; --=20 2.53.0