From nobody Mon Apr 6 18:38:42 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4C2C3F0AB7 for ; Wed, 18 Mar 2026 19:13:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773861225; cv=none; b=uBVySz2nUjYt17PjW+ebEETWFkcwMsWNdo38PX8B3q0Jb8mYuMY1sqFZm+JoZwBh6Jx1WAkiAAwMcPwTfb2wAAswrGb5aGX4Vzi57+H7R1Oc2AbDA3grrVoytiZD/AVxVY0TkXZjy87op8S7iKczFyOOJpX0IbL7ATkD056rCks= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773861225; c=relaxed/simple; bh=PuJu+cuvxYyzLYu/heimivKoS0LlknYg8MItINKiTSc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dJ2udhLH9cFnI9hDlAxqqjR5g9IOHdi6O4dUmQjFt/IIRJ6dNli1TgOVOtfkS/T/egBsQmeX4Shte1H1bfYPCXrWXWG0F3H6JQT5nwJVPtN7EtYzTi0RB245SpF/pyoHqBVKoKqQI28Zp57xEVIJucYOGltzHAEFQ6nCH0U2Ym0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b=bBGLqDd0; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b="bBGLqDd0" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-356337f058aso228435a91.2 for ; Wed, 18 Mar 2026 12:13:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20230601.gappssmtp.com; s=20230601; t=1773861222; x=1774466022; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yhpU0qTAGa7ThLCGsekUFVuiiOUf0jdr/bUs5nRSlS8=; b=bBGLqDd0Xtz5Qan+N91Z1RBmrw3qsZKthWXUG2UDZiRTY+ysomixJWq/dy8wZlwTH4 p/h7dGPJ0s+ZyNZMHGLGQFCkSt0SsoFcHXRRYrujXXVpPavMvh+cMx8JH0D10bNpKDpx q+KV83N5kbdDgRSS1KYH5Qlmdt1Eu2vLdIXO7o8C5CytbVzyP1x1QQpKyq64RnaDhOer HYRaSGdeTR8pf2dbWWbVIi+cT/s3GfIIYPAWxGwZ5S6jH+fHYUvy+ASuaQEMjiOkYcsS +JBqUXGP37O8U29eiZjIliFFXCqdBy0C+onmqCbdSJyAKE2XUSx4PaUOTRV6u6N1vedq uLDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773861222; x=1774466022; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yhpU0qTAGa7ThLCGsekUFVuiiOUf0jdr/bUs5nRSlS8=; b=cU5g/BFtxdbJeAnuixgSOFoeD6GMpPk1Qhl1CSjK3wwAmkL5Eo7tAbVg77+xPLJUAc cOgCOYObU22MnNZ3t1nK8vAs39Ci7gFGRC0Y8gicgOacusIyet0U+Hl4NPvxGLurpEo1 CWuR9Nc6gni8F4rBPkuHWywIGBM4VPqOR2Tqo3Nv84BgrB15vevzIEdtUz7iDI07ZGpF gqPOxJiNdgWoBtONCMtCVblexX8LZxuip8xz9XLhiS4lrm8xtlAQ+5C0EfLm+EuegPRA 97Zd+WxExQsU8lfXMyVOCOYINEV1ATF95HcVDcS7QxdiDy+HCP9VUMNMaBosJIL3pHj9 WC5Q== X-Forwarded-Encrypted: i=1; AJvYcCXkShRpslmdqzOwLJ+wBpOR001Eic/wmsYUHwI204XhVHr8vFeH8wtYu3PWUe++CbUIE+ZZxJQeiiKLVqg=@vger.kernel.org X-Gm-Message-State: AOJu0Yyuo5AUej5gmrkkev9YYGHMLy1I+M8ihW75ybcMYR50ZJbDEx2I RCEGHOL1xDuh4NdoDzVYMqITzqJHcE9j8QLnYHZpNdE0yl6R4rdBryHRy9ONQR3hOkM= X-Gm-Gg: ATEYQzxOEhS3ezYyQiWjvwvegeBJYJOIrpafCttiLfuV58kQG83GrvhA4Rvohb7Ac9w mj4Zk4Zz9CfF95WUK13+iwRqnvWBBipDNhx6qeLpv0aP3cHK4Gv70Oq8m1HWsrQNDKBnl5w8MbC T1e46npS8uCEp1Sq1lObNdCTT6KxHypCIVR8SJPHoCwqfbxf7qAsTEH/Ds/gOL2Ihdf/rIX7rML MB4xAqvDrZI3IWVxFr33yKMb2ct6u9RWRuEIX3Dsz63tjPeTsGIroVAos1+yXiz3xUwE+y2o+HV 7OowLJR+vPvZ/+6cYmG5J1c5DBNOatS4xYtMwfW8Gn4FqVTXCForVtJj6083yNtnHnsaRxqFPG+ Rwn5+pAdfja5dcbpABHjVmE3mL3v+5219IFE0c37JnVyw/0gIOmwFe/S7bUpSjAxjq+uPk7tc4f uwN78J X-Received: by 2002:a17:90b:3f47:b0:359:9016:1e72 with SMTP id 98e67ed59e1d1-35bb9ef6048mr3939616a91.19.1773861222027; Wed, 18 Mar 2026 12:13:42 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:42::]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c741e582fa7sm3062628a12.29.2026.03.18.12.13.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 12:13:41 -0700 (PDT) From: Joe Damato To: netdev@vger.kernel.org, Michael Chan , Pavan Chebbi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: horms@kernel.org, linux-kernel@vger.kernel.org, leon@kernel.org, Joe Damato Subject: [net-next v3 04/12] net: bnxt: Add a helper for tx_bd_ext Date: Wed, 18 Mar 2026 12:13:09 -0700 Message-ID: <20260318191325.1819881-5-joe@dama.to> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260318191325.1819881-1-joe@dama.to> References: <20260318191325.1819881-1-joe@dama.to> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Factor out some code to setup tx_bd_exts into a helper function. This helper will be used by SW USO implementation in the following commits. Suggested-by: Jakub Kicinski Signed-off-by: Joe Damato Reviewed-by: Pavan Chebbi --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 9 ++------- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 18 ++++++++++++++++++ 2 files changed, 20 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethern= et/broadcom/bnxt/bnxt.c index c9206977fd54..d12e4fcd5063 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -663,10 +663,9 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb= , struct net_device *dev) txbd->tx_bd_opaque =3D SET_TX_OPAQUE(bp, txr, prod, 2 + last_frag); =20 prod =3D NEXT_TX(prod); - txbd1 =3D (struct tx_bd_ext *) - &txr->tx_desc_ring[TX_RING(bp, prod)][TX_IDX(prod)]; + txbd1 =3D bnxt_init_ext_bd(bp, txr, prod, lflags, vlan_tag_flags, + cfa_action); =20 - txbd1->tx_bd_hsize_lflags =3D lflags; if (skb_is_gso(skb)) { bool udp_gso =3D !!(skb_shinfo(skb)->gso_type & SKB_GSO_UDP_L4); u32 hdr_len; @@ -693,7 +692,6 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb,= struct net_device *dev) } else if (skb->ip_summed =3D=3D CHECKSUM_PARTIAL) { txbd1->tx_bd_hsize_lflags |=3D cpu_to_le32(TX_BD_FLAGS_TCP_UDP_CHKSUM); - txbd1->tx_bd_mss =3D 0; } =20 length >>=3D 9; @@ -706,9 +704,6 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb,= struct net_device *dev) flags |=3D bnxt_lhint_arr[length]; txbd->tx_bd_len_flags_type =3D cpu_to_le32(flags); =20 - txbd1->tx_bd_cfa_meta =3D cpu_to_le32(vlan_tag_flags); - txbd1->tx_bd_cfa_action =3D - cpu_to_le32(cfa_action << TX_BD_CFA_ACTION_SHIFT); txbd0 =3D txbd; for (i =3D 0; i < last_frag; i++) { frag =3D &skb_shinfo(skb)->frags[i]; diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.h b/drivers/net/ethern= et/broadcom/bnxt/bnxt.h index 8147f31967b5..a822bbb71146 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.h +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.h @@ -2834,6 +2834,24 @@ static inline u32 bnxt_tx_avail(struct bnxt *bp, return bp->tx_ring_size - (used & bp->tx_ring_mask); } =20 +static inline struct tx_bd_ext * +bnxt_init_ext_bd(struct bnxt *bp, struct bnxt_tx_ring_info *txr, + u16 prod, __le32 lflags, u32 vlan_tag_flags, + u32 cfa_action) +{ + struct tx_bd_ext *txbd1; + + txbd1 =3D (struct tx_bd_ext *) + &txr->tx_desc_ring[TX_RING(bp, prod)][TX_IDX(prod)]; + txbd1->tx_bd_hsize_lflags =3D lflags; + txbd1->tx_bd_mss =3D 0; + txbd1->tx_bd_cfa_meta =3D cpu_to_le32(vlan_tag_flags); + txbd1->tx_bd_cfa_action =3D + cpu_to_le32(cfa_action << TX_BD_CFA_ACTION_SHIFT); + + return txbd1; +} + static inline void bnxt_writeq(struct bnxt *bp, u64 val, volatile void __iomem *addr) { --=20 2.52.0