From nobody Mon Apr 6 17:27:30 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6673C3B2FE8 for ; Wed, 18 Mar 2026 15:52:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773849155; cv=none; b=uee9wr+A9VkQ64efRV4unJFfXPhcW513C0TBCzKTd5XLU3iyGQrtR2BnjXOfnA8V60LnKN6a2fDDNobo3jN0L+oTaGWgtoa0mokTkN2VMjYf/G/1KiLDdwSeRY1XyhUhPBUeVbuYN7X2I4uCPa+baiWwoCE9QiP+RQQ6QyXtR1M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773849155; c=relaxed/simple; bh=TV4oxLctJgNhtEqbA+524wrVBNXAvcpMJdvANV/+k9Q=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YU52gB9g6oSkYcv1hBNREKCuHL2FgkvwiBuGNy+RjmHkgBIfY9aiyvOlpgIag3fivzHdpFhA2Wng0gZ1FDkYPpLh24Y4Iq2GBpwjNcQ/aKdClQiaNX3gx4TxGHI2opC+ka5nOzYD81H6rXKf0+uEAagIszCaEn6AA9cqPwwQF1w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TfjCfClz; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TfjCfClz" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2b0586d5bb8so24418075ad.3 for ; Wed, 18 Mar 2026 08:52:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773849151; x=1774453951; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jqkH6mzjHCAxqSeaCcRc4i6txUHa48rXIDuskLcyMco=; b=TfjCfClzuWnwhZKuj6uWtF8WI/Ufr6tDyCG9/38Jah6XXZV1ee9lmsdW2nUTRaPwvf LYjC2cC1eDxEjyUUF9yq/TPzszaXyg3s5ga/b+ODW9k6K/OgMB1WrPQ2Vsicy/RSWvna omNCylTApwrayuloguDlyGNVV1/JqAiiWbqpP7keMi/dIBrQWCtUm0OXPu5ROmg2/kTT uU4nwmqJc4CtI8/Y0vDAT5+30/axkIjg//izTUgvwjNjjY+qbzzkqUfvMeE/CNwQLzdZ 8fNmQQrhsPulGctRzeJlG4uH8Dz/wI22PLqTEkPoZarLOTd9lZyB2IUWdlsTZTbGCCHi 24Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773849151; x=1774453951; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jqkH6mzjHCAxqSeaCcRc4i6txUHa48rXIDuskLcyMco=; b=L/PxqsNWcu/bYSfiUK21NVwXNlOfxprA7rt+bJxnJF0CS/Re1tG4nVXyxGHOItRVCb 9MhvG7bvL5HSASoTmuFjKAfaVJWxYDLNFkMm2fzRagV6AUwf6c7PzvuuNo6J+OZRFlKw zelT4uAzUgWlVbI/Y5vfrOyr4N+WVYJWGsHzk3Hl1zduYqaDi0XGCaa9qSAotAE0lGHu Jn7g7cPrxQAwzhlLOSiJwtHgo9+S68oL/n25BkB5ihXn+zk4PdX4QtCuFCJppVAcyj+w nFqKnqsTdhVBxiy1eTH3wpnsKwBdCMIrJj6w1sw63HSK9jtctHlVIZaDv254tBLp+SRb /brQ== X-Forwarded-Encrypted: i=1; AJvYcCV44mr6kgS/tD/EFlfIo5cni3OKr8LEpjevhlPZPCUXr/kzmXzcWMRIbjgbpVsEm/vs+0Xhk+z58AY1vVk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1IvPayU66udR/9JQRPovmdFOpc7/SNdvV0FCEIsobaFEYYKX3 EOctWvjhktrskSzTnEa0n3JQsKAiUdljYbS/dhsmDOetod4gxtCww6Y6 X-Gm-Gg: ATEYQzyAXP4AQyvvdEoFzRzlFdLD9x5kvpvj4lpM92C/b83sFl2BkImDo8aW4fIUMZB XzKcB28hTKcYDDnLZjL31mORmkVv2XP4E0mVFIs36qqERETprTcpxkey2HJyGFXVz+9FHqK+mAn D8xZXpJ99fu4F6lImLl0toViXIR9JMQFywJ+epmJRZPdmqTZezOlc5MBci1zy9JmNeQba0sUvO/ HttLlWrcWMFBoNXTeXmCWa0BSWIOfO7EmCInmYXo3iheJZlCEvD17UTFRubcvFrkJ3UoXcIEUXu sIQnvBwEWZm7wJiQo6r8BDevcDRj8/74LejwB6N8sft8OmIRQn1u1pyiW+tqr0BWXkOO9tQ05+g RCWEavxFA60BPURVxVZKwmzLZOzzHO5y8Hmn9XVmG3bmja3OeYRJ5u2UJ3pAPvqAMAXNBkqqFXk Yo5GwxUYMDywPsGw== X-Received: by 2002:a17:902:e5d2:b0:2ae:5629:ac55 with SMTP id d9443c01a7336-2b06e385ab9mr36407775ad.21.1773849151329; Wed, 18 Mar 2026 08:52:31 -0700 (PDT) Received: from lgs.. ([36.255.193.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b06e43074esm31892605ad.19.2026.03.18.08.52.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 08:52:31 -0700 (PDT) From: Guangshuo Li To: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Joshua Hay , Tatyana Nikolova , Madhu Chittim , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] idpf: fix UAF and double free in idpf_plug_core_aux_dev() error path Date: Wed, 18 Mar 2026 23:52:20 +0800 Message-ID: <20260318155220.642160-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If auxiliary_device_add() fails, idpf_plug_core_aux_dev() calls auxiliary_device_uninit(adev), whose release callback idpf_core_adev_release() frees the containing struct iidc_rdma_core_auxiliary_dev. The current error path then accesses adev->id and later frees iadev again, which may lead to a use-after-free and double free. Fix it by storing the allocated auxiliary device id in a local variable and avoiding direct freeing of iadev after auxiliary_device_uninit(). Fixes: f4312e6bfa2a ("idpf: implement core RDMA auxiliary dev create, init,= and destroy") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li Reviewed-by: Aleksandr Loktionov Reviewed-by: Paul Menzel --- drivers/net/ethernet/intel/idpf/idpf_idc.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/idpf/idpf_idc.c b/drivers/net/ether= net/intel/idpf/idpf_idc.c index 6dad0593f7f2..0fcbf9f1ddbb 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_idc.c +++ b/drivers/net/ethernet/intel/idpf/idpf_idc.c @@ -197,6 +197,7 @@ static int idpf_plug_core_aux_dev(struct iidc_rdma_core= _dev_info *cdev_info) char name[IDPF_IDC_MAX_ADEV_NAME_LEN]; struct auxiliary_device *adev; int ret; + int id; =20 iadev =3D kzalloc(sizeof(*iadev), GFP_KERNEL); if (!iadev) @@ -211,12 +212,16 @@ static int idpf_plug_core_aux_dev(struct iidc_rdma_co= re_dev_info *cdev_info) pr_err("failed to allocate unique device ID for Auxiliary driver\n"); goto err_ida_alloc; } - adev->id =3D ret; + id =3D ret; + adev->id =3D id; adev->dev.release =3D idpf_core_adev_release; adev->dev.parent =3D &cdev_info->pdev->dev; sprintf(name, "%04x.rdma.core", cdev_info->pdev->vendor); adev->name =3D name; =20 + /* iadev is owned by the auxiliary device */ + iadev =3D NULL; + ret =3D auxiliary_device_init(adev); if (ret) goto err_aux_dev_init; @@ -230,7 +235,7 @@ static int idpf_plug_core_aux_dev(struct iidc_rdma_core= _dev_info *cdev_info) err_aux_dev_add: auxiliary_device_uninit(adev); err_aux_dev_init: - ida_free(&idpf_idc_ida, adev->id); + ida_free(&idpf_idc_ida, id); err_ida_alloc: cdev_info->adev =3D NULL; kfree(iadev); --=20 2.43.0