From nobody Mon Apr 6 18:55:09 2026 Received: from mail-dy1-f171.google.com (mail-dy1-f171.google.com [74.125.82.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1D643E5583 for ; Wed, 18 Mar 2026 15:03:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773846204; cv=none; b=iNMp9mUJoB+/VPf7Qv7zVNmmI+ZVe4ec7gKGwyzV8xH4T12pZRI4ykWREWQ6ViGfaIpM1Ku/4Um8c3vj37Z04NRGfe3suz2InAJpu1sF/kzwQs2pi3MsBzl2cbfh1pImVA35BkJM+GLax/7RtDq29/bmLhYanE1FcHaq5p/C3d0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773846204; c=relaxed/simple; bh=D5MJp9QfPCqdxbijMd08bf6IesS8CtRPNVD77gyALRk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bKiRazZ3BdhM8p3WmO3hIntiH7RPGGbN5O/hs2iV6Sn74uSrtgRd1bLjL+lacAYnVc+0D1rBUmsIOFKCnC57YIHUdDo30+2q6huK/DVD/Mgj2RJLjuEpWujRX1KPRh5wRPRLrMPmf4n6fgjDzjozV0FzXhjB8VZ1yh9lGMlwe4w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fomichev.me; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=74.125.82.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fomichev.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-dy1-f171.google.com with SMTP id 5a478bee46e88-2beab594d8eso18370eec.0 for ; Wed, 18 Mar 2026 08:03:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773846201; x=1774451001; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4k+owXpgYHddeJNnypZucTVOUuVNXL7iUBaXVHuuV44=; b=JhRBybbeehydfRopatG30b3ycJw4nc5e8ouTyvkuENxsuzLVLwzvYxcjucsmFU/25d KsKQRDwHSz9/KUxgFJQyh8OM0cLrNn68YtkU24TwHBJAwWe9IASPPyKE8rSOB/h2hoDL EcNxHv7/IafJNZqSr+H7Ja7BPalesbZ4oXM01PQc6wreDPei1cyiD9bpjKoI1t14Pr9X oVDfuC+dRzECphvGhdhI7TZWfZzHPH/lEppHzhjfj1x4y/4kxe/+8kORwA8N45hAFPG8 nAbH+qYmVPPcTSSdbeDUN4/XMb3gGjZU0d7s4uoS2V56KRdVVFzKtsKRpQw3vsjJ5epf jd1Q== X-Forwarded-Encrypted: i=1; AJvYcCU+JGZTJ0AFd71rrJKHgnhgQbYJk1kC/tzRl5wsNteLpVk400CeJ//eZe0bJ/kc1+uEzRaDNjUlB1AsaDs=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5nHh1GCCuQVmdCRPJnAS7R508iL2DOxqpt5Qd7C8q9YSQ0gPU E5/hoH4UdWxdwFy6MUq4NWSFhDRUpinR5NzD29TehvU+peqydm1jNiY= X-Gm-Gg: ATEYQzzT4tQPij6oHq9sfZkTBk5TNqWoZ/qJA9o5R5cFggr9knLrqoyUw3cGEDOt05D bOmY8Jlo1vFLV5NvMugvhEtWOJgsBPzfJV3glsSrAuRRgQQRK+pz2YlocCqcHo6coZAkFG77M5D lATFFxppCtHKKaK2g6Lh6Scmozjfojl73kxRP/STLG5NY+CogNWkTIA5IEhNFsFIotDot2r2bL1 gKcZkP+NWmoSj0ics5+2TS14mvxO2HiA7Ix+ek5fKy8OSBJ2kN+EJsRGq4jH1SfDOQFBxnrf3lh Ljr3pPKyUaPlEz8fwpvTu2+X4AmxurdWlY+UdisM1aEyM+84He5ITWLp0CQbR1Gd9TMS+rbZOtB XyegdYN6j9tJ3fitmfqaF7RZXBHzYFHPvN3dYS7biPZ6nDIcDEtYtHA3FINxMwVXas0EnDniEVl qx0GCw2+hRzqh+xZwEFo9XOusp2XaSGTGOZAvZpETGynSqRqaLdVuhndYFFHDlvYaXQTs+rg4bc MvhzHQE9oYWVrLOZz9xf1LnRpRU X-Received: by 2002:a05:7301:1004:b0:2c0:e31b:1814 with SMTP id 5a478bee46e88-2c0e4f77bbemr1902433eec.10.1773846200088; Wed, 18 Mar 2026 08:03:20 -0700 (PDT) Received: from localhost (c-76-102-12-149.hsd1.ca.comcast.net. [76.102.12.149]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c0e55834a0sm4171479eec.14.2026.03.18.08.03.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 08:03:19 -0700 (PDT) From: Stanislav Fomichev To: netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, corbet@lwn.net, skhan@linuxfoundation.org, andrew+netdev@lunn.ch, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, saeedm@nvidia.com, tariqt@nvidia.com, mbloch@nvidia.com, alexanderduyck@fb.com, kernel-team@meta.com, johannes@sipsolutions.net, sd@queasysnail.net, jianbol@nvidia.com, dtatulea@nvidia.com, sdf@fomichev.me, mohsin.bashr@gmail.com, jacob.e.keller@intel.com, willemb@google.com, skhawaja@google.com, bestswngs@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kselftest@vger.kernel.org, leon@kernel.org Subject: [PATCH net-next v2 07/13] bnxt: convert to ndo_set_rx_mode_async Date: Wed, 18 Mar 2026 08:02:59 -0700 Message-ID: <20260318150305.123900-8-sdf@fomichev.me> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260318150305.123900-1-sdf@fomichev.me> References: <20260318150305.123900-1-sdf@fomichev.me> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert bnxt from ndo_set_rx_mode to ndo_set_rx_mode_async. bnxt_set_rx_mode, bnxt_mc_list_updated and bnxt_uc_list_updated now take explicit uc/mc list parameters and iterate with netdev_hw_addr_list_for_each instead of netdev_for_each_{uc,mc}_addr. The bnxt_cfg_rx_mode internal caller passes the real lists under netif_addr_lock_bh. BNXT_RX_MASK_SP_EVENT is still used here, next patch converts to the direct call. Cc: Michael Chan Cc: Pavan Chebbi Signed-off-by: Stanislav Fomichev Reviewed-by: Aleksandr Loktionov --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 31 +++++++++++++---------- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethern= et/broadcom/bnxt/bnxt.c index c982aac714d1..225217b32e4b 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -11040,7 +11040,8 @@ static int bnxt_setup_nitroa0_vnic(struct bnxt *bp) } =20 static int bnxt_cfg_rx_mode(struct bnxt *); -static bool bnxt_mc_list_updated(struct bnxt *, u32 *); +static bool bnxt_mc_list_updated(struct bnxt *, u32 *, + const struct netdev_hw_addr_list *); =20 static int bnxt_init_chip(struct bnxt *bp, bool irq_re_init) { @@ -11130,7 +11131,7 @@ static int bnxt_init_chip(struct bnxt *bp, bool irq= _re_init) } else if (bp->dev->flags & IFF_MULTICAST) { u32 mask =3D 0; =20 - bnxt_mc_list_updated(bp, &mask); + bnxt_mc_list_updated(bp, &mask, &bp->dev->mc); vnic->rx_mask |=3D mask; } =20 @@ -13519,17 +13520,17 @@ void bnxt_get_ring_drv_stats(struct bnxt *bp, bnxt_get_one_ring_drv_stats(bp, stats, &bp->bnapi[i]->cp_ring); } =20 -static bool bnxt_mc_list_updated(struct bnxt *bp, u32 *rx_mask) +static bool bnxt_mc_list_updated(struct bnxt *bp, u32 *rx_mask, + const struct netdev_hw_addr_list *mc) { struct bnxt_vnic_info *vnic =3D &bp->vnic_info[BNXT_VNIC_DEFAULT]; - struct net_device *dev =3D bp->dev; struct netdev_hw_addr *ha; u8 *haddr; int mc_count =3D 0; bool update =3D false; int off =3D 0; =20 - netdev_for_each_mc_addr(ha, dev) { + netdev_hw_addr_list_for_each(ha, mc) { if (mc_count >=3D BNXT_MAX_MC_ADDRS) { *rx_mask |=3D CFA_L2_SET_RX_MASK_REQ_MASK_ALL_MCAST; vnic->mc_list_count =3D 0; @@ -13553,17 +13554,17 @@ static bool bnxt_mc_list_updated(struct bnxt *bp,= u32 *rx_mask) return update; } =20 -static bool bnxt_uc_list_updated(struct bnxt *bp) +static bool bnxt_uc_list_updated(struct bnxt *bp, + const struct netdev_hw_addr_list *uc) { - struct net_device *dev =3D bp->dev; struct bnxt_vnic_info *vnic =3D &bp->vnic_info[BNXT_VNIC_DEFAULT]; struct netdev_hw_addr *ha; int off =3D 0; =20 - if (netdev_uc_count(dev) !=3D (vnic->uc_filter_count - 1)) + if (netdev_hw_addr_list_count(uc) !=3D (vnic->uc_filter_count - 1)) return true; =20 - netdev_for_each_uc_addr(ha, dev) { + netdev_hw_addr_list_for_each(ha, uc) { if (!ether_addr_equal(ha->addr, vnic->uc_list + off)) return true; =20 @@ -13572,7 +13573,9 @@ static bool bnxt_uc_list_updated(struct bnxt *bp) return false; } =20 -static void bnxt_set_rx_mode(struct net_device *dev) +static void bnxt_set_rx_mode(struct net_device *dev, + struct netdev_hw_addr_list *uc, + struct netdev_hw_addr_list *mc) { struct bnxt *bp =3D netdev_priv(dev); struct bnxt_vnic_info *vnic; @@ -13593,7 +13596,7 @@ static void bnxt_set_rx_mode(struct net_device *dev) if (dev->flags & IFF_PROMISC) mask |=3D CFA_L2_SET_RX_MASK_REQ_MASK_PROMISCUOUS; =20 - uc_update =3D bnxt_uc_list_updated(bp); + uc_update =3D bnxt_uc_list_updated(bp, uc); =20 if (dev->flags & IFF_BROADCAST) mask |=3D CFA_L2_SET_RX_MASK_REQ_MASK_BCAST; @@ -13601,7 +13604,7 @@ static void bnxt_set_rx_mode(struct net_device *dev) mask |=3D CFA_L2_SET_RX_MASK_REQ_MASK_ALL_MCAST; vnic->mc_list_count =3D 0; } else if (dev->flags & IFF_MULTICAST) { - mc_update =3D bnxt_mc_list_updated(bp, &mask); + mc_update =3D bnxt_mc_list_updated(bp, &mask, mc); } =20 if (mask !=3D vnic->rx_mask || uc_update || mc_update) { @@ -13620,7 +13623,7 @@ static int bnxt_cfg_rx_mode(struct bnxt *bp) bool uc_update; =20 netif_addr_lock_bh(dev); - uc_update =3D bnxt_uc_list_updated(bp); + uc_update =3D bnxt_uc_list_updated(bp, &dev->uc); netif_addr_unlock_bh(dev); =20 if (!uc_update) @@ -15871,7 +15874,7 @@ static const struct net_device_ops bnxt_netdev_ops = =3D { .ndo_start_xmit =3D bnxt_start_xmit, .ndo_stop =3D bnxt_close, .ndo_get_stats64 =3D bnxt_get_stats64, - .ndo_set_rx_mode =3D bnxt_set_rx_mode, + .ndo_set_rx_mode_async =3D bnxt_set_rx_mode, .ndo_eth_ioctl =3D bnxt_ioctl, .ndo_validate_addr =3D eth_validate_addr, .ndo_set_mac_address =3D bnxt_change_mac_addr, --=20 2.53.0