From nobody Mon Apr 6 18:55:09 2026 Received: from mail-dl1-f51.google.com (mail-dl1-f51.google.com [74.125.82.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9140B3DF00E for ; Wed, 18 Mar 2026 15:03:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773846200; cv=none; b=pS2BWPAawzHj1h9ol5/KVXSBYGnfuygDEp/2FscF1Aj+5/yk6FlXbSSUZgkQWRlVCk51BRyYRi+Jg50wWquEb+RPdUD80qe+1tK9Kf8yCWQCez0cFh67xZTXLi3vgaFLelHiByOi80tuIXw2U4gYlaeuZY4JgkrbOtUuQghZgw8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773846200; c=relaxed/simple; bh=M5gnEc11KDkqZuchks/Py1C6vXEkiKaFsRsBBNVZ/Xo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YD8+KFke074/LWHr7sLBBnTNTpHO/7d+wisY8YcnMA5NCSaEigId7rnxZnGmiyXyogaNlgDN+X6Ex+8UywTTEscC2uvjplZxz/j/8uJBxzOd55esoVjI+8If0HRIhEMqUQlv9sFl35Gb/3ShEWMPaBkqniIKCiW7YfJ6AFwaGvI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fomichev.me; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=74.125.82.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fomichev.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-dl1-f51.google.com with SMTP id a92af1059eb24-1271195d2a7so56250c88.0 for ; Wed, 18 Mar 2026 08:03:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773846195; x=1774450995; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=T/N6mOi7xkb0zTWJlZWJy0zhM/WcNTYapi3I3y4p9TY=; b=ou28HVba59SNnj9HQiQyb0LpenK3xg/qyoL0EqPLDBWuI03BhgwbhKj8UlzzBNuws2 7keyw9E693J2biZtOJNmsNLvkZZirgXu5hAJbJLLEDw6BqbmS7Zolo8lDli7AwHr8R/T UrH7RoLo/IdB4N/6dMlOBJNlxHD3/Iw6pohbx/ZnLNDagEEq+9j9mBGfsx9j1QMl8Cln +Mmy8clSaJLbywxEz5ui0+tPdg6q+2jl3iV1hSrGdSBoR6dLh2cbIuRlUNwDJ8NW8rLz 43b5/WAT9u47P7eNBulHWNPeE0mRrqObDxkhj2/YOdFmoA94QKs4hSs31ZESl+DASFzJ FbpQ== X-Forwarded-Encrypted: i=1; AJvYcCXAXtotiyUOrhLMC4H+cJbjWsXfX9CoiwP4JgW7P9va3FnRv0niBhyXfx3Mq8kOrtd9lIhQTg3xxr8ekPo=@vger.kernel.org X-Gm-Message-State: AOJu0Yyxc2iyAT4iaGzltocJ77yajBZ/g1s7evP9JPvqetVEcwqU+pxe gen2f1pA3KpRKNXEbJh3f8hSTviR7nsfpWhGk4pRCiIjK40pAizxXLE= X-Gm-Gg: ATEYQzzsyIhEz5oi+W7aANtp6RmAC92XYZz3jnjAuZqPFc16OG93/DSFf6r4Guo1wq1 k4o6elRXBjhBPMaTvS6uIdWl7FQVcsY+UDcmJK80FCuV0Zr6GxzGSAZx8eTmYg9fEcrxdizyv5r mQitSM+3UBQ7NGebE7zLMIptGFs0st1UrcxOj12Uh3SFVpuBBsq93QT10TThGYfcJbNlxehG9B4 +OKYRgJVJAeoGeHY3gAoJMR0y37pxb2eGDEHqPVE9POyFHbHI/gxkrZTMGIrmhpc4DIjRZX7/5S FODtp0hKk47dJDpxPxdhMTGVKdGfetofENhVrnq1rHf9fEVrTjFOTkBARpZjXKlw3aw0LugAhKE Mqq9kFs9NivHnd08UpQa5eWfOliC2pmQf/PSsVXtFMseYs5fnK1VJujqvb7mPW3kUYZOkfbwpCh 72PGPUcDjn6H6w7Dw54ZteU3xfmXP1MXdUbEY251sCd03BAk4aB9jaBgm4JrnOIYMTjpq3lnBpg 5kvRjF83T/gg8opPw== X-Received: by 2002:a05:7022:f102:b0:128:d455:8501 with SMTP id a92af1059eb24-129a71abbfbmr2013611c88.37.1773846194778; Wed, 18 Mar 2026 08:03:14 -0700 (PDT) Received: from localhost (c-76-102-12-149.hsd1.ca.comcast.net. [76.102.12.149]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-129b41289e7sm3349629c88.10.2026.03.18.08.03.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 08:03:14 -0700 (PDT) From: Stanislav Fomichev To: netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, corbet@lwn.net, skhan@linuxfoundation.org, andrew+netdev@lunn.ch, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, saeedm@nvidia.com, tariqt@nvidia.com, mbloch@nvidia.com, alexanderduyck@fb.com, kernel-team@meta.com, johannes@sipsolutions.net, sd@queasysnail.net, jianbol@nvidia.com, dtatulea@nvidia.com, sdf@fomichev.me, mohsin.bashr@gmail.com, jacob.e.keller@intel.com, willemb@google.com, skhawaja@google.com, bestswngs@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kselftest@vger.kernel.org, leon@kernel.org Subject: [PATCH net-next v2 05/13] fbnic: convert to ndo_set_rx_mode_async Date: Wed, 18 Mar 2026 08:02:57 -0700 Message-ID: <20260318150305.123900-6-sdf@fomichev.me> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260318150305.123900-1-sdf@fomichev.me> References: <20260318150305.123900-1-sdf@fomichev.me> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert fbnic from ndo_set_rx_mode to ndo_set_rx_mode_async. The driver's __fbnic_set_rx_mode() now takes explicit uc/mc list parameters and uses __hw_addr_sync_dev() on the snapshots instead of __dev_uc_sync/__dev_mc_sync on the netdev directly. Update callers in fbnic_up, fbnic_fw_config_after_crash, fbnic_bmc_rpc_check and fbnic_set_mac to pass the real address lists calling __fbnic_set_rx_mode outside the async work path. Cc: Alexander Duyck Cc: kernel-team@meta.com Signed-off-by: Stanislav Fomichev Reviewed-by: Aleksandr Loktionov --- .../net/ethernet/meta/fbnic/fbnic_netdev.c | 20 ++++++++++++------- .../net/ethernet/meta/fbnic/fbnic_netdev.h | 4 +++- drivers/net/ethernet/meta/fbnic/fbnic_pci.c | 4 ++-- drivers/net/ethernet/meta/fbnic/fbnic_rpc.c | 2 +- 4 files changed, 19 insertions(+), 11 deletions(-) diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c b/drivers/net/e= thernet/meta/fbnic/fbnic_netdev.c index b4b396ca9bce..c406a3b56b37 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c +++ b/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c @@ -183,7 +183,9 @@ static int fbnic_mc_unsync(struct net_device *netdev, c= onst unsigned char *addr) return ret; } =20 -void __fbnic_set_rx_mode(struct fbnic_dev *fbd) +void __fbnic_set_rx_mode(struct fbnic_dev *fbd, + struct netdev_hw_addr_list *uc, + struct netdev_hw_addr_list *mc) { bool uc_promisc =3D false, mc_promisc =3D false; struct net_device *netdev =3D fbd->netdev; @@ -213,10 +215,10 @@ void __fbnic_set_rx_mode(struct fbnic_dev *fbd) } =20 /* Synchronize unicast and multicast address lists */ - err =3D __dev_uc_sync(netdev, fbnic_uc_sync, fbnic_uc_unsync); + err =3D __hw_addr_sync_dev(uc, netdev, fbnic_uc_sync, fbnic_uc_unsync); if (err =3D=3D -ENOSPC) uc_promisc =3D true; - err =3D __dev_mc_sync(netdev, fbnic_mc_sync, fbnic_mc_unsync); + err =3D __hw_addr_sync_dev(mc, netdev, fbnic_mc_sync, fbnic_mc_unsync); if (err =3D=3D -ENOSPC) mc_promisc =3D true; =20 @@ -238,18 +240,21 @@ void __fbnic_set_rx_mode(struct fbnic_dev *fbd) fbnic_write_tce_tcam(fbd); } =20 -static void fbnic_set_rx_mode(struct net_device *netdev) +static void fbnic_set_rx_mode(struct net_device *netdev, + struct netdev_hw_addr_list *uc, + struct netdev_hw_addr_list *mc) { struct fbnic_net *fbn =3D netdev_priv(netdev); struct fbnic_dev *fbd =3D fbn->fbd; =20 /* No need to update the hardware if we are not running */ if (netif_running(netdev)) - __fbnic_set_rx_mode(fbd); + __fbnic_set_rx_mode(fbd, uc, mc); } =20 static int fbnic_set_mac(struct net_device *netdev, void *p) { + struct fbnic_net *fbn =3D netdev_priv(netdev); struct sockaddr *addr =3D p; =20 if (!is_valid_ether_addr(addr->sa_data)) @@ -257,7 +262,8 @@ static int fbnic_set_mac(struct net_device *netdev, voi= d *p) =20 eth_hw_addr_set(netdev, addr->sa_data); =20 - fbnic_set_rx_mode(netdev); + if (netif_running(netdev)) + __fbnic_set_rx_mode(fbn->fbd, &netdev->uc, &netdev->mc); =20 return 0; } @@ -551,7 +557,7 @@ static const struct net_device_ops fbnic_netdev_ops =3D= { .ndo_features_check =3D fbnic_features_check, .ndo_set_mac_address =3D fbnic_set_mac, .ndo_change_mtu =3D fbnic_change_mtu, - .ndo_set_rx_mode =3D fbnic_set_rx_mode, + .ndo_set_rx_mode_async =3D fbnic_set_rx_mode, .ndo_get_stats64 =3D fbnic_get_stats64, .ndo_bpf =3D fbnic_bpf, .ndo_hwtstamp_get =3D fbnic_hwtstamp_get, diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_netdev.h b/drivers/net/e= thernet/meta/fbnic/fbnic_netdev.h index 9129a658f8fa..eded20b0e9e4 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_netdev.h +++ b/drivers/net/ethernet/meta/fbnic/fbnic_netdev.h @@ -97,7 +97,9 @@ void fbnic_time_init(struct fbnic_net *fbn); int fbnic_time_start(struct fbnic_net *fbn); void fbnic_time_stop(struct fbnic_net *fbn); =20 -void __fbnic_set_rx_mode(struct fbnic_dev *fbd); +void __fbnic_set_rx_mode(struct fbnic_dev *fbd, + struct netdev_hw_addr_list *uc, + struct netdev_hw_addr_list *mc); void fbnic_clear_rx_mode(struct fbnic_dev *fbd); =20 void fbnic_phylink_get_pauseparam(struct net_device *netdev, diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_pci.c b/drivers/net/ethe= rnet/meta/fbnic/fbnic_pci.c index e3aebbe3656d..6b139cf54256 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_pci.c +++ b/drivers/net/ethernet/meta/fbnic/fbnic_pci.c @@ -135,7 +135,7 @@ void fbnic_up(struct fbnic_net *fbn) =20 fbnic_rss_reinit_hw(fbn->fbd, fbn); =20 - __fbnic_set_rx_mode(fbn->fbd); + __fbnic_set_rx_mode(fbn->fbd, &fbn->netdev->uc, &fbn->netdev->mc); =20 /* Enable Tx/Rx processing */ fbnic_napi_enable(fbn); @@ -180,7 +180,7 @@ static int fbnic_fw_config_after_crash(struct fbnic_dev= *fbd) } =20 fbnic_rpc_reset_valid_entries(fbd); - __fbnic_set_rx_mode(fbd); + __fbnic_set_rx_mode(fbd, &fbd->netdev->uc, &fbd->netdev->mc); =20 return 0; } diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_rpc.c b/drivers/net/ethe= rnet/meta/fbnic/fbnic_rpc.c index 42a186db43ea..fe95b6f69646 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_rpc.c +++ b/drivers/net/ethernet/meta/fbnic/fbnic_rpc.c @@ -244,7 +244,7 @@ void fbnic_bmc_rpc_check(struct fbnic_dev *fbd) =20 if (fbd->fw_cap.need_bmc_tcam_reinit) { fbnic_bmc_rpc_init(fbd); - __fbnic_set_rx_mode(fbd); + __fbnic_set_rx_mode(fbd, &fbd->netdev->uc, &fbd->netdev->mc); fbd->fw_cap.need_bmc_tcam_reinit =3D false; } =20 --=20 2.53.0