From nobody Mon Apr 6 18:55:16 2026 Received: from mail-dl1-f46.google.com (mail-dl1-f46.google.com [74.125.82.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13BB93ECBFD for ; Wed, 18 Mar 2026 15:03:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773846213; cv=none; b=A07vlwTj0gk965/DW8meUWp+1nwNnElbUJNbEu7yJH3cSlFF5Mjh+ZFCDRljEKn56/lijHlG74GKz5z9XrunedLn6S2u9+H92l9IrgkYcNX9JMQf/97djXnBm/bSa483oQEx2a7Ici/tLTSghlp+58v62fA3qaHPvb+qycc2Yhg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773846213; c=relaxed/simple; bh=fFbx4L7c5RG8MsSh64xUKulTqmO1Wn4GpSHiz4YrwzM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PBaHlyQdsVsSZ7jqgjyd0ivbkNHzOOJzbogbFZ4t0Q/wtgb+BXYvihh2sY1Yz07MlWAtow6ZM41VNEt9pN6P7BbSKuquHICuRNJSI3KeXx66WmI2dFpSlR8CDd6JHkugRyIe+KXzlABpRhZw7Avf8uNp+hLXuvteSNFq0vfcDjE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fomichev.me; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=74.125.82.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fomichev.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-dl1-f46.google.com with SMTP id a92af1059eb24-128d2e3082eso151277c88.0 for ; Wed, 18 Mar 2026 08:03:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773846209; x=1774451009; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LwI56IvSstpXQXaX8+DYC8cYl7ak5TMhpM2nnpgQBwA=; b=DEpDXLRg7yceKAWJm6Ij3mKpdDG2ViwFzvbbuusPjHZsHc58yQQKyVLDiaXDVh8gvT LHdpRPGzkjRXqFlqVT4zo1fnYU5OQZm2UAQe9iY2rCoMYdJ427a9WoiWqyKEP9YCyZmK 1oenXKXX/fVZSnv/OwMkacPL49MvlZ7G9PtnD2Ip+JRx1r6z6UJ4vwNbqjRKiN6TZIl+ 8llUVeZYNf9YzxS+nkzZC6pstVbBSKKG520IhGiE3j5401Ahg1vpjYq+MsygS/Vo6/Ub 1Ldw7LShbLxcNJoBBHRCtI7iGruftfDMr8BX9TM0m92Z6RPVyJxOO5wJbD9IoGqpQWd8 9HkA== X-Forwarded-Encrypted: i=1; AJvYcCUiMWnB7+R1Q+7d65SZmLsbC0TGxFURPmREXjUyHmOu6zdNuDC8eOyPCxr6AAmZ8UmD6WqVA4rKRh9Ko3k=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9hLSX1nP6AHAcQPzh56GYyYPNa5Zmme8AzQfvSD+s2nLj2hB4 yFnBO9Cj1IvH9KuSQV8XNfWXP7OyknQg79zMV71/3jwNQVdqb13Eloc= X-Gm-Gg: ATEYQzzgv4IDdbPzT1XIsB+yqdX+PrItp1ZU9mSJ0PyZ25q2r3ra8kiHuah0JrYXANW V+BscS6PURW2QU1sC887ZcxWENFAQblKbOk4moNkNGvPQOr5s9TKmyQs4EmeBcKEdKNKEzf1Vgt bMhOVxSfOom+T1L7Jdci26k9N0aC/l9ust0sb2ff72lJyku4En/ys9aVgc7YSW96B6Q8PhHwMT3 VeJHlLbAOb5tSYhonn/NplEairfdJgqjsPhTtv+EByO+O8dRL6FdNSLsZY/5hJMZcCkf2WZl/GR BWoC7CDYGpGgwNQ9dT7v7Y0bx9UqczojgkO7qeuvYLEHcQHEgsw39M3924nt/XaWdofZiygpoQz ltTegVM+pVjvzYuHChMQaS9vtZJUz8kMcVOPGhtRZpmZZWgnHx09QVX/OMliTZvpuiaLfxbEeIt GOI7rHV7Lv83+p2ImKs7GdEp21cBAJlisqtoi0de8mR3I+QnPG7EZJ4CKUST21XvHx/nRl943Rc 20gWBzZki+D+4y3oQ== X-Received: by 2002:a05:7022:43aa:b0:11b:c1ab:bdd4 with SMTP id a92af1059eb24-129a70eab62mr1700585c88.38.1773846208379; Wed, 18 Mar 2026 08:03:28 -0700 (PDT) Received: from localhost (c-76-102-12-149.hsd1.ca.comcast.net. [76.102.12.149]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-129a7256263sm3541023c88.4.2026.03.18.08.03.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 08:03:27 -0700 (PDT) From: Stanislav Fomichev To: netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, corbet@lwn.net, skhan@linuxfoundation.org, andrew+netdev@lunn.ch, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, saeedm@nvidia.com, tariqt@nvidia.com, mbloch@nvidia.com, alexanderduyck@fb.com, kernel-team@meta.com, johannes@sipsolutions.net, sd@queasysnail.net, jianbol@nvidia.com, dtatulea@nvidia.com, sdf@fomichev.me, mohsin.bashr@gmail.com, jacob.e.keller@intel.com, willemb@google.com, skhawaja@google.com, bestswngs@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kselftest@vger.kernel.org, leon@kernel.org Subject: [PATCH net-next v2 13/13] selftests: net: add team_bridge_macvlan rx_mode test Date: Wed, 18 Mar 2026 08:03:05 -0700 Message-ID: <20260318150305.123900-14-sdf@fomichev.me> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260318150305.123900-1-sdf@fomichev.me> References: <20260318150305.123900-1-sdf@fomichev.me> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a test that exercises the ndo_change_rx_flags path through a macvlan -> bridge -> team -> dummy stack. This triggers dev_uc_add under addr_list_lock which flips promiscuity on the lower device. With the new work queue approach, this must not deadlock. Link: https://lore.kernel.org/netdev/20260214033859.43857-1-jiayuan.chen@li= nux.dev/ Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/net/config | 1 + tools/testing/selftests/net/rtnetlink.sh | 44 ++++++++++++++++++++++++ 2 files changed, 45 insertions(+) diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/n= et/config index 2a390cae41bf..94d722770420 100644 --- a/tools/testing/selftests/net/config +++ b/tools/testing/selftests/net/config @@ -101,6 +101,7 @@ CONFIG_NET_SCH_HTB=3Dm CONFIG_NET_SCH_INGRESS=3Dm CONFIG_NET_SCH_NETEM=3Dy CONFIG_NET_SCH_PRIO=3Dm +CONFIG_NET_TEAM=3Dy CONFIG_NET_VRF=3Dy CONFIG_NF_CONNTRACK=3Dm CONFIG_NF_CONNTRACK_OVS=3Dy diff --git a/tools/testing/selftests/net/rtnetlink.sh b/tools/testing/selft= ests/net/rtnetlink.sh index 5a5ff88321d5..c499953d4885 100755 --- a/tools/testing/selftests/net/rtnetlink.sh +++ b/tools/testing/selftests/net/rtnetlink.sh @@ -23,6 +23,7 @@ ALL_TESTS=3D" kci_test_encap kci_test_macsec kci_test_macsec_vlan + kci_test_team_bridge_macvlan kci_test_ipsec kci_test_ipsec_offload kci_test_fdb_get @@ -636,6 +637,49 @@ kci_test_macsec_vlan() end_test "PASS: macsec_vlan" } =20 +# Test ndo_change_rx_flags call from dev_uc_add under addr_list_lock spinl= ock. +# When we are flipping the promisc, make sure it runs on the work queue. +# +# https://lore.kernel.org/netdev/20260214033859.43857-1-jiayuan.chen@linux= .dev/ +# With (more conventional) macvlan instead of macsec. +# macvlan -> bridge -> team -> dummy +kci_test_team_bridge_macvlan() +{ + local vlan=3D"test_macv1" + local bridge=3D"test_br1" + local team=3D"test_team1" + local dummy=3D"test_dummy1" + local ret=3D0 + + run_cmd ip link add $team type team + if [ $ret -ne 0 ]; then + end_test "SKIP: team_bridge_macvlan: can't add team interface" + return $ksft_skip + fi + + run_cmd ip link add $dummy type dummy + run_cmd ip link set $dummy master $team + run_cmd ip link set $team up + run_cmd ip link add $bridge type bridge vlan_filtering 1 + run_cmd ip link set $bridge up + run_cmd ip link set $team master $bridge + run_cmd ip link add link $bridge name $vlan \ + address 00:aa:bb:cc:dd:ee type macvlan mode bridge + run_cmd ip link set $vlan up + + run_cmd ip link del $vlan + run_cmd ip link del $bridge + run_cmd ip link del $team + run_cmd ip link del $dummy + + if [ $ret -ne 0 ]; then + end_test "FAIL: team_bridge_macvlan" + return 1 + fi + + end_test "PASS: team_bridge_macvlan" +} + #------------------------------------------------------------------- # Example commands # ip x s add proto esp src 14.0.0.52 dst 14.0.0.70 \ --=20 2.53.0