From nobody Mon Apr 6 18:55:08 2026 Received: from mail-dy1-f175.google.com (mail-dy1-f175.google.com [74.125.82.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93A733EC2EE for ; Wed, 18 Mar 2026 15:03:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773846212; cv=none; b=PRnYj/IpKIFgo1c50r0Lcn5Q1QYrwoPJCXm2Fk/hzMt+j+n5kF6d2XwIWYAfhju1fFwrcJTjqr4jsHfWUhMpyKKMrS9Nit0NThRylNAcShxgaAaRFVYL3gNxaFRVZHvwMwW5Pg7xXRUxx2i2DABuRcbVXXJSPHqx2mPS6vu4q9Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773846212; c=relaxed/simple; bh=sVd8LTVEHoLKFD1aY4N3BnWCDAMnZxFR8UMGpqAS4sw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BIOa/zbu1PertoERrynet22y+gae6B8ppOSkibnxDaHljT4MQQ7ncgVumgSrcnTS5rwitB4m0y9MSe6edQe0hglvfyZStjNKIRBEDTTWhkukAm9P2ry8X6XOjiMIXW7qnatPhexulgKJzXJVtMbZ+V8OOWs/OVDmJsPq1fMOLWc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fomichev.me; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=74.125.82.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fomichev.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-dy1-f175.google.com with SMTP id 5a478bee46e88-2c0bcd8f194so5425483eec.1 for ; Wed, 18 Mar 2026 08:03:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773846207; x=1774451007; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=S2Eshwmt0Yi5gowTBPApYQhLiCclUhxDbq8BJfNjYyM=; b=CcMnWOc6qxJR8sr++WQE/bLxpwzVs6h64mIOkpMzWyQeOivcy63F4XpVaS84doHHUf kAXo80sT33SF/tEZuIqX4bgZYoDzZ/EnAt979dtPMiU+C5kFf3vQe/MrATn2EAG3al1+ 7rxYJh/YkFGEygk4ZlRPrnC+N8OHfMVgaBnWMkJhvCfohcDMzCiGx+ZSN4qvFb6OEZpL 9owLZR04RSMiKCdyDabcp23lGQwkmC/XqBDEJktFvU6UpAhq3CT1JpAl2gXaFAxkhEoa nUsjBrnpafaT3DdyE/lkxo604Ug96B2PKgrA5p9S8hfdCzKP5Ke6FZptKcJGwd3tBl8/ Ameg== X-Forwarded-Encrypted: i=1; AJvYcCULWC623fqyYxMMbKiAjty7Mx5Gw3YQGpDVMml3+CjwIDvPYePTyigvobn/gikBr9PQI2XzjdyGJRmiRsY=@vger.kernel.org X-Gm-Message-State: AOJu0YwejVXwKhUDBae7KRuKkRN7PlolGd0Am0xFF69lR2ehrhhC9caf rs1lDEa+dDhwUpEL2KsbXJLW15w0UA4kZlEenB76XA+E2DR/01pX/W8= X-Gm-Gg: ATEYQzy2V5ELxfV0XyhfLpm8jLKRziymMpFnZndSi5Zh2hmH2VudYxZjt+43bsMG5yT EejKIo1SCfjZZ8BlWJrzHr4tEcQDRfzGd5d5I2H5Ixc/670wRwQPtlTKhCosk+Z0wdzsNOf4dbA 2G0FsqpeVeBVq0jt63y2eJKT8Iwzbhcz16sypY0L3Kpl6+uWFJF0SHbP91aJInX84lc1f8isdGh kvpH9CDKR3kaAjzJztnNVq9pDYTZEHb/+0FMYsH9EVu+LBS2st6P6RubIYAudUGc4MNnA8Ys0SL 6YcXvU3npjIwkg9d+rR8GvRAWl+CxydcMoFBmv3WA8IcWbPTbi9eXdNJpOV2A7oQqI2NTbJ5JPu DJc6lJSbXV7Pb2qvqrxwB23lCKjoYHa/OrmKvIfsDXbtuKRbxGEDeM2gmCFy4GPTUl6RY8HtdLK +Klr17xkqapuVDK1KiWuHZtIp3x+I+RDS+CRSjoM1Avii8g+ALaZimEWUeiBB8yYUKHjJa8qDJt hwYHA4BK4Gev2oY/g== X-Received: by 2002:a05:7300:fb97:b0:2ba:a3f2:958c with SMTP id 5a478bee46e88-2c0e4dc3156mr1648308eec.0.1773846207075; Wed, 18 Mar 2026 08:03:27 -0700 (PDT) Received: from localhost (c-76-102-12-149.hsd1.ca.comcast.net. [76.102.12.149]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c0e55cd9cfsm3997754eec.26.2026.03.18.08.03.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 08:03:26 -0700 (PDT) From: Stanislav Fomichev To: netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, corbet@lwn.net, skhan@linuxfoundation.org, andrew+netdev@lunn.ch, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, saeedm@nvidia.com, tariqt@nvidia.com, mbloch@nvidia.com, alexanderduyck@fb.com, kernel-team@meta.com, johannes@sipsolutions.net, sd@queasysnail.net, jianbol@nvidia.com, dtatulea@nvidia.com, sdf@fomichev.me, mohsin.bashr@gmail.com, jacob.e.keller@intel.com, willemb@google.com, skhawaja@google.com, bestswngs@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kselftest@vger.kernel.org, leon@kernel.org Subject: [PATCH net-next v2 12/13] net: warn ops-locked drivers still using ndo_set_rx_mode Date: Wed, 18 Mar 2026 08:03:04 -0700 Message-ID: <20260318150305.123900-13-sdf@fomichev.me> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260318150305.123900-1-sdf@fomichev.me> References: <20260318150305.123900-1-sdf@fomichev.me> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Now that all in-tree ops-locked drivers have been converted to ndo_set_rx_mode_async, add a warning in register_netdevice to catch any remaining or newly added drivers that use ndo_set_rx_mode with ops locking. This ensures future driver authors are guided toward the async path. Also route ops-locked devices through dev_rx_mode_work even if they lack rx_mode NDOs, to ensure netdev_ops_assert_locked() does not fire on the legacy path where only RTNL is held. Signed-off-by: Stanislav Fomichev --- net/core/dev.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/net/core/dev.c b/net/core/dev.c index d50d6dc6ac1f..187cd7b5074f 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -9778,7 +9778,8 @@ void __dev_set_rx_mode(struct net_device *dev) if (!netif_up_and_present(dev)) return; =20 - if (ops->ndo_set_rx_mode_async || ops->ndo_change_rx_flags) { + if (ops->ndo_set_rx_mode_async || ops->ndo_change_rx_flags || + netdev_need_ops_lock(dev)) { queue_work(rx_mode_wq, &dev->rx_mode_work); return; } @@ -11470,6 +11471,11 @@ int register_netdevice(struct net_device *dev) goto err_uninit; } =20 + if (netdev_need_ops_lock(dev) && + dev->netdev_ops->ndo_set_rx_mode && + !dev->netdev_ops->ndo_set_rx_mode_async) + netdev_WARN(dev, "ops-locked drivers should use ndo_set_rx_mode_async\n"= ); + ret =3D netdev_do_alloc_pcpu_stats(dev); if (ret) goto err_uninit; --=20 2.53.0