From nobody Mon Apr 6 18:22:51 2026 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1335235F5E8 for ; Wed, 18 Mar 2026 11:07:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773832056; cv=none; b=UK7/pbI9Wp3dVquM3vmH3YesDi35lE9asx+29u5BPtjgHwghH0Imnz+8jZXNxAwSP+wuixAZdZv+Sab2qrjjBiqTN/n4d8bRArY1M/+BOd9s+otZwtn/7/3WgYDMLlgoaogNOetcrV0Xbd0ngi4p0xo6OtY6GtlL7JmLFtqD7JI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773832056; c=relaxed/simple; bh=eJBoZ48Ez5RrV80Z31ro3hsF6HK8BJFcFtu9cv4YWH4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bN8K9W0hSgjC7QZBuAX9JHHpHwMcVLY9ZhnPGxfMzL3EnLPnbMNoKqZUAkQU7Vf56UzZdNZTC/RpWCw4bsXIJXPmY6m1vkMHdO4r1nd8DF0hT2sFcsAulh4TDxbqiHpcAZrocRxCfcS5R1isQhWn6fXcOHuowtbDXBhVNZaiS10= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TmYFPKBw; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TmYFPKBw" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-c7358a7a8d1so4700652a12.3 for ; Wed, 18 Mar 2026 04:07:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773832054; x=1774436854; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3bIIa3h2z/cZqqIYFuGVpDrxnGGpkmrifYRg8XYq0Sw=; b=TmYFPKBwsFgT9a+NBot2MXvfeUJf86Gt4GbHNVL9YbFQFl3v0mOf4pv9QcGRisA9It V3XF2W7VocEL2GLCFKl1xAsrybINjKQvbkDspe6Aix5x3Ar8DPDKkKldBOSzken8TKRh +2bxN+2PWukBA4ze+quXJZCB1NFiR98fMnSFMcEfNG21S+Z11MBL12J6hvYCWmY3Jv4/ w0CuyCkIa2mviVXDdrH/j52L4rMlQ6xPp9ONjd30r5dRmFVBbY+Gk+tMr6/+1pwYlosB 5M60quWz3SaQKNgy7+SmID2lek6/4MDn5IhF6LbN4JPaCmIzjjw9R22B7aTCjxD+NUMz pK1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773832054; x=1774436854; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3bIIa3h2z/cZqqIYFuGVpDrxnGGpkmrifYRg8XYq0Sw=; b=Pd3L77b/YtO4DKzAfL+36MBNJvCOYhxsOdTOzR+8rzighfkabwdKXFyTD+vvDZsRIt XewSqhEWpOC2GbZTMoaBjNX3qsJ2uS2uh54tOoQB2bZ3l3nehvc1nJlHabiKI+z1w6jW LanLBqeOzBoc8SrZrklHeEY+99M0ZQYtuvY2WjC3WuWDRqWEJuklmZdLIHAyjI7CQkDJ IwrgwbTWAXBslmPbwsji2REkeAfvFe3LhRnk6mEgGzGUb806Ym7sVv5EhJe8MF+ZKyJA L8HDDdxGPhE1+Y7OwiyvH7CE7t79akUqGuaUKMJQxODIf9rx/+tml30ZOk1yY8xaVz5L YxWQ== X-Forwarded-Encrypted: i=1; AJvYcCWUG/vxsz4wqmZm4qhohBwLvyHNjh9uZKaTwH5w0dMMCm4/YXRyuGDwzYSKq+6Nn4atU8pCRHCulwqFD8E=@vger.kernel.org X-Gm-Message-State: AOJu0Yyc3aZEoEy+RzYSV0DPrjGvnhGVocyfEIVNVAEK6lgWKljoddU/ su3E7enoJ+Clsd0RX9lMJ4FydCklYDmuzsnOLY5R+qoNomutI3B6Ccc+ X-Gm-Gg: ATEYQzwMIBkOvFef5aTI/1TSGufEU9KlzvhnF052wBMjadLpXtrqYTN0Gw34rRyaJgJ +jNV6nqoOyfhwvB6xWqs7ioXQmSuFmD1QW3/6ZrYAwImkPOiqMlUwxNTm8IgDtaZHZmfpfKvcFV Bh9L0bNDcddr5x2m4aP78pPBEMn+PlU9wzkDpQ68BwFI93Y4OLnSCgum/q09dJHgeCJ7QLWllWh PSZH4a38wv2sIAiVptKKAF5Xj1mPUTOkJlyRwoIqyfcnHEyr91TZEZIQ+cvmOWY/zX/TOJs8kbV jNOHcw/1JP93iWGf1icp6azplbW3dk0vjz4wv3UKKWEkSHFUAnErzmJE8ZHZUdDUNfYYKLDorWm l+laF2FEBbdVnQV+QVe+WD3lucJL3LuG7rQLebeBFQGFMqwssO4GMiKodh8FrlELO5yRV6RxWuI 9DZww9e2BgmZiFOwa8n8H4xETZ X-Received: by 2002:a05:6a21:4603:b0:398:8f2a:5dd4 with SMTP id adf61e73a8af0-39b99d01abemr2840291637.8.1773832054324; Wed, 18 Mar 2026 04:07:34 -0700 (PDT) Received: from ubuntu.. ([152.58.155.3]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c741e0b2015sm2355531a12.6.2026.03.18.04.07.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 04:07:33 -0700 (PDT) From: Anas Iqbal To: mturquette@baylibre.com, sboyd@kernel.org, linux-clk@vger.kernel.org Cc: hayashi.kunihiko@socionext.com, mhiramat@kernel.org, yamada.masahiro@socionext.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Anas Iqbal Subject: [PATCH] clk: uniphier: mux: fix signedness bug in get_parent Date: Wed, 18 Mar 2026 11:02:51 +0000 Message-ID: <20260318110251.2412-1-mohd.abd.6602@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The uniphier_clk_mux_get_parent() function returns a u8, but propagates negative error codes such as -EINVAL and regmap_read() failures. These values are implicitly converted to large unsigned integers, resulting in invalid parent indices. The clk_ops.get_parent() callback is expected to return a valid parent index and does not support error codes. Fix this by returning 0 as a safe fallback in error cases. Fixes: 734d82f4a678 ("clk: uniphier: add core support code for UniPhier clo= ck driver") Signed-off-by: Anas Iqbal Reviewed-by: Brian Masney --- drivers/clk/uniphier/clk-uniphier-mux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/uniphier/clk-uniphier-mux.c b/drivers/clk/uniphier= /clk-uniphier-mux.c index 1998e9d4cfc0..f3b21ea96649 100644 --- a/drivers/clk/uniphier/clk-uniphier-mux.c +++ b/drivers/clk/uniphier/clk-uniphier-mux.c @@ -38,13 +38,13 @@ static u8 uniphier_clk_mux_get_parent(struct clk_hw *hw) =20 ret =3D regmap_read(mux->regmap, mux->reg, &val); if (ret) - return ret; + return 0; /* fallback to parent 0 on error */ =20 for (i =3D 0; i < num_parents; i++) if ((mux->masks[i] & val) =3D=3D mux->vals[i]) return i; =20 - return -EINVAL; + return 0; /* default fallback */ } =20 static const struct clk_ops uniphier_clk_mux_ops =3D { --=20 2.43.0