From nobody Mon Apr 6 18:23:07 2026 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C4CE3A382E for ; Wed, 18 Mar 2026 10:43:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773830622; cv=none; b=oJ5zn3NDYpRNrfDbSxkqP0orlZIRGPcLI1aTSR49ROQB1J3G3Q6oVHFqevKpMotlKUgBL+CQUcVsVxmt0rtJINl0BhPYssn4pFTMyp+lARDxGSdnyoroaoJWYoM9q4NxwFo+O+exvk8HFXn56CtbVYIYeVszPMQecTZACYgbPq8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773830622; c=relaxed/simple; bh=tSa75DmNBHgxIb32B87y+FuiHh+IeKhT3d3d0ekigNY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Y/QkaER+QkPKQaDRtBcJpXsLV2qZ9mp/dxH5EyLfNW0pqp69rSYmQg7f8z4O4z1rEml0MdD8W29cZnrLZJeQ8P7Uw8refV4VEbFECD/NKnpG8hdmvBDj2YffDDR3ZiSTymp9/xXuNkf1rwMCLeQuVKMa8TMM1Gm5rH9r5Q6dgEQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YTWKEMs0; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YTWKEMs0" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-8299f1ca894so396932b3a.2 for ; Wed, 18 Mar 2026 03:43:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773830621; x=1774435421; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3nbNr8wX19bOhUdlfTnz9xtLljp5bOx+5VOL73PtMdU=; b=YTWKEMs0FpQ08JI5sKAxQce1zFZUa4RY10uTuzmwP7u4Py9rSlz1j3s9QVWIEqhXni K2GAdF9FNuU+DBiYiZWdHMhyInI/M/5vSEfCHEEhzTIq53IS7eInDKan0U4j3R6XClyo veJNIQUhEja6EzvswfR0xuHR4FEoWWqBsGWMBzYRS/Fe10vbGLMOkyU5/UiouoyZj2TO umSH+5BomtWbQFQ0StnZu5Z4MpdQKUi0mEOQl6oJMhlvALcA1s54bmGmzOhkN9IAvnkv 2G76FykZIk33t2wPNaQQX7Zhac7JkqiG9qszZ8EAOY0v4FtzZqFZ+3KBCAJh7gltyVn4 e5OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773830621; x=1774435421; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3nbNr8wX19bOhUdlfTnz9xtLljp5bOx+5VOL73PtMdU=; b=UPfMwQYGUCYJlCwnljdYXXE3JuEIESoHuF7mIxZsjkG38yFtpzbgHXaqEH5rAff0v3 xZF3+oT+fTa8CpLI+cOH9gFSDGqPb3+1ItzdLyFH0CNyF+exfHncagwyuAjLzXLrIvSE A4XvgaCsF/bs3Q3eCHL5nMrVeANNx23G2VSNgYOM5jSh8YIqP4hJDqCL59KEEirfvVmT UVMwnm96cJo9hrjdvv4n7DPnLTOxReej71Eq8cTy0LzYGhwt7kvlRzX1IgmSkKPH01wS nI2+nSf2uJ6xYz7pLUwHkskzMi1y46Dnx/wkj57spZ/5e7QMhEFhxT8r0t935mXPApto g+yQ== X-Forwarded-Encrypted: i=1; AJvYcCWjaZ36dxt8DwmEP+eQ+2vRoPzXga26BljxqLYyRcBDNhQ3VFe71qUC+zsX/C50hjhoTVwmvrBwggB84T4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0sDI0TzlgO4J85mD9KogzeKboLypGMNgMqZPALPP+9xW6LyMW Dcgs+Y5nQfehvUyZPhZ1Fsnjr32fzA7fI3tbZ3NppZuT52Kk/YF704Nbo/i+kgXx X-Gm-Gg: ATEYQzzhk6OkuYq5Bx41btgoktjj211Q/dsNmQtUKv6JN/0hfP5TXejudxaKbqAZncA Y+wkNdbyP2q5At8IavepAhOuQm3jMFILW6wJob74fyHB9qmmVR/eLzmZi4gpi03L7YFpUPM/xs+ N59PfhO51TyrYTDJcP+QEqOSWqz7DD8KEvXnFdAMsWDoBjRpXJF7sNXhMlU5AjzWTNLI8TxTM25 zqTs2Wti68QBZX4NcusnIzgLy+V6Sw0CTI3Wtc0SDftH+00P0THpUm6bNmeEOp6uo8nWPHJ2+YB yBPuSgF0oi2UNw9bAdV+2e8HuIn+RTn4ZnmrgPo6RVRggBC9TKs/6958aHUTZzcKYVEGurTi4IQ HYoQSI13g2WbZkvbSK5UXeQDWfcfa6SHtoUaiD5Wh+ElwqyuwqqGq/VLMRxjkqL033shczyA7Pp 72ViS0WKDO446huXaI+MKhgGTwuKsGk8PT4w== X-Received: by 2002:a05:6a20:3d90:b0:366:14ac:e201 with SMTP id adf61e73a8af0-39b9a084f60mr2912713637.63.1773830620538; Wed, 18 Mar 2026 03:43:40 -0700 (PDT) Received: from aadarsh.. ([2401:4900:8811:147c:fe7f:9683:3d75:702e]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-82a6bbe7cc9sm2342886b3a.48.2026.03.18.03.43.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 03:43:40 -0700 (PDT) From: Aadarsh Mandal To: gregkh@linuxfoundation.org Cc: luka.gejak@linux.dev, dan.carpenter@linaro.org, ethantidmore06@gmail.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, straube.linux@gmail.com, Aadarsh Mandal Subject: [PATCH v3] staging: rtl8723bs: remove dead code Date: Wed, 18 Mar 2026 16:13:31 +0530 Message-ID: <20260318104332.32093-1-aadarshmandal9354@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260318092639.27055-1-aadarshmandal9354@gmail.com> References: <20260318092639.27055-1-aadarshmandal9354@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" remove unused and commented code=20 no changes in functionality Signed-off-by: Aadarsh Mandal --- v3: - regenrated patch from the clean tree - removed unwanted addition v2: - accidently added the functions in the {} blocks v1: - some commented code wasnt deleted. Note: * This patch is part of the GSoC2026 application process for device tree bi= ndings conversions * https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device= -Tree-Bindings drivers/staging/rtl8723bs/hal/sdio_halinit.c | 21 ++++++-------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index 063a0737933e..8fbb46b3019d 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -68,8 +68,8 @@ u8 _InitPowerOn_8723BS(struct adapter *padapter) rtw_write16(padapter, REG_APS_FSMCO, value16); =20 /* Enable CMD53 R/W Operation */ - rtw_write8(padapter, REG_CR, 0x00); =20 + rtw_write8(padapter, REG_CR, 0x00); /* Enable MAC DMA/WMAC/SCHEDULE/SEC block */ value16 =3D rtw_read16(padapter, REG_CR); value16 |=3D ( @@ -210,7 +210,7 @@ static void _InitNormalChipOneOutEpPriority(struct adap= ter *Adapter) struct hal_com_data *pHalData =3D GET_HAL_DATA(Adapter); =20 u16 value =3D 0; - +=09 switch (pHalData->OutEpQueueSel) { case TX_SELE_HQ: value =3D QUEUE_HIGH; @@ -338,7 +338,7 @@ static void _InitTransferPageSize(struct adapter *padap= ter) /* Tx page size is always 128. */ =20 u8 value8; - +=09 value8 =3D _PSRX(PBP_128) | _PSTX(PBP_128); rtw_write8(padapter, REG_PBP, value8); } @@ -482,7 +482,6 @@ static void _initSdioAggregationSetting(struct adapter = *padapter) struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); =20 /* Tx aggregation setting */ -/* sdio_AggSettingTxUpdate(padapter); */ =20 /* Rx aggregation setting */ HalRxAggr8723BSdio(padapter); @@ -636,7 +635,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) } =20 /* Disable Interrupt first. */ -/* rtw_hal_disable_interrupt(padapter); */ =20 ret =3D _InitPowerOn_8723BS(padapter); if (ret =3D=3D _FAIL) @@ -656,8 +654,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) =20 rtl8723b_InitializeFirmwareVars(padapter); =20 -/* SIC_Init(padapter); */ - if (pwrctrlpriv->reg_rfoff) pwrctrlpriv->rf_pwrstate =3D rf_off; =20 @@ -742,8 +738,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) =20 /* Record original value for template. This is arough data, we can only = use the data */ /* for power adjust. The value can not be adjustde according to differen= t power!!! */ -/* pHalData->OriginalCckTxPwrIdx =3D pHalData->CurrentCckTxPwrIdx; */ -/* pHalData->OriginalOfdm24GTxPwrIdx =3D pHalData->CurrentOfdm24GTxPwrIdx;= */ =20 rtl8723b_InitAntenna_Selection(padapter); =20 @@ -786,7 +780,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) /* ack for xmit mgmt frames. */ rtw_write32(padapter, REG_FWHW_TXQ_CTRL, rtw_read32(padapter, REG_FWHW_TX= Q_CTRL) | BIT(12)); =20 -/* pHalData->PreRpwmVal =3D SdioLocalCmd52Read1Byte(padapter, SDIO_REG_HRP= WM1) & 0x80; */ =20 { pwrctrlpriv->rf_pwrstate =3D rf_on; @@ -1068,20 +1061,18 @@ static void _ReadEfuseInfo8723BS(struct adapter *pa= dapter) static void _ReadPROMContent(struct adapter *padapter) { struct eeprom_priv *pEEPROM =3D GET_EEPROM_EFUSE_PRIV(padapter); - u8 eeValue; + u8 eeValue; =20 eeValue =3D rtw_read8(padapter, REG_9346CR); /* To check system boot selection. */ pEEPROM->EepromOrEfuse =3D (eeValue & BOOT_FROM_EEPROM) ? true : false; pEEPROM->bautoload_fail_flag =3D (eeValue & EEPROM_EN) ? false : true; =20 -/* pHalData->EEType =3D IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EEPR= OM_BOOT_EFUSE; */ - _ReadEfuseInfo8723BS(padapter); } =20 /* */ -/* Description: */ +/* Description: */ /* Read HW adapter information by E-Fuse or EEPROM according CR9346 report= ed. */ /* */ /* Assumption: */ @@ -1144,7 +1135,7 @@ void SetHwReg8723BS(struct adapter *padapter, u8 vari= able, u8 *val) case HW_VAR_SET_REQ_FW_PS: { u8 req_fw_ps =3D 0; - + =09 req_fw_ps =3D rtw_read8(padapter, 0x8f); req_fw_ps |=3D 0x10; rtw_write8(padapter, 0x8f, req_fw_ps); --=20 2.43.0