From nobody Mon Apr 6 19:44:46 2026 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 507013B7B86 for ; Wed, 18 Mar 2026 09:29:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773826200; cv=none; b=LrilqVxS5SwQ9RmFfBGUFP7kBHzW75ZRF0QTCnBFW2fcaf98oXLoRcWBxHplWUoE+H1Atj/ayGO3ck84aTdncgojU6R/fl6lwmdRkDGfYFSJiCmdI7p5JnF77ZoV5mOcWDzGQ7XxIIKi+YSRrpzW0rEGQeyD02FQTn8Xz/Jo4dA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773826200; c=relaxed/simple; bh=pRd86ixJCsIKMhFYIEKfaVMan2Ea5weBwsSCy5N7fHc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=UYHsalR929867Vs4y2P8QgasPdGkeub0ZIk1z4CxQIf/KJE0vir8P0yN7x/8+HY0Yp8GpEcVnLIJGz/y0tOT3+2ogmvwkINhPrjUP0LwR25PPsUZ2S8cuED5bGqRiBnQWuCDzpNlfL3KY0gxTPCBjotvvgnQ6KvFz+o+hXFr49c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f73HQSMl; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f73HQSMl" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-c73e9e4cdf7so2267344a12.2 for ; Wed, 18 Mar 2026 02:29:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773826195; x=1774430995; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5FT3FCWE6d/BfnmV6V9NTfwQvybJ7Oe0ujhNN4DmJ54=; b=f73HQSMlulRLagBtJc98PwMTa9Wsejt/Q86wDSG/iSq24v6CGFnaaJlXKOudSZwxfw XZdC5plIre3Big5KcDYZa31rahN+wVlO+ewOetKIUZX07X9oSTPQoWAV0EKHEY3BAa5J fy8YqXtd4lh8tP/cwyfuHVXEu2fWoYOW/vskxJgJd9hPfMtMK0jqL4NySGYle8GfOX91 l/LS2AiWtMgypPu2jeZB/v+oMrGfPvZ8aueHn3GQ2bGoHJqRrCyFnfK7P/QR90d8Tvfv KBqiuqIihwFxF1njy86RVFhI1jXPUQlWRm7hmHBdQN3ESDKCo6M3CdgOeAT//wE5Knoi 8TWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773826195; x=1774430995; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5FT3FCWE6d/BfnmV6V9NTfwQvybJ7Oe0ujhNN4DmJ54=; b=cUBcyZZZP+Ii5hGvcKHC/Et21cP9wkSVKRjquVR6na0M6FL7yfHq9/emxZWupr9o2o LNbuRwXBi9qFuO3GsGh+DXfXbq4ygxfJzJhdH2Fo6ckDpL1M7eTSQLtyvh3B53/oK5Ea SDDBEmyZ4nNAbG2BeApmV2H5Ttx6ob6yn8nQYmbNGHHpFWzFAOPjMMIoM5XWzmdpkXKn NJsHKdVl72Ktw6tpRAyX0n5Weu0lI+vI6asgThtdTTv8kmhzDMXe2HbEqNAm2E/Tjrai i94WqCWR9trxYVWOl0wwSli+jxFiqtqK9Lypjl0tpcjfukvx7IUphA1XZCv+6wWfqT4I LbiQ== X-Forwarded-Encrypted: i=1; AJvYcCVtH2KXaL5cbSR48Vew17ItbwiQuLJ1j8dSg79LVqlFg/HtBV6Lnm0NARMCe7kEjphSKdprQKRrOT0HO8g=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3ZlbT4TACl0vzdc8SbFBdivoWqt4dIevLUCxA5AaGnpbQrnC/ 0M5Ty/sTdO86TB26nIMJEw4uMpy8A+Not27p/BVkdKoxmh7WBe+Bums9 X-Gm-Gg: ATEYQzxFJ3qs846fQb55y1yUG2SuAJ3S/Eo3EtbcXjwqOOiAUmD6nReB+reQsWs4wTE oKvkOiEy8T1fKTuEzY5owj4cyBvNUn5Ty/BoOszWohyMvHoCknyRr3LWoHWBYrIJsQHOSiRxLU9 dtwuPUzxInDC/FhCJxj8IdBP3BcSXf8W5FUvRG24yXzpxXMR6NBmI4A6zAJ7n3gn8mkKCjOnwJQ ptNH9ml7Bcjla21ZdKYDg0UYr9ol9qpLBzF2xmVqvjVT099n+W1l1MEXC/O+pZXv+cdmSfLMz0s kMmDijS1Zfd6m+mwNSsMu0T0LLQPNrTdEOlCMjX53GSsIm4Ov7zR9LNONuNIotCsvgj11A3d8S8 Y2JO3aHuA8ys9+FR/q5ZvVbF+b7Gtdj/iqnLJSaD+yAKPJCBXI9M/FHoQ1NIB4GOD2SK6IDQ6uS tc9MMC1B+EnePGtdGrlLfWSKhJSwGXEuqfkW78fnenDJQt83w4kEWqzsU/CZHDA+PDrKspjfdT X-Received: by 2002:a17:902:f708:b0:2ae:4445:f39a with SMTP id d9443c01a7336-2b06e2fbf94mr27636655ad.7.1773826195304; Wed, 18 Mar 2026 02:29:55 -0700 (PDT) Received: from debian.ari ([152.58.182.62]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b06e616351sm21168315ad.67.2026.03.18.02.29.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 02:29:54 -0700 (PDT) From: Archit Anant To: jic23@kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Archit Anant Subject: [PATCH v5 3/4] iio: adc: ad799x: cache regulator voltages during probe Date: Wed, 18 Mar 2026 14:57:14 +0530 Message-Id: <20260318092715.42538-4-architanant5@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260318092715.42538-1-architanant5@gmail.com> References: <20260318092715.42538-1-architanant5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Reading the regulator voltage via regulator_get_voltage() can be a slow operation. Since the reference voltages for this ADC are not expected to change at runtime, it is inefficient to query the regulator API every time userspace reads the IIO_CHAN_INFO_SCALE attribute. Determine the active reference voltage (either VREF or VCC) during probe() and cache it in the state structure. This improves the performance of ad799x_read_raw() and removes the dependency on the regulator pointers during fast-path reads. Suggested-by: Jonathan Cameron Suggested-by: David Lechner Signed-off-by: Archit Anant --- drivers/iio/adc/ad799x.c | 24 ++++++++++++++++-------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/iio/adc/ad799x.c b/drivers/iio/adc/ad799x.c index 7504bcf627da..ae2ad4bd37cc 100644 --- a/drivers/iio/adc/ad799x.c +++ b/drivers/iio/adc/ad799x.c @@ -30,6 +30,7 @@ #include #include #include +#include =20 #include #include @@ -135,6 +136,9 @@ struct ad799x_state { u16 config; =20 unsigned int transfer_size; + + int vref_uV; + IIO_DECLARE_BUFFER_WITH_TS(__be16, rx_buf, AD799X_MAX_CHANNELS); }; =20 @@ -302,14 +306,7 @@ static int ad799x_read_raw(struct iio_dev *indio_dev, GENMASK(chan->scan_type.realbits - 1, 0); return IIO_VAL_INT; case IIO_CHAN_INFO_SCALE: - if (st->vref) - ret =3D regulator_get_voltage(st->vref); - else - ret =3D regulator_get_voltage(st->reg); - - if (ret < 0) - return ret; - *val =3D ret / 1000; + *val =3D st->vref_uV / MILLI; *val2 =3D chan->scan_type.realbits; return IIO_VAL_FRACTIONAL_LOG2; } @@ -828,9 +825,20 @@ static int ad799x_probe(struct i2c_client *client) ret =3D regulator_enable(st->vref); if (ret) goto error_disable_reg; + ret =3D regulator_get_voltage(st->vref); + if (ret < 0) + goto error_disable_vref; + st->vref_uV =3D ret; } } =20 + if (!st->vref) { + ret =3D regulator_get_voltage(st->reg); + if (ret < 0) + goto error_disable_reg; + st->vref_uV =3D ret; + } + st->client =3D client; =20 indio_dev->name =3D id->name; --=20 2.39.5