From nobody Mon Apr 6 19:44:46 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB8DC3A7F6B for ; Wed, 18 Mar 2026 09:29:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773826197; cv=none; b=KLFBNyiPC0Swu1juJ/sYObDgt0a4kphIOiSWg31goqccprYp7mLmtFMgFZ4y+hXrVm/K6vtqVDWw2BF4QM31zohIIGOmvfJ9+oqfT6LCobDWthRy87yKeVCftlqiCB/ytUnyo1kETwKy+vtJQoarrcrTemt69m6I+LMwNRYWuIU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773826197; c=relaxed/simple; bh=YeA5NTit+vRgO6O7UM7usIAyOEi9ktUs3te+RyJJPCc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PiSDsxEUcKEidhIYMOpQC1Sn8TVKSN270DZWKGMMfrhe2tpJ6u/4+eVV569PGY6px0WJZUvoLwpy4IWLO38L7U3o5AOP8BRtg5zxg/+l+ml1UEOi86D1Brlpi/mj7ZvTJd77nkvK0XgpY4joTtQuJptR2kKGnLYXqf6WMV1kNHs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g7xh4Bcb; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g7xh4Bcb" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2b0586d5bb8so21745515ad.3 for ; Wed, 18 Mar 2026 02:29:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773826191; x=1774430991; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=V7lW8LFGu1hdwVKAacX1pBoH1829SaNw1Lo72wdjeU4=; b=g7xh4Bcb4gqqNnVVvNpUHt9mKxhVcQfevQ+1J8Us/shLocSleLAhyz73N/6X9MojeV YLQ31TLU0BpAyHjV2pwPxZiFvOx8aZxYj9Wc+EWbFxDFtmpaUwklJwZb/g5yUrlx7msb xTRNOfkpP1uqJe2GePxvKR2ho4lBbqEgdDbRDRolIKOsFklRaz58hl5XFmbSfEuegVct NvtB4Qas4v0JTuVBIXr9ZXIXSjOw0SVqrhEBG4PUfEVFAnxk/5+IC4y+hG8GyYWRv1pX oKVicfgJVIPQIcIc6wPEtm2hmCrfpm/WIABv4anZovu6vDWFlnGMyU6CtlAVO7Ks0kjt RCBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773826191; x=1774430991; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=V7lW8LFGu1hdwVKAacX1pBoH1829SaNw1Lo72wdjeU4=; b=JifmELqM9V3KvHw8Zlt9ErUPysoJF8dZcvFrM9pqWSD2ESRn2Kb75lChXxu2nu9gug zaf1yHeM1QqvWngOEkiEJxoTJnw+jGFTwaIVwB9xkUpskqtYQp+Fu/pbEi4vtAktGnO9 iE/ig9MymdLwK8s/tgubO6XoijB7p2THqo4Q3VaGTbmGs+KIuFOuiGlhnBZLCFv4m+B+ DCu+987McquNTyP1WwYeV5YARYxyWZAxYeZ5kXEF/JQMCQ22ckVG7wbq+kRMYnb4qe9U YZ03coiiICVazG7RJjawrp0Xivsvc+k9Qnx0xzkDq37hMAHySVezyZE1WmFdiIGWEV4q DJDA== X-Forwarded-Encrypted: i=1; AJvYcCWvfkXW64qUS6TFuyY0ny4I7uyDSziRVLstgIgnSfueLXuNkVULf+7T86QmP3F34iL6jtsytmxSMCEVz+s=@vger.kernel.org X-Gm-Message-State: AOJu0YxqDhoffu4xTzoLwtbELf5dBWx65S1ab6H63GEzhjzksjRqj73j 5dkTgYtEIG+m48owtLbwUMHPcArsfsZGfM97egH47xTl+X9UtpP4Wiay X-Gm-Gg: ATEYQzzEoevMYO0+BjkMDHBtsSQ5aV3tzKxmnvTTnkcnfO8NffoD0RWAIphR9FN5aSv WDjK+Q4c2wWD1ph/ZTwQcQ+YIJ8MAKvoIdFFHuKb6mFHCDxw75vMHeZjU+qk4qB/hAHapo1k5Tv Ev4GHYKlx4G/pHzivQqysQJVHKCdLLcmEMFtaCHLLG9/7eYcBSfCHw9k0U+TrH7pM2IfTITotRg qSIcGf5iFVCHw7mb1H2IP7cCsONQm0oRQ9rlcG88te65kE+7TMQekVeHsNsrOXlakXm5sfUI5L6 +/DR3MK/oXKO0ZJKmUnl+XGUHxoccWhCwZb6Q57MaGlYAunfI+/kQ7xBhjBOgpzjY0Lgfl+r8ev 6WVtPWjD0BS6t5OenCSjNCGbFoG5Yjru92jwhzaYdqt2GS9En6B0XzGJlxmu1Acve42FLVHPSiA cwG0BUMm6EgbWcMITDyThiHEEdmpV+zjJaM31jT5DNmyokBZjLZB6sCFMI9W4CCM1jIJs63ZHsn Upv4FkS90Q= X-Received: by 2002:a17:903:1a67:b0:2ae:3b9b:db34 with SMTP id d9443c01a7336-2b06e41a91emr26532705ad.42.1773826190696; Wed, 18 Mar 2026 02:29:50 -0700 (PDT) Received: from debian.ari ([152.58.182.62]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b06e616351sm21168315ad.67.2026.03.18.02.29.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 02:29:50 -0700 (PDT) From: Archit Anant To: jic23@kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Archit Anant Subject: [PATCH v5 2/4] iio: adc: ad799x: use a static buffer for scan data Date: Wed, 18 Mar 2026 14:57:13 +0530 Message-Id: <20260318092715.42538-3-architanant5@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260318092715.42538-1-architanant5@gmail.com> References: <20260318092715.42538-1-architanant5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Currently, rx_buf is dynamically allocated using kmalloc() every time ad799x_update_scan_mode() is called. This can lead to memory leaks if the scan mask is updated multiple times. Drop the dynamic allocation and replace it with a static buffer at the end of the state structure using IIO_DECLARE_BUFFER_WITH_TS(). This eliminates the allocation overhead, prevents leaks, and removes the need for manual kfree() on driver removal. Signed-off-by: Archit Anant --- drivers/iio/adc/ad799x.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/iio/adc/ad799x.c b/drivers/iio/adc/ad799x.c index 9825abc9285d..7504bcf627da 100644 --- a/drivers/iio/adc/ad799x.c +++ b/drivers/iio/adc/ad799x.c @@ -39,6 +39,7 @@ #include =20 #define AD799X_CHANNEL_SHIFT 4 +#define AD799X_MAX_CHANNELS 8 =20 /* * AD7991, AD7995 and AD7999 defines @@ -133,8 +134,8 @@ struct ad799x_state { unsigned int id; u16 config; =20 - u8 *rx_buf; unsigned int transfer_size; + IIO_DECLARE_BUFFER_WITH_TS(__be16, rx_buf, AD799X_MAX_CHANNELS); }; =20 static int ad799x_write_config(struct ad799x_state *st, u16 val) @@ -217,7 +218,7 @@ static irqreturn_t ad799x_trigger_handler(int irq, void= *p) } =20 b_sent =3D i2c_smbus_read_i2c_block_data(st->client, - cmd, st->transfer_size, st->rx_buf); + cmd, st->transfer_size, (u8 *)st->rx_buf); if (b_sent < 0) goto out; =20 @@ -234,11 +235,6 @@ static int ad799x_update_scan_mode(struct iio_dev *ind= io_dev, { struct ad799x_state *st =3D iio_priv(indio_dev); =20 - kfree(st->rx_buf); - st->rx_buf =3D kmalloc(indio_dev->scan_bytes, GFP_KERNEL); - if (!st->rx_buf) - return -ENOMEM; - st->transfer_size =3D bitmap_weight(scan_mask, iio_get_masklength(indio_dev)) * 2; =20 @@ -896,7 +892,6 @@ static void ad799x_remove(struct i2c_client *client) if (st->vref) regulator_disable(st->vref); regulator_disable(st->reg); - kfree(st->rx_buf); } =20 static int ad799x_suspend(struct device *dev) --=20 2.39.5