From nobody Mon Apr 6 18:53:34 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F30C3399024 for ; Wed, 18 Mar 2026 08:42:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773823352; cv=none; b=FWYJneHGahCNXpoyGM0cxkAl4uiBftlFTcMvAIk/2ldUqHjL/vErL0bJwOnp8xzCXKmullzyip85tGvp28r8931R3uxhbelhk3gRNX2N07RQRldVg3YQWhYtXFohKeOZA+PToGf7wDSEdg9qPkh9U04k5KvVjssuTHMt1m4qqpA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773823352; c=relaxed/simple; bh=FLSNbXbJ1wplfBqtjcLyvhHCLsdlffFOB/yceOu8h2M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=c1/B3iFF9Vhbbel0oQhLYo1R6b8Df93O/0q1+hYjX2LsiK7WHr4S3G8xv4/GQ/KY2btV5Ic8OANY6GsAB4oMbLWBKkWbkDiXQsjezScehhhv6KAg5qINy8m1AK0Ib3EiFVN6AbHcQ6FJVwnsg8+ERrnpY4b5+JXFtcKyFTomLag= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KlvTfxqS; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KlvTfxqS" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2ad9516a653so28473535ad.0 for ; Wed, 18 Mar 2026 01:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773823347; x=1774428147; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gacjDmEMQGmdBNRvJ1O5mHVdwFG2Gz17UEE6HRUs/Vw=; b=KlvTfxqSynKLuGflo1wectB1GS+4afX9H+7oojc3q+KkXzu8opEaTa8jGxWZyp61Vf Ygk3lEqKG8eQ87eLTWtxiaK4gkkFXjEIC7SqLjwntd1DUzyojmD8WtBlSCjcy6ahx9tl WFg/uDgAeWd5ILtnGNisMH8OtYOcaYmdsbKuJGcE0HdHpU+AMkUZpR81VM01xygme1Lg pW91Hnt0DJM45zR5ob0gX12lmeNPa/5jNjPICO0YAWUgexW6oNaDHblR4Z700x3xiEoX sOtPsq3iZqi640CzQtPrFq7E+if2b6f5baKFTO5FgtnJej24EeGor2Hfq6bE94pkbctA pluA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773823347; x=1774428147; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gacjDmEMQGmdBNRvJ1O5mHVdwFG2Gz17UEE6HRUs/Vw=; b=GUsmu1Pu0Q17/DlWIwMZybeSXliPNPPzNTTuVF5Cpz/QdHzynNUVSnolC8nE/61O4E n/mb9yX13II/MP61FKDkkZlPeSVuFf2OWUbLWm194EQ6BgeElfTLfKG5mwSbzu3q6fFX fPJJmXM36rbYguEA1gzpUSDgDsNVLlMX07qicPxhuLpwEXzAjYcrfoxiMNQwDHawF39B E8KpwOuX5l5rkF5maAqEUrb3223P9kS0VBnjMp+1pk4/yDOm08rOttwCEPKnXiC50cfl c+2Uttghw7JpQp1DUUg2l6GnIv4bZOye/SKpRPdipYYoKlcF441M5GbYYowQclQRId7y UXKg== X-Forwarded-Encrypted: i=1; AJvYcCVZfcfYRR4tWJhOW3kDlxP5kZnKDS1q41qY/Gv2N/H2RufxJo7X0AYTPf417wTVPpcuAnAUbjz4kCDHVPE=@vger.kernel.org X-Gm-Message-State: AOJu0YwfwMWQ/JqmKTXzqjbBxsNzBW6eD7zBMCYO7wLhSvgehXbupvoS NUmuIPS0cV5n0Ey/YEw0uNAsCAAMUFEK1saFb5k1ZANAZI/5Rlij+tr0 X-Gm-Gg: ATEYQzxe2CI+ehADZjWTlCyPPPWZYh8GE9uRvzdG3YsoSXAjrzCEHr8NgVx2r2q5EQo h6c2V61s00q/NoJiIzVkSawWo8fVwFoV8EVTmrOSjPEMCJXiGRph0lw8Jv4qgc6LPn40yGOvakR zIbdjnjZQi06mJ9JeJgITmvUMIfPZLESMlwSXJMoeiOg2DwUl++3eLg/xwC/RvD/8k1q5xdiI+7 G0OnXZiPBreZDPv87vITkaDNCRHN254H4gmpquVP+qNV9jtkixCvjr9/ybh89jWHm5I1wLJL6oJ Ej1wrcl/2nRBgD2b48JzWxp0KrfSfy1DmYRxpNIHaYLGCPtkXb10YNqu09YedA3oDewnxxV28XA rUCXj2CvgT6yBUxc2UGGxwAkUlqd4W1yulUalZ0CK94nZImcA9q7WmXrcEuajM4QQnC++cKs2la 9VKUc7zo4JFACgp7Hv0kjf+RiK X-Received: by 2002:a17:902:d4c5:b0:2b0:6ba2:3d3a with SMTP id d9443c01a7336-2b06e30a339mr25574145ad.14.1773823346954; Wed, 18 Mar 2026 01:42:26 -0700 (PDT) Received: from ubuntu.. ([152.58.155.3]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b06e5f0ac2sm19580465ad.52.2026.03.18.01.42.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 01:42:26 -0700 (PDT) From: Anas Iqbal To: jonas.gorski@gmail.com Cc: florian.fainelli@broadcom.com, andrew@lunn.ch, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Anas Iqbal Subject: [PATCH net v3] net: dsa: bcm_sf2: fix missing clk_disable_unprepare() in error paths Date: Wed, 18 Mar 2026 08:42:12 +0000 Message-ID: <20260318084212.1287-1-mohd.abd.6602@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Smatch reports: drivers/net/dsa/bcm_sf2.c:997 bcm_sf2_sw_resume() warn: 'priv->clk' from clk_prepare_enable() not released on lines: 983,990. The clock enabled by clk_prepare_enable() in bcm_sf2_sw_resume() is not released if bcm_sf2_sw_rst() or bcm_sf2_cfp_resume() fails. Add the missing clk_disable_unprepare() calls in the error paths to properly release the clock resource. Fixes: e9ec5c3bd238 ("net: dsa: bcm_sf2: request and handle clocks") Reviewed-by: Jonas Gorski Reviewed-by: Florian Fainelli Signed-off-by: Anas Iqbal --- v3: - Add Fixes tag as suggested by Jonas Gorski - Add Reviewed-by from Florian Fainelli - Add proper separator (---) for changelog --- drivers/net/dsa/bcm_sf2.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c index 960685596093..de3efa3ce9a7 100644 --- a/drivers/net/dsa/bcm_sf2.c +++ b/drivers/net/dsa/bcm_sf2.c @@ -980,15 +980,19 @@ static int bcm_sf2_sw_resume(struct dsa_switch *ds) ret =3D bcm_sf2_sw_rst(priv); if (ret) { pr_err("%s: failed to software reset switch\n", __func__); + if (!priv->wol_ports_mask) + clk_disable_unprepare(priv->clk); return ret; } =20 bcm_sf2_crossbar_setup(priv); =20 ret =3D bcm_sf2_cfp_resume(ds); - if (ret) + if (ret) { + if (!priv->wol_ports_mask) + clk_disable_unprepare(priv->clk); return ret; - + } if (priv->hw_params.num_gphy =3D=3D 1) bcm_sf2_gphy_enable_set(ds, true); =20 --=20 2.43.0