From nobody Mon Apr 6 21:17:54 2026 Received: from va-1-113.ptr.blmpb.com (va-1-113.ptr.blmpb.com [209.127.230.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B6662FE057 for ; Wed, 18 Mar 2026 04:59:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.127.230.113 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773809964; cv=none; b=Kqv9Qmvo6azlMegyY11rzStzr6FVF5I+hXstCsG0YwGNAicrTZk9P67k9al6l5j/zXZSOrrYn4YxcQX5ANX8Wx97hGBM7iIO4xeJut6DQ7oTF8NU5fisybbXjUuE5iPlM4nKVGmh3MHLqJeGmG6jBTkq6e818wb3Y9r15Fq3kYo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773809964; c=relaxed/simple; bh=Qa9IpuSjSfpTtmS0nJfwKeG6oQYGbdwsouDwUnE2vi8=; h=To:Cc:Mime-Version:References:From:Date:Message-Id:Subject: In-Reply-To:Content-Type; b=DXtg08oP6VicHjaRQ+gzcqJX5zg6ciztQTMt5VKZOVDwbnoUgSDYnFgj4hmzlqMo+Sg9hlQuZmyMG2Pm1UfY6BJT86/+CNDvLXEAJivHrVopRtngvCJdMsSH/kYwaHoEimox9iqvbl6AvLHb3qgebNJYw4X3b9Jq+i47rUWAaKI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=VYv2eb7Y; arc=none smtp.client-ip=209.127.230.113 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="VYv2eb7Y" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=2212171451; d=bytedance.com; t=1773809959; h=from:subject: mime-version:from:date:message-id:subject:to:cc:reply-to:content-type: mime-version:in-reply-to:message-id; bh=0usi0H2e8tYtT63WQwB8R/fMy+WKcYDOp5mE7Fo7UFU=; b=VYv2eb7Y6MCWMHnVpNO3AKOL9o8ivDUH9Ric3fDEgJ5CVmO1PSZszJn0VBhS+1XBajza5G U18A3q+wSDfIOyosfPhxRBMhTKwi1JsMd5n0Vu4y8MpY9BEWCSMl3OjA6nVExkQyB1DAWt Q0oN8eqiBLdBPp0hiPBlLwYNLrER/iPiiN6ZhE1zJ6zEuZ1yQZ+iq/bcQxHIwtxEOzzM+p hJ2Wl/HWguNZ+jdSxQ+YgfG3OMVM364eoYP/npc5tlH/mvQydRPyYrfmBaRzYMzBCiYW62 kJffmFhzMkR5m2IpGDcSy/njCdCubnsMW7Af3opDxSTqmvPRshO36fnQ24cpXA== To: , , , , , , , , , , , Cc: , "Chuyi Zhou" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Lms-Return-Path: X-Original-From: Chuyi Zhou References: <20260318045638.1572777-1-zhouchuyi@bytedance.com> From: "Chuyi Zhou" Date: Wed, 18 Mar 2026 12:56:35 +0800 Content-Transfer-Encoding: quoted-printable X-Mailer: git-send-email 2.20.1 Message-Id: <20260318045638.1572777-10-zhouchuyi@bytedance.com> Subject: [PATCH v3 09/12] scftorture: Remove preempt_disable in scftorture_invoke_one In-Reply-To: <20260318045638.1572777-1-zhouchuyi@bytedance.com> Content-Type: text/plain; charset="utf-8" Previous patches make smp_call*() handle preemption logic internally. Now the preempt_disable() by most callers becomes unnecessary and can therefore be removed. Remove preempt_{enable, disable} in scftorture_invoke_one(). Signed-off-by: Chuyi Zhou --- kernel/scftorture.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/kernel/scftorture.c b/kernel/scftorture.c index 327c315f411c..b87215e40be5 100644 --- a/kernel/scftorture.c +++ b/kernel/scftorture.c @@ -364,8 +364,6 @@ static void scftorture_invoke_one(struct scf_statistics= *scfp, struct torture_ra } if (use_cpus_read_lock) cpus_read_lock(); - else - preempt_disable(); switch (scfsp->scfs_prim) { case SCF_PRIM_RESCHED: if (IS_BUILTIN(CONFIG_SCF_TORTURE_TEST)) { @@ -411,13 +409,10 @@ static void scftorture_invoke_one(struct scf_statisti= cs *scfp, struct torture_ra if (!ret) { if (use_cpus_read_lock) cpus_read_unlock(); - else - preempt_enable(); + wait_for_completion(&scfcp->scfc_completion); if (use_cpus_read_lock) cpus_read_lock(); - else - preempt_disable(); } else { scfp->n_single_rpc_ofl++; scf_add_to_free_list(scfcp); @@ -463,8 +458,6 @@ static void scftorture_invoke_one(struct scf_statistics= *scfp, struct torture_ra } if (use_cpus_read_lock) cpus_read_unlock(); - else - preempt_enable(); if (allocfail) schedule_timeout_idle((1 + longwait) * HZ); // Let no-wait handlers com= plete. else if (!(torture_random(trsp) & 0xfff)) --=20 2.20.1