From nobody Mon Apr 6 20:29:20 2026 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93816267B90 for ; Wed, 18 Mar 2026 02:10:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773799819; cv=none; b=GrGBrXRLjKFopA+EopyXqBO9cVcE1uznjpafXfosgxtyR9GvMKJRjl693I/YVAj0Bf5v2MNT5CVJ/nDo9cbQfH6miKhljKvHGXkirCAEenJVGBVP6ImyxuEVTviVE3vGxHiHJHlGg6C7LcJPexPiAFRS6GRbWWeZjLk/ur0Ka2U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773799819; c=relaxed/simple; bh=4O53qfF/IbTPc+o2SNdhd96beWrfWs30IF47/bDTI3o=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=osXRyGNuGrBl5KIBRZ5NMMXJgKRPQGV0KTimls4Rq3srOxPg+gnN8dEX8cLfXMCfeKcdcucdqoaIAy+oEhwDYVey7Mvg7zrALTvWGsLAPZca2/L32fNWewt8BZThUVEv9l3Wt517SAOT+wtU8BP9n52sgjNc9t9K5VNeZvqKCTU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lAfyp/pU; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lAfyp/pU" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-82a07738118so3706189b3a.0 for ; Tue, 17 Mar 2026 19:10:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773799816; x=1774404616; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wZF45FPlZkKXx7FWrcZ0HH07OhL9LF0KsZg6tSsoZIE=; b=lAfyp/pUiw0agwJCz0xeovr+LVRCVKFqpetrAaXujkX3ydRqxLoWk2EVBrxXIUfsUT nLzcOScNm2+L+52zZtbbTEj47asdtiW1oWrf/dOdRXArX9zdZUqhoDsjDGWO1qunE2b6 6nGdzsCS6sHxf+VsAFLaqiEmqWcRNuft1x0eZtRkOM5nLvq6alo9JqbVBbVKA/M3bDK6 +6uQ8rsTnJG5+3331v8293BEi59Hw+8CGlauv5ROywp/f6V7kzTKQsHOfzksriVX7FLs g2CSD8k9CBMvU1XX2zmEMNLmbXcRiMJFFSUp9n/YvTJnTodSXEpVNtJIu9SJ4wW/FXAN uKbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773799816; x=1774404616; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wZF45FPlZkKXx7FWrcZ0HH07OhL9LF0KsZg6tSsoZIE=; b=ciLCJGK173aed9+KcHiF0O5QD4p0Yb2Gt4dqNPl4MasWHxIgiaIE0XIgP1mfyK5Y2D woI6vkYvPhnN1OIad/cLUhXDe8/U6+7tX2ErlaZNQ3xY4JUrfS/drReqAe5+lenuyXVV 9Y7wa9+Yqd/hXG68WOgay8r+92/ibjeXmuZPqd7sFIiUk4i8CO+wLLetTaKLe/xO5DDK KEDeXOU0OkuyPfEPyTs0LstmUzVc1EPsTfKK9Qd+jsqjBBBUvyrm4A2dfbyQAM9IhFV8 wwhp6U4ZvzZE941JcCdNK/z+xhwxefCRmIhg+zyAZDHXEKD83PaeMWdYflCd0M/b5Jnh 3hPA== X-Forwarded-Encrypted: i=1; AJvYcCUgIwYCDaonOu5RsVZWZnH2IM1NdH6UpAzn9UohsnxZoYOBNg+seiUVu3UJz0RmYpmoAyIaA5W02TNhymE=@vger.kernel.org X-Gm-Message-State: AOJu0Ywkkjuf+8pOqrlc/hxUpp7RQiThotb27OIfnAYGhqsXAe9G1CVB 6Yz4CtpuCpxjw7bE8ghkyCBV1IuMTScwNF6YbtkS/Ngf7zcXROEqW38R X-Gm-Gg: ATEYQzwZPjEb5vGOeRGrkCCDuB+HH5XrtXcHmDSY74kzQ/a0xbuBqSpvNRlciiXEzK8 nCEzBx0CHgi7Fb67JAlrrNJ2VTckzLdd5l/9G9OJ4uK9tcwTxheZLZgL32Nb/8VgKjHEy2Fbm8C /vWY8HKoopX5/sNl48r/iXNEA+bGhDp76vFZCauo2eEjl95SvBZbvxRBf0Ng8D+wtydeiadvMeG raYYA+MwfCjSbThgrOL6xAAhWVfa+xi4PoPV4bFnabCw0skxKR2EPaA//DzKpCkS+ZcJwNh4zpg u8PehBtXFpMik8G+anHEX/ukT6Gy9FiM2lW8F7mL94VGA1mGkTiak2FaNegNYIlqdaPBcphEqky WFhJPGOCyDN7lW1DUN/dZa/tcc+qXjOsYwFxhqKRSMcZBw1hIqQ273GEIwPJSvHPu0OUvXFHkpL 1UB7MLj2/A2XOkynZqOQ66Vr5R8WqR7QZYRHva X-Received: by 2002:a05:6a00:8583:b0:82a:6cb6:2e79 with SMTP id d2e1a72fcca58-82a6cb63162mr895256b3a.60.1773799815853; Tue, 17 Mar 2026 19:10:15 -0700 (PDT) Received: from aadarsh.lan ([2409:4090:801b:f416:baba:6c3a:26ad:b5b5]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-82a6bef2ab1sm840537b3a.55.2026.03.17.19.10.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 19:10:15 -0700 (PDT) From: Aadarsh Mandal To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, straube.linux@gmail.com, dan.carpenter@linaro.org, ethantidmore06@gmail.com, lukagejak5@gmail.com, Aadarsh Mandal Subject: [PATCH] staging: rtl8723bs: fixed the trailing whitespaces/commented code Date: Wed, 18 Mar 2026 07:40:05 +0530 Message-ID: <20260318021005.6346-1-aadarshmandal9354@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" fixed the warnings,reported by checkpatch in drivers/staging/rtl8723bs/hal/sdio_halinit.c It mainly included the leading whitespace errors and commented line of codes, deleted those lines rebuild the module and it didn't produced any errors. one warning remains, fixing it breaks the logic. Signed-off-by: Aadarsh Mandal --- Note: * This patch is part of the GSoC2026 application process for device tree bi= ndings conversions * https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device= -Tree-Bindings drivers/staging/rtl8723bs/hal/sdio_halinit.c | 54 ++++++++++---------- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index e32f051ed415..70a5213ae52a 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -46,7 +46,7 @@ u8 _InitPowerOn_8723BS(struct adapter *padapter) u16 value16; u32 value32; u8 ret; -/* u8 bMacPwrCtrlOn; */ + =20 =20 /* all of these MUST be configured before power on */ @@ -70,8 +70,6 @@ u8 _InitPowerOn_8723BS(struct adapter *padapter) rtw_write16(padapter, REG_APS_FSMCO, value16); =20 /* Enable CMD53 R/W Operation */ -/* bMacPwrCtrlOn =3D true; */ -/* rtw_hal_set_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn); */ =20 rtw_write8(padapter, REG_CR, 0x00); /* Enable MAC DMA/WMAC/SCHEDULE/SEC block */ @@ -214,6 +212,7 @@ static void _InitNormalChipOneOutEpPriority(struct adap= ter *Adapter) struct hal_com_data *pHalData =3D GET_HAL_DATA(Adapter); =20 u16 value =3D 0; + switch (pHalData->OutEpQueueSel) { case TX_SELE_HQ: value =3D QUEUE_HIGH; @@ -341,6 +340,7 @@ static void _InitTransferPageSize(struct adapter *padap= ter) /* Tx page size is always 128. */ =20 u8 value8; + value8 =3D _PSRX(PBP_128) | _PSTX(PBP_128); rtw_write8(padapter, REG_PBP, value8); } @@ -357,7 +357,6 @@ static void _InitNetworkType(struct adapter *padapter) value32 =3D rtw_read32(padapter, REG_CR); =20 /* TODO: use the other function to set network type */ -/* value32 =3D (value32 & ~MASK_NETTYPE) | _NETTYPE(NT_LINK_AD_HOC); */ value32 =3D (value32 & ~MASK_NETTYPE) | _NETTYPE(NT_LINK_AP); =20 rtw_write32(padapter, REG_CR, value32); @@ -485,7 +484,7 @@ static void _initSdioAggregationSetting(struct adapter = *padapter) struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); =20 /* Tx aggregation setting */ -/* sdio_AggSettingTxUpdate(padapter); */ +/* sdio_AggSettingTxUpdate(padapter); */ =20 /* Rx aggregation setting */ HalRxAggr8723BSdio(padapter); @@ -639,7 +638,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) } =20 /* Disable Interrupt first. */ -/* rtw_hal_disable_interrupt(padapter); */ +/* rtw_hal_disable_interrupt(padapter); */ =20 ret =3D _InitPowerOn_8723BS(padapter); if (ret =3D=3D _FAIL) @@ -659,7 +658,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) =20 rtl8723b_InitializeFirmwareVars(padapter); =20 -/* SIC_Init(padapter); */ +/* SIC_Init(padapter); */ =20 if (pwrctrlpriv->reg_rfoff) pwrctrlpriv->rf_pwrstate =3D rf_off; @@ -745,8 +744,8 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) =20 /* Record original value for template. This is arough data, we can only = use the data */ /* for power adjust. The value can not be adjustde according to differen= t power!!! */ -/* pHalData->OriginalCckTxPwrIdx =3D pHalData->CurrentCckTxPwrIdx; */ -/* pHalData->OriginalOfdm24GTxPwrIdx =3D pHalData->CurrentOfdm24GTxPwrIdx= ; */ +/* pHalData->OriginalCckTxPwrIdx =3D pHalData->CurrentCckTxPwrIdx; */ +/* pHalData->OriginalOfdm24GTxPwrIdx =3D pHalData->CurrentOfdm24GTxPwrIdx;= */ =20 rtl8723b_InitAntenna_Selection(padapter); =20 @@ -789,7 +788,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) /* ack for xmit mgmt frames. */ rtw_write32(padapter, REG_FWHW_TXQ_CTRL, rtw_read32(padapter, REG_FWHW_TX= Q_CTRL) | BIT(12)); =20 -/* pHalData->PreRpwmVal =3D SdioLocalCmd52Read1Byte(padapter, SDIO_REG_HR= PWM1) & 0x80; */ +/* pHalData->PreRpwmVal =3D SdioLocalCmd52Read1Byte(padapter, SDIO_REG_HRP= WM1) & 0x80; */ =20 { pwrctrlpriv->rf_pwrstate =3D rf_on; @@ -842,7 +841,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) =20 /* */ /* Description: */ -/* RTL8723e card disable power sequence v003 which suggested by Scott. */ +/* RTL8723e card disable power sequence v003 which suggested by Scott. */ /* */ /* First created by tynli. 2011.01.28. */ /* */ @@ -854,7 +853,7 @@ static void CardDisableRTL8723BSdio(struct adapter *pad= apter) /* Run LPS WL RFOFF flow */ HalPwrSeqCmdParsing(padapter, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_= SDIO_MSK, rtl8723B_enter_lps_flow); =20 - /* =3D=3D=3D=3D Reset digital sequence =3D=3D=3D=3D=3D=3D */ + /* =3D=3D=3D=3D Reset digital sequence =3D=3D=3D=3D=3D=3D */ =20 val =3D rtw_read8(padapter, REG_MCUFWDL); if ((val & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */ @@ -877,7 +876,7 @@ static void CardDisableRTL8723BSdio(struct adapter *pad= apter) val |=3D BIT(0); rtw_write8(padapter, REG_RSV_CTRL + 1, val); =20 - /* =3D=3D=3D=3D Reset digital sequence end =3D=3D=3D=3D=3D=3D */ + /* =3D=3D=3D=3D Reset digital sequence end =3D=3D=3D=3D=3D=3D */ =20 bMacPwrCtrlOn =3D false; /* Disable CMD53 R/W */ rtw_hal_set_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn); @@ -979,13 +978,13 @@ void rtl8723bs_interface_configure(struct adapter *pa= dapter) } =20 /* */ -/* Description: */ -/* We should set Efuse cell selection to WiFi cell in default. */ +/* Description: */ +/* We should set Efuse cell selection to WiFi cell in default. */ /* */ -/* Assumption: */ -/* PASSIVE_LEVEL */ +/* Assumption: */ +/* PASSIVE_LEVEL */ /* */ -/* Added by Roger, 2010.11.23. */ +/* Added by Roger, 2010.11.23. */ /* */ static void _EfuseCellSel(struct adapter *padapter) { @@ -1071,24 +1070,24 @@ static void _ReadEfuseInfo8723BS(struct adapter *pa= dapter) static void _ReadPROMContent(struct adapter *padapter) { struct eeprom_priv *pEEPROM =3D GET_EEPROM_EFUSE_PRIV(padapter); - u8 eeValue; + u8 eeValue; =20 eeValue =3D rtw_read8(padapter, REG_9346CR); /* To check system boot selection. */ pEEPROM->EepromOrEfuse =3D (eeValue & BOOT_FROM_EEPROM) ? true : false; pEEPROM->bautoload_fail_flag =3D (eeValue & EEPROM_EN) ? false : true; =20 -/* pHalData->EEType =3D IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EEP= ROM_BOOT_EFUSE; */ +/* pHalData->EEType =3D IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EEPR= OM_BOOT_EFUSE; */ =20 _ReadEfuseInfo8723BS(padapter); } =20 /* */ -/* Description: */ -/* Read HW adapter information by E-Fuse or EEPROM according CR9346 repo= rted. */ +/* Description: */ +/* Read HW adapter information by E-Fuse or EEPROM according CR9346 report= ed. */ /* */ -/* Assumption: */ -/* PASSIVE_LEVEL (SDIO interface) */ +/* Assumption: */ +/* PASSIVE_LEVEL (SDIO interface) */ /* */ /* */ static s32 _ReadAdapterInfo8723BS(struct adapter *padapter) @@ -1147,6 +1146,7 @@ void SetHwReg8723BS(struct adapter *padapter, u8 vari= able, u8 *val) case HW_VAR_SET_REQ_FW_PS: { u8 req_fw_ps =3D 0; + req_fw_ps =3D rtw_read8(padapter, 0x8f); req_fw_ps |=3D 0x10; rtw_write8(padapter, 0x8f, req_fw_ps); @@ -1200,14 +1200,14 @@ void SetHwRegWithBuf8723B(struct adapter *padapter,= u8 variable, u8 *pbuf, int l } =20 /* */ -/* Description: */ -/* Query setting of specified variable. */ +/* Description: */ +/* Query setting of specified variable. */ /* */ u8 GetHalDefVar8723BSDIO( struct adapter *Adapter, enum hal_def_variable eVariable, void *pValue ) { - u8 bResult =3D _SUCCESS; + u8 bResult =3D _SUCCESS; =20 switch (eVariable) { case HAL_DEF_IS_SUPPORT_ANT_DIV: --=20 2.43.0