From nobody Mon Apr 6 20:27:57 2026 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7DDD1D5ABA for ; Wed, 18 Mar 2026 01:04:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773795882; cv=none; b=pC2oWM9C8qLWHk/hWpKYCAdxt4Qntd/cg/YuzLkdiKndtgPijdF44RkuHE07dVOe7mPjxp0QhxlNow5nVCvvIka+c6JrKxfy8amnt2ZbyRJ+x0ZEoo7KVvYWwEIfBo1xROyaLy7H9atwIYFngryrBHugr0/Z9Vi0WicuxgSjFkY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773795882; c=relaxed/simple; bh=THzzDNF8GpfxxtI/EItqwopxBXguI9PXFA2AmDPRreE=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=QIoM4fZX1fjYD8vtwY7Au++g/r0BmnvusyWmpNQ4USqFAWCt3AjTB3mBYY6wRbmyUIdx3p0hR5WmsRvUtzRBPa5zSvG8cgs3c80BqMdjmD7BxLD41ZX9/ZV4S1ssnE7/yxw3kmyrnaSYKd9ENj91TbksgxfG7vyolwrztYwOPbA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--treapking.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=G7g7KjGb; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--treapking.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="G7g7KjGb" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-2b061868724so125322105ad.1 for ; Tue, 17 Mar 2026 18:04:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1773795881; x=1774400681; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=citUlJS1cTHKzG0Mc8HWnWcaRo8SkwkYhwdVqJdujW0=; b=G7g7KjGbnWH43vL/CqCumIps8DTjJ8i0bJoLJXIZP+Nw2ZmjqL3uVMTMCRB/jjVPhU Uc/LQ9SkVGGWCva7G3lT04onzH7SQOHDOiXRBgHkj5yVMARE5sP2PfLK7gfYi14EC0aR xDZb5PJle2hB+LgzU9D7q9Mt14JAysnZA+Gec4JTIDsn1/QmYWU1PN9GU0lcvtTVQ1UJ GgM9AFxIK3BGXHAlVO7NUQeSY8nK4fE4OAdoesCF+9kXUuwZ5IE7oEKeqQfwbYqRllSi AssF/SbpKI58x4ld6luoRhRzT4z4+lT+FjDUI4LP+fURzk94QnzbzmGNfehT6rYru10Z pXsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773795881; x=1774400681; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=citUlJS1cTHKzG0Mc8HWnWcaRo8SkwkYhwdVqJdujW0=; b=PCd4xUB2D6++8i+flbL/rP0AK8eBC4IVYVOjmzY5K0BFunmVd1MjifPDjyzB4zh9di tLkTesRsZBPoQQDd3UhjxXL5gM2uLn8SOqsjsNXBPJ4mYv7kNgdv/3xfzh4b7r6Kdihh VcG0vxJBhCdYtX04AdHbEPMWUtyXjQoP9DNWmKDmWAaB4yQvSl+hYL34JWZpChMemrDO kIchoao0Ec3kO9Hfi61vUJPUH45Ae5M9jD6ZANi+jM1BYde1iMrDdNpwOq9lORxd+aIB ohW7J6GNP33SGDtlPJjI2h6zHTktwZSaxAdKyYPd8oIcek0D22yBcg/JMUC4IuiIWIkp l5ag== X-Gm-Message-State: AOJu0Yxed3/J4nwuCkkBE13gFPRHaXmKJy0yT64mit587Bli8ZQ9JZlH huWOh9N7+EovDTHU3Ap9cdDvwM57Jp697q9XO0o8BX9C9XNm9B2DqZ0InQZlMrL1gje+rf4kF1i I3SmoPGdxlwBsOJyw6w== X-Received: from plhb12.prod.google.com ([2002:a17:903:228c:b0:2ae:4f41:cd11]) (user=treapking job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:e751:b0:2ae:cefd:18d6 with SMTP id d9443c01a7336-2b06e3244e9mr14740125ad.2.1773795880882; Tue, 17 Mar 2026 18:04:40 -0700 (PDT) Date: Tue, 17 Mar 2026 18:01:17 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.53.0.851.ga537e3e6e9-goog Message-ID: <20260318010325.2003395-1-treapking@google.com> Subject: [PATCH net] selftests: drv-net: ping: Wait for carrier after toggling offloads From: Pin-yen Lin To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan , Taehee Yoo Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, Pin-yen Lin Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Toggling checksum offload (or HW-GRO via feature dependencies) can cause certain physical interfaces to undergo a reset or a temporary link-down state. In the ping.py test, this leads to immediate test failures if the ping is attempted before the carrier is restored. This is observed when running the test with GVE driver when HW-GRO is enabled. When checksum offload is toggled, HW-GRO is toggled as well because of the feature dependency. This leads to an interface reset, causing the subsequent ping to fail. Add a sleep period after changing these features to allow the link to stabilize. Fixes: 75cc19c8ff89 ("selftests: drv-net: add xdp cases for ping.py") Signed-off-by: Pin-yen Lin --- tools/testing/selftests/drivers/net/ping.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/drivers/net/ping.py b/tools/testing/se= lftests/drivers/net/ping.py index da3623c5e8a9..951cd99136c3 100755 --- a/tools/testing/selftests/drivers/net/ping.py +++ b/tools/testing/selftests/drivers/net/ping.py @@ -64,7 +64,10 @@ def _set_offload_checksum(cfg, netnl, on) -> None: try: ethtool(f" -K {cfg.ifname} rx {on} tx {on} ") except: - return + pass + + if no_sleep !=3D True: + time.sleep(10) =20 def _set_xdp_generic_sb_on(cfg) -> None: prog =3D cfg.net_lib_dir / "xdp_dummy.bpf.o" --=20 2.53.0.851.ga537e3e6e9-goog base-commit: 64dcbde7f8f870a4f2d9daf24ffb06f9748b5dd3 branch: net-upstream