From nobody Mon Apr 6 21:30:56 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E259D346AC2 for ; Tue, 17 Mar 2026 17:22:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773768125; cv=none; b=MLNIyMXbwnnvsAHjSzB/1KLkj4yu0f+9fshYYiVu+ZQtvpjxAmEC9e98r9DxMXNmkkhS14MKias0FaI/RCjsbFwN/D2o/GDVmjMbCnWKfV/RyShxDaEvXP46/vRz80LYKkoi4L477lSxConztoG4RhHHRTABMe6MAx2Jn5t8sz8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773768125; c=relaxed/simple; bh=LX3WrCkmBT80+WbDdsLXcY90w5LjQ8QZ9GC6fBf1zns=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ozthaIJT0wL96DjVsPLg8nPWDODrAMISQICpwXT9P0hbnVeRgnQ8lrW4lUqtivDDUd3v23urmybBjtEvKGGP1WRuhmZL0G2uy7fCvTyWuV/5h7BO45b1qIjHJE+c1OnfFw+AWkI/xC7zfCoPZGG4GxPNNldMljTCgGMBr8cDPR8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZwWjso2B; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZwWjso2B" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2aaf59c4f7cso28994705ad.1 for ; Tue, 17 Mar 2026 10:22:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773768120; x=1774372920; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=RlnnacpIBF5tbzl0VRGQD3bXIyCs0S6ifDpvfz5RffI=; b=ZwWjso2BDsDibWKEjAvLLKrT3CgpCFHL6uLGbycSIjCTXhuL8XhW0WGojttB5vkqF+ rTxyf/j6FjnsjUCriNwASxcWFNoaLrx9EkgmDJHCplW2Y1C2LxkZRSrEEECEvCDkYHNa Gbv0XP+E6cdSlxTRVH4FnT6+yyOqjz+OwQOXVgOjgJbTUtu5sH+4uWCoE3FlZ9aXFVPF KH3NnhSZ0uwtFV+2+pmV9ebOehAT98cDfhXx55DxXUBio3G4JdqPlNSJ65jEhRP2Uywp mbMn6GWTZNOVJdz+xfJCyVZWApKlgI/geRsOe3OKw2xw9lYvk4+GXh4/f6CyIx9/m6E2 cAeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773768120; x=1774372920; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=RlnnacpIBF5tbzl0VRGQD3bXIyCs0S6ifDpvfz5RffI=; b=Ub48NhHoa5qB3lSpJfgk7LsV70mFjsenIt2ZIq02V+X0uGCV+Lnx9YJMMgE53R/zqR lBigazQpYF+4nnecu+yx/QADhgkPFWXzSrHZjCoDWrbFlwo4Qg/JkflcMNymDx1Z4tNG MFfhNfXh+89d8wmgdiBuOp0AgP/dQYuI9fmae+nEWDtaLUGqes30MxEhrRNuDiMAgqaE rMuIRtinMpMukP2UVmQeHuXvsaKIsLJkFqHu2ZnOOnQeaXaHangOyE+5LQpUhfQXnRYR WKxxTehijkuTKe7gLaHi5quBcPRXsP5R9DV4rUCD/EZknhOrtlvzhkZuDnTXSv6+SjEJ qaHA== X-Forwarded-Encrypted: i=1; AJvYcCUzCalo2D3EPqyBop6tJmETUDP6vySiWYwv56JDRO+VpZ6IdmpHwPnQUjavYWEuMCCEH/Nib04UNF4ii1Y=@vger.kernel.org X-Gm-Message-State: AOJu0YybYbY8nup/r6CPEjD1qkDH02QxzcOaIpeFtXprmnLy8mn4h0Cp Yp85dBTqnE0Eo5s3KMoW0JbZJKWeCUUdNjRWZbZHZcWWkL9f6BT1dMEI X-Gm-Gg: ATEYQzzY3eHIIe1EkSCbTSGVQqmqJAfzA7b0RVVgDDuJF9I+EtR6IU8shpJCT+SxzZb FGFb4No0+ajtb3yKVvYKbEOQ6+GlZsL458j8dYp2JmEwpzsArlkXn4on5TXHIgddaVX9wR5CGyc mee2LZgPobLLeaynPexMVc8dbqjGWBPRBmzkR8AH/1ktAhg3Keyw5SYTjCuN3S1IS6Cx5rKVQmU HA9TaRK5JJkE7eCLoyifpB8V/YpKSlB/FkQMr61K+egboAD7u30WBxxH/XKp88KF3jNODQoMID0 zuxO6NSFw1j5PUCpBh6e3nVNtS1/loByMnQzuTo1DT8sr+LIdpaQo3GU2MAD+K2df1UCbIyVYoV OeVeeqm+kqiyCUxakSFe+8BMigv14DrkFpLVUc32RWm7kd+ZeNpnB7fYO6TB/bU3y6RqfWr6C8x Kou5yu4x0knWBjvbIf+Y2FV+c2k9mHvNaDsoHA+jUjDomRYEQ= X-Received: by 2002:a17:903:19e6:b0:2b0:59c4:e9e2 with SMTP id d9443c01a7336-2b06e2da870mr3486765ad.2.1773768120187; Tue, 17 Mar 2026 10:22:00 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.240]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b06e608a66sm934825ad.61.2026.03.17.10.21.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 10:21:59 -0700 (PDT) From: Felix Gu Date: Wed, 18 Mar 2026 01:21:53 +0800 Subject: [PATCH 1/3] media: ti: vpe: Fix fwnode_handle leak in vip_probe_complete() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260318-vip-v1-1-5fdcdbd01829@gmail.com> References: <20260318-vip-v1-0-5fdcdbd01829@gmail.com> In-Reply-To: <20260318-vip-v1-0-5fdcdbd01829@gmail.com> To: Yemike Abhilash Chandra , Mauro Carvalho Chehab , Dale Farnsworth , Benoit Parrot , Hans Verkuil , Sukrut Bellary Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773768115; l=1909; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=LX3WrCkmBT80+WbDdsLXcY90w5LjQ8QZ9GC6fBf1zns=; b=4rD6cG3wRc8/1B34vC8AbbcZ0qq3UmKAa6j6mkH84dCPLJz4IgcTlx8eCBCDAcqNJ+jzhs/pu +opfntOaohwCMpz4MD8Wle2TxrN5oGdhWyoz9hRVRRjG0EpCLXXdmiK X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= In vip_probe_complete(), the fwnode_handle reference is not released if the loop continues via the default switch case or if alloc_port() fails. This results in a reference count leak. Switch to using the __free(fwnode_handle) cleanup attribute to ensure the reference is automatically released when the handle goes out of scope. Fixes: fc2873aa4a21 ("media: ti: vpe: Add the VIP driver") Signed-off-by: Felix Gu --- drivers/media/platform/ti/vpe/vip.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/ti/vpe/vip.c b/drivers/media/platform/t= i/vpe/vip.c index a4b616a5ece7..01d27769cd10 100644 --- a/drivers/media/platform/ti/vpe/vip.c +++ b/drivers/media/platform/ti/vpe/vip.c @@ -9,6 +9,7 @@ */ =20 #include +#include #include #include #include @@ -3389,7 +3390,6 @@ static int vip_probe_complete(struct platform_device = *pdev) struct vip_port *port; struct vip_dev *dev; struct device_node *parent =3D pdev->dev.of_node; - struct fwnode_handle *ep =3D NULL; unsigned int syscon_args[5]; int ret, i, slice_id, port_id, p; =20 @@ -3411,8 +3411,9 @@ static int vip_probe_complete(struct platform_device = *pdev) ctrl->syscon_bit_field[i] =3D syscon_args[i + 1]; =20 for (p =3D 0; p < (VIP_NUM_PORTS * VIP_NUM_SLICES); p++) { - ep =3D fwnode_graph_get_next_endpoint_by_regs(of_fwnode_handle(parent), - p, 0); + struct fwnode_handle *ep __free(fwnode_handle) =3D + fwnode_graph_get_next_endpoint_by_regs( + of_fwnode_handle(parent), p, 0); if (!ep) continue; =20 @@ -3447,7 +3448,6 @@ static int vip_probe_complete(struct platform_device = *pdev) port =3D dev->ports[port_id]; =20 vip_register_subdev_notify(port, ep); - fwnode_handle_put(ep); } return 0; } --=20 2.43.0 From nobody Mon Apr 6 21:30:56 2026 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FEFD363C74 for ; Tue, 17 Mar 2026 17:22:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773768124; cv=none; b=bx8BCVb0gh6kZkJ5BEiJ0rI40sMpc5pmnZgeCzZXv4kMVlkQG1GkReCShCN10RCrqh4/uktnx2Acfn96V9MRWDbyc/p1ek4ni2owb+33HZdiRsnoelhDBAJP9Ev7dpNzuJrxpf+0e0z5YvpRO0PKncEczmWZQJgigHKZnd23L0s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773768124; c=relaxed/simple; bh=kVu8V0tfTcg7/zwXLEA72sf21oRs9Dazt9SBXJYxuoQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nQi6YlvEGdJp2HxhSZQo6vUgURLB/3720eScSWqR4r7WYG44RmiB7VAKvJ4sX06qqAPqqlqoYxfImjs/6m4kVmH+U3baVFhf190n/DOfD3NtdwNE0pyX+O7pV0F5iVdfnKPDEE8Alo2PMbaAq0nU4CQ9V2gUhLAFL0jHOl2Z8GM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hm7iApr6; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hm7iApr6" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2adff872068so27457235ad.1 for ; Tue, 17 Mar 2026 10:22:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773768123; x=1774372923; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HLDFnLZxZRt9r2soPVpOYTQmBDwc/HqSXqOmk7Ap7oQ=; b=hm7iApr6Ab8XIXI74I2lwFP9ZgVmbOLmugWlw/BHt7p84hwJWL4Nc1uCI8GwihX2bA rVGVk26UnbStgyn+FrWDFvIaJzIRvHBWQD71p9yJFsOLUFTm6AG5F95NLO6kPe0VGyiM h+nxi1WCpixB1cZCi8lWK1lLT6Jxj1/pAi96MRPqjMo97KkXG3N1prv8yjPN2uzER37D Cx/hWo2vxHYXiLiA8xqiLjvwg8r304m+jy+o6vcVMG0myJ2q4vS4W82FcQ1Mjd+GpZnp Sxo1t+gZ/l26bH5uFO2VnNw1hF4o49SEnuhiL/CKHFpSve9ZMD5CBHgDzezHicUGAfra nGog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773768123; x=1774372923; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=HLDFnLZxZRt9r2soPVpOYTQmBDwc/HqSXqOmk7Ap7oQ=; b=DZH3hO6EreRidSFFuZdkDXKK2BBacNc63b9MIFPY8fT3CLAfrylq5972xiC5JM+1pA M6sPpbDdF9HPrM5T0p+RGhJNp1ppCE/Hyw/D0tPxGecJwXyr+dapCxHZaVYW2qAYKx9n D1zray/fsY1LkEch8RuxahVmkN4Sow8kiW+6a2KpscvO5VSAKKD7kBre0g9cJJCR2VfB OelDNW7Jmksx7SG93o+tLeo0vWTgjKBAM5cng8M1RiYtlHQNMiq1VcrFcoDA9tGjsQeQ MiA7g42HJvRyipjPWim4fZsV9XR6Ul7yu+60m0Ep1FyMxUearTuuUSeSz9HygOcC4bVh WsXw== X-Forwarded-Encrypted: i=1; AJvYcCXvVUSJ4viTlkzXEj8xQ3XFNGVwRtKF9HWGFiOe8Kd0v2dhIegPpqoH5SxomsnH9VgmCDjIXKPIHoxomXQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7yhpOrfHF5xakqJK5IUc5TjjG9/61s4WlPivGOKTmuqNr5+SZ kav5J/u9XPw3Qv2pp+afx7D5962ez8JOTlLgRTm73M9TC7b3Os4K/UX9 X-Gm-Gg: ATEYQzx+9ukUc+afODtP4TtTAiaR4ZyFiuZ00ltvBDlpOMihGQwu9PFD48clw3ibANv 4TeLaQGA+YJ+/fY964opHlW86dN5uS0bSKSyCZNuHSKL8bdm+5POegJpYnE65DGPLk/5LMcgBrz UOsRNcLLA5IpAnTdN8cTLrlr+i9NYp8Ykg2Fcli1afo+0FHBi/kJpH2zgP1qcB5cGQE9ayv6RWB wd83xnkDvzc6tc+7sQw4HHV8olgL+Xs7tr0xcXUAmRtFIQm6p/NS1ASkm6H5xE9MGLc7FOTxNpT tsl1svq7TRTqaj8u3O6fYl5p9dxnRhx7EqWV27Dwdj1UJ2amUsNZ0Oe1SxjeUY21tRFOJzxaXUv fQhPBP/w0skGcyESBUFnVT5Ay9HQFtuExRScyTMApb61JcbiJlp4OlUuyGXkwyou5NVrluUYv5e k/x6Y6fqlDpbJLwM/Y23rQ0XXfoWVBjowc9Vdi X-Received: by 2002:a17:903:37c6:b0:2ae:7f28:124b with SMTP id d9443c01a7336-2b06e3554d7mr3267585ad.22.1773768122890; Tue, 17 Mar 2026 10:22:02 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.240]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b06e608a66sm934825ad.61.2026.03.17.10.22.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 10:22:02 -0700 (PDT) From: Felix Gu Date: Wed, 18 Mar 2026 01:21:54 +0800 Subject: [PATCH 2/3] media: ti: vpe: Fix the error code of devm_request_irq() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260318-vip-v1-2-5fdcdbd01829@gmail.com> References: <20260318-vip-v1-0-5fdcdbd01829@gmail.com> In-Reply-To: <20260318-vip-v1-0-5fdcdbd01829@gmail.com> To: Yemike Abhilash Chandra , Mauro Carvalho Chehab , Dale Farnsworth , Benoit Parrot , Hans Verkuil , Sukrut Bellary Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773768115; l=835; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=kVu8V0tfTcg7/zwXLEA72sf21oRs9Dazt9SBXJYxuoQ=; b=iXIrjXBvrbpwa9s2w0WekxDWtpXwn1zCtfyIBLBNyHBMzbeY7e+k6mPDVZpO6Di45r/YcqWCj QQrTikep7DhCLjsPAHNfz4H3QtpzQkgdUaYFmISFArnRqIpo1BEa1R5 X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= Return the actual error code from devm_request_irq() instead of incorrectly returning -ENOMEM. Fixes: fc2873aa4a21 ("media: ti: vpe: Add the VIP driver") Signed-off-by: Felix Gu --- drivers/media/platform/ti/vpe/vip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/ti/vpe/vip.c b/drivers/media/platform/t= i/vpe/vip.c index 01d27769cd10..f0354b52048e 100644 --- a/drivers/media/platform/ti/vpe/vip.c +++ b/drivers/media/platform/ti/vpe/vip.c @@ -3472,7 +3472,7 @@ static int vip_probe_slice(struct platform_device *pd= ev, int slice) ret =3D devm_request_irq(&pdev->dev, dev->irq, vip_irq, 0, VIP_MODULE_NAME, dev); if (ret < 0) - return -ENOMEM; + return ret; =20 spin_lock_init(&dev->slock); mutex_init(&dev->mutex); --=20 2.43.0 From nobody Mon Apr 6 21:30:56 2026 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A48A376BCD for ; Tue, 17 Mar 2026 17:22:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773768128; cv=none; b=GfT9TruCsfVOpBf46epwIdUq6GsKTRGvhAxXcCoHKtjDu6y1ZVbEvHjmEHnE+NZM+6k2M3CRLqqvp6CYW7tqG43kHBEHw2NfTsf4CVHGY8ClQDLCeBJEGW174ZNfv09yk1WFk/Ltgjw1ibMoTikL9EGLyRCz7dlfrn94koV34ak= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773768128; c=relaxed/simple; bh=5fbdFUXVV+cKT7Grp0jiBr2mRY8i+YGcR4bReK6++V4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oedlCZiDKzO2Lq4ENv+RQfi/riGUNVSPebY/Z3aaTsrEOOvMXGKuzkSCMXhtGEpxhBHpOUMuC2d/3y4WFFBgc7bWSnWHTqQhe41j5pdhe6kBffk0Nu7LqUhURQatL2DqPTVR7+Rmzjj5EB1250Z003JIYXccY+wQZ3/L935MAkQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZnmpP+lW; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZnmpP+lW" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-c6e2355739dso2304463a12.2 for ; Tue, 17 Mar 2026 10:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773768126; x=1774372926; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wYn015pT4R/PGnVg6K8bkUFTi/0ATFS6CFR2gbnSwSM=; b=ZnmpP+lWjHtbOknrinXpU9y0pQOYP/zSNOA/Hs37TQOvj4wxSaLKkAc6Um/OsoIrib WvaHJyRp4Wk2TReaC76sx6TBHzzheJIQBBBPvtwo2cowIWVov3IfRwM82LoS5OuOyWK/ OdZitT/c4X/c2dJtAyCJhnPOK77wZJBA+sYW8pAltHKG9D2WN9tWClElXl+9B9JWqwLH uDtO+5/KyJLN6kzB7WupB0Qhzo9LxI5hQPVU7AL6gysUkMzpiVE8R9rjcd0msIKzAAPP TaBuzCj7KlvFj20vY37ktyiT4tXT0nM0YpRRdm/AhIfBHMRrp66p06cfCEGHTd12mLph emiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773768126; x=1774372926; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=wYn015pT4R/PGnVg6K8bkUFTi/0ATFS6CFR2gbnSwSM=; b=i1eScyT+6rUAKFlOPCN4wC5PdOI6CC0Gk0108b1aRwzEuNq6GuaARONfh0w2NRULK6 ZOAI47ijbGt1ZMzXxNXrf98f0HgV2S8WVfAJPyIWnYj0hFySuOYSawGjZbEV5Du/ni9s 3PWf8+VZ6u9dFWVM93D8EEzTXg7KgZ1SXgB7UBm0Osi9zgqeNIJDfvJC/9LBklj8FAj0 L8zHxpbTA5aEMcu7NGnR3hQ6b+kiGKg3a75GK9E8AccYT+p65NhNLAKcN3CN55Z61ZW7 oAV/XcAwBKHLBUVJTFKF6dDgX80WGldB/OPAwp68cBzIA4QYizXVwdpdH92X4p5mMKTo npPQ== X-Forwarded-Encrypted: i=1; AJvYcCWS7iVl3TLq8yPAUKdJH/WNVJ28qRmmDL6c5ftA9gt8NGBZOlBPmUsnwHcwHnlFz1EDK3I/mfl88BV0xqY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw65eSMx0hGTGF3t/hpKBD/mq1Ev4kip+mAW7jogZ11VIuwvPGF W1NToRq51z1Tfkcajykq8MB+lyBQebvoGsO4qfO4XAmt2Z9wZnr5+3Fk X-Gm-Gg: ATEYQzzNd9uEaKU0ohVf2ootfIo6TF68t54PnfpIZX07VOxQTATg7XsOz6gX4Slvn4w JEEqf6zUqZfAdJpCwp/o2Gu2xnLAG/A/3PJgD0sA2AkMjPjhl31MrZR6Itxa7YUpXQxkhPO3ZiD 3O0dBEEV/DQqzF0WvKvj85tWh3v+QkslzxRw8W1agaIxBESMy58WW9heNf5ycTX1VuoVZNkx+u7 tcQ/WOdr0eBFZVMkMB/G04lPTbF2eJRi0RtjvsvFUUE2lG2cdx/jXijzMS9/rfQFLL3el5YAVUc nBhwkBXcDlErdOi4ZUrxOYO/iMLESdOduMgqMVgEsOlMM+lDPxGKz8yobJ6s8AzcsX0W/xGKXSV SmZnmReFLz1SHIWjmxOueqD19VLFFOCjE+wpjTSa902Pzzegpg6K0KSQnrhmfJQSvQs6K9wD0/f mKsMVHjIUsf2Ly6eNyomNlS0dZmjcd/0XzlmrT X-Received: by 2002:a17:903:8d0:b0:2b0:6cb5:c6c5 with SMTP id d9443c01a7336-2b06e40be78mr2851655ad.49.1773768125745; Tue, 17 Mar 2026 10:22:05 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.240]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b06e608a66sm934825ad.61.2026.03.17.10.22.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 10:22:05 -0700 (PDT) From: Felix Gu Date: Wed, 18 Mar 2026 01:21:55 +0800 Subject: [PATCH 3/3] media: ti: vpe: Fix the error code of devm_kzalloc() in vip_probe_slice() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260318-vip-v1-3-5fdcdbd01829@gmail.com> References: <20260318-vip-v1-0-5fdcdbd01829@gmail.com> In-Reply-To: <20260318-vip-v1-0-5fdcdbd01829@gmail.com> To: Yemike Abhilash Chandra , Mauro Carvalho Chehab , Dale Farnsworth , Benoit Parrot , Hans Verkuil , Sukrut Bellary Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773768115; l=1683; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=5fbdFUXVV+cKT7Grp0jiBr2mRY8i+YGcR4bReK6++V4=; b=DmY0TFp4htY9o1eDrRrpaEV6cj59v6ve1wRvqGCt+xM81s9P11k/VrAG4dp9rvjTRcSbaRzU0 VDUQkFQZNcwDzaehshoTbZLxaZ5hSrraYu3/gkYNutExL9V8xyILXSD X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= In vip_probe_slice(), the error check for devm_kzalloc() incorrectly uses PTR_ERR_OR_ZERO() which returns 0 for NULL pointer. Return -ENOMEM for devm_kzalloc() failure. Fixes: fc2873aa4a21 ("media: ti: vpe: Add the VIP driver") Signed-off-by: Felix Gu --- drivers/media/platform/ti/vpe/vip.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/ti/vpe/vip.c b/drivers/media/platform/t= i/vpe/vip.c index f0354b52048e..aec9dbd1320a 100644 --- a/drivers/media/platform/ti/vpe/vip.c +++ b/drivers/media/platform/ti/vpe/vip.c @@ -3490,7 +3490,7 @@ static int vip_probe_slice(struct platform_device *pd= ev, int slice) =20 parser =3D devm_kzalloc(&pdev->dev, sizeof(*dev->parser), GFP_KERNEL); if (!parser) - return PTR_ERR_OR_ZERO(parser); + return -ENOMEM; =20 parser->base =3D dev->base + (slice ? VIP_SLICE1_PARSER : VIP_SLICE0_PARS= ER); if (IS_ERR(parser->base)) @@ -3502,7 +3502,7 @@ static int vip_probe_slice(struct platform_device *pd= ev, int slice) dev->sc_assigned =3D VIP_NOT_ASSIGNED; sc =3D devm_kzalloc(&pdev->dev, sizeof(*dev->sc), GFP_KERNEL); if (!sc) - return PTR_ERR_OR_ZERO(sc); + return -ENOMEM; =20 sc->base =3D dev->base + (slice ? VIP_SLICE1_SC : VIP_SLICE0_SC); if (IS_ERR(sc->base)) @@ -3514,7 +3514,7 @@ static int vip_probe_slice(struct platform_device *pd= ev, int slice) dev->csc_assigned =3D VIP_NOT_ASSIGNED; csc =3D devm_kzalloc(&pdev->dev, sizeof(*dev->csc), GFP_KERNEL); if (!csc) - return PTR_ERR_OR_ZERO(csc); + return -ENOMEM; =20 csc->base =3D dev->base + (slice ? VIP_SLICE1_CSC : VIP_SLICE0_CSC); if (IS_ERR(csc->base)) --=20 2.43.0