From nobody Mon Apr 6 17:27:46 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D2823DEAD0 for ; Wed, 18 Mar 2026 14:50:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773845442; cv=none; b=NRRem9vaNYO+UGCtfXGecM3feKP1SMLkAzAmkJO6Jcax5slY3eexB4IuUW7EjQZaddQj/G/O23nKNnvcgqrUXYOp8C9vvEV62wHAPkiFT1AWKzzGHPVo6cEI8BMLL/kFwGNq18ShY1vJ0hUG4ykcSPVluHUIV1lc5IB9u1IGicc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773845442; c=relaxed/simple; bh=NLuWlcb8pDVc/jx4hn9f+1Y4XpERqSPMPejDpC3HkM8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=fw19MOx2A4RZmHls5nWWg8u24CrmOlVwwXQ1wcKZxTn8HDRnSxcQyd8mJFa+rhqvnQ9x/FG8lEGA5WO6NJssv6yudrsBoUuh1vLWlnq7am7v9HzCb8Afs2JJu9Ai73omSzi7B5dSpbNa+607qAk8LFZj6jGTnOkaGHLUKVQCseg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=ks1QBwoK; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="ks1QBwoK" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-48541edecf9so75854865e9.1 for ; Wed, 18 Mar 2026 07:50:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1773845437; x=1774450237; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=v4jx9be2ixpeez8G3+677w21LKJvNvIiDEiSr10SzEQ=; b=ks1QBwoKU3XSB9oaHbxpsCtyvCaVhgW/Js3cEUr/snbzBUVlfk1RvoVnXFN8Eg1T0K I+HZD+GpqZ/inZykKDEfK7vHeDhIDs2n3FMeN2g+OwpS1HCx0c/1mLbleFCxMV4pyBCZ pxJWREQy4k9zdetybrOTW5jtw+PfCPDR0eNGuHDaxrcQrDsoMeoh5qaNa/WRXN+XDjtl mP2yGc6CdE/KMeCWPjIcY2cXPMo8DziX+NuiezspsBJB6GLHLE+8S6B6cVy6JDbBFAhn ViLTKuiLLhIYF1Fk1tncVwvq9qrcG343SfrE5wTluYZxjBcg4L5WlEXxmXDhtDCSbwj2 JfNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773845437; x=1774450237; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=v4jx9be2ixpeez8G3+677w21LKJvNvIiDEiSr10SzEQ=; b=T0g886HkHcPbbfvd9dmu4TrLJcArjNies4UKxe03YAq5Pix/ktTudwB3xbdq6G5vTv 1gBSIhucqOzsGgLTsolGsxTEAVNFSz3wFh0DFT1/4/A3a4fPbzs2H+JKHiYEU1uma6Hw HJsHfo369uyIAVn3M9tIoz3l4jKlujUYKKOFB1vj5Mfl5Ggaowp3wl5dWEeZs4X9PLaU bAz1SEClaby8HAAkmpUkJxgoISdTIoiGvIMoCStrlx/oOaAvbHI/OgSD45HX4uyCO4f8 8fB00C7sinq1Vc+igvQVjwoCukZA/D8i5atGA6tRdK4dO95gcW8rQaw2SoBuuLGtzEBr rZvg== X-Forwarded-Encrypted: i=1; AJvYcCXXiDkm3JSmf2tMDMsdNpytalYriXbEBtQbaInX2lsfuwCdygqC/h6FcObvcpi7Uyxe611hOAK1eqmZ2Fg=@vger.kernel.org X-Gm-Message-State: AOJu0YxzLmKXX2FvCX9N/Qnxn9K1Jn9SVGBNAW8MXP5CKTUMAZd4iUsu 97TDMj3Yrcl7BHPCEhyiyWxFE942fo9wIt7MDtsYWqSDlDfvYjmbCoIYzNlMiKAtBIQ= X-Gm-Gg: ATEYQzyMlCwoeoe2fIpQOABzusHGQfPv8C6jHsU7atPmxtdbVva3K3vxHrjh/dkclJi IGYWsbZ06tO/6NgeqYVWugy8yVhBrPO+jT4xRo+aKIsbFf+OG0lkzG2Ht8Tro3lGieGbkklZhUf 2oiIUfTW4zEd5ewf0hxBmvdFjUtc1AaxQfKj29CTRO0SqSIh6yVprSYWDgwSaprSubjiIZyxhaV Rp4hNmrCHrU36h08pFymZLsRq//SXwO6mdEhnrYhhmfbZ7zo2b2DPyaT3Wdq+DFfotXZ5N5UXax mb3s1lMeuBUB0dg9Vac1c1wkt/lSQf/hhOC9zg7N+HjbF4UUCJyfP084X6uIgdXRDAa6MEUB3i4 S7vvb6m/lEsnBINpsrCLoVDNKrdyNlIdTHfg38BVxCxw9aWQIqgRNokVpr4DNo/nUCibn8r5ROU MFN+2ILwyv4Y/ddrwzFnWxOqcmiHlKXkxGZuMI8FvREEuSJx5dX8ELQVmZCMXTc/vl/EBcdL2H8 u7k/g== X-Received: by 2002:a05:600c:1f13:b0:485:3c05:24dc with SMTP id 5b1f17b1804b1-486f4465ec5mr61165625e9.33.1773845437260; Wed, 18 Mar 2026 07:50:37 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f421a6f2sm64455665e9.8.2026.03.18.07.50.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 07:50:36 -0700 (PDT) From: Alexey Charkov Date: Wed, 18 Mar 2026 18:50:25 +0400 Subject: [PATCH] ASoC: rockchip: rockchip_sai: Set slot width for non-TDM mode Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260318-sai-slot-width-v1-1-1f68186f71e3@flipper.net> X-B4-Tracking: v=1; b=H4sIALC7umkC/x3MQQqAIBBA0avErBswo5KuEi1EpxwICycqkO6et HyL/zMIJSaBscqQ6GLhPRY0dQUu2LgSsi8GrXSv2sagWEbZ9hNv9mfAdjBEvnNaOw8lOhIt/Pz DaX7fD/krs4pgAAAA X-Change-ID: 20260318-sai-slot-width-378eed5c22cd To: Nicolas Frattaroli , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Heiko Stuebner , Sugar Zhang Cc: linux-rockchip@lists.infradead.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1654; i=alchark@flipper.net; h=from:subject:message-id; bh=NLuWlcb8pDVc/jx4hn9f+1Y4XpERqSPMPejDpC3HkM8=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWTu2r2LQXabQmNxUOTmuWuVZk1xYDH7F7xj3tm5YhsuT d5751SZX8dEFgYxLgZLMUWWud+W2E414pu1y8PjK8wcViaQIdIiDQxAwMLAl5uYV2qkY6Rnqm2o Z2ioY6xjxMDFKQBTff4ZI8P3KSv/KzEcnL3vu/K+l+pbFh3xStZe+UPM8PKzyZlhs3YwMzLskdU R9W1wm3mARX752pKM9Qv8kr5alHXePbncc8pXtio2AA== X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 Currently the slot width in non-TDM mode is always kept at the POR value of 32 bits, regardless of the sample width, which doesn't work well for some codecs such as NAU8822. Set the slot width according to the sample width in non-TDM mode, which is what other CPU DAI drivers do. Tested on the following RK3576 configurations: - SAI2 + NAU8822 (codec as the clock master), custom board - SAI1 + ES8388 (codec as the clock master), RK3576 EVB1 - SAI2 + RT5616 (SAI as the clock master), FriendlyElec NanoPi M5 NAU8822 didn't work prior to this patch but works after the patch. Other two configurations work both before and after the patch. Fixes: cc78d1eaabad ("ASoC: rockchip: add Serial Audio Interface (SAI) driv= er") Signed-off-by: Alexey Charkov Acked-by: Nicolas Frattaroli Tested-by: Nicolas Frattaroli --- sound/soc/rockchip/rockchip_sai.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/soc/rockchip/rockchip_sai.c b/sound/soc/rockchip/rockchi= p_sai.c index 1bf614dbdf4d..ed393e5034a4 100644 --- a/sound/soc/rockchip/rockchip_sai.c +++ b/sound/soc/rockchip/rockchip_sai.c @@ -628,6 +628,10 @@ static int rockchip_sai_hw_params(struct snd_pcm_subst= ream *substream, =20 regmap_update_bits(sai->regmap, reg, SAI_XCR_VDW_MASK | SAI_XCR_CSR_MASK,= val); =20 + if (!sai->is_tdm) + regmap_update_bits(sai->regmap, reg, SAI_XCR_SBW_MASK, + SAI_XCR_SBW(params_physical_width(params))); + regmap_read(sai->regmap, reg, &val); =20 slot_width =3D SAI_XCR_SBW_V(val); --- base-commit: 8e5a478b6d6a5bb0a3d52147862b15e4d826af19 change-id: 20260318-sai-slot-width-378eed5c22cd Best regards, --=20 Alexey Charkov