From nobody Mon Apr 6 18:23:57 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C7A03D3480 for ; Wed, 18 Mar 2026 11:49:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773834576; cv=none; b=M4ViL1gTql0EzN6zilKnOn10OEbMEvcKcP4BtS/s+s9A9eZl9oZOZfvqvI64Re+AwrB5Ru9qKo1NjR1oSoujDl5RQuB8iHQ1sDanwhzi6njtcWahqUWf+eYx0HsTSUJxbGnrDsSSsdQAcbp2juCuKPNG9jSt9dYdAT+ubOjeauM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773834576; c=relaxed/simple; bh=BrZuPlklCAo71qWA5RBbDtAMQZKPiERrhde+rkkQchE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=HK1iEiHXQj05HudiL8HrM9qOkH5OL5NrKNyoCVEwZt5zKcN7haEYGcWvQqk4nTbNIQ6UT0TrrT5VP2CSx9tTYJHELGpICQsbPmuPHsW0/68mpgZ/2ka8TDaYjqrPgr4vykHbM01ZnZux15vwZAcnwWIaQNG8wWebWFZ2LXePZXk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VtZWAF1J; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CKV7PKix; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VtZWAF1J"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CKV7PKix" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62IBB9fa320093 for ; Wed, 18 Mar 2026 11:49:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=y6uekHplewyqgNPzHqkV6E 5PzKA4fuWkkb//gMyMjmE=; b=VtZWAF1JfTCOn3kMg2k0rq91Fq0bQHN7l2YXIZ VkvoWcCA0EtypC5bR4XGydkZvClGmv+VQAnyOTFnmW/A5zXJ4PHun5d3euJE/t0j xlnxTh7xHRKEMLfODJPP+NkzRByZATeT5TGAUgL8eAjO2rQH5/T2uGLQqMehjTVC GaAn+jLMb2FM0yfNpCF8dNP/N3uHv10nF/f+gCGt3X8loNa7sbE18i5KlnNYOs/V G1PXGHch1rfd+x6z7POk1EKyw7ZWF8JHlKi7EeF5mE+K8Ete3pZmkvX77ElR5kYd wLxVMYbqXE8NQ7CMxmRYJj5reAn04K1juru3C5gcSQmeHXdA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cytxyr3un-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 18 Mar 2026 11:49:34 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-35449510446so6829490a91.0 for ; Wed, 18 Mar 2026 04:49:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773834574; x=1774439374; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=y6uekHplewyqgNPzHqkV6E5PzKA4fuWkkb//gMyMjmE=; b=CKV7PKixJhWVPKWgF4Ice+F8y5meSF000jEVI0+0/U3V12R9dioo8a3ja7pKjwTAQ0 IraCB2EymAO6VUSwkmRnLxwxtqc6aBqOkV0uQq06kcmyY5iQ0HltdPd3N6p1FR+i58Wc eqv4Q38OWi8UQ9i4LishQ6czIjgaff4uiY8L1daK/+66i+m+T88QScYDn94sd6qPFjnW q9b9wQ77hNnSDC6ZLFcSLun5ryoChsusqcrOCPiCbtfjC2+wgbmHF3MqH82WpgMCzfsG ahshr3TaFnIlqRl52iQ14QYkTjAExY7QfoiZrhXf1WT6LnpPL9Wr5/o5CxYwH7G61jGA V+Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773834574; x=1774439374; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y6uekHplewyqgNPzHqkV6E5PzKA4fuWkkb//gMyMjmE=; b=a/D3+lajSkpaxMmsklLl7OkhrWlLzPPeqhT7gufqoPK08SPU2LoIEzV5zNQi6KQu3U FgfquTW2qhtJDjsbSeFZdbBS5M1vQLc0Qrele1XlkD07xiFgqiXZ3coSQqSi6Cb+40Uy ucb+EIo0DAi6SSMJLLEcMHZeFZUznIM64j7xO0Y8G7II8wK4IcpUlkK5FCiJbM6PvV1w McxX22cwBMBzbwtGZkBND9ythFcZ5ENIoRqEetY3LhWaQhWN/tcKB452jG76buBPBEEO aYDkCPKNgiIrRg7sSrlopIUgjIMqNpyj/i193xzKRp5+AvTR9Buplw/WwvQYtFZYV5dd HPIQ== X-Forwarded-Encrypted: i=1; AJvYcCVT/VbgBOnXdETKwdlDLVj0nWSyCJx9gc8MDP32Bp3MjOscMC6FPxoTNNk4eAAaaWeluwiofyjmHBAlHgQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyjGbT0eYtOYc+dKxq4IVCYJet/6mXoL+H2xuhIuf72G2QjqGiO SNWl8HgtoRV0k7OxZ9VgS7M2tcdSjXoFdqc/yvn0UEb4URAyFXm4pLSj28r8pQZcNRTpVZW/5Fb c/4Lelph/6GTSDxDi1qb9N7vJlprQC2TAs4TA6QypBVbNQHkte0rG8mgVyjF1W5LyZJQ= X-Gm-Gg: ATEYQzz/jHWPW24TF/jqqFZG9twYCGqqNY3wfTunuoXK7NMPTHKla2QUGbmKav+wwgv J+Eq39NGx+g4GheaVKaboZCEqrbcvBRptuxPcRS+ypP17d2l+vTvLcGhTpdq72nSWHGZGZd5Kcu 2yCwCqANeFTM11BV+IPbbT8zX1EguOF+y/1qxgZA1Vp09+igkQHgNQ7hiAif6ROuPaIZw1wDDqr E376gB619B06kCcWWYDEcNpebsTMRJQFi1HBNOEUM9kCgkJg2AvhUfFTegELICIeO0gu1SvUg8v 24VeLDivs5MDQdGAfbtNGPSK11ydOLirdVrNtISuWU2E7BOoqux+x0oyHNnpduksjamNjrOsI5+ AzwSOugkQqOaV47QgKw0f3/yLuKhKc5JPRfL8fvDhQrNOv/8sSg== X-Received: by 2002:a17:90b:47:b0:35b:9ab6:1d4a with SMTP id 98e67ed59e1d1-35bb9f2e18emr2458666a91.18.1773834573666; Wed, 18 Mar 2026 04:49:33 -0700 (PDT) X-Received: by 2002:a17:90b:47:b0:35b:9ab6:1d4a with SMTP id 98e67ed59e1d1-35bb9f2e18emr2458641a91.18.1773834573169; Wed, 18 Mar 2026 04:49:33 -0700 (PDT) Received: from hu-wasimn-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c741e543579sm2351542a12.16.2026.03.18.04.49.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 04:49:32 -0700 (PDT) From: Wasim Nazir Date: Wed, 18 Mar 2026 17:19:16 +0530 Subject: [PATCH v2] remoteproc: qcom: Fix leak when custom dump_segments addition fails Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260318-rproc-memleak-v2-1-ade70ab858f2@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIADuRumkC/3XMQQ6CMBCF4auQWVvCFK3IynsYFqUOMpFSbLXRk N7dyt7NJP8k71shkGcK0BYreIoc2M055K4AM+r5RoKvuUFWUlU1KuEX74ywZCfSd1GrIw0NoVb 7HvJm8TTwe/MuXe6Rw9P5z8ZH/H3/SREFipPq8YCNzh6eXQjl46Un46wt84EupfQFSLEQybEAA AA= X-Change-ID: 20260316-rproc-memleak-367ef8e1a64b To: Bjorn Andersson , Mathieu Poirier , Rishabh Bhatnagar , Gurbir Arora , Siddharth Gupta Cc: kernel@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Mukesh Ojha , Wasim Nazir X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773834569; l=2218; i=wasim.nazir@oss.qualcomm.com; s=20250807; h=from:subject:message-id; bh=BrZuPlklCAo71qWA5RBbDtAMQZKPiERrhde+rkkQchE=; b=lyyyjlH5zeW1Pqi+u+EtZk3SE7wbtbfu/CEk5yxYGfMcTz56GvcJtHglpaJjOyvZU03w8GYkt X8s8qrAv6y7D4Oxx71HpQMUN2+RVVosLqaMYApOuiXs+YbU5+uRTKXL X-Developer-Key: i=wasim.nazir@oss.qualcomm.com; a=ed25519; pk=4ymqwKogZUOQnbcvSUHyO19kcEVTLEk3Qc4u795hiZM= X-Proofpoint-GUID: loRhS1lGCxABHhWetWuNqJFCL6XS6Pz1 X-Authority-Analysis: v=2.4 cv=FKAWBuos c=1 sm=1 tr=0 ts=69ba914e cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=BdrfqlbclRokfh3ynYUA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE4MDA5OSBTYWx0ZWRfX3HDzjqItJgYg l4bXzAknRpaqDdW1kLvrDbYq1vwAVg/BbjbRugCvQ+tMwmLgEj/MyxF9jPwD34Md5gs8Th8d7Ro vJQo5C0EfOhHErYKYvZ2YN3ChbWOHZj7o7JBfr8zB1qDUo2XwJVmvJxrU+63z98gBQ1V2lrPhkG Ygi34kt/payOVrOVOxKk1QKtPRSh/bhEcuwoQhNwZgqLkBEQRxbOqauEj/q6dWu/rncb/LUf8x1 p3pAYqMPgrTWWICJnxgpw2vnwDXCbn+mvzmz3BeT79xNYWTHdZgxPyLn2l7Qoc/jkdIc+Z5nWOu vfF3m1gZ20HBac+dUXiqw/+X9VzMnSR5vwnlirQKlhGiPMWjjtoy5Rh+3t4Skua//dCRZuIILUf 4bjK84jFHOC3UBpRyLxPv6uB1ySLHSvDoa0/ZBgn3D65eO34q2bvuJeG1Znh9K/YAgebseW9GDl 1bAYygO73+DGwvjvgnQ== X-Proofpoint-ORIG-GUID: loRhS1lGCxABHhWetWuNqJFCL6XS6Pz1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-18_01,2026-03-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 adultscore=0 bulkscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603180099 Free allocated minidump_region 'name' in qcom_add_minidump_segments() when failing before adding the region to 'dump_segments'. Otherwise, the 'name' is not tracked and is never freed by qcom_minidump_cleanup(). Return error when adding to 'dump_segments' fails. Cc: stable@vger.kernel.org # v5.11 Fixes: 8ed8485c4f05 ("remoteproc: qcom: Add capability to collect minidumps= ") Reviewed-by: Mukesh Ojha Signed-off-by: Wasim Nazir --- Changes in v2: - Add fixes tag in commit. - Add stable mailing list in cc. - Link to v1: https://lore.kernel.org/r/20260316-rproc-memleak-v1-1-96b1518= a1a61@oss.qualcomm.com --- drivers/remoteproc/qcom_common.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/remoteproc/qcom_common.c b/drivers/remoteproc/qcom_com= mon.c index 6c31140268ac..aa93d3324561 100644 --- a/drivers/remoteproc/qcom_common.c +++ b/drivers/remoteproc/qcom_common.c @@ -110,6 +110,7 @@ static int qcom_add_minidump_segments(struct rproc *rpr= oc, struct minidump_subsy struct minidump_region __iomem *ptr; struct minidump_region region; int seg_cnt, i; + int ret =3D 0; dma_addr_t da; size_t size; char *name; @@ -130,17 +131,22 @@ static int qcom_add_minidump_segments(struct rproc *r= proc, struct minidump_subsy if (le32_to_cpu(region.valid) =3D=3D MINIDUMP_REGION_VALID) { name =3D kstrndup(region.name, MAX_REGION_NAME_LENGTH - 1, GFP_KERNEL); if (!name) { - iounmap(ptr); - return -ENOMEM; + ret =3D -ENOMEM; + break; } da =3D le64_to_cpu(region.address); size =3D le64_to_cpu(region.size); - rproc_coredump_add_custom_segment(rproc, da, size, rproc_dumpfn_t, name= ); + ret =3D rproc_coredump_add_custom_segment(rproc, da, size, rproc_dumpfn= _t, + name); + if (ret) { + kfree(name); + break; + } } } =20 iounmap(ptr); - return 0; + return ret; } =20 void qcom_minidump(struct rproc *rproc, unsigned int minidump_id, --- base-commit: b84a0ebe421ca56995ff78b66307667b62b3a900 change-id: 20260316-rproc-memleak-367ef8e1a64b Best regards, --=20 Wasim Nazir