From nobody Mon Apr 6 16:45:58 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9767523505E for ; Wed, 18 Mar 2026 19:00:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773860453; cv=none; b=YQIVXA0Fry6lhV5e1P/YENTjcZfTQeI3NnVvtUaiVygWVFsev1AtYs+inTwc2V6E8vxeFQoyh41jgB4N9bPPPfltu+/6658gMYy45TQ++eyGv2NEojHWW+lQSNtvNpq+Io47WDNGUNeYcgifIlqR93nv3tthzBNca0FQ4uXrPfY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773860453; c=relaxed/simple; bh=l05p2P8jbPIsUaFo7Qj8Qp6JYdNm4AXrHDpNPS/Z3vo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=IeaX0qdvjuLufQqNDTCkUNpuQuOcouXUOqCauf32+ncS45ijXmmw2iPXtjh7qDVl7aTptWfZGxdX6fajP5ar/6zvovXLz5Anh1oDU/h/BCWlLbXBLv5RJVV2VMHueRWyAqNM9MaD9Qv+/ShdZNTH34oiV8uQPTS+GEvLkZcZ650= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=FvpzYI3T; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="FvpzYI3T" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4852c9b4158so1553025e9.0 for ; Wed, 18 Mar 2026 12:00:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1773860450; x=1774465250; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=CoGjFN/z+qtdjAUEKN5brTEgWB6PlxMWaZaSRuHaNgI=; b=FvpzYI3TMZtiRqYuBcZIDIFxWVLoJMA24xwzUec9+kzJoGp6QLkaaWOMIddMLVdCMm xAdhNhXyiFUFQZFwtpmoWZqUtEy2+TRiEXrda74Z1q4qixlbgONEKk6oKY0ikX+GztVd Dwxz8tavYSK0Z6eho0e3slWL/iaIbCA6x8hEsaBwzGnNY3A/iUwkEJeTm3Y6/PfZb8Dc 4hj1h4jZENndxSt/+VQqiWQuJDqM7UfXbDvyNvmW/wxR5/3BgN+sAU+qx3rifud85fgF 8de+tKkztX1JNdF1zY9oNx4mO7zqXbSvclJIwz5j1+/uIhhg5S2w8UWnkLWkMHJe34zM n1Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773860450; x=1774465250; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CoGjFN/z+qtdjAUEKN5brTEgWB6PlxMWaZaSRuHaNgI=; b=WM/rHUgsjoQg2vIMNCO96UkoY9Wn2GJmd7sdEKY4+2eFZxPZE8NbTaczr7HgRZC8By ZpcWT+ThpQAufiDSo5ElF/Veb3n4oa2LqUXYsLy+1oojzLtCHkUzSuTQ2+WgPGMNMOGG oSuF9BG16YNSKxafWDaMgWe7MCNjV5s/qpWt8iOpwvV3Q4L1MVuQtUKC7L0neCiJesME oE3314Ugv5SNnMJBMuaBKVAujpUbCk84jVX+j+OBWbGo6b5jIG1oaFEegD5ggj+NLGlI iwDkmmJkQwy9Z9CDL0mtWfpwxYTbN7QIlRvccpw+I/YpP5mc4/BslXx2eKkc2aJs7sqB SxJg== X-Gm-Message-State: AOJu0YzO+RS0aC3NbhWdPwFrDDehbuH5gagtoPFHZZW3QdJfoF09ZM0k Y3ts4upmJB/KJj5FAr4bdwiswHKCScOMnWmjlCOPgnpzcKR++G+LyKYTa0q0GUGL4ds= X-Gm-Gg: ATEYQzzBFw5cgbnkp2vTMxlZoIVjGRejB2pIMxZM3m25pxcGAZjEKap5NVQ/7KqB6gg /3tLUoJVw0ipCQ+yemzWCB6NtyIryMliqEoDKSb91Jrm4yEoIhqgKsVe2uxEnHXyDHXKqqjW3I2 7fvwxRAJyIgjQNkmZLiEDZ8gWW0CHhFBU+6OprzAb1wVYogD75+jf+VxFYBa9vXIOFyMKVYinn0 W/r96N8YK6cUeUh8unfMyBtmp/8wOy0fHD5lBmOE16OyisXHflqnjUV88G31/6/k2CG8g51dCxq ajyOpc3Djz8wuhrbirjqA1eh3EFN4B7gc23sqopg4ayTW74PM9Oi+w5enwOMyx31TNQIWnYTpbo 1tgccVEpE08qVTcauJPGx1H4Cr2XeSNjerQQPe7bvBIdXir77Bs0jyDPFYOePUiFaB7vjg+4AZp JKzCk0N5YEFg== X-Received: by 2002:a05:600c:3224:b0:485:6cd3:f7ac with SMTP id 5b1f17b1804b1-486f446b04amr47252565e9.20.1773860449835; Wed, 18 Mar 2026 12:00:49 -0700 (PDT) Received: from localhost ([189.99.238.44]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79a7136de7bsm22098397b3.2.2026.03.18.12.00.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 12:00:49 -0700 (PDT) From: =?utf-8?q?Ricardo_B=2E_Marli=C3=A8re?= Date: Wed, 18 Mar 2026 16:00:43 -0300 Subject: [PATCH] ktest: Store failure logs also in fatal paths Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260318-ktest-fixes-v1-1-9dd94d46d84c@suse.com> X-B4-Tracking: v=1; b=H4sIAFr2umkC/x3M0QqDMAyF4VeRXC+s6uxkryJe1C6dYVAlKSKI7 77My4/Dfw5QEiaFV3WA0MbKSzbUtwriHPKHkN9maFzjXVv3+C2kBRPvpNj5R/v00cXOJ7BiFbo GC4bRPAUlnCTkOP8/rvSeFsFMe4Hz/AHDBEpzfgAAAA== X-Change-ID: 20260318-ktest-fixes-564376c0c56f To: Steven Rostedt , John Hawley Cc: linux-kernel@vger.kernel.org, =?utf-8?q?Ricardo_B=2E_Marli=C3=A8re?= X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openssh-sha256; t=1773860445; l=1202; i=rbm@suse.com; h=from:subject:message-id; bh=l05p2P8jbPIsUaFo7Qj8Qp6JYdNm4AXrHDpNPS/Z3vo=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgguRCc5X8/UX9M40lkMnr//aFGOhce x5ezt8MFNUFlqYAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QG2+0jQuWaWsn4mXVLNiRKs6qgNgaQVyZ2/YWsLLCy38rytv5rya6hSaMthjtqrmACMzuAwVHNd KC5c2tiThBAA= X-Developer-Key: i=rbm@suse.com; a=openssh; fpr=SHA256:pzhe0fJpYLz+3cZ33FFPhIfaUElk9CXPFFXmalIH+1g STORE_FAILURES was only saved from fail(), so paths that reached dodie() could exit without preserving failure logs. That includes fatal hook paths such as: POST_BUILD_DIE =3D 1 and ordinary failures when: DIE_ON_FAILURE =3D 1 Call save_logs("fail", ...) from dodie() too so fatal failures keep the same STORE_FAILURES artifacts as non-fatal fail() paths. Signed-off-by: Ricardo B. Marli=C3=A8re --- tools/testing/ktest/ktest.pl | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl index de99b82d16ad..112f9ca2444b 100755 --- a/tools/testing/ktest/ktest.pl +++ b/tools/testing/ktest/ktest.pl @@ -1635,6 +1635,11 @@ sub dodie { print " See $opt{LOG_FILE} for more info.\n"; } =20 + # Fatal paths bypass fail(), so STORE_FAILURES needs to be handled her= e. + if (defined($store_failures)) { + save_logs("fail", $store_failures); + } + if ($email_on_error) { my $name =3D get_test_name; my $log_file; --- base-commit: 229517449879b3ca8ca5588593cbea6a67ba0ad2 change-id: 20260318-ktest-fixes-564376c0c56f Best regards, --=20 Ricardo B. Marli=C3=A8re