From nobody Mon Apr 6 20:11:40 2026 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD90D3B4E99 for ; Wed, 18 Mar 2026 09:24:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773825852; cv=none; b=CUULwSz4ejxOpHl9dB4OwRCL5BMC3m6deQj3Fn8T3TRiXQfpusUxCieaI5BySFr9owdpZ0PD7e3lX53nvdQoPLPf1vQ05f2kUflC1loDMypw/9sScjoxBLLQXCOsIM3/IjYYWSQuM5qxmr/VMYidlJyB5S/ObTBku2oxZ5+yGQc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773825852; c=relaxed/simple; bh=adUNrc5DmhRHUleLGmdaxH9/D4sLCU6UUObKtpN1GPU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=j0wXbIcTbSNvgAwfsfVawvXimFjVrPtgPM01hzD+UkVJkKzbVbt+arHnCy6hpoUuWThkVuDGrW7ATkrmtSatmb1rBkhO64wZVTXX05EynhK2VKQOlYP9TGEqygbSK4nmde2g7RQ5EriSGlwPjDpR9spVbdAaqzLn8QGbVZBJ+/4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=bfKIO4+m; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="bfKIO4+m" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-6611e4aefdcso989870a12.3 for ; Wed, 18 Mar 2026 02:24:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1773825849; x=1774430649; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=zZzaejzhKh2/pl8uBJakl190/CtTYCUrflLlLKsisxI=; b=bfKIO4+mtjuMcQNbIWJWPJGrwJm1nBY3Nj6e/ojm3sart/NFD/nsgMXOvFmw61uFKu atAQzZde7AuT+FGErxtBvA7Y2GnmHcVZKvX2kZUzoz6idSjehZJsyYeqb/tMDPTjCVbl acc5S8mAMyH0+L4fVo0gfGvENBnAlzLlAmoAsxFReJnM3oP28HG9SwjBTUVj2P+80cvt k6bPvxnueeBELo9a7yk3Cjc6fJIhwe84yD777liyLtXw6R5CXC1FQAv+2t3+TeOcyRhq NFjRgeBH1hjFwLeFdIHgSkvWPU/yn1YBH3Q1HWPGzzMCnqpYB37IXSsRpetjqQRpHjYh ODBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773825849; x=1774430649; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=zZzaejzhKh2/pl8uBJakl190/CtTYCUrflLlLKsisxI=; b=Dn9t1DcUvpHfeCtngJn2vErQmDLvVxRtx0wEO0XY0HaPpzyMsPNis/PpMrIeHj3sUw NH7OAgPdOkSeYkXEmE5FINQWiMhe8DbbAVKNPP7uVcaVhXzgxwiBkb84or6Xybu9S6SI NnhtuWL4roPlpBTZ5P3PUtFE5DmmyChFj9ZH5SLteAwYugPp5yWLTOVrAGucLTBaAg6I wM0gj3Vr0vTsu77XoZ0z+KUhxrXQLhLyrJhii1mJubMbgeF78ytAf0nyi/zTHw/nFnzG Cyc6ha4o3lYK8SlSMNIBMf2H4I1xZ/mI2P/oCWqhT6T1o9rbJJTDoRSVBAsEnxbQHpsb jtlA== X-Forwarded-Encrypted: i=1; AJvYcCW1lLOAoNfEAMeKxz1GpL9qAeKcgQpnvhfSBihT+aW6pfNAQn+FDfG8mVIJCJJLt167eAVBsyfxlLqfc1Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0Ss6glkaJlF6cvyKuWQgMOCNK6CqbVAcl8PW/xh443ZVr0Jtn Wg8EBAWg5ZCkPnd7rn3lqWyt5JJROaPQVDtKUNNS+SHHB/pTw8ettnRJSsnMAXvFxos= X-Gm-Gg: ATEYQzyeL4E7Qq6gm8LYPSF5HHvmkIyz3QzGTe8nvE/fwmVhsFDJauiLyxAFBDUADLI DJU53GXUYlyiY996aYx2rvWn79UJAoTYj/wSgGQseC1F6i+Oa3XK92U5GZqU/b/IxkTZ7/iKXvd 3CskpLQIyOFat0riRqgE+G9b38/GlTg61WedbSrcbH/8fDuI9TDmHDSEtr0ZutMHMU07dxrs9Qi Mj1FhfMl9FsOZLUJEliWolmrUwI83pyZM9+wpYPkLkFYM+OZPMW0e4byX71c2+T2ZH7qpqM/Nt5 KVWCvt44FrxsJoH2kYITYlylXcnJ1vHvE+NicIysTMOQ3H9wh2hYUITLDLhj7mP8ZvaH7nteTec wPB/DeaqJLSoo97Hca8rQd2+ItUxPZFQrVs8KEjVcxod5CsHQ0Azi8EjiQOytxU1VP6Ew7L3VST wLAVO5tNHZ+N7QII73rlCu2UET7zRC64n3r7x9xtf19dY= X-Received: by 2002:a05:6402:4304:b0:667:186d:7afe with SMTP id 4fb4d7f45d1cf-667b214d7f1mr1907362a12.6.1773825848904; Wed, 18 Mar 2026 02:24:08 -0700 (PDT) Received: from alchark-surface.localdomain ([193.32.126.212]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-667afb4cf11sm1309970a12.13.2026.03.18.02.24.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 02:24:08 -0700 (PDT) From: Alexey Charkov Date: Wed, 18 Mar 2026 13:23:46 +0400 Subject: [PATCH v3 4/4] usb: typec: tcpci_rt1711h: Drop unnecessary VID/PID/DID checks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260318-husb311-v3-4-2b32e6192b9c@flipper.net> References: <20260318-husb311-v3-0-2b32e6192b9c@flipper.net> In-Reply-To: <20260318-husb311-v3-0-2b32e6192b9c@flipper.net> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heikki Krogerus , Greg Kroah-Hartman , Gene Chen , Yuanshen Cao Cc: Sebastian Reichel , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Krzysztof Kozlowski , Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3767; i=alchark@flipper.net; h=from:subject:message-id; bh=adUNrc5DmhRHUleLGmdaxH9/D4sLCU6UUObKtpN1GPU=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWTuytcIa+Ct/yLxZ2eku05C/ZELKxxZmld7XUlITA43b rujcGBNx0QWBjEuBksxRZa535bYTjXim7XLw+MrzBxWJpAh0iINDEDAwsCXm5hXaqRjpGeqbahn aKhjrGPEwMUpAFO9io2R4V362fzmOT8tulazp96L+mZnuNPYKuyAfWu4yxOd0zw9LQz/017lTzJ iMk26U9Aiu7hZY0eHmmbtt+nKIbGbd3wMO6nJBAA= X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 Existing checks for VID/PID/DID in the driver are redundant since the driver is already matched to the device via I2C device ID and OF compatible strings, and they preclude the use of fallback compatibles. Remove them to make the driver slimmer and adding new clones easier. Signed-off-by: Alexey Charkov Reviewed-by: Heikki Krogerus --- drivers/usb/typec/tcpm/tcpci_rt1711h.c | 59 ++----------------------------= ---- 1 file changed, 2 insertions(+), 57 deletions(-) diff --git a/drivers/usb/typec/tcpm/tcpci_rt1711h.c b/drivers/usb/typec/tcp= m/tcpci_rt1711h.c index 37cf55ad74f8..4b3e4e22a82e 100644 --- a/drivers/usb/typec/tcpm/tcpci_rt1711h.c +++ b/drivers/usb/typec/tcpm/tcpci_rt1711h.c @@ -18,13 +18,6 @@ #include #include =20 -#define RT1711H_VID 0x29CF -#define ET7304_VID 0x6DCF -#define RT1711H_PID 0x1711 -#define RT1711H_DID 0x2171 -#define RT1715_DID 0x2173 -#define ET7304_DID 0x2173 - #define RT1711H_PHYCTRL1 0x80 #define RT1711H_PHYCTRL2 0x81 =20 @@ -57,8 +50,6 @@ =20 struct rt1711h_chip_info { u32 rxdz_sel; - u16 vid; - u16 did; bool enable_pd30_extended_message; }; =20 @@ -304,35 +295,6 @@ static int rt1711h_sw_reset(struct rt1711h_chip *chip) return 0; } =20 -static int rt1711h_check_revision(struct i2c_client *i2c, struct rt1711h_c= hip *chip) -{ - int ret; - - ret =3D i2c_smbus_read_word_data(i2c, TCPC_VENDOR_ID); - if (ret < 0) - return ret; - if (ret !=3D chip->info->vid) { - dev_err(&i2c->dev, "vid is not correct, 0x%04x\n", ret); - return -ENODEV; - } - ret =3D i2c_smbus_read_word_data(i2c, TCPC_PRODUCT_ID); - if (ret < 0) - return ret; - if (ret !=3D RT1711H_PID) { - dev_err(&i2c->dev, "pid is not correct, 0x%04x\n", ret); - return -ENODEV; - } - ret =3D i2c_smbus_read_word_data(i2c, TCPC_BCD_DEV); - if (ret < 0) - return ret; - if (ret !=3D chip->info->did) { - dev_err(&i2c->dev, "did is not correct, 0x%04x\n", ret); - return -ENODEV; - } - dev_dbg(&i2c->dev, "did is 0x%04x\n", ret); - return ret; -} - static int rt1711h_probe(struct i2c_client *client) { int ret; @@ -349,12 +311,6 @@ static int rt1711h_probe(struct i2c_client *client) =20 chip->info =3D i2c_get_match_data(client); =20 - ret =3D rt1711h_check_revision(client, chip); - if (ret < 0) { - dev_err(&client->dev, "check vid/pid fail\n"); - return ret; - } - chip->data.regmap =3D devm_regmap_init_i2c(client, &rt1711h_regmap_config); if (IS_ERR(chip->data.regmap)) @@ -408,27 +364,16 @@ static void rt1711h_remove(struct i2c_client *client) tcpci_unregister_port(chip->tcpci); } =20 -static const struct rt1711h_chip_info et7304 =3D { - .rxdz_sel =3D RT1711H_BMCIO_RXDZSEL, - .vid =3D ET7304_VID, - .did =3D ET7304_DID, - .enable_pd30_extended_message =3D true, -}; - static const struct rt1711h_chip_info rt1711h =3D { - .vid =3D RT1711H_VID, - .did =3D RT1711H_DID, }; =20 static const struct rt1711h_chip_info rt1715 =3D { .rxdz_sel =3D RT1711H_BMCIO_RXDZSEL, - .vid =3D RT1711H_VID, - .did =3D RT1715_DID, .enable_pd30_extended_message =3D true, }; =20 static const struct i2c_device_id rt1711h_id[] =3D { - { "et7304", (kernel_ulong_t)&et7304 }, + { "et7304", (kernel_ulong_t)&rt1715 }, { "rt1711h", (kernel_ulong_t)&rt1711h }, { "rt1715", (kernel_ulong_t)&rt1715 }, {} @@ -436,7 +381,7 @@ static const struct i2c_device_id rt1711h_id[] =3D { MODULE_DEVICE_TABLE(i2c, rt1711h_id); =20 static const struct of_device_id rt1711h_of_match[] =3D { - { .compatible =3D "etekmicro,et7304", .data =3D &et7304 }, + { .compatible =3D "etekmicro,et7304", .data =3D &rt1715 }, { .compatible =3D "richtek,rt1711h", .data =3D &rt1711h }, { .compatible =3D "richtek,rt1715", .data =3D &rt1715 }, {} --=20 2.52.0