From nobody Thu Apr 2 01:49:40 2026 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FC163E3C6E for ; Wed, 18 Mar 2026 15:28:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773847696; cv=none; b=JbNnQ0pWfsdrLksabYJCflgcextjRzbqoh9TMwuQRMpEtJtaeR1pYP0Q1P8mnzNHroTBoWnps1SRzBYeFC6OzO0EhXeIbxwD0t2hP0zs3mNqa+XeQ4Gcmi+rnTJ4j6CNlnnDPjcgNXJkFpjg/voJFmpWv6Sx1+MiA3BphCL5f0I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773847696; c=relaxed/simple; bh=6sDUse3Gsz/EvIu2exz7kbl0iyrErcAU5VbpCSGeG7c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=maLKkx28HTUV3q4QC4343exd4O6B53ffFU4srAcWhSNoV4QA9j8pg424XR2+b7ZnbBt1aF3TJsW1DcE01txYYxB8QaW0UOMIXQDvyEldnGPMOSubMaJamiXMRVHAPiCyvQ0wQh9t40r+NxqmPO4eQgTIgDKdi5qbxHCLCJdzj1E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fXhB7LJz; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fXhB7LJz" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-b97b30fa5e5so623391366b.3 for ; Wed, 18 Mar 2026 08:28:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773847685; x=1774452485; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=02tyCAuDgIFu9biWUbxZXHp6fnkY15VCU6AYSHfqVA0=; b=fXhB7LJzNuPGdJHoowXe2Yt63IHYbZy5eSTuJqD1TI5ZjtFT34DfvyfQeSiilxaK/V mVnC1INh8BYRPg7evKtorROI2151TQXwEnl6uw0TYQqLAaXluBELS3YL1G22VtorSaeo wPQ7jVhvS/Rvv7voUaji+wv7Tt31ukL6G7HMaUWdUVc162B9keSZJT+7+1O4pJUaGgA1 aRdzJykGrK/xvJOpdk3Ctobwhk47F922mHFUIs2t4kn7dTrBsuI2p0k2sN6tqNuGLjvX ADV1ZEV7ZU9cGsYAvWk6nG7EAUh0uHCli7LGGuEj7TTrPnp2kgkIixvsFBvGBaSkitkY noqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773847685; x=1774452485; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=02tyCAuDgIFu9biWUbxZXHp6fnkY15VCU6AYSHfqVA0=; b=XGpY1w+3LHnNZnnm2yipgf6yr/G/jd3xWwQ7YFwELp3WHXboPnf03ElRs7ubRSkV1X oHHYvm/JOfOE6DYyLW3t/edkBTx0DrwM1+QR8uAqyKvzSDdaDyQbJgAOSjSb566v+sbI jNr5dzDyL03mKUFrxSPMNcWlM8ojdlgyUFYJmNbtmN/T2s28GPwb1VxEO/zt2UlvKnPp TA29POTPSPFUIGv6EIOGBJz1RNCEyHde7AqBjQF/pRAIHwh9Ebv4c4SVBTCf72irKW0y 2etKe/F+TMWV38RA48fXy7bMw9b1rDNQw0aNRlwgniHK1z6cqnK4ZLR5+gmsPnjE8rMC o73A== X-Forwarded-Encrypted: i=1; AJvYcCUav98kuRyVDXw96XQxT3wg0w6reaueOcT8xy0W3CDSuIRYwJpyCEXLtdZ6dU6fgEBrwB8mFFerzZIE6XM=@vger.kernel.org X-Gm-Message-State: AOJu0YzoD+aDVpBlaLWC7Mz2moGi7S9xouXoANWVfPg+DwKmC+u46jXZ WSyRAtSVZSD6rI3RI5IectMH1s9xoXk1DxtINa2QZ7BvIyuOorEinqfrPRiID/lI9hw= X-Gm-Gg: ATEYQzxsxkq6S5S9hltd6A1nzAb2GyUXCt/YzH/1ab5nFvhq0m17OhERlULtQVPnuHV pa1oSOIbqt6zAdGjpLNZAqHktDJgowMvL9ptfsnIeQOfz0z3jtpMORlsGNqpEXVoCNn8cYjtqlr JPCZ1ubJu3JYMx1DLiwBcPWn3f/ETOYPpmTh64Qi0BBf3uWc7WXhpR7pJYs8uOKlO478NChxNPl 3InYOiYqwFdZ0t3gLEQIlQOhogRHRgEos5VFbGzcTG5+jBx8nu7Y33/BlwAeVZFO2ztCWsV0fDD GbBb1IgOJ8VfmKsmhDJYzjYuUJPKyCE2Ej+1Ll90zud2jRW/UdvilrMQKNNrqmFQ4h07mTW7SAf CXEkY957RiqhB60HsrjJ42vbbCQPd2MpY778LSe6hhICvvEXgmsWT51CFg1blb8XNapRmJwFv8n f7JPIlZX2xkQ+//MQ0x4kqWgSJq+UnUQBVSd1wyI8yuxuGpAN6tNr/dwuqZ7hWULoseeGdY5XIp hhKxiIP+ptgFPk= X-Received: by 2002:a17:907:3e89:b0:b8e:a1ad:36d3 with SMTP id a640c23a62f3a-b97f4ac9dcamr257964866b.46.1773847685322; Wed, 18 Mar 2026 08:28:05 -0700 (PDT) Received: from puffmais2.c.googlers.com (221.210.91.34.bc.googleusercontent.com. [34.91.210.221]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97f173a3e3sm226989566b.61.2026.03.18.08.28.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 08:28:05 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Wed, 18 Mar 2026 15:27:55 +0000 Subject: [PATCH v8 10/10] pmdomain: samsung: implement domain-supply regulator Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260318-gs101-pd-v8-10-241523460b10@linaro.org> References: <20260318-gs101-pd-v8-0-241523460b10@linaro.org> In-Reply-To: <20260318-gs101-pd-v8-0-241523460b10@linaro.org> To: Krzysztof Kozlowski , Alim Akhtar , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Ulf Hansson , Liam Girdwood , Mark Brown Cc: Peter Griffin , Tudor Ambarus , Juan Yescas , Will McVicker , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.3 Some power domains on Exynos are fed by a regulator rail and therefore regulator control needs be implemented for Exynos power domains. On Google gs101, HSI0 (USB) is one example of such a power domain. While at it, add a to_exynos_pd() to avoid direct use of container_of() in various additional places, and update existing code to use it. Signed-off-by: Andr=C3=A9 Draszik --- v8: - add missing \n in some of the new log messages --- drivers/pmdomain/samsung/exynos-pm-domains.c | 53 ++++++++++++++++++++++++= +--- 1 file changed, 48 insertions(+), 5 deletions(-) diff --git a/drivers/pmdomain/samsung/exynos-pm-domains.c b/drivers/pmdomai= n/samsung/exynos-pm-domains.c index d2e00f8310ce..3b5e84ca2dec 100644 --- a/drivers/pmdomain/samsung/exynos-pm-domains.c +++ b/drivers/pmdomain/samsung/exynos-pm-domains.c @@ -20,12 +20,15 @@ #include #include #include +#include =20 #define EXYNOS_SMC_CMD_PREPARE_PD_ONOFF 0x82000410 #define EXYNOS_GET_IN_PD_DOWN 0 #define EXYNOS_WAKEUP_PD_DOWN 1 #define EXYNOS_RUNTIME_PM_TZPC_GROUP 2 =20 +#define to_exynos_pd(gpd) container_of_const(gpd, struct exynos_pm_domain,= pd) + struct exynos_pm_domain_config { /* Value for LOCAL_PWR_CFG and STATUS fields for each domain */ u32 local_pwr_cfg; @@ -39,6 +42,7 @@ struct exynos_pm_domain_config { struct exynos_pm_domain { struct regmap *regmap; struct device *dev; + struct regulator *supply; struct generic_pm_domain pd; const struct exynos_pm_domain_config *cfg; u32 configuration_reg; @@ -64,12 +68,10 @@ static int exynos_pd_access_controller_power(struct exy= nos_pm_domain *pd, =20 static int exynos_pd_power(struct generic_pm_domain *domain, bool power_on) { - struct exynos_pm_domain *pd; + struct exynos_pm_domain *pd =3D to_exynos_pd(domain); u32 timeout, pwr; int err; =20 - pd =3D container_of(domain, struct exynos_pm_domain, pd); - if (!power_on) { err =3D exynos_pd_access_controller_power(pd, power_on); if (err) { @@ -126,14 +128,45 @@ static int exynos_pd_power(struct generic_pm_domain *= domain, bool power_on) return err; } =20 +static int exynos_pd_regulator_enable(struct regulator *supply) +{ + return supply ? regulator_enable(supply) : 0; +} + +static int exynos_pd_regulator_disable(struct regulator *supply) +{ + return supply ? regulator_disable(supply) : 0; +} + static int exynos_pd_power_on(struct generic_pm_domain *domain) { - return exynos_pd_power(domain, true); + struct exynos_pm_domain *pd =3D to_exynos_pd(domain); + int ret; + + ret =3D exynos_pd_regulator_enable(pd->supply); + if (ret) + return ret; + + ret =3D exynos_pd_power(domain, true); + if (ret) + exynos_pd_regulator_disable(pd->supply); + + return ret; } =20 static int exynos_pd_power_off(struct generic_pm_domain *domain) { - return exynos_pd_power(domain, false); + struct exynos_pm_domain *pd =3D to_exynos_pd(domain); + int ret; + + ret =3D exynos_pd_power(domain, false); + if (ret) + return ret; + + /* Ignore regulator errors - the domain was disabled after all. */ + exynos_pd_regulator_disable(pd->supply); + + return 0; } =20 static const struct exynos_pm_domain_config exynos4210_cfg =3D { @@ -291,6 +324,16 @@ static int exynos_pd_probe(struct platform_device *pde= v) if (ret) return ret; =20 + /* get the domain power supply if required */ + pd->supply =3D devm_regulator_get_optional(dev, "domain"); + if (IS_ERR(pd->supply)) { + if (PTR_ERR(pd->supply) !=3D -ENODEV) + return dev_err_probe(dev, PTR_ERR(pd->supply), + "failed to get domain supply\n"); + + pd->supply =3D NULL; + } + /* * Some Samsung platforms with bootloaders turning on the splash-screen * and handing it over to the kernel, requires the power-domains to be --=20 2.53.0.851.ga537e3e6e9-goog