From nobody Mon Apr 6 19:39:22 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 737EE3D9DAF for ; Wed, 18 Mar 2026 14:01:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773842482; cv=none; b=hxEwfI7ttDEy4Y4KwpG5jbJdWvF136nDhRF21uRsN/y2tgUFgM0vibQ3LTeweVpL2xQc12YXAO33Tvr2t+tuw4FfPJS8ZmUb+IVaVginoMsVN7Jvs8CmmPASohWOQRnoluGWJ8i5x7gLHdeVH01puP+koqISNKyWjkI6QuJPmVA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773842482; c=relaxed/simple; bh=ubpNCg+eCquK/K4zeAZFihfdGgYEzRYx81jkET3tDO4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uM+4N1oFa3mU59P09L4ipcHmyb5MUpBU7B+rCWmWccyJNMt1oAvPsg8iOk7kjaxaNxu9dn3RVJEnjPRonD3nNnkdXQuipJAl4NO8ef5hMrEgKHYFr48JtaSh0PIJzUh/dssyh9LKZ100mu5h4GDGUNfOVReQU2ANNKbyJf9ZLkw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GJY6cqrp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=W2V64EKC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GJY6cqrp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="W2V64EKC" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62IBB9jh320090 for ; Wed, 18 Mar 2026 14:01:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 36+wA6uuRwTHM8WRBDoOkT5gScbIDxHTx6NZKKyP2iI=; b=GJY6cqrp3uRljkIR K9OAgHcieKrbz8qJLYsmiTvaHsiwHohA3Uex9QORM5ajOcbhc488o/dg3Uwu/NEv ZfC5QEdGfDy8uGQz6rcIRWrz/Rib2M6VCkWsmEwYbEEv8vv3Xr84KKwXXzjuAZWK BTgvEMreEBvBP9mqKQGbDuzrXw/fAFerl9s9nvsS185Msp4XO0TE7FEWfVv2vbif m2hN88JO/LogvU44dANtxNaHSBFib5YFZmgO3rKjHaS72T6Vny8Sc/wdcXu62wff TykDG3BtwN5QPvaDBlBrOp2NwZ+nSlVUmwX9Rj1F0elnEgJByYnj44SFnQT2zgXz 1rk1vw== Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cytxyrhg0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 18 Mar 2026 14:01:18 +0000 (GMT) Received: by mail-ua1-f70.google.com with SMTP id a1e0cc1a2514c-948476b92e8so13180257241.3 for ; Wed, 18 Mar 2026 07:01:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773842478; x=1774447278; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=36+wA6uuRwTHM8WRBDoOkT5gScbIDxHTx6NZKKyP2iI=; b=W2V64EKCDajW8ou0Mcdh6B4wMt4fbTT7XAOfr3MZ/kEWRhQromcWl+91wp9CpXMnsq k0Vlk7k09HseLpQgilxIxTEw5Exv+OK1zVTHXPZtvCB9+rHVctaGPcOZnztkuemY3YnS ntqJOpVuAfQlmCZu7u5Svy2/YLnTTvsA5pwwKWgtyOPJWKVnK8k+vhuYTEFCDO34TZEk zaNbxbKeZp2cSwGhtzkM0BGpb5zZc3f7x+OO5lHOX1xz6eQ6CHCVYq0xVM7L9CP3oLhW tpWm0kICo0d2V5A5dn9BRLFekxUxVl1P5MjYaekfpcux8hPu6GqAFtHaI4C0O9eCDZy0 F+mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773842478; x=1774447278; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=36+wA6uuRwTHM8WRBDoOkT5gScbIDxHTx6NZKKyP2iI=; b=pI58ux5FF42wB+c++oUbatrG1dIV7xDCHYqjBQgY28yXBGNnSO3vJz1ncKSYGAAXoO 7T6o1iSsx9xafhZdELM+UCcoVahHSI+WK9jds78VikuHWvVYW8KEK/PW03jmedCjW6zP SAoqZlakxBhqj+FHFLY/ldfTBOldxYAM+DXP0124bGx0Iax0k7u02mfsy0M5UAutDYtM 1nR/zuzOyzgt3ePGQXU/4A/DBkNYpOAPK7hqh4qw0NNfnury3m0lZ6LVCJnfk4zH9z08 o54GUji8R4wYGe3IL3HFzHkdkHAr8RjySRAwW2KdTEbE30kBfauPwNltavwSwJBjhBo6 gjbg== X-Forwarded-Encrypted: i=1; AJvYcCUrT7VFTEBRZjjTnNMitgQqn+1zXkWUFDFHtEHIkF1xzhpghaGopTiweyUIxBA880QWFjSyi4EpxOgiwh4=@vger.kernel.org X-Gm-Message-State: AOJu0YxnZ723gSd45QkYhHuin5y7grPZlKzaE0BbQGRMaTGdbSCx36Zg kYTQzJ2ckSSXQGMDSZHptrun0hAuOmxghZuDStgPY/gTtFB5T08Gp1UMbYQVeUbNqqzvvDd4O1H iPlQqvQCYv2wsiA4z1XjNS+ClquVlAZOaLL+zfYOvgqGDcAYO9VHlQcxyeL2PoExxcMM= X-Gm-Gg: ATEYQzxfV6o89kYwiqw8nLvNFpmJExBGjLK5wgY2zhxQWqkP78R6HVu4lBvU188IhVE EMunhskVggjnchF6d3Nw0KiBQ15xVyxCNgknAvw5vwo+E1qLv1SGd958pSaPovrTuQtJP+OnqjB puVcQvayfy4FR5JMEfaBQBqftM9vhlIjErVwTdpskIuX3HQeaUjqjsOGtZCnbArs8CImsSIw+G8 9EdnrkS7hPbr9Z4f2tnWzFWTRmYcym9GhWXEfVWTj7fyk4Ctt0NoKy9zzO6VZ+mx2QXfMdUpwfN NB+0lttEjkXQsD6mINIxn++EXNSfqLpVfiUC3zxQ0geQRR2LW/1u04zrJj14+83CgqhqxgdA3gr BMbAy0DKMa25On8Pe5j4pktWQukdGls87efptP1AY1IONPjHxN02A X-Received: by 2002:a05:6102:c93:b0:5fd:f509:c97 with SMTP id ada2fe7eead31-6027d2e45d2mr1342708137.18.1773842477598; Wed, 18 Mar 2026 07:01:17 -0700 (PDT) X-Received: by 2002:a05:6102:c93:b0:5fd:f509:c97 with SMTP id ada2fe7eead31-6027d2e45d2mr1342383137.18.1773842473091; Wed, 18 Mar 2026 07:01:13 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:b8ec:50c4:23a0:2505]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97f144e53bsm214207566b.25.2026.03.18.07.01.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 07:01:12 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 18 Mar 2026 15:00:53 +0100 Subject: [PATCH v2 1/2] gpio: shared: call gpio_chip::of_xlate() if set Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260318-gpio-shared-xlate-v2-1-0ce34c707e81@oss.qualcomm.com> References: <20260318-gpio-shared-xlate-v2-0-0ce34c707e81@oss.qualcomm.com> In-Reply-To: <20260318-gpio-shared-xlate-v2-0-0ce34c707e81@oss.qualcomm.com> To: Linus Walleij , Bartosz Golaszewski , Jon Hunter Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, brgl@kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4236; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=ubpNCg+eCquK/K4zeAZFihfdGgYEzRYx81jkET3tDO4=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBpurAiV0trUWpLMD6yT4Jeil+kPSMu1YX5vbP2I 0MXarRPmVmJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCabqwIgAKCRAFnS7L/zaE wyAFEACC3znYtj3MFeRpHPQanS2Fg25LyegJqVKr17u6WhOBTh7ZHeL4BltPOLZvXM9T8uJK9FG wa8TzWSKzzb0vzATj7lCBCdZAewjVByfrS4UKMYXbBF0fdKGyX7Ma6VPzv65wlc9UdSy04FB1fN Wg/RCKGImfUkQjjtWCqDIB4DTTRR8CQPGYT4tZn8ohMEYmSXJ+ilpMwBgr8SHoHCB0lXm4st6bH XRVCmTfJJdOHCq8Hzs0Vifs6P9u/fpHc3vepw81a+zlaOYW9hhAeZKoaTeHIbG7wc4sIdZS6NuL 1ns5DEbwyvWwfIMhPgClYwQQixDXT2HoBduFKSYrIX1HoWKyHGZEr8MviDKy6WU5PIkfhzv8SQd 7MrO4kUPwClil3MU86Pgeng0S5+ZIn57Fz2/HUOo2nVwmttblzEcxMpnMO/GMW8sDODBd0mrWaT cudJlRKAYdjbW9REdaPiolqAi2VHiKW/FnHIB3n/zmVBT1MLIpWsZ6V4enDZLNlI0AzVgpbadLU y0SJg26Y9c0uAZUdCZR86USnQNAwshNS+LSFqOd898FT85reyxfVP5XN2l2pjnXtg4d0Z79Zi0b u4HsI9gP58vUPq7d2al4tw+kZ3/agGbVcuqYLfJIUEGQtggm5BNX4tCTKOZH5+HG4AGiqZ+/MTD CDUhM1WTCKXdOtA== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Authority-Analysis: v=2.4 cv=FKAWBuos c=1 sm=1 tr=0 ts=69bab02f cx=c_pps a=R6oCqFB+Yf/t2GF8e0/dFg==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=Ikd4Dj_1AAAA:8 a=EUspDBNiAAAA:8 a=hgUgvgRoQYGt6P0yErkA:9 a=QEXdDO2ut3YA:10 a=TD8TdBvy0hsOASGTdmB-:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE4MDExOSBTYWx0ZWRfX6K6nLmphUBG4 spSRO3DQfzNNRQ5gkPLYKCDKjie10G2+pStolMzaWk3kIGM1cZlIehAQk/Cny2e9qViIDtYhy8O FXlN+MuL5ne3xCRvXz7tAi6+sIDqgJwRyabJ291uLVD5lEIgVEq7MTgTsqRFHpfa7YLAssp44BV gcAF7gByqyKlADPODCJFVxPHcn6IHTwo6WnM0PM4ju4PQk9R83AOUcJVpGWjGW8QbAQiCWQA/zV FV/gv7ATyZxtR6yC972zdVc3Fs9W/uAK0PXUbgyCgcdzg28VHo0fjpj6Z5dunw+vwHYFh5amtSI wQHcKCFYjTV+JgtDTB1WnCiGvh2xerqEdthLu4dkzl2kkUV+Gcrv1QHY1JJhPDjCHfwFtsM9xKd X2qSJaL3Qd5mb5Vyza8hMrTr0oGR1A== X-Proofpoint-ORIG-GUID: j5LP_eWgWt-VM4NrnXscDm7l5Y8E1Gsk X-Proofpoint-GUID: j5LP_eWgWt-VM4NrnXscDm7l5Y8E1Gsk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-18_01,2026-03-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 adultscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603180119 OF-based GPIO controller drivers may provide a translation function that calculates the real chip offset from whatever devicetree sources provide. We need to take this into account in the shared GPIO management and call of_xlate() if it's provided and adjust the entry->offset we initially set when scanning the tree. To that end: modify the shared GPIO API to take the GPIO chip as argument on setup (to avoid having to rcu_dereference() it from the GPIO device) and protect the access to entry->offset with the existing lock. Fixes: a060b8c511ab ("gpiolib: implement low-level, shared GPIO support") Reported-by: Jon Hunter Closes: https://lore.kernel.org/all/921ba8ce-b18e-4a99-966d-c763d22081e2@nv= idia.com/ Reviewed-by: Linus Walleij Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpiolib-shared.c | 27 ++++++++++++++++++++++++++- drivers/gpio/gpiolib-shared.h | 4 ++-- drivers/gpio/gpiolib.c | 2 +- 3 files changed, 29 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpiolib-shared.c b/drivers/gpio/gpiolib-shared.c index 17a7128b6bd9bf6023deccee50b2453caebe3d9a..3a8db9bf456daaf021d3c691677= a90fc6da15889 100644 --- a/drivers/gpio/gpiolib-shared.c +++ b/drivers/gpio/gpiolib-shared.c @@ -506,8 +506,9 @@ static void gpio_shared_remove_adev(struct auxiliary_de= vice *adev) auxiliary_device_uninit(adev); } =20 -int gpio_device_setup_shared(struct gpio_device *gdev) +int gpiochip_setup_shared(struct gpio_chip *gc) { + struct gpio_device *gdev =3D gc->gpiodev; struct gpio_shared_entry *entry; struct gpio_shared_ref *ref; struct gpio_desc *desc; @@ -532,12 +533,34 @@ int gpio_device_setup_shared(struct gpio_device *gdev) * exposing shared pins. Find them and create the proxy devices. */ list_for_each_entry(entry, &gpio_shared_list, list) { + guard(mutex)(&entry->lock); + if (!device_match_fwnode(&gdev->dev, entry->fwnode)) continue; =20 if (list_count_nodes(&entry->refs) <=3D 1) continue; =20 +#if IS_ENABLED(CONFIG_OF) + if (is_of_node(entry->fwnode) && gc->of_xlate) { + /* + * This is the earliest that we can tranlate the + * devicetree offset to the chip offset. + */ + struct of_phandle_args gpiospec =3D { }; + + gpiospec.np =3D to_of_node(entry->fwnode); + gpiospec.args_count =3D 2; + gpiospec.args[0] =3D entry->offset; + + ret =3D gc->of_xlate(gc, &gpiospec, NULL); + if (ret < 0) + return ret; + + entry->offset =3D ret; + } +#endif /* CONFIG_OF */ + desc =3D &gdev->descs[entry->offset]; =20 __set_bit(GPIOD_FLAG_SHARED, &desc->flags); @@ -575,6 +598,8 @@ void gpio_device_teardown_shared(struct gpio_device *gd= ev) struct gpio_shared_ref *ref; =20 list_for_each_entry(entry, &gpio_shared_list, list) { + guard(mutex)(&entry->lock); + if (!device_match_fwnode(&gdev->dev, entry->fwnode)) continue; =20 diff --git a/drivers/gpio/gpiolib-shared.h b/drivers/gpio/gpiolib-shared.h index 40568ef7364ccbf08b7f583e279a7d5b572af477..e11e260e1f590c46c5e575d3bb8= f3b5a2240892d 100644 --- a/drivers/gpio/gpiolib-shared.h +++ b/drivers/gpio/gpiolib-shared.h @@ -14,14 +14,14 @@ struct device; =20 #if IS_ENABLED(CONFIG_GPIO_SHARED) =20 -int gpio_device_setup_shared(struct gpio_device *gdev); +int gpiochip_setup_shared(struct gpio_chip *gc); void gpio_device_teardown_shared(struct gpio_device *gdev); int gpio_shared_add_proxy_lookup(struct device *consumer, const char *con_= id, unsigned long lflags); =20 #else =20 -static inline int gpio_device_setup_shared(struct gpio_device *gdev) +static inline int gpiochip_setup_shared(struct gpio_chip *gc) { return 0; } diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 6e000ad58a11f7e3de85d8a0630150368acc53ce..1777efe1a986c941da464da9225= 5c261f27a5a6b 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1223,7 +1223,7 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, = void *data, if (ret) goto err_remove_irqchip_mask; =20 - ret =3D gpio_device_setup_shared(gdev); + ret =3D gpiochip_setup_shared(gc); if (ret) goto err_remove_irqchip; =20 --=20 2.47.3