From nobody Mon Apr 6 19:48:51 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFC4E3AA1B8; Wed, 18 Mar 2026 10:09:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773828557; cv=none; b=JoNJ3xE7D5ycG6bAGlZTgOiVrtMYGmfBqbrhCaIMWdjW1z1juGrbTLRzOt17GOG1xUT1k/JrCF78uakKt6XlMJU8QkUPgQlU4ANExDnA0gQfwBvwP3kWrSHdyeuL0QmjMmKviDauhiSNgZ+LbeyGqtjhSSeZ5X/KPKLtADQPKn4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773828557; c=relaxed/simple; bh=RwF8uylKoOHKmbOSm14ruGnoPloK28/E7b/HHxSXYyY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GgCMoHO1K1i0SdyHPyc7F4f90J+KMekA1LPoM9ZEwmEz7EVvmMNTqRHZyvXvTrPchiEApFs0yta2vQ2UbFtIPk+g6CvFcs6EQflexs+gDYLnhnuk2gFSzm3PoafRd08C2VncfReWg29korlWPicdDENHqApiqyDB5GpFtf08ztg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bZ/FlLc8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bZ/FlLc8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F66DC19421; Wed, 18 Mar 2026 10:09:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773828557; bh=RwF8uylKoOHKmbOSm14ruGnoPloK28/E7b/HHxSXYyY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bZ/FlLc8DkIdZTQS1nK0S9AR5dra3y5QkPD9GxVIkVjaW/IS0Uo9lNDlIPKR7hPIj z7ehTclLErIYIpDJETUayyk3L9auC/TD9EkAQCH+ZAYxOVeOtYQPRwEAZ+c2DYSxzK SyhV3bqx3a9ltzfeOGVdZ/GQsbOA24UQpIBiZ9sNa7SYezPhU9JqAWvtl2ynbozpum QAF5tk7/XT0MtUYEvWjM/cV15pdmbnJAkO0Xmvp8P0/RSyAN4Yvf2RGDXFQvD0SzZg GxiM3BB0GGWrkZStAFPdL31PuB0TXHpCpMZAVqyj8T9OPy0oXVFe48S9saP4P6zvbA qbbGAmsuOmaqA== From: Leon Romanovsky To: Selvin Xavier , Kalesh AP , Jason Gunthorpe , Leon Romanovsky Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH rdma-next 4/4] RDMA/bnxt_re: Clean up uverbs CQ creation path Date: Wed, 18 Mar 2026 12:08:53 +0200 Message-ID: <20260318-bnxt_re-cq-v1-4-381cb1b5e625@nvidia.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260318-bnxt_re-cq-v1-0-381cb1b5e625@nvidia.com> References: <20260318-bnxt_re-cq-v1-0-381cb1b5e625@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.15-dev-18f8f Content-Transfer-Encoding: quoted-printable From: Leon Romanovsky Remove unnecessary checks, user=E2=80=91visible prints that can flood dmesg, superfluous assignments, and convoluted goto label. Signed-off-by: Leon Romanovsky Acked-by: Selvin Xavier --- drivers/infiniband/hw/bnxt_re/ib_verbs.c | 28 +++++++++------------------- 1 file changed, 9 insertions(+), 19 deletions(-) diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/= hw/bnxt_re/ib_verbs.c index 1aee4fec137eb..59ef56030dbe8 100644 --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c @@ -3377,7 +3377,6 @@ int bnxt_re_create_user_cq(struct ib_cq *ibcq, const = struct ib_cq_init_attr *att struct bnxt_qplib_chip_ctx *cctx; struct bnxt_re_cq_resp resp =3D {}; struct bnxt_re_cq_req req; - int cqe =3D attr->cqe; int rc; u32 active_cqs, entries; =20 @@ -3385,10 +3384,8 @@ int bnxt_re_create_user_cq(struct ib_cq *ibcq, const= struct ib_cq_init_attr *att return -EOPNOTSUPP; =20 /* Validate CQ fields */ - if (cqe < 1 || cqe > dev_attr->max_cq_wqes) { - ibdev_err(&rdev->ibdev, "Failed to create CQ -max exceeded"); + if (attr->cqe > dev_attr->max_cq_wqes) return -EINVAL; - } =20 cq->rdev =3D rdev; cctx =3D rdev->chip_ctx; @@ -3409,15 +3406,13 @@ int bnxt_re_create_user_cq(struct ib_cq *ibcq, cons= t struct ib_cq_init_attr *att ibcq->umem =3D ib_umem_get(&rdev->ibdev, req.cq_va, entries * sizeof(struct cq_base), IB_ACCESS_LOCAL_WRITE); - if (IS_ERR(ibcq->umem)) { - rc =3D PTR_ERR(ibcq->umem); - goto fail; - } + if (IS_ERR(ibcq->umem)) + return PTR_ERR(ibcq->umem); } =20 rc =3D bnxt_re_setup_sginfo(rdev, ibcq->umem, &cq->qplib_cq.sg_info); if (rc) - goto fail; + return rc; =20 cq->qplib_cq.dpi =3D &uctx->dpi; cq->qplib_cq.max_wqe =3D entries; @@ -3426,10 +3421,8 @@ int bnxt_re_create_user_cq(struct ib_cq *ibcq, const= struct ib_cq_init_attr *att cq->qplib_cq.cnq_hw_ring_id =3D cq->qplib_cq.nq->ring_id; =20 rc =3D bnxt_qplib_create_cq(&rdev->qplib_res, &cq->qplib_cq); - if (rc) { - ibdev_err(&rdev->ibdev, "Failed to create HW CQ"); - goto fail; - } + if (rc) + return rc; =20 cq->ib_cq.cqe =3D entries; cq->cq_period =3D cq->qplib_cq.period; @@ -3442,16 +3435,14 @@ int bnxt_re_create_user_cq(struct ib_cq *ibcq, cons= t struct ib_cq_init_attr *att hash_add(rdev->cq_hash, &cq->hash_entry, cq->qplib_cq.id); /* Allocate a page */ cq->uctx_cq_page =3D (void *)get_zeroed_page(GFP_KERNEL); - if (!cq->uctx_cq_page) { - rc =3D -ENOMEM; - goto fail; - } + if (!cq->uctx_cq_page) + return -ENOMEM; + resp.comp_mask |=3D BNXT_RE_CQ_TOGGLE_PAGE_SUPPORT; } resp.cqid =3D cq->qplib_cq.id; resp.tail =3D cq->qplib_cq.hwq.cons; resp.phase =3D cq->qplib_cq.period; - resp.rsvd =3D 0; rc =3D ib_respond_udata(udata, resp); if (rc) { bnxt_qplib_destroy_cq(&rdev->qplib_res, &cq->qplib_cq); @@ -3462,7 +3453,6 @@ int bnxt_re_create_user_cq(struct ib_cq *ibcq, const = struct ib_cq_init_attr *att =20 free_mem: free_page((unsigned long)cq->uctx_cq_page); -fail: return rc; } =20 --=20 2.53.0