From nobody Mon Apr 6 16:31:03 2026 Received: from mail-dy1-f176.google.com (mail-dy1-f176.google.com [74.125.82.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74069389DE8 for ; Thu, 19 Mar 2026 02:56:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773888990; cv=none; b=qd2hlXJbAxsD/wCt2Nf7uQEcyiXRKntK4aOEVv+Usxe5bK46YeimTDFbXYXBKM1z+sIizoM3tmn7XUxO6eYTFawFA5tHf1mJ1z/ftV9/tObtlDk/9gdQwNmh0rDH3YscZ2ACpJyK/NhULODdjLrYiGeIZXXqEKkmo/gsszmKwno= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773888990; c=relaxed/simple; bh=j+TfdR2vMLzYv/kUd6Hr5UCBSIgEc4azCMqHxSkXbWg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GeU/hyW9k2v3mp6rIHZ5MkyCtFoxn5tXm7IPne/AnhgVzYVCqo9PcOvz/lZZngdZWplurNOSBLn4SOkN0RJrO9/F+tNG1QF7R/gsRTREyvTz0FxS2iyBBUxbONCHAk5hiPfZy3RaNMNwysHEdJ8w6PR7ZShw5mqjqjg6t5+bDXs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nWqta3mO; arc=none smtp.client-ip=74.125.82.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nWqta3mO" Received: by mail-dy1-f176.google.com with SMTP id 5a478bee46e88-2bdd40d3c61so576149eec.1 for ; Wed, 18 Mar 2026 19:56:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773888989; x=1774493789; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ZgPWB+b9LbV2c18ggNpLoeCrPTB8CAkNmY8m136D6Cw=; b=nWqta3mOso4lZn7+gmMBtwu8ePo40ttfPa7PjyV/mb0X9/7GWTxrSn148HqlerQB6K 0BfbFmv6nSBM1EenuSpTRCqZd8Zy7FSjpID1NnmJ01QeIzyGdRIw2pYChMH22S1QPowJ PogNDjAfwOzAwGu8MUxVDgcF/mO7ZXEml1oU9tIu/lqC54Q6MewOjizCEiueNoflwBJK ydp6VQxwQuhG3VfKzCYbYf4gOxpilCegfvYTGb9bRHux+IfeT8ylu8MyyeJ/NtboWQKI 3i4kRNd1YBwa0Kxr698mESatsdMzc69qBUuEU90U2BOft7dlMSe/arfKJ2AyI+bY2lF7 KEMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773888989; x=1774493789; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ZgPWB+b9LbV2c18ggNpLoeCrPTB8CAkNmY8m136D6Cw=; b=nrmv/g3Z1chhEQ1c9Vw6Q/lLo90wVmT++zmMztc22IKnbViOWpShVVbrPeXI62nXBs 5bH/p8pdh6c737kOme5uqtwYmd+p6Rj0R40uuMPgurHRsHATeDiysbYm0Wgzu9FNVQam N88jqgrOK6eQXftSEU+89jhRupkMyCcYHo4jb+yCYXffLg/dYfP8ilZJDHz+nHiz52Ra L7vP433fn1iBJXQokHb90cb7Mmn+lUQde5gTQfLCJ6IcBqhtFuOGD/ct6CDj9nBnJQAP ttoRaGEPOz7Fb1AFkmM9Gkdlwotz8zILokS2U9ZFQoZ1R5P2byGuEi+U4k4oATCb8EMl BFig== X-Forwarded-Encrypted: i=1; AJvYcCXt+J3QmQKfWxU0mgHgagg0FvAVPKiW3vFuWIk2SJxtCI6FMG7s5DYI28PqqfPwUhfX+X6oqwOMQkgD/Uk=@vger.kernel.org X-Gm-Message-State: AOJu0YwgNLIRTk8aHULkLXvYNzlwqyikQSzpKB++5uLBG5C3iucha8rd fN5sY0Pof1+PtcoWRfvc3D9MgVAGlJCbCPA6hVgSxk6SCTT24o9sMj1x X-Gm-Gg: ATEYQzxS9oDH18j81Toi2EltSnVp8Elp3f2Oj8r/SmHEMdVc1tjW5pJLY613DySdMSF NEcEZqcFmLaw3TowvGhID6MlclTeHYZXtRDI3+3KNG8MU4srp3fjTKv6eOXYg8GE49fwZcbMqup zL5+YfEC9SmDE4zPlJAcG64G/ZbZeTDGhaaAuJfPWXE6rk5cAj5SptjS5llEYot6zRRvM75RdaE N7yBOvXeLWlaD4YtbRJwFx7vEm9JDNXOEq72W505XW1yQvBVp9lG/8cB+JNBDk03xmyikGHKOm2 iaT3JZGh7cBz+wux33zBFWJLjvb8DAMchY9nZC3yJvI84TPJ16jhS2XSt8+dkBSUQtZ5i89WTXD LCY5OxuDmyGPYZ4UZBcu6ydo4APwGo9FAdtgfrHqJwvnvB80LDxGwNLHppla4ECmvRNFlJLuUbE xVkTXUJKOc6PiRzADOEgv2C7uXndPvWElobF/KgPAz76Al+69ID1uViVCzxDmcbyU96PoJ7fmVd 1Cfo9HdnSCjug== X-Received: by 2002:a05:7300:7fa2:b0:2ba:6a79:f04c with SMTP id 5a478bee46e88-2c0e50631femr2651118eec.18.1773888988115; Wed, 18 Mar 2026 19:56:28 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:5966:2bd9:1ed:e7c4]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c0e55a53fcsm8250983eec.24.2026.03.18.19.56.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 19:56:27 -0700 (PDT) From: Dmitry Torokhov Date: Wed, 18 Mar 2026 19:56:18 -0700 Subject: [PATCH v2 2/2] platform/x86: barco-p50-gpio: convert to guard() notation Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260318-barco-p50-gpio-set-v2-2-c0a4a6416163@gmail.com> References: <20260318-barco-p50-gpio-set-v2-0-c0a4a6416163@gmail.com> In-Reply-To: <20260318-barco-p50-gpio-set-v2-0-c0a4a6416163@gmail.com> To: =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Santosh Kumar Yadav Cc: Peter Korsgaard , Hans de Goede , Linus Walleij , Bartosz Golaszewski , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org X-Mailer: b4 0.15-dev-a6826 Using guard notation simplifies control flow and makes the code clearer. Suggested-by: Ilpo J=C3=A4rvinen Signed-off-by: Dmitry Torokhov Reviewed-by: Bartosz Golaszewski --- drivers/platform/x86/barco-p50-gpio.c | 26 ++++++++++---------------- 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/drivers/platform/x86/barco-p50-gpio.c b/drivers/platform/x86/b= arco-p50-gpio.c index 360ffd8505d6..2a6d8607c402 100644 --- a/drivers/platform/x86/barco-p50-gpio.c +++ b/drivers/platform/x86/barco-p50-gpio.c @@ -272,33 +272,27 @@ static int p50_gpio_get(struct gpio_chip *gc, unsigne= d int offset) struct p50_gpio *p50 =3D gpiochip_get_data(gc); int ret; =20 - mutex_lock(&p50->lock); + guard(mutex)(&p50->lock); =20 ret =3D p50_send_mbox_cmd(p50, P50_MBOX_CMD_READ_GPIO, gpio_params[offset= ], 0); - if (ret =3D=3D 0) { - ret =3D p50_read_mbox_reg(p50, P50_MBOX_REG_DATA); - if (ret >=3D 0) - ret =3D !!ret; - } + if (ret < 0) + return ret; =20 - mutex_unlock(&p50->lock); + ret =3D p50_read_mbox_reg(p50, P50_MBOX_REG_DATA); + if (ret < 0) + return ret; =20 - return ret; + return !!ret; } =20 static int p50_gpio_set(struct gpio_chip *gc, unsigned int offset, int val= ue) { struct p50_gpio *p50 =3D gpiochip_get_data(gc); - int ret; - - mutex_lock(&p50->lock); =20 - ret =3D p50_send_mbox_cmd(p50, P50_MBOX_CMD_WRITE_GPIO, - gpio_params[offset], value); + guard(mutex)(&p50->lock); =20 - mutex_unlock(&p50->lock); - - return ret; + return p50_send_mbox_cmd(p50, P50_MBOX_CMD_WRITE_GPIO, + gpio_params[offset], value); } =20 static int p50_gpio_probe(struct platform_device *pdev) --=20 2.53.0.851.ga537e3e6e9-goog