From nobody Mon Apr 6 16:31:02 2026 Received: from mail-dy1-f174.google.com (mail-dy1-f174.google.com [74.125.82.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECBD1387591 for ; Thu, 19 Mar 2026 02:56:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773888989; cv=none; b=WkPOBkz+jE7bNDGeblLQD8gOvqCTxlFJPuyL4l/z+mvJpyCrEen8GmipZIUDwas+dPyB809xnJB6KK6lUtd5ByBAbRO+QeDdm9c8Hk5kPL1db0Cv+6sMnMLyyqWRp0sO/mYxD0kpoVg0HnHz9MV5t7RMWh2lTjaUya2zAaVfJCw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773888989; c=relaxed/simple; bh=t7uiBdls3lv7OiEXA8iMgDOA6vzogD6b3u5EkKw9yBM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rR7TvIM6nrJqPh2Bgb8ONTpm2NpKyvDqEI7A+xcjRQlDAOQZ8q4RcB/vkOwbBVdjV5kX4EPWmQVb/UYFxgPbbaWCgCRR0tpy3l+SmupbhJOMhCOvT0akGsJE0rmqrwvnIY5vwlVOw6DnfijQ7pxa+e3rI7o8wecJFGpDel2me0E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AU7IP8Dd; arc=none smtp.client-ip=74.125.82.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AU7IP8Dd" Received: by mail-dy1-f174.google.com with SMTP id 5a478bee46e88-2c0c955a481so474932eec.1 for ; Wed, 18 Mar 2026 19:56:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773888987; x=1774493787; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=T3xnuvBTm20lU9ioy0TlmhVylnqjZKhbjidK+UiXkzc=; b=AU7IP8Ddm/hqqe4FQ88O3q5nuLLqtSKitlufs9lBPT+3RR30T28E1UeKmRojyoCVNu l0Jxb/ORjxobzmNF7+kMS/cmTonfSha9RVDg0+fj1L6jH9eqK903Nt/QVUbC01gAM6T9 lZgW15nwV80sVoTT8030dn43PYpxsknRpqEBzjhh5R68accQFKb42JQWQynmV8XIIakb D/o5Scuu5bmFtBPKJkCZEEDq9tem2fy2iyhmGG4gupirxV9rtWgPH9p2L7aiIOufm4oA iL0vHv3JE7RGcMjPU5k/uh+CSvVVpRslVGPPiJoQ3uFxBEN/5Gh9iHz4P0JOjoPgRgfD 44Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773888987; x=1774493787; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=T3xnuvBTm20lU9ioy0TlmhVylnqjZKhbjidK+UiXkzc=; b=eOdJF5IvBufiILsjAKfWjRWdNkuh9Pjk1UNbVXX4o1ezibFHxcteCEbnOnU9HaLfoi 2zMvCocyRnW4y+RWTl4DrCmnxw+Az5Wrwn4tY6wsuPWmMhHej3RRFXQVnMlOPeXINwvE 6yTHsX7Z7E7CeLc+1+MhBE5FTq/xA26H8Pwm2wiIk/eUZS8oirevYYJj6G6ObK2nsja7 rr47d2GMfYFznsY+fdpZQBYv1T04e1MwFIUkvwZPvWHkNdjgODPykLDV512VH7qHEtUr uKiMkruzqrTXO4s1GG4S7EkJZT986FT/h8CR/yWDqPud2lsIealn8x8iqe4DPpuGPpmw Bfjw== X-Forwarded-Encrypted: i=1; AJvYcCVxJjYPS3QXwDyl6/v9YcleK4viHP7icI9eKAx0HBxWsMJfWo7hbvEPjUwprPNMBb0kf0KkxGw8kbn0bGs=@vger.kernel.org X-Gm-Message-State: AOJu0YxgEQCKhe950S9b5jMwqrqBXfpmm8aguI1/AAD5JsE/vmQ6nMLv yjygAtQZlUjH5Awx4q0HdTC0Y3bKa6dSAF9uVKvdCN1enB3bvDaLmuH0 X-Gm-Gg: ATEYQzw4O6Vbt1bDosQzdzk26IMXr8mPheknmvaMs3Lfn07njdGtsu1D9fe2vkoLpDT IhrHC1ULLausXerQwE+jfL+PN0nazomIfgPXnHpqTvvCxvIyPcGSZ1xiGGXnywz+g7VipeUv9ON wrUdFFdP2luoMiOFSYvs0BD6kQUPy84qnbWy3DpTEjTI7kNb/pA1MWAgmco1jkluZmrh0WkC2OK eGUeQ50I7c43QWG9MR3J/+EN+9ew/XGl1LOHMXSV/lHM5ZbGXs0Drg+qAOpbg8B8bSg/ieF4NJr s6Uqa6tkNPh7Jt/4g3RGaNmoMPD8SoWpDJvHKx1la+0uEpmjKKjTuxsHmVFuIOdM7Tfrd7RsF9t ze0QVWvGTwA26G2vlJXlmXRlLB6qZk4g7SN5bTWlEBV4ybT5bkyVtfyAvVqPDHFqESXhTbE3Dzc aVi+VvOxLlYnn6EpTx6wbUHFYy/g4rLTX7cgFVOVs+UOxRPitMcmBjOFxRqoVzVOpJVWKDFHyV7 p6FTB/Nfqz1tw== X-Received: by 2002:a05:7300:a2ca:b0:2ba:a2fa:84a6 with SMTP id 5a478bee46e88-2c0e5101a34mr2974532eec.24.1773888986579; Wed, 18 Mar 2026 19:56:26 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:5966:2bd9:1ed:e7c4]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c0e55a53fcsm8250983eec.24.2026.03.18.19.56.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 19:56:25 -0700 (PDT) From: Dmitry Torokhov Date: Wed, 18 Mar 2026 19:56:17 -0700 Subject: [PATCH v2 1/2] platform/x86: barco-p50-gpio: normalize return value of gpio_get Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260318-barco-p50-gpio-set-v2-1-c0a4a6416163@gmail.com> References: <20260318-barco-p50-gpio-set-v2-0-c0a4a6416163@gmail.com> In-Reply-To: <20260318-barco-p50-gpio-set-v2-0-c0a4a6416163@gmail.com> To: =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Santosh Kumar Yadav Cc: Peter Korsgaard , Hans de Goede , Linus Walleij , Bartosz Golaszewski , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org X-Mailer: b4 0.15-dev-a6826 The GPIO get callback is expected to return 0 or 1 (or a negative error code). Ensure that the value returned by p50_gpio_get() is normalized to the [0, 1] range. Fixes: 86ef402d805d606a ("gpiolib: sanitize the return value of gpio_chip::= get()") Reviewed-by: Linus Walleij Signed-off-by: Dmitry Torokhov Reviewed-by: Bartosz Golaszewski --- drivers/platform/x86/barco-p50-gpio.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/barco-p50-gpio.c b/drivers/platform/x86/b= arco-p50-gpio.c index 6f13e81f98fb..360ffd8505d6 100644 --- a/drivers/platform/x86/barco-p50-gpio.c +++ b/drivers/platform/x86/barco-p50-gpio.c @@ -275,8 +275,11 @@ static int p50_gpio_get(struct gpio_chip *gc, unsigned= int offset) mutex_lock(&p50->lock); =20 ret =3D p50_send_mbox_cmd(p50, P50_MBOX_CMD_READ_GPIO, gpio_params[offset= ], 0); - if (ret =3D=3D 0) + if (ret =3D=3D 0) { ret =3D p50_read_mbox_reg(p50, P50_MBOX_REG_DATA); + if (ret >=3D 0) + ret =3D !!ret; + } =20 mutex_unlock(&p50->lock); =20 --=20 2.53.0.851.ga537e3e6e9-goog