From nobody Mon Apr 6 21:52:24 2026 Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85BCC3EC2EE for ; Tue, 17 Mar 2026 23:23:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773789804; cv=none; b=JIHpPBvANAo5bG007g1freHyCDLLXJt7iP4qL8wIQD/Q070U3CpUS7kBDagx12zbEDCrDM9Qb9t/9YbiZfrTp3pKFVBUiB05CaqAB/jY0/4AbzS2SPwb40kpzABvEetyCERJGhh+apH1OOmJojho425yALaD+vOgXmtyBYpWrgU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773789804; c=relaxed/simple; bh=PB4QUoC40I8Vz2PFxEtUkYeG9DwMnvMUVdft52S+vrg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Coau3LCNrn+3LHPSn49IHienFSe24kyDPr5363FUDM5yI2ifHjHm+vPCcAyfOYYON/BkBzzKZLv6P11cdSh6mUNz9AvRn5g8L2qtVtQ0nMvo7irNjurVG1+P/UEnSE5OREK/OOVyO8TSg2ypMZvVyulp1VXPLcr7cR1i14h4jhU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hdVObZgG; arc=none smtp.client-ip=209.85.128.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hdVObZgG" Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-79a74765703so1435197b3.3 for ; Tue, 17 Mar 2026 16:23:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773789802; x=1774394602; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FnaNOvfPGt1J4YqTrzM2VRxejeZjN9i1yPf1CzG0bKk=; b=hdVObZgGdZnJuDGO1FFdwEi1NPJDg8HG88C3x9VqAVq5Jc0QgRdLdqp7oRCutwfuwL 6gad7xUsnFJfH5rR3IGDVm54Fu0z1AN/UXBoN0i3Xvicr6EzXIw8cppGV/eicRso0w98 8OyHOe7IYhSc2f8PvKjhcRS0Yiy/i4zewMyrfDkCW63si3f8gkoZv8iUiddy6ORomckM nUAVw7Tx5O/em9AO+LtoyPyqCLkRxyCAgOxlgDC1rF2m4SZpBE2/No2QeAJWjiBvUJMo Z1xZFfLlcMiC3Ymn2CTI7ZzBp3DX84UycFm29DQR88X1oCKpVM/qLCamXWR4TRLKk9kQ rwKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773789802; x=1774394602; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FnaNOvfPGt1J4YqTrzM2VRxejeZjN9i1yPf1CzG0bKk=; b=P2qupO4qI9OiDsPjVUh3NsI5KsvrQSuLh/q0v1VwIdqlwehm1bKEOkH2zy6LklumCr NjjjjkZoFa/+TmOFfg1kGed7JgEp13y23q2WGvgbydulMs8wv9DwzZo1TsoZguIwhlyc f1df94m1YL8KJGfNh9ItOVEPMj+3nqwEm8hsi/3m/vL0Nv9QJfThA5jHPVOSpu+Fl3PT raOWHqnZCpHw0FowP5w4dht6jvbIntbuVyNFCL85i4g4O+y0TW9O12TRp97jdj0QSrGR DI+DgdCyifA6XOjoOa/DF08yM2JWN0Itc/gXfcsgoRF5+WR38BtqZzKwqJnFe8me2y7C pmoQ== X-Forwarded-Encrypted: i=1; AJvYcCUyCKJHFV038hEZd68b4QsuMKAd9xVb7LDVB1EiN4toUHe4O0uEJ++FEojT16ngWACEpkJntva7XW3TmSE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6Eo7/BO+6ycC0hSfEK9+0KmPFCfzMpL0EnPz93xy8FsmVBDGR N7hdCF83D2hY8yf9W9c/Ia+zF8kARbeGbbCkKmirZ9KWcU6lOEZHEMDg X-Gm-Gg: ATEYQzzJd/xQ6lsRD4umHE1rHOE5wkcPy5Drp84XUfbyQgoNykDwOyDtY6EheIfhRcH 4xjP+fbae0rUsPY1u6CjZGBqept7JA+Z/zgGflqvxhpXZ1MBSgYRFDgL2EU/c9Q5OOas3SFCzsX zbbe6tzcxCwB926QiLxmIC4MthEazTyQi8iZJgbWRENDEiahBxCmbqCIQTpjYgaxAmShCn0iorJ ewEV+7NwgU6XX8+P+ixU30pLesZUhLNLKPukK1HUL4dJMpTPjvSiLYdCyJPP+OcklgC83UtmmWr Gm8J2W8m47z6PgP3VnWzDwVsflMj0x617qLj7cfKqkxPdP7iaGPSb6e5C13eKJun/EEd9rpihE5 YtBION/Ej1YCD5KXfIkX9tJaCrewKfF2t/dRSBCYIdSj6OKn4wfu8kwtK5O/2xXaNTIT5VZ3/aE pzKdej5QzM7BwRtFpVjLGv5G1438OleQq2pS6kVqWDAUVH4bUrPp8vAmXPfZv/Muqty/AvauRGU ouPZJhftDI/HHljDaL9k8Gk X-Received: by 2002:a05:690c:c119:b0:797:f005:2dc0 with SMTP id 00721157ae682-79a71c88395mr12043627b3.50.1773789802632; Tue, 17 Mar 2026 16:23:22 -0700 (PDT) Received: from tux ([2601:7c0:c37e:2360::f769]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79a715d221dsm6858217b3.37.2026.03.17.16.23.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 16:23:22 -0700 (PDT) From: Ethan Tidmore To: Philipp Reisner , Lars Ellenberg , =?UTF-8?q?Christoph=20B=C3=B6hmwalder?= , Jens Axboe Cc: drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH 3/4] drbd: Add missing error code in drbd_main.c Date: Tue, 17 Mar 2026 18:23:17 -0500 Message-ID: <20260317232318.18923-4-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260317232318.18923-1-ethantidmore06@gmail.com> References: <20260317232318.18923-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" No error code is assigned in alloc_workqueue() error path. Assign error code -ENOMEM. Detected by Smatch: drivers/block/drbd/drbd_main.c:4575 drbd_init() warn: missing error code 'err' Fixes: b2e550c8d1f54 ("drbd: rework module core for DRBD 9 transport and mu= lti-peer") Signed-off-by: Ethan Tidmore --- drivers/block/drbd/drbd_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c index e2c3530cfa13..689b7cac5ec2 100644 --- a/drivers/block/drbd/drbd_main.c +++ b/drivers/block/drbd/drbd_main.c @@ -4569,6 +4569,7 @@ static int __init drbd_init(void) goto fail; } =20 + err =3D -ENOMEM; ping_ack_sender =3D alloc_workqueue("drbd_pas", WQ_UNBOUND | WQ_MEM_RECLAIM | WQ_HIGHPRI, 0); if (!ping_ack_sender) --=20 2.53.0