From nobody Mon Apr 6 20:10:51 2026 Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B39936F43F for ; Tue, 17 Mar 2026 23:23:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773789803; cv=none; b=aCMPLWUrh1Fbyl3XMoPUMBxsG7tArXwUD6YPEk4JRXItYOcTTORgYOSw/n8/2SrvjrZCTzFa4lgJq3A+dIDs0wOlmKwIop4EUQbiZk90VXIXHP4ZziHQ1Iy8e5QNdetUeJl5AcdcgD57TGQPWsqyr+V1l+vanOTQzUcgkdC4CYw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773789803; c=relaxed/simple; bh=+nWtQs07r0pE+Ze4LkjAmQmhutwoys7wbSABJeTYcqY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OdzupMjjjkaBWXLGaBZSvyLSYKgVPsuSrb2UQUtMJgDgQJm+TJCx7xLzhjUrlp5HorJeFtI0Vh7Iw/4MEZt6iRslrn2Qh5lowSFKoIP1+KIeuvJpYRYuEkFDyF8YR6TG8KAEu0mM6QJ5s6lxm03qnWgu7m4eibHzBx8GvgG6eiQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Pb8qhOux; arc=none smtp.client-ip=209.85.128.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pb8qhOux" Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-79495b1aaa7so59231197b3.1 for ; Tue, 17 Mar 2026 16:23:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773789801; x=1774394601; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1bBa9pDPqbGfhOBwqPMjjiTOMbtTfvieka9d6hhFj70=; b=Pb8qhOuxXHE5LBfgsEwoSIB8p8wiHxRSdWJFQ9+ZjO5KpbTEaK+n/09xTFXwa9kYx/ gSMEQfnYtD9Z5NzXmgyPZETu6TrpUWhZQfQC8VjavUSj3jMF7RIVUDky6BFL6Uwtv60d ZuegBAvYD4FCtdzmYRV4uHolZfAtUT43306IPNrJ4iKfxpFVN8+4VZhHeXSldMbv/E8f HJkYWr+qc6IxKex1ytNQBSYmpapP1j3c9Tb4ih4RnXBPNyn8yWLijH+ciZgR9k7ISlBw yDN5RCVqSfh/FjwkRCTPGat2Xzln2rJ5XaVlKk4NknOWI7ONhirRUBFHXpPRbUwqgTT8 J5eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773789801; x=1774394601; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1bBa9pDPqbGfhOBwqPMjjiTOMbtTfvieka9d6hhFj70=; b=Q7UOOXVxddzp1HnUFcUwFgvly2d0LZ0ZVJljuZO7iFJ0xkltR4gbZdyFLxocLqJoB3 SmDf6PyLFjOHgWimH+EDJvU1owUzt2HO6HKKlHvkzz9i6oQ/FbpiUzUBGoi9h9v9cLlH L/g6lE0WcCSgl0k/yiEyd2hbUtlCeJOjiH98eU+lSkRdnImlT8eTjtMCI7iVIDsluKr1 VpxKCQoBrqNs5+HlqNtZ000M+zK4K7V4L0x3HaCLDBAk2YoFfC2ynJewREIThY4W4ldJ g+BwikZP4YUoGujfd/uQxFTV7dPxCgfg8I55icj1qloIMm1AmeFs1BDUYBY7AXI9Y2iR tNiQ== X-Forwarded-Encrypted: i=1; AJvYcCW47QDmlQZHsOyPI1X/vpUFJwXdEkBEnFRFKaBxNzighO+t34YfIvB+rmceFZbf1j3dZ65/0gaZKV6j6uU=@vger.kernel.org X-Gm-Message-State: AOJu0YzcTyeXXH8Y5Q1p4PJ0t3HjvUqTPt3mwFbUJgn/OjjINXnRyLXF oH3K72Ap6mZ9IYlP6ANFPT+/1v61XKi0CIkHbbBv/grEEnS60EzAhwnk X-Gm-Gg: ATEYQzzeh4/vUBs47BKNZFxc8M9L2hqYDhL2UQri1L5ScyqIH8HgH7j5V6Y0ayAQjHb DUVSUZwC6kotk2w80W8w5D5eZFm91IEuh3Bvcm62mTRiplObF/CWGM2j0GYGhuNtE+9KcJ8Qenv tYv9E8QsmL357ocS81kSHeYMs0YGEJcYo2870pJ/9Pg7tC6uHalY1EsPI/4EzSQ6K2Iak1pNyBi fo7zuk3UBwofVYYBK7oGjwmYKuEsVI43QIgV45w+cOlKMmBVkWqXJErwwEHAzQDPWHH1Sf7BbJq uTfvjPM7oai3uiuxmtVZeird749OvlnaXytdHkm//42LP/jmAX7UHAunAXTxf/6k/CxrU1HNFfx 36CMsylwdG5c9v9P3n70PRmTwicAgSU7SdYx/kucO4ydktW/zMHkM6/KYSYt6xi4U/bGkxK/lkA sVaR1n1skFfCvQf1WOzHOZMLJQC1pgjcP55Ksb2KxIqJfKcXd1zn5nz22xjalN8ReNf0xdLL6sd x/YF0lbMRysD+8k7PeI2TsT X-Received: by 2002:a05:690c:c1dc:b0:79a:3e2a:7b5e with SMTP id 00721157ae682-79a71637f2fmr12821057b3.0.1773789801257; Tue, 17 Mar 2026 16:23:21 -0700 (PDT) Received: from tux ([2601:7c0:c37e:2360::f769]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79a715d221dsm6858217b3.37.2026.03.17.16.23.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 16:23:21 -0700 (PDT) From: Ethan Tidmore To: Philipp Reisner , Lars Ellenberg , =?UTF-8?q?Christoph=20B=C3=B6hmwalder?= , Jens Axboe Cc: drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH 1/4] drbd: Fix out-of-bounds access Date: Tue, 17 Mar 2026 18:23:15 -0500 Message-ID: <20260317232318.18923-2-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260317232318.18923-1-ethantidmore06@gmail.com> References: <20260317232318.18923-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The array sync_rule_names[] has 22 elements and rule is used to access this array. The variable rule has the possibility of being index 22 because the condition (rule > ARRAY_SIZE(sync_rule_names)) could evaluate to 22 > 22 which would be false and then rule would be used to index sync_rule_names[] which would cause and out-of-bounds bug. Change condition from (rule > ARRAY_SIZE(sync_rule_names)) to (rule >=3D ARRAY_SIZE(sync_rule_names)). Detected by Smatch: drivers/block/drbd/drbd_receiver.c:280 drbd_sync_rule_str() error: buffer overflow 'sync_rule_names' 22 <=3D 22 Fixes: 851f106c134a3 ("drbd: rework receiver for DRBD 9 transport and proto= col") Signed-off-by: Ethan Tidmore --- drivers/block/drbd/drbd_receiver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_r= eceiver.c index 06d83b5ffafb..280be2ee7d7e 100644 --- a/drivers/block/drbd/drbd_receiver.c +++ b/drivers/block/drbd/drbd_receiver.c @@ -273,7 +273,7 @@ static void drbd_cancel_conflicting_resync_requests(str= uct drbd_peer_device *pee =20 static const char *drbd_sync_rule_str(enum sync_rule rule) { - if (rule < 0 || rule > ARRAY_SIZE(sync_rule_names)) { + if (rule < 0 || rule >=3D ARRAY_SIZE(sync_rule_names)) { WARN_ON(true); return "?"; } --=20 2.53.0 From nobody Mon Apr 6 20:10:51 2026 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBB1737A4B5 for ; Tue, 17 Mar 2026 23:23:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773789804; cv=none; b=inVJNq+KT4Hr2DWAPRcmQhSa5MDbaz25Nlbk0w0/erntjP1pc7Cffh4Hq/qXBviyLToZfIf3w5fAqoP6dMPY1KUmWtWheDFbVigtAe8kmtla/fYFfpcBuomSKglQOgNl/u/sdRGzThZoA/EGskfjl//zo5fqBakP7PqhuBlIZqI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773789804; c=relaxed/simple; bh=k3hQv9gFEIVWQ8BuojhozFDq2pcGJwnuFRlaWbZuJLI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nu5OmqFi+LRDODDlFMAV9KhUPQEPAwdrUrZf4LjlSqmxokGEeHy5r3fM8e6fl2C8sjqJh3cFqfNEk5FKUdwPlywkrATU8KkUWlJTE8GClePDOGawdfmbn07j1ViMmiV42Kh2gZbXuzDnAb2i2/siBq6ZGOAhg0WG4bw6a6MeuTc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hxtoQgbx; arc=none smtp.client-ip=209.85.128.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hxtoQgbx" Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-7986e538decso53542467b3.1 for ; Tue, 17 Mar 2026 16:23:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773789802; x=1774394602; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GVqejN9RcyteX0OK/Wyi8jfYU0wStXL+Y9sOPfh9k1k=; b=hxtoQgbx2Uk8OlZmjjNMnhNYkUKT+wpKSKyd4eWcn1FgcaRMzq2hHQt9FOq7HZpZHk ua4L2A4lfckexLMfu4VjEtSLXEj5Rq6vi1O8W8Qn2ln/PBWS5V6MqkPlh5ZIn8mWvWI1 wkgBOSK9FtovWO6pUn9hKsgBSM7mOMM/bvSlZrzQ5oVk1J5JxU3vrNWGuhplpG8rULxR dN2m12U4PWAxdyhhVgUqv+NgyF5xMuuxXGOTwfUW2k/ibW7uvo2t/NawYeSv6r4gRPhg F3ul+dJLiV9eD5sAN/5sWgT2e8Z61hte1k1A3aEZ/PxkEqgZJtrssqALAspkPJzRYozb rEIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773789802; x=1774394602; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GVqejN9RcyteX0OK/Wyi8jfYU0wStXL+Y9sOPfh9k1k=; b=aBde0vdSL/QxGQi4ipIebQ94t8f9PtP8S+nKaoFjdja36/6Q2nfUipo9uWB0GdmnZ0 M2iOUJhAgAADZxTSHbJQDQah2oC/664MCLqo2vzJbzs7i+4dx5kDakfcMOOA1j+FVmEg N05xlqPs2p04dcUIuwtvhNEzSFLl66V3fJoFma5Wx9stzq2aYioQiruliGYiWyI/r07t /F1U8Fj2WSIIsJQx6hIZhLLWA9F1gieqUJ5zwMwHEuGvIPuSWx9u/W011/IDoFoWber4 KNI8zpJb96y9jSlqZUcG61+VKg+5PaBiu/5NeYDkLhAu3JSAMZADKeGk1JadDN986DRS EQ5Q== X-Forwarded-Encrypted: i=1; AJvYcCVzDXqUjxzUeoyooplxyWiCpPZPGozQy7lxAjpxSP/TnF5+ZJDmflc+Y1b4NjVQCk/cklZHWUec8WGpKIQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzhAWLyAMTzV2YZk6/xpvOzoJg8bYmeJBNA+F+KQcLjf66fPI8y oDtJh2Xj0LQqYUGrM+1UR0BMtRfC1iJhmPZVkyOuGLk3cykZGZIWM7sP X-Gm-Gg: ATEYQzy5te/58aIybaGbJYZjcbTeeK2Pq5j2bItF0QP37SAEFStGKssRKlgHm5gG0vH FUOZGiEJ/tGMjbihLEX31yFE5Oi4vP4uErJZK4GlJ99yrIXtRWNFRe+treRN/zSVCeVePDWR+c5 aRLk/VBegcR4ePighrsISO6CgU6pE21l3RC3x8RZyn+8r1r8e2yl2SmvBVRNz5fEw8jIBYqsXwq YzeVkMKPhj18zcRRvDb4VpHAsIHxucF8rfiDUApV+g12yA+qePnnpXN53NGwx4cDJJDnAt5UrLE G5501GXAGotZpRIfCZUA+NpgvUPBC+Ey7Vl2Gq9tut7vXlw3zZwUYeN+62TWs2kQVop8xpXu0Ad 4CJ1kXbLEJZMspiMTgIG83Ydb6yQnoeLDMZcciFsipn4ZEHB4Q5QAL/v8olJMk4UmNg176IR3/c oAMDDOoX8l69uiD7KWIShgicvptJ8WqjoZUrXJxVmmHvGZ0TOPVGJ3v2VNMsPMUXP3FMx5dNFlf XUUgZV1xxSl3aajWHVXX/hG X-Received: by 2002:a05:690c:110:b0:79a:38a2:d8ca with SMTP id 00721157ae682-79a718c62demr13000817b3.23.1773789801990; Tue, 17 Mar 2026 16:23:21 -0700 (PDT) Received: from tux ([2601:7c0:c37e:2360::f769]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79a715d221dsm6858217b3.37.2026.03.17.16.23.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 16:23:21 -0700 (PDT) From: Ethan Tidmore To: Philipp Reisner , Lars Ellenberg , =?UTF-8?q?Christoph=20B=C3=B6hmwalder?= , Jens Axboe Cc: drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH 2/4] drbd: Fix variable dereference before check Date: Tue, 17 Mar 2026 18:23:16 -0500 Message-ID: <20260317232318.18923-3-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260317232318.18923-1-ethantidmore06@gmail.com> References: <20260317232318.18923-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The struct is 'req' is checked for NULL after resource was assigned from a member from it. Check 'req' for NULL before assigning resource. Detected by Smatch: drivers/block/drbd/drbd_req.c:1996 drbd_unplug() warn: variable dereferenced before check 'req' (see line 1993) Fixes: 71d075200b462 ("drbd: rework request processing for DRBD 9 multi-pee= r IO") Signed-off-by: Ethan Tidmore --- drivers/block/drbd/drbd_req.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c index e88b5da15c1e..4cbd9ec15157 100644 --- a/drivers/block/drbd/drbd_req.c +++ b/drivers/block/drbd/drbd_req.c @@ -1990,12 +1990,14 @@ static void drbd_unplug(struct blk_plug_cb *cb, boo= l from_schedule) { struct drbd_plug_cb *plug =3D container_of(cb, struct drbd_plug_cb, cb); struct drbd_request *req =3D plug->most_recent_req; - struct drbd_resource *resource =3D req->device->resource; + struct drbd_resource *resource; =20 kfree(cb); if (!req) return; =20 + resource =3D req->device->resource; + read_lock_irq(&resource->state_rwlock); /* In case the sender did not process it yet, raise the flag to * have it followed with P_UNPLUG_REMOTE just after. */ --=20 2.53.0 From nobody Mon Apr 6 20:10:51 2026 Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85BCC3EC2EE for ; Tue, 17 Mar 2026 23:23:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773789804; cv=none; b=JIHpPBvANAo5bG007g1freHyCDLLXJt7iP4qL8wIQD/Q070U3CpUS7kBDagx12zbEDCrDM9Qb9t/9YbiZfrTp3pKFVBUiB05CaqAB/jY0/4AbzS2SPwb40kpzABvEetyCERJGhh+apH1OOmJojho425yALaD+vOgXmtyBYpWrgU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773789804; c=relaxed/simple; bh=PB4QUoC40I8Vz2PFxEtUkYeG9DwMnvMUVdft52S+vrg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Coau3LCNrn+3LHPSn49IHienFSe24kyDPr5363FUDM5yI2ifHjHm+vPCcAyfOYYON/BkBzzKZLv6P11cdSh6mUNz9AvRn5g8L2qtVtQ0nMvo7irNjurVG1+P/UEnSE5OREK/OOVyO8TSg2ypMZvVyulp1VXPLcr7cR1i14h4jhU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hdVObZgG; arc=none smtp.client-ip=209.85.128.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hdVObZgG" Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-79a74765703so1435197b3.3 for ; Tue, 17 Mar 2026 16:23:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773789802; x=1774394602; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FnaNOvfPGt1J4YqTrzM2VRxejeZjN9i1yPf1CzG0bKk=; b=hdVObZgGdZnJuDGO1FFdwEi1NPJDg8HG88C3x9VqAVq5Jc0QgRdLdqp7oRCutwfuwL 6gad7xUsnFJfH5rR3IGDVm54Fu0z1AN/UXBoN0i3Xvicr6EzXIw8cppGV/eicRso0w98 8OyHOe7IYhSc2f8PvKjhcRS0Yiy/i4zewMyrfDkCW63si3f8gkoZv8iUiddy6ORomckM nUAVw7Tx5O/em9AO+LtoyPyqCLkRxyCAgOxlgDC1rF2m4SZpBE2/No2QeAJWjiBvUJMo Z1xZFfLlcMiC3Ymn2CTI7ZzBp3DX84UycFm29DQR88X1oCKpVM/qLCamXWR4TRLKk9kQ rwKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773789802; x=1774394602; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FnaNOvfPGt1J4YqTrzM2VRxejeZjN9i1yPf1CzG0bKk=; b=P2qupO4qI9OiDsPjVUh3NsI5KsvrQSuLh/q0v1VwIdqlwehm1bKEOkH2zy6LklumCr NjjjjkZoFa/+TmOFfg1kGed7JgEp13y23q2WGvgbydulMs8wv9DwzZo1TsoZguIwhlyc f1df94m1YL8KJGfNh9ItOVEPMj+3nqwEm8hsi/3m/vL0Nv9QJfThA5jHPVOSpu+Fl3PT raOWHqnZCpHw0FowP5w4dht6jvbIntbuVyNFCL85i4g4O+y0TW9O12TRp97jdj0QSrGR DI+DgdCyifA6XOjoOa/DF08yM2JWN0Itc/gXfcsgoRF5+WR38BtqZzKwqJnFe8me2y7C pmoQ== X-Forwarded-Encrypted: i=1; AJvYcCUyCKJHFV038hEZd68b4QsuMKAd9xVb7LDVB1EiN4toUHe4O0uEJ++FEojT16ngWACEpkJntva7XW3TmSE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6Eo7/BO+6ycC0hSfEK9+0KmPFCfzMpL0EnPz93xy8FsmVBDGR N7hdCF83D2hY8yf9W9c/Ia+zF8kARbeGbbCkKmirZ9KWcU6lOEZHEMDg X-Gm-Gg: ATEYQzzJd/xQ6lsRD4umHE1rHOE5wkcPy5Drp84XUfbyQgoNykDwOyDtY6EheIfhRcH 4xjP+fbae0rUsPY1u6CjZGBqept7JA+Z/zgGflqvxhpXZ1MBSgYRFDgL2EU/c9Q5OOas3SFCzsX zbbe6tzcxCwB926QiLxmIC4MthEazTyQi8iZJgbWRENDEiahBxCmbqCIQTpjYgaxAmShCn0iorJ ewEV+7NwgU6XX8+P+ixU30pLesZUhLNLKPukK1HUL4dJMpTPjvSiLYdCyJPP+OcklgC83UtmmWr Gm8J2W8m47z6PgP3VnWzDwVsflMj0x617qLj7cfKqkxPdP7iaGPSb6e5C13eKJun/EEd9rpihE5 YtBION/Ej1YCD5KXfIkX9tJaCrewKfF2t/dRSBCYIdSj6OKn4wfu8kwtK5O/2xXaNTIT5VZ3/aE pzKdej5QzM7BwRtFpVjLGv5G1438OleQq2pS6kVqWDAUVH4bUrPp8vAmXPfZv/Muqty/AvauRGU ouPZJhftDI/HHljDaL9k8Gk X-Received: by 2002:a05:690c:c119:b0:797:f005:2dc0 with SMTP id 00721157ae682-79a71c88395mr12043627b3.50.1773789802632; Tue, 17 Mar 2026 16:23:22 -0700 (PDT) Received: from tux ([2601:7c0:c37e:2360::f769]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79a715d221dsm6858217b3.37.2026.03.17.16.23.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 16:23:22 -0700 (PDT) From: Ethan Tidmore To: Philipp Reisner , Lars Ellenberg , =?UTF-8?q?Christoph=20B=C3=B6hmwalder?= , Jens Axboe Cc: drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH 3/4] drbd: Add missing error code in drbd_main.c Date: Tue, 17 Mar 2026 18:23:17 -0500 Message-ID: <20260317232318.18923-4-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260317232318.18923-1-ethantidmore06@gmail.com> References: <20260317232318.18923-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" No error code is assigned in alloc_workqueue() error path. Assign error code -ENOMEM. Detected by Smatch: drivers/block/drbd/drbd_main.c:4575 drbd_init() warn: missing error code 'err' Fixes: b2e550c8d1f54 ("drbd: rework module core for DRBD 9 transport and mu= lti-peer") Signed-off-by: Ethan Tidmore --- drivers/block/drbd/drbd_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c index e2c3530cfa13..689b7cac5ec2 100644 --- a/drivers/block/drbd/drbd_main.c +++ b/drivers/block/drbd/drbd_main.c @@ -4569,6 +4569,7 @@ static int __init drbd_init(void) goto fail; } =20 + err =3D -ENOMEM; ping_ack_sender =3D alloc_workqueue("drbd_pas", WQ_UNBOUND | WQ_MEM_RECLAIM | WQ_HIGHPRI, 0); if (!ping_ack_sender) --=20 2.53.0 From nobody Mon Apr 6 20:10:51 2026 Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 566E73F7E9E for ; Tue, 17 Mar 2026 23:23:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773789805; cv=none; b=ByOFBHQ2OM0tMhxzWkvFyxfIFTCfhYlsYQV8JoTdzEXLJBTRUEXLuqlBXJVmNhbG5H1cgH7041IrggTRP/sjdOe1x3xjxsE5h982rOPlGcxgEBP5nZg+wO8a7MvTWh4mSkJvuij0cDcoZb9eAWX8UvtPcYecqys2RdQc51D0pYI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773789805; c=relaxed/simple; bh=MamMwEHvD7VENb++o+ubuwCysRUMRUnSxlW8m9IcJtA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=maVK/JdKlsjBqbhxsJ5Fw3tMFwFXLR5dQ1aJ0JMmpvRGhCuLtkiMLDjv1rwf63nJsKDqjJXUd9DFJFANS5WWD9Kmv/LhXOKnduY76ST6h0yTDuldHWfHcV3msZ+XBhSR3bfiYMzqm+C9PoKP1P9Q1BFLWDixsNeEUuReGChDNtk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PewwBtqY; arc=none smtp.client-ip=209.85.128.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PewwBtqY" Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-79a2ee65171so37482217b3.2 for ; Tue, 17 Mar 2026 16:23:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773789803; x=1774394603; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4qAb7BAjRHOKOhLG2ZwGENg8pg0OEX1p0HLdyPGydEM=; b=PewwBtqYLja3Gc9qhxGWsbRDgmuOKbe2bSAvUKKlmX1P2P5c2sA8hO8rUS4v+PsAaV Qbn0WTICYMzmYcqVj7zsKhWeOcGMa0LZkeGruVMD8ujslHfh6q1NuLJOZs4uYVTPq4rB Wxp63OgnrinaymSAybZbsr/Uw1v+aV3fjDRGWCJXKlkykLhWImjRSD3jA4LU9uZ4d8dS hnmsQlV7cpUi+VkYrlXOmnRlzuP1Mpip+cTe14ColX5u9VmjjFLBkjIotUcVtfcKsoq3 tM3BsmuUsjFriyJjZYFEMaw3P1kBwo5sDYalE6zdFz107ey7Ixg/SdEarN/TqWxawKdH FIPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773789803; x=1774394603; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4qAb7BAjRHOKOhLG2ZwGENg8pg0OEX1p0HLdyPGydEM=; b=WpY6A4U2MWJrSlYu/ea0LOZpJeTWILSVDYwOc/2FZpAaV1Hs6/klwuS2H05WAVo0P/ QwF5T5Lvp8zSUUZzesILcrxKTWQhpMpjOBM564+gsF7Z1uc2s//EKrTUHRWNn1eu01GC 4Pdu6TVENt/ghb0ezGdlr1LMDOLwxGsjVY+BebroLPMM3zM54Bcj+Ubx4n+JS35Ay+Kt VpdInb+F4w4nHcYw6TASfQvD49FTi/7m2CCAhHE0fUsdiLY+b6kfX092jc7HmJy96GQs Q40KnJxmf4k9LA9bGdrKfHp1aun6vYIAxrQeCAKWmFCYdaxg9kx7WYE8K9SM2A5WuhX8 bU4A== X-Forwarded-Encrypted: i=1; AJvYcCURc2P4PC22jjFNj6s+gPX3sI6ZyU1Y2qBGTisxzSxqwE2e97QxkPW6xrH4V0MH3eZUISVCV0bjWYEKZow=@vger.kernel.org X-Gm-Message-State: AOJu0YyKOBDql8A3NBxA6ojCfe4KkWFdAZJGayuGfrkXflYvkY0YKyng GpYTyYa2z+aNOu0/LvMtUulfu0kkgiMYub5YdTiTb4IsRSygW6p+Mjiz X-Gm-Gg: ATEYQzwDejCkwPmFhLcioSkNPbpb4u92Bd5CWHzfQbNFFNMppTBfZCj8k23DgOwIfuw HNGiGw1wu9+dsNQiecih/tdLMMNSgro16HEggd/KeG77WgUzici7iFmQmyyxx05kx29vEPMRl6q rKsNCcZARxwcETA6vPslYlceRPgPvpIiZHK1u4ddgEKgJxtALi+R/4lXKuasIXFhHey/2c6dW34 T0EEmPtd34+DuYOfUbeTayPPblA6mU3dZvK+zdQ7XFZCoCCczo6GkTU4/zioo0L4WzfwWMIQXeG jPWHMYFrR73Kb4P3WXJimRDBp+TgV2jsk4mmddsaVEHSVxK21v9sZwboEenPujirOE4J3UFzmUu bFJvFfg+cnsR82LJqHOdxiV6WkBVXv7UbE+W/lfAcw7j9Z9vvyXRhdJZc8uGPtz9KMTJ5j51Ues TGQqYs9FsUf3Y1pblwO8++O12aImFfN4rndDjn0hIeCi19MGN9r656qSg0HkejZr6x9vRHXhZwW mAm9vZOZMOaJM1aDC5KHsr8 X-Received: by 2002:a05:690c:60c4:b0:799:1c93:7adb with SMTP id 00721157ae682-79a718a5e91mr13675337b3.23.1773789803317; Tue, 17 Mar 2026 16:23:23 -0700 (PDT) Received: from tux ([2601:7c0:c37e:2360::f769]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79a715d221dsm6858217b3.37.2026.03.17.16.23.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 16:23:23 -0700 (PDT) From: Ethan Tidmore To: Philipp Reisner , Lars Ellenberg , =?UTF-8?q?Christoph=20B=C3=B6hmwalder?= , Jens Axboe Cc: drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH 4/4] drbd: Add check for error pointer Date: Tue, 17 Mar 2026 18:23:18 -0500 Message-ID: <20260317232318.18923-5-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260317232318.18923-1-ethantidmore06@gmail.com> References: <20260317232318.18923-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function find_cfg_context_attr() can return an error pointer or NULL in its error path. Change NULL check to IS_ERR_OR_NULL(). Detected by Smatch: drivers/block/drbd/drbd_nl.c:6571 drbd_adm_dump_paths() error: 'resource_filter' dereferencing possible ERR_PTR() Fixes: 626c95b0e2a23 ("drbd: rework netlink interface for DRBD 9 multi-peer= config") Signed-off-by: Ethan Tidmore --- drivers/block/drbd/drbd_nl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c index c5e253820ccf..1f458eb972e9 100644 --- a/drivers/block/drbd/drbd_nl.c +++ b/drivers/block/drbd/drbd_nl.c @@ -6566,7 +6566,7 @@ static int drbd_adm_dump_paths(struct sk_buff *skb, s= truct netlink_callback *cb) resource =3D (struct drbd_resource *)cb->args[0]; if (!cb->args[0]) { resource_filter =3D find_cfg_context_attr(cb->nlh, T_ctx_resource_name); - if (resource_filter) { + if (!IS_ERR_OR_NULL(resource_filter)) { retcode =3D ERR_RES_NOT_KNOWN; resource =3D drbd_find_resource(nla_data(resource_filter)); if (!resource) --=20 2.53.0