From nobody Mon Apr 6 23:21:08 2026 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9516A346771 for ; Tue, 17 Mar 2026 19:56:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773777419; cv=none; b=RyoLBvILCQp7N/POG9k2CpNQlSzXeAhjOGn7VGAD8pMmtvF257jm3mqAN6mrmICWOoEhJXlh0tzpRbTA/3KoBbDWTPzs0PHSdkb+N5T5h4+mAzuQEm/3BFf84rYBrkriH1Q5k+JPdRdBQkkehD+fcpHt4Nlki+3qYXf1uwVSPWI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773777419; c=relaxed/simple; bh=iUjasimP5+ky9qKqqpISytS+Xv3jTe4n2zAFs2FsfCs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NPRgJFlk4ojqumoMAr7vg13G7SMZnPEZ0Frfq09aihClBKHCI4glZFNU/jPO3P0rziikT/XMNGREY2ihFgGPtzY8dCzDPND8VLPRvpxjqVKJjzqezPRHpNt87NV0ZHQ26jSXomEYP/80vH5SXVP2piFaL9ZxpOHKevkDyuDSAjw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VE/WTXvO; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VE/WTXvO" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-43b45bb7548so26455f8f.1 for ; Tue, 17 Mar 2026 12:56:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773777416; x=1774382216; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=X3fwT/mI+98cVYuLBwkfIUddmcoX9bFrR6d/WpZ9rik=; b=VE/WTXvODx4CouvcYCbH8ZSY8bzT0hBU57AaLfm9wVD6BQZhRVSAtaq7OnlVOvfWl4 mIFIyiQz2F1i+3dUBX7Zt8prkZ6H+sDaaQ7Wi4TMiWL7TmxAUswBmcEYgVbqfdNQXNoD XPzT0nEtW6CDuu/HjEtITsmxGlpPeKiS2c043IG2BF1jb958sXFByb98o2u5E2TLuwiV lk9FYBlGBDSLmVrYG7HVpHFAVeKf7J6MGL/Xd89x8lV5rpwyVf62j8mYMZd0tVY3WfOl 5lpdu/UQztcWnSCmVmNsgiPlUlObCWQNGGl5MzlFg/nkQhbQwnLSc9H+EzohXPhMogcP zB3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773777416; x=1774382216; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=X3fwT/mI+98cVYuLBwkfIUddmcoX9bFrR6d/WpZ9rik=; b=VZor0LrJh0Ukenccy8uS5us0P03tg2FHZmuVIkbL0+daGBG8nIFpLWcmgDtILumotC a+oeCNBLAmp/PItw7P0ojC3BJSQJ9IlGAqC5H695wjX0Xx/RMdUZlnKRtyXnZIQ2l6SZ UIgm7vGDJ/TbSXbRMJK/HTiwlAOnKTS3E74EXwV8HE6+c6/jmGTt8ShxM1wrgEnwXY4e xZYBNqjd/0MS08HB6MV7xSd+1CtXuH7dxmuSENuCMxSjtjee2J4GCZ6AVX2i86K68s7X ZRMiLaP216WlQCndjDHMe6hBCKMHYj4vKO7+rUNeGwL3Js+CpAI1uKKamLCv2AB1Qex8 CWUw== X-Forwarded-Encrypted: i=1; AJvYcCUWbN2mtgDE8jdghht6ChOqzu8QjzB5tYaVFIYuTSlBdVXS3qICAn40aUENUV5cHmE99fURSs5CGzSeiW8=@vger.kernel.org X-Gm-Message-State: AOJu0YzcZFeiUKflb63VOwJvAdzJiRDvB0FlZrQHBPZIbNrZ7hbB6swD 2vNiThmqI2mz1RY2JVT02jpm+6ixpKklhovffu6jqlk7mJ+Pku5uzXgL X-Gm-Gg: ATEYQzzbVGgNzUdnxwvdHCFqutoW2uPpUh4f+lYo6j9pX48H89Tci8eKMVuAYdgje1Y dR55kvvFFfTURfXXYIV0f0JaIYtPNl4lqa2VrgtzgPlLGr4r8UlKaAVZKFkz5C3tMu/HeTz4056 VXH7CVtRxiR0BxaBAC7Wq/H0DwZGyZjv5PQfXT7Vd7PjCes4nQHZV4hgHjFf8DxtmoHI3Jc4aGo f8EIIMXOM0XE7p3QkCfTJzRQs4ykq/6QVyZjQqQ6tdg6P6alHW4tt1HijaGsOv9gXdlFoyBLy5j UBF9kiGxhBEQkIjMIL6W6vCmMbPt6m+a7qPZa3Cq2knU/iN2fDU4grgdwl68jy9OiIqgc3qAh20 aSVD8s/xZi/f83vNGpxnSNPEmhrNDW6sumxLfU4/SKu0PuKAnD4e00MhWp9j7wcnSRLBHCGqTjK 6Wv1U1eu7rxFjl/QMF4mNpeegCSx/eC+8rON8GklPGPlApWm7A X-Received: by 2002:a05:6000:24c3:b0:439:df03:f300 with SMTP id ffacd0b85a97d-43b527c8a49mr786234f8f.40.1773777415878; Tue, 17 Mar 2026 12:56:55 -0700 (PDT) Received: from localhost.localdomain ([2a00:23c4:a758:8a01:e16b:fc56:e220:9aa9]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b5189221dsm1339217f8f.23.2026.03.17.12.56.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 12:56:55 -0700 (PDT) From: Biju X-Google-Original-From: Biju To: Geert Uytterhoeven , Michael Turquette , Stephen Boyd , Philipp Zabel Cc: Biju Das , linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar Mahadev Lad , Biju Das Subject: [PATCH v4 2/9] clk: renesas: rzg2l-cpg: Add support for critical resets Date: Tue, 17 Mar 2026 19:56:31 +0000 Message-ID: <20260317195650.468330-3-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260317195650.468330-1-biju.das.jz@bp.renesas.com> References: <20260317195650.468330-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das Some reset lines must remain deasserted at all times after boot, as asserting them would disable critical system functionality with no owning driver to restore them. This mirrors the existing crit_mod_clks mechanism which protects critical module clocks from being disabled. On RZ/G2L family SoCs, the DMA reset must be remain deasserted for routing some peripheral interrupts to CPU. Add crit_resets and num_crit_resets fields to struct rzg2l_cpg_info to allow SoC-specific data tables to declare reset IDs that must never be asserted. Introduce rzg2l_cpg_deassert_crit_resets() to iterate over all critical resets and deassert them. Call it both at probe time and during resume to ensure critical peripherals are held out of reset after power-on and suspend/resume cycles. Signed-off-by: Biju Das --- v4: * Moved this patch from [1] as it is boot-dependent [1] https://lore.kernel.org/all/20260306134228.871815-1-biju.das.jz@bp.ren= esas.com/ --- drivers/clk/renesas/rzg2l-cpg.c | 33 +++++++++++++++++++++++++++++++++ drivers/clk/renesas/rzg2l-cpg.h | 7 +++++++ 2 files changed, 40 insertions(+) diff --git a/drivers/clk/renesas/rzg2l-cpg.c b/drivers/clk/renesas/rzg2l-cp= g.c index c0584bab58a3..8165c163143a 100644 --- a/drivers/clk/renesas/rzg2l-cpg.c +++ b/drivers/clk/renesas/rzg2l-cpg.c @@ -1765,6 +1765,15 @@ static int __rzg2l_cpg_assert(struct reset_controlle= r_dev *rcdev, dev_dbg(rcdev->dev, "%s id:%ld offset:0x%x\n", assert ? "assert" : "deassert", id, CLK_RST_R(reg)); =20 + if (assert) { + unsigned int i; + + for (i =3D 0; i < priv->info->num_crit_resets; i++) { + if (id =3D=3D priv->info->crit_resets[i]) + return 0; + } + } + if (!assert) value |=3D mask; writel(value, priv->base + CLK_RST_R(reg)); @@ -1802,6 +1811,21 @@ static int rzg2l_cpg_deassert(struct reset_controlle= r_dev *rcdev, return __rzg2l_cpg_assert(rcdev, id, false); } =20 +static int rzg2l_cpg_deassert_crit_resets(struct reset_controller_dev *rcd= ev, + const struct rzg2l_cpg_info *info) +{ + unsigned int i; + int ret; + + for (i =3D 0; i < info->num_crit_resets; i++) { + ret =3D rzg2l_cpg_deassert(rcdev, info->crit_resets[i]); + if (ret) + return ret; + } + + return 0; +} + static int rzg2l_cpg_reset(struct reset_controller_dev *rcdev, unsigned long id) { @@ -2051,6 +2075,10 @@ static int __init rzg2l_cpg_probe(struct platform_de= vice *pdev) if (error) return error; =20 + error =3D rzg2l_cpg_deassert_crit_resets(&priv->rcdev, info); + if (error) + return error; + debugfs_create_file("mstop", 0444, NULL, priv, &rzg2l_mod_clock_mstop_fop= s); return 0; } @@ -2058,6 +2086,11 @@ static int __init rzg2l_cpg_probe(struct platform_de= vice *pdev) static int rzg2l_cpg_resume(struct device *dev) { struct rzg2l_cpg_priv *priv =3D dev_get_drvdata(dev); + int ret; + + ret =3D rzg2l_cpg_deassert_crit_resets(&priv->rcdev, priv->info); + if (ret) + return ret; =20 rzg2l_mod_clock_init_mstop(priv); =20 diff --git a/drivers/clk/renesas/rzg2l-cpg.h b/drivers/clk/renesas/rzg2l-cp= g.h index 55e815be16c8..af0a003d93f7 100644 --- a/drivers/clk/renesas/rzg2l-cpg.h +++ b/drivers/clk/renesas/rzg2l-cpg.h @@ -276,6 +276,9 @@ struct rzg2l_reset { * @crit_mod_clks: Array with Module Clock IDs of critical clocks that * should not be disabled without a knowledgeable driver * @num_crit_mod_clks: Number of entries in crit_mod_clks[] + * @crit_resets: Array with Reset IDs of critical resets that should not be + * asserted without a knowledgeable driver + * @num_crit_resets: Number of entries in crit_resets[] * @has_clk_mon_regs: Flag indicating whether the SoC has CLK_MON registers */ struct rzg2l_cpg_info { @@ -302,6 +305,10 @@ struct rzg2l_cpg_info { const unsigned int *crit_mod_clks; unsigned int num_crit_mod_clks; =20 + /* Critical Resets that should not be asserted */ + const unsigned int *crit_resets; + unsigned int num_crit_resets; + bool has_clk_mon_regs; }; =20 --=20 2.43.0